February 2016 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: SerialChildCommandsExecutionCallback - consider comman...
by laravot＠redhat.com 14 Feb '16

14 Feb '16

Liron Aravot has submitted this change and it was merged. Change subject: core: SerialChildCommandsExecutionCallback - consider command execution ...................................................................... core: SerialChildCommandsExecutionCallback - consider command execution When setting the TaskGroupSuccess member to indicate whether the execution was succesful or not the command status should be taken into consideration as well and if the execute() method execution wasn't completed the task group success should be set to false as some logic maybe wasn't executed. Change-Id: I94079624e22c2e8f5dae84c8f1d54aeff65b8bf2 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SerialChildCommandsExecutionCallback.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Moti Asayag: Looks good to me, approved Liron Aravot: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/49379 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I94079624e22c2e8f5dae84c8f1d54aeff65b8bf2 Gerrit-PatchSet: 13 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: renaming FAILED_RESTARTED to EXECUTION_FAILED
by laravot＠redhat.com 14 Feb '16

14 Feb '16

Liron Aravot has submitted this change and it was merged. Change subject: core: renaming FAILED_RESTARTED to EXECUTION_FAILED ...................................................................... core: renaming FAILED_RESTARTED to EXECUTION_FAILED The FAILED_RESTARTED flag is used to mark that the command execution didn't complete for some reason (currently engine restart). As a preparation to use that status also on execution failure that wasn't caused by a restart, the enum name is changed to be more generic. Change-Id: Ic69d7b246ec903502c4dd9204d2492916fbe4808 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChildCommandsCallbackBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MergeExtendCommandCallback.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmPoolCommandCallback.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdeploy/HostUpgradeCallback.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/RemoveDiskSnapshotsCommandCallback.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/RemoveSnapshotCommandCallback.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/RemoveSnapshotSingleDiskLiveCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/cinder/CloneCinderDisksCommandCallback.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/cinder/RemoveCinderDiskCommandCallback.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandAsyncTask.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandExecutor.java M backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/CommandStatus.java 12 files changed, 14 insertions(+), 15 deletions(-) Approvals: Moti Asayag: Looks good to me, approved Liron Aravot: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/53157 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic69d7b246ec903502c4dd9204d2492916fbe4808 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: set command status after compensation rollback
by laravot＠redhat.com 14 Feb '16

14 Feb '16

Liron Aravot has submitted this change and it was merged. Change subject: core: set command status after compensation rollback ...................................................................... core: set command status after compensation rollback In case of command execution failure the status should be set only after the compensation data was reverted to avoid races when the status change is determined by the parent command (if exists). Change-Id: I02b69a42e616de179c5818568a96c429f2f2b777 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Moti Asayag: Looks good to me, approved Liron Aravot: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/53156 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I02b69a42e616de179c5818568a96c429f2f2b777 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: vdsbroker: Adding Map generic return for VDS broker.
by mlipchuk＠redhat.com 14 Feb '16

14 Feb '16

Maor Lipchuk has submitted this change and it was merged. Change subject: vdsbroker: Adding Map generic return for VDS broker. ...................................................................... vdsbroker: Adding Map generic return for VDS broker. This patch adds a generic map return from VDS broker, for map values that are returned from VDSM verbs. Change-Id: I069949c1a05720184588b7bc4ee14f492173e2a7 Related-To: https://bugzilla.redhat.com/1091377 Signed-off-by: Amit Aviram <aaviram(a)redhat.com> --- A backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/OneMapReturnForXmlRpc.java 1 file changed, 19 insertions(+), 0 deletions(-) Approvals: Greg Padgett: Verified Jenkins CI: Passed CI tests Maor Lipchuk: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/50010 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I069949c1a05720184588b7bc4ee14f492173e2a7 Gerrit-PatchSet: 20 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: webadmin: Prevent NPE in StorageGeneralModel
by tnisan＠redhat.com 14 Feb '16

14 Feb '16

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Prevent NPE in StorageGeneralModel ...................................................................... webadmin: Prevent NPE in StorageGeneralModel Potential NPE discovered by coverity (CID:1201871). The connection is checked for null, then is directly referenced a few lines after. Change-Id: I699ec5f85d0dbb9e449e29e9476aa5a24aeb538f Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1304674 Signed-off-by: Fred Rolland <frolland(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageGeneralModel.java 1 file changed, 14 insertions(+), 11 deletions(-) Approvals: Alexander Wels: Verified Daniel Erez: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, but someone else must approve Freddy Rolland: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/53491 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I699ec5f85d0dbb9e449e29e9476aa5a24aeb538f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: host setup networks validator for unmananged networks
by alkaplan＠redhat.com 14 Feb '16

14 Feb '16

Alona Kaplan has submitted this change and it was merged. Change subject: engine: host setup networks validator for unmananged networks ...................................................................... engine: host setup networks validator for unmananged networks Validates network changes associated with unmanaged networks The following use cases are validated: Lables: - a label is added to a nic with an unmanaged network Network attachements: - check if a network attachement containing an unmanaged network is modified/added Removed unmanaged network - check network in removed unmanaged network list is not a managed network on the cluster - check network in removed unmanaged network list is an unmanaged network on the host Bug-Url: https://bugzilla.redhat.com/1167698 Change-Id: I266383deb6ab1e6e2457749517930c94b2d3791e Signed-off-by: Marcin Mirecki <mmirecki(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/HostSetupNetworksCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/HostSetupNetworksValidator.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/UnmanagedNetworkValidator.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/host/HostSetupNetworksValidatorTest.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/host/UnmanagedNetworkValidatorTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 9 files changed, 454 insertions(+), 3 deletions(-) Approvals: Marcin Mirecki: Verified Alona Kaplan: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/46074 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I266383deb6ab1e6e2457749517930c94b2d3791e Gerrit-PatchSet: 13 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: webadmin: Fixed column separator in new quota dialog
by piotr.kliczewski＠gmail.com 12 Feb '16

12 Feb '16

Piotr Kliczewski has submitted this change and it was merged. Change subject: webadmin: Fixed column separator in new quota dialog ...................................................................... webadmin: Fixed column separator in new quota dialog The new quota dialog had duplicate line separators in table headers due to a left border being added via CSS. Removal of this border attribute corrects the issue. Change-Id: Iad677b1688bca30fe3722841b864d5c54d9bf4d3 Bug-Url: https://bugzilla.redhat.com/1139754 Signed-off-by: Phillip Bailey <phbailey(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/css/PopupCellTable.css 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Phillip Bailey: Verified -- To view, visit https://gerrit.ovirt.org/53356 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iad677b1688bca30fe3722841b864d5c54d9bf4d3 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: webadmin: added help for Storage > ISO > DC > Attach
by piotr.kliczewski＠gmail.com 12 Feb '16

12 Feb '16

Piotr Kliczewski has submitted this change and it was merged. Change subject: webadmin: added help for Storage > ISO > DC > Attach ...................................................................... webadmin: added help for Storage > ISO > DC > Attach Change-Id: Id7310bf2a623dd049d66f88425ee7cbcc81a9270 Bug-Url: https://bugzilla.redhat.com/1174045 Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageDataCenterListModel.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Alexander Wels: Looks good to me, approved Jenkins CI: Passed CI tests Greg Sheremeta: Verified -- To view, visit https://gerrit.ovirt.org/53376 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id7310bf2a623dd049d66f88425ee7cbcc81a9270 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6.3]: webadmin: Disk edit dialogs are all enbabled when they shoul...
by tnisan＠redhat.com 12 Feb '16

12 Feb '16

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Disk edit dialogs are all enbabled when they should not ...................................................................... webadmin: Disk edit dialogs are all enbabled when they should not Change-Id: I92e7c532910d15ac16cbf2bf0a495fd009e9471d Bug-Url: https://bugzilla.redhat.com/1305945 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmDiskPopupWidget.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/AbstractDiskModel.java 2 files changed, 31 insertions(+), 17 deletions(-) Approvals: Tal Nisan: Verified Jenkins CI: Passed CI tests Daniel Erez: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/53427 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I92e7c532910d15ac16cbf2bf0a495fd009e9471d Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6.3 Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: webadmin: Disk edit dialogs are all enbabled when they shoul...
by tnisan＠redhat.com 12 Feb '16

12 Feb '16

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Disk edit dialogs are all enbabled when they should not ...................................................................... webadmin: Disk edit dialogs are all enbabled when they should not Change-Id: I92e7c532910d15ac16cbf2bf0a495fd009e9471d Bug-Url: https://bugzilla.redhat.com/1305945 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmDiskPopupWidget.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/AbstractDiskModel.java 2 files changed, 31 insertions(+), 17 deletions(-) Approvals: Tal Nisan: Verified Jenkins CI: Passed CI tests Daniel Erez: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/53426 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I92e7c532910d15ac16cbf2bf0a495fd009e9471d Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0