Change in ovirt-engine[master]: core: Set parent command for child comamnd.
by mlipchuk＠redhat.com
Maor Lipchuk has submitted this change and it was merged.
Change subject: core: Set parent command for child comamnd.
......................................................................
core: Set parent command for child comamnd.
CreateAllSnapshotsFromVmCommand should initialize its child commands with
parent action type and parameters of CreateAllSnapshotsFromVmCommand
Change-Id: I0d38dd9904a3baad487114302dd75da87bb8122f
Bug-Url: https://bugzilla.redhat.com/1305809
Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/CreateAllSnapshotsFromVmCommand.java
1 file changed, 4 insertions(+), 1 deletion(-)
Approvals:
Jenkins CI: Passed CI tests
Daniel Erez: Looks good to me, approved
Maor Lipchuk: Verified
--
To view, visit https://gerrit.ovirt.org/53495
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0d38dd9904a3baad487114302dd75da87bb8122f
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 10 months
Change in ovirt-engine[master]: core: Validate steps using CoCo on RunVmCommand
by mlipchuk＠redhat.com
Maor Lipchuk has submitted this change and it was merged.
Change subject: core: Validate steps using CoCo on RunVmCommand
......................................................................
core: Validate steps using CoCo on RunVmCommand
When RunVmCommand calls CreateAllsnapshotsFromVmCommand with
execution context it should use getContext instead of cloneContext
so the executionContext of RunVmcommand should also get updated with the
relevant steps.
The reason why this should be changed is because CoCo is using the
executionContext of the command itself while the AsyncTaskManager sets
the executionContext of the child, CreateAllsnapshotsFromVmCommand, once
RunVmCommand is being called.
Once the engine also sets the context of the existing command, RunVmCommand,
the engine will not throw an NPE that the step does not exists.
Change-Id: I6dfed690d8a15684beda506808e788a2be805aa6
Bug-Url: https://bugzilla.redhat.com/1305809
Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Jenkins CI: Passed CI tests
Daniel Erez: Looks good to me, approved
Maor Lipchuk: Verified
Arik Hadas: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/53493
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6dfed690d8a15684beda506808e788a2be805aa6
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 10 months
Change in ovirt-engine[master]: core: Use Callback for RunVmCommand.
by mlipchuk＠redhat.com
Maor Lipchuk has submitted this change and it was merged.
Change subject: core: Use Callback for RunVmCommand.
......................................................................
core: Use Callback for RunVmCommand.
As part of the the use of ConcurrentChildCommandsExecutionCallback with
Cinder disks.
RunVmCommand should also use it since this command also running a
stateles VM.
Change-Id: I7b86461dd394aab9cd790397be21ac4d6801baa2
Bug-Url: https://bugzilla.redhat.com/1305809
Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java
1 file changed, 15 insertions(+), 1 deletion(-)
Approvals:
Jenkins CI: Passed CI tests
Daniel Erez: Looks good to me, approved
Maor Lipchuk: Verified
--
To view, visit https://gerrit.ovirt.org/53492
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7b86461dd394aab9cd790397be21ac4d6801baa2
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 10 months
Change in ovirt-engine[master]: vdsbroker: Image upload VDS commands and strings
by mlipchuk＠redhat.com
Maor Lipchuk has submitted this change and it was merged.
Change subject: vdsbroker: Image upload VDS commands and strings
......................................................................
vdsbroker: Image upload VDS commands and strings
Add VDS commands and strings used by the backend Image Upload commands.
Change-Id: Iddf676fb15c88e126811a25e5e97609c6d937b25
Related-To: https://bugzilla.redhat.com/1091377
Signed-off-by: Amit Aviram <aaviram(a)redhat.com>
Signed-off-by: Greg Padgett <gpadgett(a)redhat.com>
---
A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/AddImageTicketVDSCommandParameters.java
A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/ExtendImageTicketVDSCommandParameters.java
A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/GetImageTransferSessionStatsVDSCommandParameters.java
A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/ImageTicketVDSCommandParametersBase.java
A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/RemoveImageTicketVDSCommandParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/VDSCommandType.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcVdsServer.java
A backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/AddImageTicketVDSCommand.java
A backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/ExtendImageTicketVDSCommand.java
A backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/GetImageTransferSessionStatsVDSCommand.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/IVdsServer.java
A backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/RemoveImageTicketVDSCommand.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerConnector.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerWrapper.java
14 files changed, 339 insertions(+), 0 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Amit Aviram: Verified
Maor Lipchuk: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/40366
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iddf676fb15c88e126811a25e5e97609c6d937b25
Gerrit-PatchSet: 43
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Amit Aviram <aaviram(a)redhat.com>
Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 10 months
Change in ovirt-engine[master]: core: numa node with cpus in one query
by ahadas＠redhat.com
Arik Hadas has submitted this change and it was merged.
Change subject: core: numa node with cpus in one query
......................................................................
core: numa node with cpus in one query
In order to improve the inefficient retrieval of numa nodes
(per-host and per-VM), we unified two queries to single query.
Instead of getting the relevant nodes and then query their CPU
cores, we let the DB do that in a single query.
Change-Id: I212630eab537eb3bc3d4731ca66beed62353855d
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsNumaNodeDaoImpl.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmNumaNodeDaoImpl.java
M packaging/dbscripts/create_views.sql
M packaging/dbscripts/numa_sp.sql
4 files changed, 29 insertions(+), 93 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Roy Golan: Looks good to me, approved
Arik Hadas: Verified
--
To view, visit https://gerrit.ovirt.org/52869
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I212630eab537eb3bc3d4731ca66beed62353855d
Gerrit-PatchSet: 17
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <mskrivan(a)redhat.com>
Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 10 months
Change in ovirt-engine[master]: core: VM compatibility version scheduler filter
by ahadas＠redhat.com
Arik Hadas has submitted this change and it was merged.
Change subject: core: VM compatibility version scheduler filter
......................................................................
core: VM compatibility version scheduler filter
This patch is part of the series introducing VM compatibility version
feature. This feature allows to customize a VM to its own compatibility
version unrelated to one of the cluster. VM compatibility version is
limited by Data Center and capabilities of the host the VM will be able
to run on.
This patch adds a new filter to the scheduler to filter out hosts that
do not support the desired VM compatibility version.
Change-Id: I96967b10e3af8f31f81c16e461ef69d5fb605833
Signed-off-by: Shmuel Melamud <smelamud(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/InternalClusterPolicies.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/InternalPolicyUnits.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/CompatibilityVersionFilterPolicyUnit.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
8 files changed, 84 insertions(+), 0 deletions(-)
Approvals:
Martin Sivák: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Shmuel Leib Melamud: Verified
Arik Hadas: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/48161
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I96967b10e3af8f31f81c16e461ef69d5fb605833
Gerrit-PatchSet: 11
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shmuel Leib Melamud <smelamud(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <mskrivan(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 10 months
Change in ovirt-engine[master]: vdsbroker: Adjusting checkstyle to new VDSM API names.
by mlipchuk＠redhat.com
Maor Lipchuk has submitted this change and it was merged.
Change subject: vdsbroker: Adjusting checkstyle to new VDSM API names.
......................................................................
vdsbroker: Adjusting checkstyle to new VDSM API names.
The vdsm api name style has changed and new ones use underscores. Since
the vdsbroker method names must match, we have some methods like
add_image_ticket which checkstyle doesn't like.
This patch makes the checkstyle validations to surpress these checks.
Change-Id: I9275d93153604f3e49ec43eb7065d6c6c4ddfab5
Signed-off-by: Amit Aviram <aaviram(a)redhat.com>
Signed-off-by: Greg Padgett <gpadgett(a)redhat.com>
---
M build-tools-root/checkstyles/src/main/resources/checkstyle-suppressions.xml
1 file changed, 3 insertions(+), 0 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Amit Aviram: Verified
Allon Mureinik: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/53497
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9275d93153604f3e49ec43eb7065d6c6c4ddfab5
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Amit Aviram <aaviram(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 10 months
Change in ovirt-engine[ovirt-engine-3.6.3]: core: Live Merge's check for merge completion is wrong
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: Live Merge's check for merge completion is wrong
......................................................................
core: Live Merge's check for merge completion is wrong
When the DESTROY_IMAGE_CHECK step was added to the Live Merge flow, the
completedMerge() method was not updated. This method is called upon
failure and checks if the merge operation was completed based on the
current command step.
Without this, a failure during the DESTROY_IMAGE_CHECK step will result
in live merge updating the database in such a way that recovery will
retry the merge operation, requiring manual intervention to repair.
This patch also includes a change to a log message so that it is
possible to tell which database updates the flow performed based on
the result of completedMerge().
Change-Id: Ia20aab2233493b8653c6a714c8504964f8196878
Bug-Url: https://bugzilla.redhat.com/1306367
Signed-off-by: Greg Padgett <gpadgett(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotSingleDiskLiveCommand.java
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
Greg Padgett: Verified
Jenkins CI: Passed CI tests
Allon Mureinik: Looks good to me, approved
Ala Hino: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/53439
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia20aab2233493b8653c6a714c8504964f8196878
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6.3
Gerrit-Owner: Greg Padgett <gpadgett(a)redhat.com>
Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 10 months
Change in ovirt-engine[ovirt-engine-3.6]: core: Live Merge's check for merge completion is wrong
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: Live Merge's check for merge completion is wrong
......................................................................
core: Live Merge's check for merge completion is wrong
When the DESTROY_IMAGE_CHECK step was added to the Live Merge flow, the
completedMerge() method was not updated. This method is called upon
failure and checks if the merge operation was completed based on the
current command step.
Without this, a failure during the DESTROY_IMAGE_CHECK step will result
in live merge updating the database in such a way that recovery will
retry the merge operation, requiring manual intervention to repair.
This patch also includes a change to a log message so that it is
possible to tell which database updates the flow performed based on
the result of completedMerge().
Change-Id: Ia20aab2233493b8653c6a714c8504964f8196878
Bug-Url: https://bugzilla.redhat.com/1306367
Signed-off-by: Greg Padgett <gpadgett(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotSingleDiskLiveCommand.java
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
Greg Padgett: Verified
Jenkins CI: Passed CI tests
Allon Mureinik: Looks good to me, approved
Ala Hino: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/53383
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia20aab2233493b8653c6a714c8504964f8196878
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Greg Padgett <gpadgett(a)redhat.com>
Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 10 months
Change in ovirt-engine[master]: core: Live Merge's check for merge completion is wrong
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: Live Merge's check for merge completion is wrong
......................................................................
core: Live Merge's check for merge completion is wrong
When the DESTROY_IMAGE_CHECK step was added to the Live Merge flow, the
completedMerge() method was not updated. This method is called upon
failure and checks if the merge operation was completed based on the
current command step.
Without this, a failure during the DESTROY_IMAGE_CHECK step will result
in live merge updating the database in such a way that recovery will
retry the merge operation, requiring manual intervention to repair.
This patch also includes a change to a log message so that it is
possible to tell which database updates the flow performed based on
the result of completedMerge().
Change-Id: Ia20aab2233493b8653c6a714c8504964f8196878
Bug-Url: https://bugzilla.redhat.com/1306367
Signed-off-by: Greg Padgett <gpadgett(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/RemoveSnapshotSingleDiskLiveCommand.java
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
Tal Nisan: Passed CI tests
Greg Padgett: Verified
Allon Mureinik: Looks good to me, approved
Ala Hino: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/53370
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia20aab2233493b8653c6a714c8504964f8196878
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Greg Padgett <gpadgett(a)redhat.com>
Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 10 months