February 2016 - Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.6.3]: webadmin: Block restore memory on newer compatibility versions
by tnisan＠redhat.com 08 Feb '16

08 Feb '16

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Block restore memory on newer compatibility versions ...................................................................... webadmin: Block restore memory on newer compatibility versions User confirmation is needed to preview VM snapshot with memory which was taken in different cluster version (i.e. cluster upgrade). The newly added VmBase.clusterCopatibilityVersionOrigin is (de)marshalled in OVF. Change-Id: I774fe07583a2ad762b8e16b12aacd9f15c8371ba Bug-Url: https://bugzilla.redhat.com/1292398 Signed-off-by: Marek Libra <mlibra(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VM.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmBase.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfProperties.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfReader.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfWriter.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmSnapshotPreviewPopupWidget.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/SnapshotModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmSnapshotListModel.java 9 files changed, 66 insertions(+), 0 deletions(-) Approvals: Tomas Jelinek: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Marek Libra: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/53162 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I774fe07583a2ad762b8e16b12aacd9f15c8371ba Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6.3 Gerrit-Owner: Marek Libra <mlibra(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marek Libra <mlibra(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: move monitoring related classes to separate package
by ahadas＠redhat.com 08 Feb '16

08 Feb '16

Arik Hadas has submitted this change and it was merged. Change subject: core: move monitoring related classes to separate package ...................................................................... core: move monitoring related classes to separate package Introduce org.ovirt.engine.core.vdsbroker.monitoring package that stores monitoring related classes. Change-Id: I102d7e06a5eb579d316a99a6b3de05cbae24ecde Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddUnmanagedVmsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AutoRecoveryManager.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/pm/VdsNotRespondingTreatmentCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmManager.java R backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/EventVmStatsRefresher.java R backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/GlusterMonitoringStrategy.java R backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/HostMonitoring.java R backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/MonitoringStrategy.java R backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/MonitoringStrategyFactory.java R backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/MultipleServicesMonitoringStrategy.java R backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/NetworkMonitoringHelper.java R backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/PollAllVmStatsOnlyRefresher.java R backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/PollListAndAllVmStatsRefresher.java R backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/PollVmStatsRefresher.java R backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/RefresherFactory.java R backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VirtMonitoringStrategy.java R backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmAnalyzer.java R backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmDevicesMonitoring.java R backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmStatsRefresher.java R backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmsListFetcher.java R backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmsMonitoring.java R backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmsStatisticsFetcher.java D backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/VmStatisticsFetcherTest.java R backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/monitoring/HostMonitoringTest.java R backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/monitoring/MultipleServicesMonitoringStrategyTest.java R backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/monitoring/VirtMonitoringStrategyTest.java R backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/monitoring/VmAnalyzerTest.java A backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/monitoring/VmStatisticsFetcherTest.java R backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/monitoring/VmTestPairs.java R backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/monitoring/VmsListFetcherTest.java 32 files changed, 72 insertions(+), 41 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/53093 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I102d7e06a5eb579d316a99a6b3de05cbae24ecde Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: invalid ValidationGroup used when record is identified...
by alkaplan＠redhat.com 08 Feb '16

08 Feb '16

Alona Kaplan has submitted this change and it was merged. Change subject: core: invalid ValidationGroup used when record is identified by name ...................................................................... core: invalid ValidationGroup used when record is identified by name In HostSetupNetworksCommand Bonds and NetworkAttachments can be identified by either name of id. Probably for historic reasons are all new or updated, Bonds or NetworkAttachments passed from client (ui, rest) in same list, one for each type. On Bll we need to separate them. Currently there's a bug, which causes wrong ValidationGroup is used, when validating NetworkAttachment for update, where record is identified by name. Luckily, the only place where validationGroup is used, is Network attachment: @NetworkIdOrNetworkNameIsSet(groups = { CreateEntity.class, UpdateEntity.class }) and this validation will work equally for both usecases. Change-Id: Ib95ad75353735f9a894624989d8d06b3eaf822b6 Bug-Url: https://bugzilla.redhat.com/1271220 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/HostSetupNetworksCommand.java 1 file changed, 6 insertions(+), 7 deletions(-) Approvals: Martin Mucha: Verified Alona Kaplan: Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/52541 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib95ad75353735f9a894624989d8d06b3eaf822b6 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: extract unmanaged hosted engine code from vms monitoring
by rgolan＠redhat.com 08 Feb '16

08 Feb '16

Roy Golan has submitted this change and it was merged. Change subject: core: extract unmanaged hosted engine code from vms monitoring ...................................................................... core: extract unmanaged hosted engine code from vms monitoring Extract the code that handles installed hosted-engine VM from VmsMonitoring to simplify VmsMonitoring and reduce duplicated code with AddUnmanagedVmsCommand. The analyzer treats installed hosted-engine VM as an external VMs and pass it to the AddUnamangedVmsCommand. The command in turn identifies installed hosted- engine VM as external hosted-engine VM that should be imported. A positive side-effect of this change, besides the ones mentioned above, is that we now store the static part of the VM before flushing the refreshed data to the database and therefore at the end of the first cycle in which we get the VM we will have the VM presented with the right status. Change-Id: Ie19247de8093bd79e8bb3ae62233d79853bbb601 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddUnmanagedVmsCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmAnalyzer.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmsMonitoring.java M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/VmAnalyzerTest.java 4 files changed, 26 insertions(+), 65 deletions(-) Approvals: Jenkins CI: Passed CI tests Roy Golan: Looks good to me, approved Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/51059 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie19247de8093bd79e8bb3ae62233d79853bbb601 Gerrit-PatchSet: 14 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-iso-uploader[master]: license: fix usage of ASL 2.0 License
by sbonazzo＠redhat.com 08 Feb '16

08 Feb '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: license: fix usage of ASL 2.0 License ...................................................................... license: fix usage of ASL 2.0 License Change-Id: Ie199baa049b2eafc658e97f622784dd3947df479 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M Makefile.am M build/python.inc M configure.ac M ovirt-iso-uploader.spec.in M po/Makevars M src/Makefile.am M src/__init__.py M src/__main__.py M src/logrotate.d/Makefile.am 9 files changed, 81 insertions(+), 105 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/52951 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie199baa049b2eafc658e97f622784dd3947df479 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-iso-uploader Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Keith Robertson <kroberts(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: findbugs: Fix useless object alert in ResourcesModel.java
by tjelinek＠redhat.com 07 Feb '16

07 Feb '16

Tomas Jelinek has submitted this change and it was merged. Change subject: findbugs: Fix useless object alert in ResourcesModel.java ...................................................................... findbugs: Fix useless object alert in ResourcesModel.java ResourcesModel.java:248, UC_USELESS_OBJECT, Priority: Low Change-Id: Id19c27c9e2f5b57ab3212f3e16e6f88bbd879f74 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/resources/ResourcesModel.java 1 file changed, 0 insertions(+), 3 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Tal Nisan: Verified Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/53170 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id19c27c9e2f5b57ab3212f3e16e6f88bbd879f74 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core, frontend: Prevent console stealing from admin user
by tnisan＠redhat.com 07 Feb '16

07 Feb '16

Tal Nisan has submitted this change and it was merged. Change subject: core, frontend: Prevent console stealing from admin user ...................................................................... core, frontend: Prevent console stealing from admin user Before this patch all users were able to take over a console from other users. Now the console can only be stealed by admin users (DbUser#isAdmin()). * ConfitureConsoleOptionsQuery calls SetVmTicketCommand using runAction() instead of runInternalAction() to allow premissions checking * ConfigureConsoleOptionsQuery reports errors of nested SetVmTicketCommand calls in VdcQueryReturnValue#exceptionString * SetVmTicketCommand has extended permission checking taking into account current console user (VM#getConsoleUserId()). * Frontend calls of ConfitureConsoleOptionsQuery are able to show localized error messages to users (limited to one string error key, so variable replacements are no available). Change-Id: I83ce78829d3f435d0e8d98ab133777c32268303e Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/1297018 --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ConfigureConsoleOptionsQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SetVmTicketCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ConfigureConsoleOptionsQueryTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/SetVmTicketCommandTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/ShowErrorAsyncQuery.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/SpiceConsoleModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VncConsoleModel.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 12 files changed, 192 insertions(+), 11 deletions(-) Approvals: Tomas Jelinek: Looks good to me, but someone else must approve Jakub Niedermertl: Verified Jenkins CI: Passed CI tests Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/53127 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I83ce78829d3f435d0e8d98ab133777c32268303e Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Rename VM.getVmUnamagedDeviceList() to getUnmanagedDev...
by ahadas＠redhat.com 07 Feb '16

07 Feb '16

Arik Hadas has submitted this change and it was merged. Change subject: core: Rename VM.getVmUnamagedDeviceList() to getUnmanagedDeviceList() ...................................................................... core: Rename VM.getVmUnamagedDeviceList() to getUnmanagedDeviceList() Rename VM.getVmUnamagedDeviceList() to getUnmanagedDeviceList() to fix the typo and for consistency in naming with VM.setUnmanagedDeviceList() and corresponding methods of VmBase class. Change-Id: Ia356d9ebeea338f3a81f69b3bf3e58f3f7fe3106 Signed-off-by: Shmuel Melamud <smelamud(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmAndCloneImageCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ProcessDownVmCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VM.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/serialization/json/JsonVmMixIn.java 4 files changed, 4 insertions(+), 4 deletions(-) Approvals: Jenkins CI: Passed CI tests Shmuel Leib Melamud: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/53108 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia356d9ebeea338f3a81f69b3bf3e58f3f7fe3106 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: webadmin: Fix migration policy update for running VM
by tnisan＠redhat.com 07 Feb '16

07 Feb '16

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Fix migration policy update for running VM ...................................................................... webadmin: Fix migration policy update for running VM Problem description: -------------------- When a VM is running and its migration policy is pinned, a change of the migration policy to migrateable allows the running VM to migrate to another host. This behavior is a security threat, passing information from the pinned host to the migration target. And migration could fail due to incompatible target host. Desired behavior: ----------------- When a VM is running and changing migration policy from pinned to Migrateable (manual or automatic). - Provide warning and UX indicator. - If user confirms proceed with normal update. Implementation: -------------- 1. Replace @EditableOnVmStatusField with @EditableField to fields {dedicatedVmForVdsList, migrationSupport} (VmBase.java). Disable (vm restart requirement), when updating dedicated hosts field or updating migrationSupport field. 2. Redesign VmNextRunConfiguration UI to display warnning if running VM is unpinned. Modify VmListModel.java to append warning into VmNextRunConfigurationModel.java . Also Modify VmNextRunConfiguration layout and widget to display selective information (coresponding to updated fields). Change-Id: Idcc9c120606ebe5bc55803213065124f44972e0b Bug-Url: https://bugzilla.redhat.com/1058384 Signed-off-by: Andrej Krejcir <akrejcir(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmBase.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationMessages.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmNextRunConfigurationWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmNextRunConfigurationWidget.ui.xml M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmNextRunConfigurationModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/vm/VmNextRunConfigurationPopupView.java 9 files changed, 166 insertions(+), 44 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Jenkins CI: Passed CI tests Andrej Krejcir: Verified -- To view, visit https://gerrit.ovirt.org/50622 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idcc9c120606ebe5bc55803213065124f44972e0b Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Andrej Krejcir <akrejcir(a)redhat.com> Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Add VM to touchedVms only once
by ahadas＠redhat.com 07 Feb '16

07 Feb '16

Arik Hadas has submitted this change and it was merged. Change subject: core: Add VM to touchedVms only once ...................................................................... core: Add VM to touchedVms only once If lockTouchedVm() is called several times for the same VM in the same thread, the VM ID must be added to touchedVms only once, when the lock is actually taken for the first time. Change-Id: I1e6119ae81d84250083ec390d757ff00baa439d7 Signed-off-by: Shmuel Melamud <smelamud(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmDevicesMonitoring.java 1 file changed, 11 insertions(+), 5 deletions(-) Approvals: Shmuel Leib Melamud: Verified Arik Hadas: Looks good to me, approved; Passed CI tests Objections: Jenkins CI: Failed CI tests -- To view, visit https://gerrit.ovirt.org/53161 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1e6119ae81d84250083ec390d757ff00baa439d7 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0