February 2016 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: SerialChildCommandsExecutionCallback - endAction() rel...
by laravot＠redhat.com 07 Feb '16

07 Feb '16

Liron Aravot has submitted this change and it was merged. Change subject: core: SerialChildCommandsExecutionCallback - endAction() related log ...................................................................... core: SerialChildCommandsExecutionCallback - endAction() related log This patch adds logging when the endAction() will be executed by the parent, so that the serial callback logging will be similar to the logging in ConcurrentChildCommandsExecutionCallback. Change-Id: Icf61e950c7f6cc2f024558d51bdbc3ef70ceab74 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChildCommandsCallbackBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ConcurrentChildCommandsExecutionCallback.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SerialChildCommandsExecutionCallback.java 3 files changed, 15 insertions(+), 12 deletions(-) Approvals: Moti Asayag: Looks good to me, approved Liron Aravot: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/52566 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icf61e950c7f6cc2f024558d51bdbc3ef70ceab74 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: CommandBase - adjust getTaskIdList() to CoCo flows
by laravot＠redhat.com 07 Feb '16

07 Feb '16

Liron Aravot has submitted this change and it was merged. Change subject: core: CommandBase - adjust getTaskIdList() to CoCo flows ...................................................................... core: CommandBase - adjust getTaskIdList() to CoCo flows The internal task list should be returned only if the parent command doesn't have a callback so that the endAction() won't be called by the AsyncTaskManager. Change-Id: I7e9292cb6a58563ae4c70a77c1cd00b00150131e Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Moti Asayag: Looks good to me, approved Liron Aravot: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/52565 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7e9292cb6a58563ae4c70a77c1cd00b00150131e Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: German messages overlapp with icons in Nic dialog
by alkaplan＠redhat.com 07 Feb '16

07 Feb '16

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: German messages overlapp with icons in Nic dialog ...................................................................... webadmin: German messages overlapp with icons in Nic dialog There is an overlapping between icon and text (German locales) observed in nic dialog in VM --> Network Interfaces Change-Id: I8e725c661f01c4ca18191662a68cf10fb66f60e9 Bug-Url: https://bugzilla.redhat.com/1291146 Signed-off-by: mirecki <mmirecki(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/networkinterface/NetworkInterfacePopupWidget.ui.xml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Marcin Mirecki: Verified Alona Kaplan: Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/53118 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8e725c661f01c4ca18191662a68cf10fb66f60e9 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: Edit VM dialog -- capitalize "Host"
by awels＠redhat.com 05 Feb '16

05 Feb '16

Alexander Wels has submitted this change and it was merged. Change subject: webadmin: Edit VM dialog -- capitalize "Host" ...................................................................... webadmin: Edit VM dialog -- capitalize "Host" text change only. Change-Id: I563e557ef06b10d929f32d66a022c3f75eb005fa Bug-Url: https://bugzilla.redhat.com/1304776 Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Alexander Wels: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/53111 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I563e557ef06b10d929f32d66a022c3f75eb005fa Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-setup[master]: network: enforce NetworkManager is not active
by sbonazzo＠redhat.com 05 Feb '16

05 Feb '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: network: enforce NetworkManager is not active ...................................................................... network: enforce NetworkManager is not active hosted-engine-setup will create the network bridge before calling host.add() and then host-deploy will stop NetworkManager: stopping NetworkManager in the middle of the deployment can modify the bridge so it's safer to ask the user to explictly stop and disable it before. Change-Id: If8df5187ed6ffc82a5d97140399fa5def022447c Bug-Url: https://bugzilla.redhat.com/1291083 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M src/plugins/ovirt-hosted-engine-setup/network/bridge.py 1 file changed, 14 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/53134 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If8df5187ed6ffc82a5d97140399fa5def022447c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: Block restore memory on newer compatibility versions
by tjelinek＠redhat.com 05 Feb '16

05 Feb '16

Tomas Jelinek has submitted this change and it was merged. Change subject: webadmin: Block restore memory on newer compatibility versions ...................................................................... webadmin: Block restore memory on newer compatibility versions User confirmation is needed to preview VM snapshot with memory which was taken in different cluster version (i.e. cluster upgrade). The VM.customCompatibilityVersion and newly introduced VM.clusterCopatibilityVersionOrigin is (de)marshalled in OVF. Change-Id: I774fe07583a2ad762b8e16b12aacd9f15c8371ba Bug-Url: https://bugzilla.redhat.com/1292398 Signed-off-by: Marek Libra <mlibra(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VM.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmBase.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfProperties.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfReader.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfWriter.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmSnapshotPreviewPopupWidget.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/SnapshotModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmSnapshotListModel.java 9 files changed, 81 insertions(+), 0 deletions(-) Approvals: Tomas Jelinek: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved Marek Libra: Verified Arik Hadas: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/52751 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I774fe07583a2ad762b8e16b12aacd9f15c8371ba Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Marek Libra <mlibra(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Marek Libra <mlibra(a)redhat.com> Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: A couple of fixes for lago jobs
by dcaro＠redhat.com 05 Feb '16

05 Feb '16

David Caro has submitted this change and it was merged. Change subject: A couple of fixes for lago jobs ...................................................................... A couple of fixes for lago jobs * Allowing manual runs * Pin jobs to fc23 slaves (there's a bug when running the cirros image nested on fc<23 or el*) Change-Id: I052d98e9b5e1919e76482e928a0f3e217793900a Signed-off-by: David Caro <dcaroest(a)redhat.com> --- M jobs/confs/groovy-scripts/standard-pipeline.groovy M jobs/confs/projects/lago/lago_standard.yaml M jobs/confs/yaml/scms/github.yaml M jobs/confs/yaml/templates/standard-stage.yaml 4 files changed, 27 insertions(+), 5 deletions(-) Approvals: Sandro Bonazzola: Looks good to me; Ready for merge Jenkins CI: Passed CI tests David Caro: Verified; Ready for review -- To view, visit https://gerrit.ovirt.org/53117 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I052d98e9b5e1919e76482e928a0f3e217793900a Gerrit-PatchSet: 3 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: David Caro <dcaro(a)redhat.com> Gerrit-Reviewer: Anatoly Litovsky <tlitovsk(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: David Caro <dcaro(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-live[master]: artwork: aligned artwork paths
by sbonazzo＠redhat.com 05 Feb '16

05 Feb '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: artwork: aligned artwork paths ...................................................................... artwork: aligned artwork paths Fixed paths to artworks with ovirt-live-artwork. Dropped images within fedora subproject already provided by ovirt-live-artwork. Change-Id: I71e534736eb7f55a3823b73d80e8d1d456e22673 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M centos-7/oVirtLiveFiles/root/etc/xdg/autostart/engine-setup.desktop M centos-7/oVirtLiveFiles/root/home/liveuser/oVirtLiveFiles/engine-setup-yad.sh M centos-7/oVirtLiveFiles/root/usr/share/applications/ovirt.desktop M fedora/kickstart/ovirt.ks D fedora/oVirtLiveFiles/desktop-backgrounds-spherical-cow.xml M fedora/oVirtLiveFiles/engine-setup-yad.sh D fedora/oVirtLiveFiles/images/ovirt-icon-128.png D fedora/oVirtLiveFiles/images/ovirt-setup.png D fedora/oVirtLiveFiles/images/ovirt-usb-stick.png D fedora/oVirtLiveFiles/images/ovirt-usb-stick.svg D fedora/oVirtLiveFiles/images/ovirt-wallpaper-16:10.jpg D fedora/oVirtLiveFiles/images/ovirt-wallpaper-16:9.jpg D fedora/oVirtLiveFiles/images/ovirt-wallpaper-4:3.jpg M fedora/oVirtLiveFiles/root/usr/share/applications/engine-setup.desktop M fedora/oVirtLiveFiles/root/usr/share/applications/ovirt.desktop 15 files changed, 17 insertions(+), 52 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/53116 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I71e534736eb7f55a3823b73d80e8d1d456e22673 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-live Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: Add job to build the API explorer
by sbonazzo＠redhat.com 05 Feb '16

05 Feb '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: Add job to build the API explorer ...................................................................... Add job to build the API explorer This patch adds the SCM configuration and the standard-ci jobs to build the API explorer. Change-Id: I346113b9efa773f72a88d67c83f245be29413943 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- A jobs/confs/projects/ovirt-engine-api-explorer/ovirt-engine-api-explorer_build-artifacts.yaml A jobs/confs/yaml/scms/ovirt-engine-api-explorer.yaml 2 files changed, 22 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me; Ready for merge Juan Hernandez: Ready for review Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/53124 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I346113b9efa773f72a88d67c83f245be29413943 Gerrit-PatchSet: 1 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: David Caro <dcaro(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: restapi: V3 compatibility for pinnig to one host
by juan.hernandez＠redhat.com 05 Feb '16

05 Feb '16

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: V3 compatibility for pinnig to one host ...................................................................... restapi: V3 compatibility for pinnig to one host In version 4 pinning to a host is done using a "hosts" element, containing exactly one "host" element. In version 3 this could also be done using directly only the "host" element. Now that the API supports multiple versions this can be rea-added to version 3 without touching the V4 implementation. Change-Id: Idaba066fe876fada4138ed3d97902f96e92042c3 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/adapters/V3VmPlacementPolicyInAdapter.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/adapters/V3VmPlacementPolicyOutAdapter.java 2 files changed, 21 insertions(+), 0 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/53029 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idaba066fe876fada4138ed3d97902f96e92042c3 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0