February 2016 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin: Fix display if Online Logical CPU Cores list
by oourfali＠redhat.com 04 Feb '16

04 Feb '16

Oved Ourfali has submitted this change and it was merged. Change subject: webadmin: Fix display if Online Logical CPU Cores list ...................................................................... webadmin: Fix display if Online Logical CPU Cores list On medium/large servers (with many cores), the "Online Logical CPU Cores" entry on the Hosts General tab, corrupts the display of other information Change-Id: I9d3b193fa431b76acbe0e334d931bab91010a163 Bug-Url: https://bugzilla.redhat.com/1301871 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostGeneralModel.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Ravi Nori: Verified Alexander Wels: Looks good to me, approved Jenkins CI: Passed CI tests Oved Ourfali: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/52932 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9d3b193fa431b76acbe0e334d931bab91010a163 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Case-insensitive match of file name patterns
by ahadas＠redhat.com 04 Feb '16

04 Feb '16

Arik Hadas has submitted this change and it was merged. Change subject: core: Case-insensitive match of file name patterns ...................................................................... core: Case-insensitive match of file name patterns In IsoDomainSyncronizer, when detecting file type by file name, match file name patterns case-insensitively. This will allow to correctly classificate files with extensions written in uppercase. Change-Id: I2948e0bc18b86a5eb98647ee9dd4b8e0c572aedb Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1154391 Signed-off-by: Shmuel Melamud <smelamud(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/IsoDomainListSyncronizer.java 1 file changed, 5 insertions(+), 4 deletions(-) Approvals: Jenkins CI: Passed CI tests Shmuel Leib Melamud: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/53070 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2948e0bc18b86a5eb98647ee9dd4b8e0c572aedb Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: UI: v2v - add support for Xen
by shavivi＠redhat.com 04 Feb '16

04 Feb '16

Shahar Havivi has submitted this change and it was merged. Change subject: UI: v2v - add support for Xen ...................................................................... UI: v2v - add support for Xen Support for importing and listing Xen VMs in import VMs dialog Change-Id: I6438860f49c882b8743be275feddc016dcaaabcc Signed-off-by: Shahar Havivi <shaharh(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVmsFromExternalProviderQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/vms/VmwareVmProviderProxy.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetVmsFromExternalProviderQueryParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/GetVmsFromExternalProviderParameters.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/GetVmsFromExternalProviderVDSCommand.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ImportSource.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ImportVmsModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/LocalizedEnums.java M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/LocalizedEnums.properties M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/ImportVmsPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/ImportVmsPopupView.ui.xml 13 files changed, 141 insertions(+), 20 deletions(-) Approvals: Shahar Havivi: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/51123 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6438860f49c882b8743be275feddc016dcaaabcc Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: VmValidator streaming
by amureini＠redhat.com 04 Feb '16

04 Feb '16

Allon Mureinik has submitted this change and it was merged. Change subject: core: VmValidator streaming ...................................................................... core: VmValidator streaming Replace the outdated of Apache Commons Collections' Predicate with modern Java 8 streaming APIs to improve the code's readability and make it more standard. Change-Id: I82f4d1590ba3865f94204c06be0ff9ba1c6adea2 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/VmValidator.java 1 file changed, 2 insertions(+), 8 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/53043 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I82f4d1590ba3865f94204c06be0ff9ba1c6adea2 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core: add code setting storage pool id in DetachNetworkFromV...
by tnisan＠redhat.com 04 Feb '16

04 Feb '16

Tal Nisan has submitted this change and it was merged. Change subject: core: add code setting storage pool id in DetachNetworkFromVdsInterfaceCommand ...................................................................... core: add code setting storage pool id in DetachNetworkFromVdsInterfaceCommand DetachNetworkFromVdsInterfaceCommand does not initialize storagePoolId property defined in CommandBase. So when method: org.ovirt.engine.core.bll.CommandBase#getMacPool is called, it will find: org.ovirt.engine.core.dal.dbbroker.auditloghandling.AuditLogableBase#getStoragePoolId to be null. Which causes MacPool not be found for null-valued datacenter. Change-Id: I2bd3d7bcb8a6bbd667d9bbde6658a8746f195692 Bug-Url: https://bugzilla.redhat.com/1299630 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/DetachNetworkFromVdsInterfaceCommand.java 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Martin Mucha: Verified Alona Kaplan: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/53082 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2bd3d7bcb8a6bbd667d9bbde6658a8746f195692 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core: Do not acquire in left-most-available order
by tnisan＠redhat.com 04 Feb '16

04 Feb '16

Tal Nisan has submitted this change and it was merged. Change subject: core: Do not acquire in left-most-available order ...................................................................... core: Do not acquire in left-most-available order Before this path, when querying MAC from pool, always the leftmost MAC, from first range with available MAC, was returned. This approach caused problems when removing/creating new VMs within short time period. To remove this problems, before MAC is returned from pool again, all other free MAC in pool has to be used. As a coincidence of this change also ranges 'takes turns'. So if we have 3 ranges and perform 3 'queries', each of them will be performed on different range, where query in this context mean 'acquisition of 1..N MACs'. Example: Assume that there are two Ranges, defined as <1,2>, <3,4,5>. Client code contains single thread, which query pool for MAC, and return it back before querying for another one. No MAC was queried so far. In this case, MAC will be returned in this order: 1, 3, 2, 4, 1, 5, 2, 3, 1, 4, 2, 5 then the sequence repeats from start. Change-Id: I00f4ebf8371c1a0e531baf7ef764c99d0be63ab2 Bug-Url: https://bugzilla.redhat.com/1269301 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/macpoolmanager/MacsStorage.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/macpoolmanager/Range.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/macpoolmanager/MacsStorageTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/macpoolmanager/RangeTest.java 4 files changed, 140 insertions(+), 9 deletions(-) Approvals: Martin Mucha: Verified Alona Kaplan: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/53081 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I00f4ebf8371c1a0e531baf7ef764c99d0be63ab2 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Removal of SnapshotType name and I18n improvement
by laravot＠redhat.com 04 Feb '16

04 Feb '16

Liron Aravot has submitted this change and it was merged. Change subject: core: Removal of SnapshotType name and I18n improvement ...................................................................... core: Removal of SnapshotType name and I18n improvement Currently the ACTION_TYPE_FAILED_VM_SNAPSHOT_TYPE_NOT_ALLOWED message supports multiple snapshot types set generically to the message. In practice, this message is used with one status only (Regular) and the generification requires specific serialization/deserialization code in the SnapshotType class and lacks i18n support. As this message is used with that status only, this patch updates it to specify it explictly (thus making it i18n compatible), if we'll need to change add support to more types in the future that can be done, right now we can remove that and the related code. Change-Id: I8fb722dd15f0ccc2ac058765bfd6802a2a21134c Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1304653 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/RemoveSnapshotCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/SnapshotsValidator.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/AttachDiskToVmCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/snapshots/SnapshotsValidatorTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/Snapshot.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 10 files changed, 25 insertions(+), 61 deletions(-) Approvals: Daniel Erez: Looks good to me, approved Allon Mureinik: Looks good to me, but someone else must approve Liron Aravot: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/52996 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8fb722dd15f0ccc2ac058765bfd6802a2a21134c Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: exttool: aaa: fix recursive loop print
by mperina＠redhat.com 04 Feb '16

04 Feb '16

Martin Peřina has submitted this change and it was merged. Change subject: exttool: aaa: fix recursive loop print ...................................................................... exttool: aaa: fix recursive loop print Change-Id: I1dc28137c59480b92ac302aae8357c59ad771eb4 Bug-Url: https://bugzilla.redhat.com/1301345 Signed-off-by: Ondra Machacek <omachace(a)redhat.com> --- M backend/manager/extensions-tool/src/main/java/org/ovirt/engine/exttool/aaa/AAAServiceImpl.java 1 file changed, 15 insertions(+), 8 deletions(-) Approvals: Ondra Machacek: Verified Martin Peřina: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/53047 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1dc28137c59480b92ac302aae8357c59ad771eb4 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6.3]: core: serialization/deserialization of SnapshotType
by tnisan＠redhat.com 04 Feb '16

04 Feb '16

Tal Nisan has submitted this change and it was merged. Change subject: core: serialization/deserialization of SnapshotType ...................................................................... core: serialization/deserialization of SnapshotType Because of the toString() implementation of SnapshotType (which is used in returned messages) its deserialization is broken. This patch fixes the serialization issue, as this code seems unneeded to me I've removed it in change I8fb722dd15f0ccc2ac058765bfd6802a2a21134c. This patch just fixes the serialization is it should be backported to the 3.6 branch and I'd like to minimize the changes and testing scope there. Change-Id: Iee7192bd4e3bdf0b56ee57d4b25c5fcc17190be7 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1303840 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/Snapshot.java 1 file changed, 18 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Passed CI tests Allon Mureinik: Looks good to me, approved Liron Aravot: Verified -- To view, visit https://gerrit.ovirt.org/53069 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iee7192bd4e3bdf0b56ee57d4b25c5fcc17190be7 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6.3 Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6.3]: core: CreateAllSnapshotsFromVmCommand - use snapshot type fr...
by tnisan＠redhat.com 04 Feb '16

04 Feb '16

Tal Nisan has submitted this change and it was merged. Change subject: core: CreateAllSnapshotsFromVmCommand - use snapshot type from params ...................................................................... core: CreateAllSnapshotsFromVmCommand - use snapshot type from params When CreateAllSnapshotsFromVmCommand is executed the snapshot type from the parameters is used if the execution is internal, otherwise a default value is used and set to the parameters. This change removes that code and sets a default value in the parameters class. Change-Id: I66d50e6189e7facfab26317e1c3270107903410e Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1303840 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/CreateAllSnapshotsFromVmParameters.java 2 files changed, 1 insertion(+), 10 deletions(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved Liron Aravot: Verified -- To view, visit https://gerrit.ovirt.org/53068 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I66d50e6189e7facfab26317e1c3270107903410e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6.3 Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0