February 2016 - Engine-commits - oVirt List Archives

Change in ovirt-live[master]: build: fix recent pep8 warnings
by sbonazzo＠redhat.com 05 Feb '16

05 Feb '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: build: fix recent pep8 warnings ...................................................................... build: fix recent pep8 warnings * Fixed errors detected with pep8 1.6.2: - E402 module level import not at top of file. - E731 do not assign a lambda expression, use a def * sorting all the imports Change-Id: Ib5044515a870d3552d690024f2eaa321f2fd0da3 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M ovirt-engine-setup-plugin-live/src/ovirt_live/__init__.py M ovirt-engine-setup-plugin-live/src/ovirt_live/constants.py M ovirt-engine-setup-plugin-live/src/plugins/ovirt_live/__init__.py M ovirt-engine-setup-plugin-live/src/plugins/ovirt_live/core.py 4 files changed, 12 insertions(+), 14 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/53115 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib5044515a870d3552d690024f2eaa321f2fd0da3 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-live Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-log-collector[master]: spec: updated to match master
by sbonazzo＠redhat.com 05 Feb '16

05 Feb '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: spec: updated to match master ...................................................................... spec: updated to match master - Updated SDK requirements - Dropped EL6 support Change-Id: If2d1df69ffb900a82c855fed889ab3308e6077a7 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M ovirt-log-collector.spec.in 1 file changed, 1 insertion(+), 9 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/53113 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If2d1df69ffb900a82c855fed889ab3308e6077a7 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-log-collector Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-image-uploader[master]: spec: updated to match master
by sbonazzo＠redhat.com 05 Feb '16

05 Feb '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: spec: updated to match master ...................................................................... spec: updated to match master - Updated SDK requirements - Dropped EL6 support Change-Id: I1a512ae3ce3690dbb6d87618b075f8c365078d2b Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M ovirt-image-uploader.spec.in 1 file changed, 2 insertions(+), 8 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/53112 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1a512ae3ce3690dbb6d87618b075f8c365078d2b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-image-uploader Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: restapi: V3 compatibility for disk "size"
by juan.hernandez＠redhat.com 05 Feb '16

05 Feb '16

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: V3 compatibility for disk "size" ...................................................................... restapi: V3 compatibility for disk "size" In version 4 the disk "size" attribute was removed in favour of "provisioned_size". Now that the API supports multiple versions this can be rea-added to version 3 without touching the V4 implementation. Change-Id: I20663c44720e6c831785a7d3ed6a8521f4568c66 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/adapters/V3DiskInAdapter.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/adapters/V3DiskOutAdapter.java 2 files changed, 9 insertions(+), 0 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/53005 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I20663c44720e6c831785a7d3ed6a8521f4568c66 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-iso-uploader[master]: spec: updated to match master
by sbonazzo＠redhat.com 05 Feb '16

05 Feb '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: spec: updated to match master ...................................................................... spec: updated to match master - Updated SDK requirements - Dropped EL6 support Change-Id: Ib7a235b1c316a4574fdc538d2c5363e8c2b289c1 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M ovirt-iso-uploader.spec.in 1 file changed, 2 insertions(+), 7 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/52950 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib7a235b1c316a4574fdc538d2c5363e8c2b289c1 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-iso-uploader Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6.3]: webadmin: Edit Fence Agent
by piotr.kliczewski＠gmail.com 05 Feb '16

05 Feb '16

Piotr Kliczewski has submitted this change and it was merged. Change subject: webadmin: Edit Fence Agent ...................................................................... webadmin: Edit Fence Agent - Fixed issue where not changing the type or management ip address on edit would cause the validation to fail with a message stating that there is a duplicate fence agent. Change-Id: Iacc04913d131706cd6ef390eba61a18bac166f58 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1304773 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/FenceAgentModel.java 1 file changed, 24 insertions(+), 1 deletion(-) Approvals: Alexander Wels: Verified Jenkins CI: Passed CI tests Greg Sheremeta: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/53105 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iacc04913d131706cd6ef390eba61a18bac166f58 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6.3 Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: Updated "Specific" label in Edit VM dialog
by awels＠redhat.com 04 Feb '16

04 Feb '16

Alexander Wels has submitted this change and it was merged. Change subject: webadmin: Updated "Specific" label in Edit VM dialog ...................................................................... webadmin: Updated "Specific" label in Edit VM dialog Changed the value of the constant associated with the "Specific" label in the Host side-tab of the Edit VM dialog popup to "Specific host(s)" to better indicate to users that multiple selection of hosts is allowed. Change-Id: Ib7f742b87f8aadf275bda2b3ebff3c37d57a3f45 Bug-Url: https://bugzilla.redhat.com/1304776 Signed-off-by: Phillip Bailey <phbailey(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java 1 file changed, 7 insertions(+), 6 deletions(-) Approvals: Alexander Wels: Looks good to me, approved Jenkins CI: Passed CI tests Phillip Bailey: Verified -- To view, visit https://gerrit.ovirt.org/53107 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib7f742b87f8aadf275bda2b3ebff3c37d57a3f45 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Phillip Bailey <phbailey(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: restapi: Add null servlet
by juan.hernandez＠redhat.com 04 Feb '16

04 Feb '16

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Add null servlet ...................................................................... restapi: Add null servlet When there is nothing mapped explicity (without patterns) to the root of the application, the servlet container assumes that requests for this root without a trailing slash correspond to a directory, and as a result it redirects, using the HTTP 302 code, to the same root with a trailing slash. For example, if the client sends this request: GET /ovirt-engine/api HTTP/1.1 The server will responds like this: HTTP/1.1 302 Found Location: https://engine.example.com/ovirt-engine/api/ This works fine for browsers, but it isn't supported by the SDKs, as they don't understand HTTP redirections. To avoid this issue this patch introduces a "null" servlet, that does nothing and is explicitly mapped to the root of the application. Change-Id: I45ddcc86b519cca6422f9347eaa18a18b305df53 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/NullServlet.java M backend/manager/modules/restapi/webapp/src/main/webapp/WEB-INF/web.xml 2 files changed, 60 insertions(+), 0 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/53106 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I45ddcc86b519cca6422f9347eaa18a18b305df53 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: restapi: Fix initialization of system resource singleton
by juan.hernandez＠redhat.com 04 Feb '16

04 Feb '16

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Fix initialization of system resource singleton ...................................................................... restapi: Fix initialization of system resource singleton This is required in order to avoid the following findbugs warning: Incorrect lazy initialization and update of static field This method contains an unsynchronized lazy initialization of a static field. After the field is set, the object stored into that location is further updated or accessed. The setting of the field is visible to other threads as soon as it is set. If the futher accesses in the method that set the field serve to initialize the object, then you have a very serious multithreading bug, unless something else prevents any other thread from accessing the stored object until it is fully initialized. Even if you feel confident that the method is never called by multiple threads, it might be better to not set the static field until the value you are setting it to is fully populated/initialized. Bug kind and pattern: LI - LI_LAZY_INIT_UPDATE_STATIC Change-Id: I0ca474dc6a65e29c128d14c13b3a512ab0373a91 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendApiResource.java 1 file changed, 5 insertions(+), 2 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/53102 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0ca474dc6a65e29c128d14c13b3a512ab0373a91 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6.3]: core: Copy non template disks correctly
by tnisan＠redhat.com 04 Feb '16

04 Feb '16

Tal Nisan has submitted this change and it was merged. Change subject: core: Copy non template disks correctly ...................................................................... core: Copy non template disks correctly When copying VM and floating disks the volume type was mistakenly set to SHARED same as template disk which prevents certain flow to execture on the volume, this patch changes this behavior and copies those non template disks and sets the volume type correctly Change-Id: I2529f04d72597b05e682937461a951538100fbd8 Bug-Url: https://bugzilla.redhat.com/1304405 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyDiskCommand.java 1 file changed, 6 insertions(+), 1 deletion(-) Approvals: Tal Nisan: Verified Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/53098 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2529f04d72597b05e682937461a951538100fbd8 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6.3 Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0