February 2016 - Engine-commits - oVirt List Archives

Change in ovirt-hosted-engine-ha[ovirt-hosted-engine-ha-1.3]: storage: fixing a double call of get_images_list
by sbonazzo＠redhat.com 24 Feb '16

24 Feb '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: storage: fixing a double call of get_images_list ...................................................................... storage: fixing a double call of get_images_list Using just result = cli.getImagesList(self._sdUUID) instead of result = cli.getImagesList(cli.getImagesList(self._sdUUID)) It's iSCSI specific since getImagesList always fails on NFS due to rhbz#1274622 but in that case scanning the directory on the mount point is enough while on iSCSI we have to rely just on getImagesList since before preparing the images we don't have a link to the volumes. Change-Id: I2baf5d24d794486b713fbafdea4049e0b885671f Bug-Url: https://bugzilla.redhat.com/1297457 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M ovirt_hosted_engine_ha/lib/image.py 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Nir Soffer: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/53937 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2baf5d24d794486b713fbafdea4049e0b885671f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: ovirt-hosted-engine-ha-1.3 Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-ha[master]: storage: fixing a double call of get_images_list
by sbonazzo＠redhat.com 24 Feb '16

24 Feb '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: storage: fixing a double call of get_images_list ...................................................................... storage: fixing a double call of get_images_list Using just result = cli.getImagesList(self._sdUUID) instead of result = cli.getImagesList(cli.getImagesList(self._sdUUID)) It's iSCSI specific since getImagesList always fails on NFS due to rhbz#1274622 but in that case scanning the directory on the mount point is enough while on iSCSI we have to rely just on getImagesList since before preparing the images we don't have a link to the volumes. Change-Id: I2baf5d24d794486b713fbafdea4049e0b885671f Bug-Url: https://bugzilla.redhat.com/1297457 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M ovirt_hosted_engine_ha/lib/image.py 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/53935 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2baf5d24d794486b713fbafdea4049e0b885671f Gerrit-PatchSet: 6 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Artyom Lukianov <alukiano(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Disabled ability to make VM HA on hosted engine
by rgolan＠redhat.com 23 Feb '16

23 Feb '16

Roy Golan has submitted this change and it was merged. Change subject: core: Disabled ability to make VM HA on hosted engine ...................................................................... core: Disabled ability to make VM HA on hosted engine Disabled checkbox for high availability in the Edit VM dialog popup and ability to change the setting via the REST API when the hosted engine option is being used. These options shouldn't be available on hosted engine because hosted engine uses a different HA mechanism than the non-hosted version. Change-Id: I088cf32361cbd2b59e328b8c31b0e63377865251 Bug-Url: https://bugzilla.redhat.com/1305330 Signed-off-by: Phillip Bailey <phbailey(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVmCommandTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ExistingVmModelBehavior.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 9 files changed, 56 insertions(+), 1 deletion(-) Approvals: Jenkins CI: Passed CI tests Daniel Erez: Looks good to me, but someone else must approve Doron Fediuck: Looks good to me, but someone else must approve Roy Golan: Looks good to me, approved Greg Sheremeta: Looks good to me, but someone else must approve Phillip Bailey: Verified -- To view, visit https://gerrit.ovirt.org/53603 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I088cf32361cbd2b59e328b8c31b0e63377865251 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Phillip Bailey <phbailey(a)redhat.com> Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6.3]: build: ovirt-engine-3.6.3.3
by tnisan＠redhat.com 23 Feb '16

23 Feb '16

Tal Nisan has submitted this change and it was merged. Change subject: build: ovirt-engine-3.6.3.3 ...................................................................... build: ovirt-engine-3.6.3.3 Change-Id: If003db031f6d2433d91c54e5054d146feef5bf6a Signed-off-by: Rafael Martins <rmartins(a)redhat.com> --- M automation/build-artifacts.sh M backend/manager/dependencies/common/pom.xml M backend/manager/dependencies/pom.xml M backend/manager/dependencies/tools/pom.xml M backend/manager/extensions-tool/pom.xml M backend/manager/modules/aaa/pom.xml M backend/manager/modules/auth-plugin/pom.xml M backend/manager/modules/bll/pom.xml M backend/manager/modules/branding/pom.xml M backend/manager/modules/builtin-extensions/pom.xml M backend/manager/modules/common/pom.xml M backend/manager/modules/compat/pom.xml M backend/manager/modules/dal/pom.xml M backend/manager/modules/docs/pom.xml M backend/manager/modules/extensions-api-root/extensions-api/pom.xml M backend/manager/modules/extensions-api-root/pom.xml M backend/manager/modules/extensions-manager/pom.xml M backend/manager/modules/logger/pom.xml M backend/manager/modules/pom.xml M backend/manager/modules/restapi/interface/common/jaxrs/pom.xml M backend/manager/modules/restapi/interface/common/pom.xml M backend/manager/modules/restapi/interface/definition/pom.xml M backend/manager/modules/restapi/interface/pom.xml M backend/manager/modules/restapi/jaxrs/pom.xml M backend/manager/modules/restapi/pom.xml M backend/manager/modules/restapi/types/pom.xml M backend/manager/modules/restapi/webapp/pom.xml M backend/manager/modules/root/pom.xml M backend/manager/modules/scheduler/pom.xml M backend/manager/modules/searchbackend/pom.xml M backend/manager/modules/services/pom.xml M backend/manager/modules/utils/pom.xml M backend/manager/modules/uutils/pom.xml M backend/manager/modules/vdsbroker/pom.xml M backend/manager/modules/welcome/pom.xml M backend/manager/pom.xml M backend/manager/tools/pom.xml M backend/pom.xml M build-tools-root/checkstyles/pom.xml M build-tools-root/jboss-modules-maven-plugin/pom.xml M build-tools-root/ovirt-checkstyle-extension/pom.xml M build-tools-root/pom.xml M build/validations/pom.xml M ear/pom.xml M frontend/pom.xml M frontend/webadmin/modules/frontend-symbols/pom.xml M frontend/webadmin/modules/frontend/pom.xml M frontend/webadmin/modules/gwt-common/pom.xml M frontend/webadmin/modules/gwt-extension/pom.xml M frontend/webadmin/modules/pom.xml M frontend/webadmin/modules/uicommonweb/pom.xml M frontend/webadmin/modules/uicompat/pom.xml M frontend/webadmin/modules/userportal-gwtp/pom.xml M frontend/webadmin/modules/webadmin/pom.xml M frontend/webadmin/pom.xml M mavenmake/pom.xml M ovirt-engine.spec.in M pom.xml M version.mak 59 files changed, 64 insertions(+), 64 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Sandro Bonazzola: Verified; Looks good to me, but someone else must approve Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/53851 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If003db031f6d2433d91c54e5054d146feef5bf6a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6.3 Gerrit-Owner: Rafael Martins <rmartins(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[ovirt-engine-3.6.3]: core: Added Roles and groups for cpu profiling
by tnisan＠redhat.com 23 Feb '16

23 Feb '16

Tal Nisan has submitted this change and it was merged. Change subject: core: Added Roles and groups for cpu profiling ...................................................................... core: Added Roles and groups for cpu profiling The following CPU Profiles were added in order to prevent unauthorized access to cpu profiles: CpuProfileOperator - Will have the ability to Assign CPU Profile to VMs. CpuProfileCreator - Will have the ability to Create/Update/Delete and Assign CPU Profile to VMs. Action groups that were added to engine and REST API: Create CPU Profile, Update CPU Profile, Remove CPU Profile, Assign CPU Profile. Roles that were granted Create/Update/Delete and Assign permissions for cpu profiles (Same as CpuProfileCreator + CpuProfileOperator): SuperUser, PowerUser, ClusterAdmin, DataCenterAdmin. Other roles that were granted permission same as the ones for CpuProfileOperator: CpuProfileCreator, UserVmManager, VmPoolAdmin, VmCreator, UserTemplateBasedVm and UserVmRuntimeManager. Before this patch, any user that had permissions for the cluster associated with the CPU Profile, could Create/Update/Delete and Assign it. The Data Access Objects tests(DAO tests) were changed inorder to comply with the new behaviour. Change-Id: I8217f0146d83afe3ae740bd1d1e37825091ed206 Bug-Url: https://bugzilla.redhat.com/1143869 Bug-Url: https://bugzilla.redhat.com/1310541 Signed-off-by: Tomer Saban <tsaban(a)redhat.com> Signed-off-by: Martin Sivak <msivak(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/PredefinedRoles.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/ActionGroup.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/FixturesTool.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/RoleDaoTest.java M backend/manager/modules/dal/src/test/resources/fixtures.xml M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/model/PermitType.java M packaging/dbscripts/cpu_profiles_sp.sql M packaging/dbscripts/create_views.sql A packaging/dbscripts/upgrade/03_06_2040_attach_cpu_profile_permissions.sql A packaging/dbscripts/upgrade/03_06_2050_create_index_cpu_profiles.sql 10 files changed, 249 insertions(+), 26 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Martin Sivák: Verified Jenkins CI: Passed CI tests Roy Golan: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/53912 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8217f0146d83afe3ae740bd1d1e37825091ed206 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6.3 Gerrit-Owner: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomer Saban <tsaban(a)redhat.com>

1 0

Change in ovirt-engine[master]: backend: add AuditLogTypes to ImportRepoImageCommand
by tnisan＠redhat.com 23 Feb '16

23 Feb '16

Tal Nisan has submitted this change and it was merged. Change subject: backend: add AuditLogTypes to ImportRepoImageCommand ...................................................................... backend: add AuditLogTypes to ImportRepoImageCommand When importing an image as a template from Glance, we log about importing an image, forgetting to mention that we import it as a template. This patch adds the missing AuditLogTypes so we can have more accurate audit logs. Change-Id: I3191725e7e22f31c05aabc98b840d8f3e6e97f03 Bug-Url: https://bugzilla.redhat.com/1310642 Signed-off-by: Idan Shaby <ishaby(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/repoimage/ImportRepoImageCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties 3 files changed, 24 insertions(+), 4 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, but someone else must approve Idan Shaby: Verified -- To view, visit https://gerrit.ovirt.org/53836 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3191725e7e22f31c05aabc98b840d8f3e6e97f03 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-ha[ovirt-hosted-engine-ha-1.3]: build: post ovirt-hosted-engine-ha-1.3.4.2
by msivak＠redhat.com 23 Feb '16

23 Feb '16

Martin Sivák has submitted this change and it was merged. Change subject: build: post ovirt-hosted-engine-ha-1.3.4.2 ...................................................................... build: post ovirt-hosted-engine-ha-1.3.4.2 Change-Id: I2e01983f5d2e16d04383e8b05bc8a909abc454a3 Signed-off-by: Rafael Martins <rmartins(a)redhat.com> --- M configure.ac M ovirt-hosted-engine-ha.spec.in 2 files changed, 9 insertions(+), 6 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Martin Sivák: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/53908 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2e01983f5d2e16d04383e8b05bc8a909abc454a3 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: ovirt-hosted-engine-ha-1.3 Gerrit-Owner: Rafael Martins <rmartins(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-ha[ovirt-hosted-engine-ha-1.3]: build: ovirt-hosted-engine-ha-1.3.4.2
by msivak＠redhat.com 23 Feb '16

23 Feb '16

Martin Sivák has submitted this change and it was merged. Change subject: build: ovirt-hosted-engine-ha-1.3.4.2 ...................................................................... build: ovirt-hosted-engine-ha-1.3.4.2 Change-Id: Id4cdf51de94589e73e992f4529b48ae33e5ac20c Signed-off-by: Rafael Martins <rmartins(a)redhat.com> --- M configure.ac M ovirt-hosted-engine-ha.spec.in 2 files changed, 11 insertions(+), 8 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Martin Sivák: Looks good to me, approved; Passed CI tests Rafael Martins: Verified -- To view, visit https://gerrit.ovirt.org/53907 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id4cdf51de94589e73e992f4529b48ae33e5ac20c Gerrit-PatchSet: 3 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: ovirt-hosted-engine-ha-1.3 Gerrit-Owner: Rafael Martins <rmartins(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-ha[ovirt-hosted-engine-ha-1.3]: storage: always pass a blank SP UUID in image.py
by msivak＠redhat.com 23 Feb '16

23 Feb '16

Martin Sivák has submitted this change and it was merged. Change subject: storage: always pass a blank SP UUID in image.py ...................................................................... storage: always pass a blank SP UUID in image.py If we are upgrading from 3.5 in the config file spuuid still point to the bootstrap storage pool so we must ignore it. On normal flow we don't realize it since all the images are already prepared by the previous 3.5 run but, it the user reboots the host just after yum update, the prepareImage will fail after the reboot and since the images are not prepared nothing else happens. Always forcing spuuid = blank there. This would not affect host that are already at 3.6 since in that case we will have for sure spUUID=00000000-0000-0000-0000-000000000000 under /etc/ovirt-hosted-engine/hosted-engine.conf Change-Id: I7bed963c8bbc4aca82185cdd7072dda4f3f2286c Bug-Url: https://bugzilla.redhat.com/1297457 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> (cherry picked from commit d93fceca78c78bb625ba98069d6eee13d8e25e92) --- M ovirt_hosted_engine_ha/lib/image.py 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Martin Sivák: Looks good to me, approved Simone Tiraboschi: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/53928 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7bed963c8bbc4aca82185cdd7072dda4f3f2286c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: ovirt-hosted-engine-ha-1.3 Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-ha[master]: storage: always pass a blank SP UUID in image.py
by msivak＠redhat.com 23 Feb '16

23 Feb '16

Martin Sivák has submitted this change and it was merged. Change subject: storage: always pass a blank SP UUID in image.py ...................................................................... storage: always pass a blank SP UUID in image.py If we are upgrading from 3.5 in the config file spuuid still point to the bootstrap storage pool so we must ignore it. On normal flow we don't realize it since all the images are already prepared by the previous 3.5 run but, it the user reboots the host just after yum update, the prepareImage will fail after the reboot and since the images are not prepared nothing else happens. Always forcing spuuid = blank there. This would not affect host that are already at 3.6 since in that case we will have for sure spUUID=00000000-0000-0000-0000-000000000000 under /etc/ovirt-hosted-engine/hosted-engine.conf Change-Id: I7bed963c8bbc4aca82185cdd7072dda4f3f2286c Bug-Url: https://bugzilla.redhat.com/1297457 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M ovirt_hosted_engine_ha/lib/image.py 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Martin Sivák: Looks good to me, approved Simone Tiraboschi: Verified Jenkins CI: Passed CI tests Artyom Lukianov: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/53927 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7bed963c8bbc4aca82185cdd7072dda4f3f2286c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Artyom Lukianov <alukiano(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0