February 2016 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Set default boot order if absent in OVF
by shavivi＠redhat.com 03 Feb '16

03 Feb '16

Shahar Havivi has submitted this change and it was merged. Change subject: core: Set default boot order if absent in OVF ...................................................................... core: Set default boot order if absent in OVF Set a default boot order if <BootOrder> elements are absent from OVF. The default boot order includes all bootable disks in the order the appear in OVF. Change-Id: I03b398f6e5ab56670eec645b490588a1674a6737 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1297202 Signed-off-by: Shmuel Melamud <smelamud(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ConvertVmCommand.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfReader.java 2 files changed, 21 insertions(+), 0 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Shmuel Leib Melamud: Verified Arik Hadas: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/52991 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I03b398f6e5ab56670eec645b490588a1674a6737 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-1.3]: cloud-init: disable cloud-init services after appliance depl...
by sbonazzo＠redhat.com 03 Feb '16

03 Feb '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: cloud-init: disable cloud-init services after appliance deployment ...................................................................... cloud-init: disable cloud-init services after appliance deployment Disabling cloud-init services on the engine-appliance after deployment in order to speed up subsequent boots. Change-Id: Ic432dfed4625d5557567b880f9779acd6eaae7cf Bug-Url: https://bugzilla.redhat.com/1299200 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M src/plugins/ovirt-hosted-engine-setup/vm/cloud_init.py 1 file changed, 7 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved; Passed CI tests Simone Tiraboschi: Verified -- To view, visit https://gerrit.ovirt.org/52963 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic432dfed4625d5557567b880f9779acd6eaae7cf Gerrit-PatchSet: 2 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: ovirt-hosted-engine-setup-1.3 Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6.3]: packaging: rename: Handle storage domains more nicely
by tnisan＠redhat.com 02 Feb '16

02 Feb '16

Tal Nisan has submitted this change and it was merged. Change subject: packaging: rename: Handle storage domains more nicely ...................................................................... packaging: rename: Handle storage domains more nicely Check all NFS, not only iso, in case data domains are also on engine. Notify user about active machines/domains on engine machine. Change-Id: I5a23ca3bb75efb23227c761b2aa4369d5828cf7f Bug-Url: https://bugzilla.redhat.com/1250556 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> (cherry picked from commit d1da280c79f861fad810707ceef4e465163b41ab) --- M packaging/setup/ovirt_engine_setup/domains.py M packaging/setup/plugins/ovirt-engine-rename/ovirt-engine/database.py 2 files changed, 235 insertions(+), 52 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Jenkins CI: Passed CI tests Yedidyah Bar David: Verified -- To view, visit https://gerrit.ovirt.org/52899 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5a23ca3bb75efb23227c761b2aa4369d5828cf7f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6.3 Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: packaging: rename: Handle storage domains more nicely
by tnisan＠redhat.com 02 Feb '16

02 Feb '16

Tal Nisan has submitted this change and it was merged. Change subject: packaging: rename: Handle storage domains more nicely ...................................................................... packaging: rename: Handle storage domains more nicely Check all NFS, not only iso, in case data domains are also on engine. Notify user about active machines/domains on engine machine. Change-Id: I5a23ca3bb75efb23227c761b2aa4369d5828cf7f Bug-Url: https://bugzilla.redhat.com/1250556 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/setup/ovirt_engine_setup/domains.py M packaging/setup/plugins/ovirt-engine-rename/ovirt-engine/database.py 2 files changed, 235 insertions(+), 52 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Jenkins CI: Passed CI tests Yedidyah Bar David: Verified -- To view, visit https://gerrit.ovirt.org/52898 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5a23ca3bb75efb23227c761b2aa4369d5828cf7f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-setup[master]: cloud-init: disable cloud-init services after appliance depl...
by sbonazzo＠redhat.com 02 Feb '16

02 Feb '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: cloud-init: disable cloud-init services after appliance deployment ...................................................................... cloud-init: disable cloud-init services after appliance deployment Disabling cloud-init services on the engine-appliance after deployment in order to speed up subsequent boots. Change-Id: Ic432dfed4625d5557567b880f9779acd6eaae7cf Bug-Url: https://bugzilla.redhat.com/1299200 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M src/plugins/ovirt-hosted-engine-setup/vm/cloud_init.py 1 file changed, 7 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/52453 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic432dfed4625d5557567b880f9779acd6eaae7cf Gerrit-PatchSet: 4 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-1.3]: storage: remove mount.glusterfs related warning
by sbonazzo＠redhat.com 02 Feb '16

02 Feb '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: storage: remove mount.glusterfs related warning ...................................................................... storage: remove mount.glusterfs related warning The issues with mount.glusterfs has been fixed, removing the warning. Change-Id: I74f43a13a92a2bca4e91c52bc61a124ec8b79762 Bug-Url: https://bugzilla.redhat.com/1287397 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M src/plugins/ovirt-hosted-engine-setup/storage/nfs.py 1 file changed, 0 insertions(+), 11 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/52444 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I74f43a13a92a2bca4e91c52bc61a124ec8b79762 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: ovirt-hosted-engine-setup-1.3 Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-1.3]: packaging: setup: ensure that memory is always stored as int...
by sbonazzo＠redhat.com 02 Feb '16

02 Feb '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: ensure that memory is always stored as integer ...................................................................... packaging: setup: ensure that memory is always stored as integer Change-Id: I7511664fd1a3addb3a4e8e4fddcf04e72b4094cc Bug-Url: https://bugzilla.redhat.com/1300245 Signed-off-by: Rafael Martins <rmartins(a)redhat.com> (cherry picked from commit 98dc90d4a68f020b2320b7bdb37f0035609965e4) --- M src/plugins/ovirt-hosted-engine-setup/vm/boot_disk.py M src/plugins/ovirt-hosted-engine-setup/vm/memory.py 2 files changed, 17 insertions(+), 3 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Jenkins CI: Passed CI tests Rafael Martins: Verified -- To view, visit https://gerrit.ovirt.org/52593 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7511664fd1a3addb3a4e8e4fddcf04e72b4094cc Gerrit-PatchSet: 3 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: ovirt-hosted-engine-setup-1.3 Gerrit-Owner: Rafael Martins <rmartins(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: Enable template name in Glance import
by tnisan＠redhat.com 02 Feb '16

02 Feb '16

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Enable template name in Glance import ...................................................................... webadmin: Enable template name in Glance import The user is able to specify the template name when importing an image as template from Glance. Change-Id: I7fb6d9c2384f8919264df704640c4ffbe88c1ce4 Bug-Url: https://bugzilla.redhat.com/1240954 Signed-off-by: Fred Rolland <frolland(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/ImportExportRepoImageBaseModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/ImportRepoImageModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/ImportExportImagePopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/ImportExportImagePopupView.ui.xml 5 files changed, 47 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, but someone else must approve Freddy Rolland: Verified -- To view, visit https://gerrit.ovirt.org/52534 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7fb6d9c2384f8919264df704640c4ffbe88c1ce4 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Fred Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core: Only allow continuous numa node indices
by tnisan＠redhat.com 02 Feb '16

02 Feb '16

Tal Nisan has submitted this change and it was merged. Change subject: core: Only allow continuous numa node indices ...................................................................... core: Only allow continuous numa node indices QEMU only allow continuous virtual NUMA nodes indices. Therefore, on numa node creation, update and removal make sure that: * every index exists only once * the smallest index starts with 0 * no index is missing. Change-Id: I05e38768be59d9c2eee8a114a3e6d1f684ab5d2d Bug-Url: https://bugzilla.redhat.com/1126180 Signed-off-by: Roman Mohr <rmohr(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/numa/vm/AbstractVmNumaNodeCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/numa/vm/NumaValidator.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/numa/vm/RemoveVmNumaNodesCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/numa/vm/AddVmNumaNodesCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/numa/vm/NumaValidatorTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/numa/vm/RemoveVmNumaNodesCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/numa/vm/SetVmNumaNodesCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/numa/vm/UpdateVmNumaNodesCommandTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 12 files changed, 195 insertions(+), 43 deletions(-) Approvals: Roman Mohr: Verified Jenkins CI: Passed CI tests Roy Golan: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/52924 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I05e38768be59d9c2eee8a114a3e6d1f684ab5d2d Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: webadmin: Consistent relation memory - guaranteed memory
by tnisan＠redhat.com 02 Feb '16

02 Feb '16

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Consistent relation memory - guaranteed memory ...................................................................... webadmin: Consistent relation memory - guaranteed memory * Null checks added * If value of 'System' > 'Memory Size' is changed, value of 'Resource allocation' > 'Physical Memory Guaranteed' is set to (memory size / cluster over-commitment factor) for following dialogs: * New/Edit VM * New Pool * Values 'Memory Size' and 'Physical Memory Guaranteed' are not connected for dialogs: * New/Edit Template * New/Edit Instance Type Change-Id: I2c1d257b6edc81964272474510afd004248b9e39 Bug-Url: https://bugzilla.redhat.com/1302582 Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ExistingVmModelBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewTemplateVmModelBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewVmModelBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/PoolModelBehaviorBase.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/TemplateVmModelBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmModelBehaviorBase.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/instancetypes/NewInstanceTypeModelBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/instancetypes/NonClusterModelBehaviorBase.java 8 files changed, 16 insertions(+), 27 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Jakub Niedermertl: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/52921 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2c1d257b6edc81964272474510afd004248b9e39 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0