Change in ovirt-engine[master]: core: UntaggedNetworkPredicate streaming
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: UntaggedNetworkPredicate streaming
......................................................................
core: UntaggedNetworkPredicate streaming
Replaced the old-fashioned, relatively hard to read, Apache Commons
Collections usage with a more modern, standard, Java 8 streaming API
usage.
Change-Id: If286c7d411e06b7f81b5b8e71355400077e7a645
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/network/UntaggedNetworkPredicate.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/network/VlanUntaggedNetworkExclusivenessValidator.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/network/UntaggedNetworkPredicateTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/network/VlanUntaggedNetworkExclusivenessValidatorTest.java
4 files changed, 17 insertions(+), 20 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Allon Mureinik: Verified; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/53018
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If286c7d411e06b7f81b5b8e71355400077e7a645
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in ovirt-engine[master]: core: GetAllDiskSnapshotsByStorageDomainIdQuery streaming
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: GetAllDiskSnapshotsByStorageDomainIdQuery streaming
......................................................................
core: GetAllDiskSnapshotsByStorageDomainIdQuery streaming
Replace the outdated of Apache Commons Collections' Predicate with
modern Java 8 streaming APIs to improve the code's readability and make
it more standard.
Change-Id: Ic9ee22129f59f0205ffaa8620a1f99cd1d8ef1e0
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/GetAllDiskSnapshotsByStorageDomainIdQuery.java
1 file changed, 2 insertions(+), 8 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Allon Mureinik: Verified; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/53025
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic9ee22129f59f0205ffaa8620a1f99cd1d8ef1e0
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in ovirt-engine[master]: core: DiskImageDaoTest streaming API
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: DiskImageDaoTest streaming API
......................................................................
core: DiskImageDaoTest streaming API
Replaced the cumbersome org.apache.commons.collections.Predicate usage
with a cleaner, straight-forward built in streaming API.
Note that this change is made possible by upgrading the Spring version
we use done in patch 38d542e9b170bda3966d58a283ffb96014d666d1.
Change-Id: I044c8d49676666e21b4930602ed7b0cc924b326f
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/DiskImageDaoTest.java
1 file changed, 1 insertion(+), 7 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Martin Peřina: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Allon Mureinik: Verified
--
To view, visit https://gerrit.ovirt.org/52957
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I044c8d49676666e21b4930602ed7b0cc924b326f
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in ovirt-engine[master]: webadmin: Warn for suspended VMs when cluster change
by ahadas＠redhat.com
Arik Hadas has submitted this change and it was merged.
Change subject: webadmin: Warn for suspended VMs when cluster change
......................................................................
webadmin: Warn for suspended VMs when cluster change
The user gets warning:
- if changing cluster compatibility version on a cluster
with suspended VMs (Edit Cluster dialog, upgrading cluster).
- if changing cluster of a suspended VM (Edit VM dialog)
- if changing VM's custom compatibility version (Edit VM dialog)
Suggested operation: power off suspended VM(s) when changing
cluster version or moving VM between clusters of different versions.
Change-Id: I74066a3d7a62d1e994d185e6daaae436e4f5d175
Bug-Url: https://bugzilla.redhat.com/1298487
Signed-off-by: Marek Libra <mlibra(a)redhat.com>
---
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SuspendedVMClusterEditChecker.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java
A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/CommonCompatibilityVersionUtils.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/CompatibilityVersionUtils.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ExistingVmModelBehavior.java
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
10 files changed, 89 insertions(+), 13 deletions(-)
Approvals:
Tomas Jelinek: Looks good to me, but someone else must approve
Shmuel Leib Melamud: Looks good to me, but someone else must approve
Marek Libra: Verified
Arik Hadas: Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/52859
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I74066a3d7a62d1e994d185e6daaae436e4f5d175
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Marek Libra <mlibra(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marek Libra <mlibra(a)redhat.com>
Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in ovirt-engine[master]: webadmin: one MAC address range must contain less than (2^31...
by alkaplan＠redhat.com
Alona Kaplan has submitted this change and it was merged.
Change subject: webadmin: one MAC address range must contain less than (2^31)-1 MACs.
......................................................................
webadmin: one MAC address range must contain less than (2^31)-1 MACs.
Change-Id: I9f68ce9282573c3a0f33e16531e74df40b46ec0f
Bug-Url: https://bugzilla.redhat.com/1219383
Signed-off-by: Martin Mucha <mmucha(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/validation/MacRangeValidation.java
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java
2 files changed, 29 insertions(+), 3 deletions(-)
Approvals:
Tomas Jelinek: Looks good to me, but someone else must approve
Martin Mucha: Verified
Alona Kaplan: Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/47735
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9f68ce9282573c3a0f33e16531e74df40b46ec0f
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in ovirt-engine[master]: restapi: Use version 4.0.4 of the model
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: restapi: Use version 4.0.4 of the model
......................................................................
restapi: Use version 4.0.4 of the model
This patch modifies the API so that it uses version 4.0.4 of the model.
This version is needed because it includes some fixes that are required
in order to build correctly the adapters that transform V3 objects to V4
objects.
Change-Id: I694e9b43107bd34d50cb03a4369b4f46a04c47e5
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M pom.xml
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/53002
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I694e9b43107bd34d50cb03a4369b4f46a04c47e5
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in ovirt-engine[ovirt-engine-3.6.3]: core: cleanup cmd data when compensation deleted
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: cleanup cmd data when compensation deleted
......................................................................
core: cleanup cmd data when compensation deleted
This patch validates that when compensation data is deleted, the
corresponding entries in the command_entities table are deleted as well.
Change-Id: I8889f52a6ac44de4c1aa2b16d82c799e345a740f
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1303163
Signed-off-by: emesika <emesika(a)redhat.com>
---
M packaging/setup/dbutils/taskcleaner_sp.sql
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/upgrade/asynctasks.py
2 files changed, 32 insertions(+), 1 deletion(-)
Approvals:
Eli Mesika: Verified
Jenkins CI: Passed CI tests
Oved Ourfali: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/52956
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8889f52a6ac44de4c1aa2b16d82c799e345a740f
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6.3
Gerrit-Owner: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in ovirt-engine[ovirt-engine-3.6]: core: cleanup cmd data when compensation deleted
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: cleanup cmd data when compensation deleted
......................................................................
core: cleanup cmd data when compensation deleted
This patch validates that when compensation data is deleted, the
corresponding entries in the command_entities table are deleted as well.
Change-Id: I8889f52a6ac44de4c1aa2b16d82c799e345a740f
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1303163
Signed-off-by: emesika <emesika(a)redhat.com>
---
M packaging/setup/dbutils/taskcleaner_sp.sql
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/upgrade/asynctasks.py
2 files changed, 32 insertions(+), 1 deletion(-)
Approvals:
Eli Mesika: Verified
Jenkins CI: Passed CI tests
Oved Ourfali: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/52955
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8889f52a6ac44de4c1aa2b16d82c799e345a740f
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in ovirt-engine[master]: core: Do not acquire in left-most-available order
by alkaplan＠redhat.com
Alona Kaplan has submitted this change and it was merged.
Change subject: core: Do not acquire in left-most-available order
......................................................................
core: Do not acquire in left-most-available order
Before this path, when querying MAC from pool, always the leftmost
MAC, from first range with available MAC, was returned. This approach
caused problems when removing/creating new VMs within short time
period.
To remove this problems, before MAC is returned from pool again, all
other free MAC in pool has to be used. As a coincidence of this
change also ranges 'takes turns'. So if we have 3 ranges and perform 3
'queries', each of them will be performed on different range, where
query in this context mean 'acquisition of 1..N MACs'.
Example:
Assume that there are two Ranges, defined as <1,2>, <3,4,5>. Client
code contains single thread, which query pool for MAC, and return it
back before querying for another one. No MAC was queried so far. In
this case, MAC will be returned in this order:
1, 3, 2, 4, 1, 5, 2, 3, 1, 4, 2, 5
then the sequence repeats from start.
Change-Id: I00f4ebf8371c1a0e531baf7ef764c99d0be63ab2
Bug-Url: https://bugzilla.redhat.com/1269301
Signed-off-by: Martin Mucha <mmucha(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/macpoolmanager/MacsStorage.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/macpoolmanager/Range.java
A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/macpoolmanager/MacsStorageTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/macpoolmanager/RangeTest.java
4 files changed, 140 insertions(+), 9 deletions(-)
Approvals:
Martin Mucha: Verified
Alona Kaplan: Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/49502
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I00f4ebf8371c1a0e531baf7ef764c99d0be63ab2
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com>
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in ovirt-engine[master]: core: Remove unused method from CommandCallback
by masayag＠redhat.com
Moti Asayag has submitted this change and it was merged.
Change subject: core: Remove unused method from CommandCallback
......................................................................
core: Remove unused method from CommandCallback
Change-Id: I2ab16f1ce12e6dad5cd1b8e04229566fbb17a3d5
Signed-off-by: Moti Asayag <masayag(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandExecutor.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/interfaces/CommandCallback.java
2 files changed, 0 insertions(+), 12 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Moti Asayag: Verified
Liron Aravot: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/52853
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2ab16f1ce12e6dad5cd1b8e04229566fbb17a3d5
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months