February 2016 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: serialization/deserialization of SnapshotType
by laravot＠redhat.com 03 Feb '16

03 Feb '16

Liron Aravot has submitted this change and it was merged. Change subject: core: serialization/deserialization of SnapshotType ...................................................................... core: serialization/deserialization of SnapshotType Because of the toString() implementation of SnapshotType (which is used in returned messages) its deserialization is broken. This patch fixes the serialization issue, as this code seems unneeded to me I've removed it in change I8fb722dd15f0ccc2ac058765bfd6802a2a21134c. This patch just fixes the serialization is it should be backported to the 3.6 branch and I'd like to minimize the changes and testing scope there. Change-Id: Iee7192bd4e3bdf0b56ee57d4b25c5fcc17190be7 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1303840 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/Snapshot.java 1 file changed, 18 insertions(+), 0 deletions(-) Approvals: Allon Mureinik: Looks good to me, but someone else must approve Moti Asayag: Looks good to me, approved Liron Aravot: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/52995 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iee7192bd4e3bdf0b56ee57d4b25c5fcc17190be7 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Fix DLS in CommandExecutor
by masayag＠redhat.com 03 Feb '16

03 Feb '16

Moti Asayag has submitted this change and it was merged. Change subject: core: Fix DLS in CommandExecutor ...................................................................... core: Fix DLS in CommandExecutor Commit 26cc6a0aa334f0b9c1e80b8f4e46cec8210597e7 removed the usage of the local callback variable, but did not remove the variable itself, creating a DLS. This patch removes it in order to appease FindBugs. Change-Id: Ib819160d0c44e2768c06aa9281828b9f4f60f8ae Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandExecutor.java 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Allon Mureinik: Verified Moti Asayag: Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/53057 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib819160d0c44e2768c06aa9281828b9f4f60f8ae Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: hosted engine: Avoid choosing the hosted engine sd as ...
by rgolan＠redhat.com 03 Feb '16

03 Feb '16

Roy Golan has submitted this change and it was merged. Change subject: core: hosted engine: Avoid choosing the hosted engine sd as master ...................................................................... core: hosted engine: Avoid choosing the hosted engine sd as master Hosted engine domain will be under domain-monitoring in bootstrap mode and when there is no pool and that prevents VDSM in connecting it to the pool. to avoid further locking and special treatment we have for SPM we would completly avoid using that domain as master. Change-Id: Idd42aa656bea838059aaa274c91e7a5400b3b797 Bug-Url: https://bugzilla.redhat.com/1298697 Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostedengine/HostedEngineHelper.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/StorageDomainCommandBase.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/domain/StorageDomainCommandBaseTest.java 3 files changed, 70 insertions(+), 0 deletions(-) Approvals: Roman Mohr: Verified Jenkins CI: Passed CI tests Roy Golan: Looks good to me, approved Liron Aravot: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/52351 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idd42aa656bea838059aaa274c91e7a5400b3b797 Gerrit-PatchSet: 15 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6.3]: Use the proper whitelist for MigrateVmCommand.canDoAction
by tnisan＠redhat.com 03 Feb '16

03 Feb '16

Tal Nisan has submitted this change and it was merged. Change subject: Use the proper whitelist for MigrateVmCommand.canDoAction ...................................................................... Use the proper whitelist for MigrateVmCommand.canDoAction The execute methods gets whitelist using the getVdsWhiteList method. But canDoAction used getParameters directly. This caused trouble for MigrateVmToServerCommand which overrides getVdsWhitelist as a different value was used for canDoAction and execute calls. Change-Id: Ieb03d8d7933cca6c87c255d5e846c9c3cb14ee33 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1258960 Signed-off-by: Martin Sivak <msivak(a)redhat.com> (cherry picked from commit 4fc4bb5ab27c8e0c69112d4c331aeaa6e4774e86) --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmCommand.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Martin Sivák: Verified Jenkins CI: Passed CI tests Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/53038 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ieb03d8d7933cca6c87c255d5e846c9c3cb14ee33 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6.3 Gerrit-Owner: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: CreateAllSnapshotsFromVmCommand - use snapshot type fr...
by laravot＠redhat.com 03 Feb '16

03 Feb '16

Liron Aravot has submitted this change and it was merged. Change subject: core: CreateAllSnapshotsFromVmCommand - use snapshot type from params ...................................................................... core: CreateAllSnapshotsFromVmCommand - use snapshot type from params When CreateAllSnapshotsFromVmCommand is executed the snapshot type from the parameters is used if the execution is internal, otherwise a default value is used and set to the parameters. This change removes that code and sets a default value in the parameters class. Change-Id: I66d50e6189e7facfab26317e1c3270107903410e Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1303840 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/CreateAllSnapshotsFromVmCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/CreateAllSnapshotsFromVmParameters.java 2 files changed, 1 insertion(+), 10 deletions(-) Approvals: Jenkins CI: Passed CI tests Daniel Erez: Looks good to me, approved Liron Aravot: Verified -- To view, visit https://gerrit.ovirt.org/52918 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I66d50e6189e7facfab26317e1c3270107903410e Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6.3]: webadmin: Warn for suspended VMs when cluster change
by tnisan＠redhat.com 03 Feb '16

03 Feb '16

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Warn for suspended VMs when cluster change ...................................................................... webadmin: Warn for suspended VMs when cluster change The user gets warning: - if changing cluster compatibility version on a cluster with suspended VMs (Edit Cluster dialog, upgrading cluster). - if changing cluster of a suspended VM (Edit VM dialog) - if changing VM's custom compatibility version (Edit VM dialog) Suggested operation: power off suspended VM(s) when changing cluster version or moving VM between clusters of different versions. Change-Id: I74066a3d7a62d1e994d185e6daaae436e4f5d175 Bug-Url: https://bugzilla.redhat.com/1298487 Signed-off-by: Marek Libra <mlibra(a)redhat.com> --- A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SuspendedVMClusterEditChecker.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ExistingVmModelBehavior.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 8 files changed, 63 insertions(+), 0 deletions(-) Approvals: Jenkins CI: Passed CI tests Marek Libra: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/53034 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I74066a3d7a62d1e994d185e6daaae436e4f5d175 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6.3 Gerrit-Owner: Marek Libra <mlibra(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marek Libra <mlibra(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: packaging: Make a DB validation error more clear
by sbonazzo＠redhat.com 03 Feb '16

03 Feb '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: Make a DB validation error more clear ...................................................................... packaging: Make a DB validation error more clear Signed-off-by: Lev Veyde <lveyde(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/1261335 Change-Id: Ib0fdb664d93b53953aeeda78f5c7ca2478a448e9 --- M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/upgrade/dbvalidations.py 1 file changed, 26 insertions(+), 6 deletions(-) Approvals: Lev Veyde: Verified Sandro Bonazzola: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/47743 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib0fdb664d93b53953aeeda78f5c7ca2478a448e9 Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: restapi: Fix RSDL for adding clusters
by tnisan＠redhat.com 03 Feb '16

03 Feb '16

Tal Nisan has submitted this change and it was merged. Change subject: restapi: Fix RSDL for adding clusters ...................................................................... restapi: Fix RSDL for adding clusters The RSDL metadata doesn't document correctly the use of the "scheduling_policy.name" element for adding a cluster. As a result the Python SDK doesn't document it in its documentation comments and the CLI doesn't list it in autocompletion. This patch fixes that issue. Change-Id: I3418e301679c31eec3950c4428485d48e39cad73 Bug-Url: https://bugzilla.redhat.com/1279159 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Juan Hernandez: Looks good to me, approved Jenkins CI: Passed CI tests Roy Golan: Verified -- To view, visit https://gerrit.ovirt.org/52927 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3418e301679c31eec3950c4428485d48e39cad73 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6.3]: webadmin: added warning when import windows without virtio
by tnisan＠redhat.com 03 Feb '16

03 Feb '16

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: added warning when import windows without virtio ...................................................................... webadmin: added warning when import windows without virtio It is dangerous not to attach VirtIO driwers to windows VMs - added message to warn the user. Change-Id: Iec069ed5a5b021f0dadb594dcc7e087b00bf062c Bug-Url: https://bugzilla.redhat.com/1296593 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ImportVmFromExternalProviderModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/vm/ImportVmFromExternalProviderPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/vm/ImportVmFromExternalProviderPopupView.ui.xml 4 files changed, 60 insertions(+), 1 deletion(-) Approvals: Shahar Havivi: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/53028 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iec069ed5a5b021f0dadb594dcc7e087b00bf062c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6.3 Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: webadmin: Warn for suspended VMs when cluster change
by tnisan＠redhat.com 03 Feb '16

03 Feb '16

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Warn for suspended VMs when cluster change ...................................................................... webadmin: Warn for suspended VMs when cluster change The user gets warning: - if changing cluster compatibility version on a cluster with suspended VMs (Edit Cluster dialog, upgrading cluster). - if changing cluster of a suspended VM (Edit VM dialog) - if changing VM's custom compatibility version (Edit VM dialog) Suggested operation: power off suspended VM(s) when changing cluster version or moving VM between clusters of different versions. Change-Id: I74066a3d7a62d1e994d185e6daaae436e4f5d175 Bug-Url: https://bugzilla.redhat.com/1298487 Signed-off-by: Marek Libra <mlibra(a)redhat.com> --- A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SuspendedVMClusterEditChecker.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ExistingVmModelBehavior.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 8 files changed, 63 insertions(+), 0 deletions(-) Approvals: Tomas Jelinek: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Marek Libra: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/53026 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I74066a3d7a62d1e994d185e6daaae436e4f5d175 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Marek Libra <mlibra(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marek Libra <mlibra(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0