March 2016 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: Revert "core: prevent a race on add template version"
by ahadas＠redhat.com 28 Mar '16

28 Mar '16

Arik Hadas has submitted this change and it was merged. Change subject: Revert "core: prevent a race on add template version" ...................................................................... Revert "core: prevent a race on add template version" This reverts commit 0c02d2930c1b0064417d1f2b22871a61b86ddc72. Cannot add null value to ConcurrentHashMap. Not sure how it wasn't catched in the verification. Change-Id: Icbb7fd15dcee11d40c26edcbff429914d2dc690f Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/exclude-filters.xml M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java 2 files changed, 0 insertions(+), 11 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/55345 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icbb7fd15dcee11d40c26edcbff429914d2dc690f Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Remove VmTemplateCommand#executeCommand
by ahadas＠redhat.com 28 Mar '16

28 Mar '16

Arik Hadas has submitted this change and it was merged. Change subject: core: Remove VmTemplateCommand#executeCommand ...................................................................... core: Remove VmTemplateCommand#executeCommand Throwing a NotImplementedException isn't a useful behavior - its just a stub implementation intended to mark that whoever extends this class should override this method. A much better way to do this is to declare the class abstract (as it already is), and leave this method unimplemented, so overriding it is checked in compile time. Change-Id: Ia96bf6ddfd5ca194a70f86742be609ec8a400d4e Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmTemplateCommand.java 1 file changed, 0 insertions(+), 6 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/55297 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia96bf6ddfd5ca194a70f86742be609ec8a400d4e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-live[master]: plugins: Remove unneeded after=
by didi＠redhat.com 28 Mar '16

28 Mar '16

Yedidyah Bar David has submitted this change and it was merged. Change subject: plugins: Remove unneeded after= ...................................................................... plugins: Remove unneeded after= No need to set after=event2 in event1 if event2 runs at a later stage. Change-Id: Ifb8d0c071f369af8c9597c6666bc1d41eb6da4ab Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M ovirt-engine-setup-plugin-live/src/plugins/all-in-one/vdsmi.py 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Jenkins CI: Passed CI tests Yedidyah Bar David: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/55340 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifb8d0c071f369af8c9597c6666bc1d41eb6da4ab Gerrit-PatchSet: 1 Gerrit-Project: ovirt-live Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: userportal: Fixed New Template dialog size
by derez＠redhat.com 28 Mar '16

28 Mar '16

Daniel Erez has submitted this change and it was merged. Change subject: userportal: Fixed New Template dialog size ...................................................................... userportal: Fixed New Template dialog size Changed the size of the New Template dialog in the user portal so elements won't slide off it when "Create as a Template Sub Version" widget is open. Change-Id: I366f19dc7bb6efd8a2b4b96f539a80d269de5e1b Bug-Url: https://bugzilla.redhat.com/1190142 Signed-off-by: Tomer Saban <tsaban(a)redhat.com> --- M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/popup/vm/VmMakeTemplatePopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/vm/VmMakeTemplatePopupView.java 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Jenkins CI: Passed CI tests Daniel Erez: Looks good to me, approved Tomer Saban: Verified -- To view, visit https://gerrit.ovirt.org/54453 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I366f19dc7bb6efd8a2b4b96f539a80d269de5e1b Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomer Saban <tsaban(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Tomer Saban <tsaban(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk[sdk_3.6]: sdk: Support URL parameters in actions
by juan.hernandez＠redhat.com 28 Mar '16

28 Mar '16

Juan Hernandez has submitted this change and it was merged. Change subject: sdk: Support URL parameters in actions ...................................................................... sdk: Support URL parameters in actions Currently the SDK doesn't support the URL parameters that are available in some actions. For example, the action to deactivate a host supports the "async" parameter, but it isn't possible to use in the SDK because the signature of the "deactivate" method doesn't contain it: def deactivate( self, action=params.Action(), correlation_id=None ) It should be like this instead: def deactivate( self, action=params.Action(), correlation_id=None, async=None ) In order to support that this patch modifies the code generator so that these URL parameters are added to the signature, and sent to the server. Change-Id: I7cad178d3b7d809d5bb81efcc128a671e97bdea3 Bug-Url: https://bugzilla.redhat.com/1311495 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M generator/src/main/java/org/ovirt/engine/sdk/generator/python/Action.java M generator/src/main/java/org/ovirt/engine/sdk/generator/python/Documentation.java M generator/src/main/java/org/ovirt/engine/sdk/generator/python/templates/ResourceActionTemplate M src/ovirtsdk/infrastructure/brokers.py 4 files changed, 1,252 insertions(+), 775 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/53962 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7cad178d3b7d809d5bb81efcc128a671e97bdea3 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: sdk_3.6 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: text: slightly improve English
by alkaplan＠redhat.com 28 Mar '16

28 Mar '16

Alona Kaplan has submitted this change and it was merged. Change subject: text: slightly improve English ...................................................................... text: slightly improve English Change-Id: Ib3600459e9bee5d5bf36398aa52a2d15a6e0312f Bug-Url: https://bugzilla.redhat.com/1261795 Signed-off-by: Dan Kenigsberg <danken(a)redhat.com> --- M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 3 files changed, 3 insertions(+), 3 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/55289 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib3600459e9bee5d5bf36398aa52a2d15a6e0312f Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in otopi[master]: core: flush in _earlyDebug
by didi＠redhat.com 28 Mar '16

28 Mar '16

Yedidyah Bar David has submitted this change and it was merged. Change subject: core: flush in _earlyDebug ...................................................................... core: flush in _earlyDebug Change-Id: Ia63f0e58d355afc9b153bc5ef6d9538f00f96617 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M src/otopi/context.py 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Jenkins CI: Passed CI tests Yedidyah Bar David: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/55326 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia63f0e58d355afc9b153bc5ef6d9538f00f96617 Gerrit-PatchSet: 1 Gerrit-Project: otopi Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Support configurable mixed RHEL 6, 7 check
by rgolan＠redhat.com 28 Mar '16

28 Mar '16

Roy Golan has submitted this change and it was merged. Change subject: core: Support configurable mixed RHEL 6, 7 check ...................................................................... core: Support configurable mixed RHEL 6, 7 check Today we ban adding a host with RHEL 7 to a cluster with RHEL 6 or vice versa. This patch will make that check configurable leaving the default behaviour as is for 3.5 and disabling it onward. Change-Id: I1d99473ed8a068fbafde3f11605a942f6a8f989c Bug-Url: https://bugzilla.redhat.com/1241149 Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VirtMonitoringStrategy.java M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/monitoring/VirtMonitoringStrategyTest.java M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql M packaging/etc/engine-config/engine-config.properties 5 files changed, 24 insertions(+), 2 deletions(-) Approvals: Eli Mesika: Looks good to me, but someone else must approve Roman Mohr: Verified Jenkins CI: Passed CI tests Roy Golan: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/45851 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1d99473ed8a068fbafde3f11605a942f6a8f989c Gerrit-PatchSet: 13 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <mskrivan(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <d.mosquito(a)gmail.com> Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in otopi[master]: automation: build-artifacts: createrepo
by didi＠redhat.com 28 Mar '16

28 Mar '16

Yedidyah Bar David has submitted this change and it was merged. Change subject: automation: build-artifacts: createrepo ...................................................................... automation: build-artifacts: createrepo Change-Id: I949e16fec9802a705ef87ce0fcb5cf1f50589fdf Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M automation/build-artifacts.packages M automation/build-artifacts.sh M automation/check-merged.packages M automation/check-patch.packages 4 files changed, 6 insertions(+), 0 deletions(-) Approvals: Jenkins CI: Passed CI tests Yedidyah Bar David: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/55325 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I949e16fec9802a705ef87ce0fcb5cf1f50589fdf Gerrit-PatchSet: 2 Gerrit-Project: otopi Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: packaging: Conflict on version below 3.5.6
by tnisan＠redhat.com 28 Mar '16

28 Mar '16

Tal Nisan has submitted this change and it was merged. Change subject: packaging: Conflict on version below 3.5.6 ...................................................................... packaging: Conflict on version below 3.5.6 Change-Id: I39c1394358e5cf16bf748ddd75890a4f834020e4 Signed-off-by: Lev Veyde <lveyde(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/1315744 --- M ovirt-engine.spec.in 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Lev Veyde: Verified Sandro Bonazzola: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/54714 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I39c1394358e5cf16bf748ddd75890a4f834020e4 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Ido Rosenzwig <irosenzw(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>

1 0