March 2016 - Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.6]: core: graphics of template were not available in user portal
by tnisan＠redhat.com 27 Mar '16

27 Mar '16

Tal Nisan has submitted this change and it was merged. Change subject: core: graphics of template were not available in user portal ...................................................................... core: graphics of template were not available in user portal The problem was that in user portal (filter: true) the GetGraphicsDevicesQuery called the getVmDeviceByVmIdTypeAndDevice which cares takes into account only the VM permissions, not the template ones. Change-Id: I197748d44f5eb50a3e81b3b5924898770fbbcb8c Bug-Url: https://bugzilla.redhat.com/1315886 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M packaging/dbscripts/vm_device_sp.sql 1 file changed, 8 insertions(+), 1 deletion(-) Approvals: Tomas Jelinek: Verified Eli Mesika: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/54996 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I197748d44f5eb50a3e81b3b5924898770fbbcb8c Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in otopi[master]: automation: add functional testing
by didi＠redhat.com 27 Mar '16

27 Mar '16

Yedidyah Bar David has submitted this change and it was merged. Change subject: automation: add functional testing ...................................................................... automation: add functional testing Change-Id: I31b0c9f073bb412cd7961dcb2fa1006123083af1 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M automation/check-merged.packages M automation/check-merged.sh M automation/check-patch.packages M automation/check-patch.sh 4 files changed, 22 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified Jenkins CI: Passed CI tests Yedidyah Bar David: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/55241 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I31b0c9f073bb412cd7961dcb2fa1006123083af1 Gerrit-PatchSet: 2 Gerrit-Project: otopi Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in otopi[master]: automation: add standard ci
by didi＠redhat.com 27 Mar '16

27 Mar '16

Yedidyah Bar David has submitted this change and it was merged. Change subject: automation: add standard ci ...................................................................... automation: add standard ci Change-Id: I255a2d7884b8bf3f1eb91361729e5a39dfeafc66 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- A automation/build-artifacts.packages A automation/build-artifacts.sh A automation/check-merged.packages A automation/check-merged.sh A automation/check-patch.packages A automation/check-patch.sh 6 files changed, 66 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified Jenkins CI: Passed CI tests Yedidyah Bar David: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/55239 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I255a2d7884b8bf3f1eb91361729e5a39dfeafc66 Gerrit-PatchSet: 1 Gerrit-Project: otopi Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: restapi: Fix V3 VM graphics console server
by juan.hernandez＠redhat.com 26 Mar '16

26 Mar '16

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Fix V3 VM graphics console server ...................................................................... restapi: Fix V3 VM graphics console server The V3 VM graphics console server doesn't support the "proxyticket" operation because it implements the base graphics console interface used by virtual machines and templates, and this interface doesn't contain the "proxyticket" operation. This patch changes the server so that it implements the interface specialized for virtual machines, which does contain the "proxyticket" operation. Change-Id: I192b32f7822250147003af7b93db4e01b162d42a Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/servers/V3VmGraphicsConsolesServer.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/servers/V3VmServer.java 2 files changed, 56 insertions(+), 2 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/55245 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I192b32f7822250147003af7b93db4e01b162d42a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Console stealing fix
by tjelinek＠redhat.com 25 Mar '16

25 Mar '16

Tomas Jelinek has submitted this change and it was merged. Change subject: core: Console stealing fix ...................................................................... core: Console stealing fix Only users with permission "VM" > "Administrative Operations" > "Override opened console session" (in code ActionGroup.RECONNECT_TO_VM) are able to connect to console someone else already have connected to (before next restart). This applies to if "Edit" VM dialog > "Console" tab > "Advanced parameters" > "Disable strict user checking" is disabled (in code VmBase#allowConsoleReconnect == false). If Strict user checking is disabled, anyone can steal console form anyone. Method SetVmTicketCommand#checkPermissions was removed and thus its tests were removed. "General command failure" was removed. Any error in SetVmTicketCommand that is not related to unauthorized console stealing is reporated by ConfigureConsoleOptionsQuery as EngineMessage.SETTING_VM_TICKET_FAILED. Previously it might happen that unauthorized attempt to steal console resulted in locked screen for current console user. This was caused by firing VDSM command "desktopLogin" earlier than execution SetVmTicketCommand (which actually verifies the permissions). It is solved by fixing frontend permission checking that prevents firing any command if SetVmTicketCommand would fail on permission check. User is notified about console being used by other user by pure fronend dialog. VM#getConsoleCurrentUserName() was replace by VM#getConsoleCurrentUserId() in ConsoleModel #executeCommandWithConsoleSafenessWarning() as getConsoleCurrentUserName() is not reliable (it is nulled in VdsEventListener#processOnClientIpChange()). Change-Id: Ib47107b2e2f85e4d05b13c3fe35ab4ad449d0ca5 Bug-Url: https://bugzilla.redhat.com/1297018 Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ConfigureConsoleOptionsQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SetVmTicketCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/SetVmTicketCommandTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ConsoleModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 10 files changed, 24 insertions(+), 127 deletions(-) Approvals: Tomas Jelinek: Looks good to me, but someone else must approve Jakub Niedermertl: Verified Jenkins CI: Passed CI tests Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/54228 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib47107b2e2f85e4d05b13c3fe35ab4ad449d0ca5 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-1.3]: cpu: sync support for latest 3.6 CPUs
by sbonazzo＠redhat.com 25 Mar '16

25 Mar '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: cpu: sync support for latest 3.6 CPUs ...................................................................... cpu: sync support for latest 3.6 CPUs Adding entries for latest 3.6 CPUs. Change-Id: Ia174094407920796b10e45dd736cf65adffcbb69 Bug-Url: https://bugzilla.redhat.com/1319881 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M src/plugins/ovirt-hosted-engine-setup/vdsmd/cpu.py 1 file changed, 57 insertions(+), 12 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/55251 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia174094407920796b10e45dd736cf65adffcbb69 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: ovirt-hosted-engine-setup-1.3 Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-setup[master]: cpu: sync support for latest 3.6 CPUs
by sbonazzo＠redhat.com 25 Mar '16

25 Mar '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: cpu: sync support for latest 3.6 CPUs ...................................................................... cpu: sync support for latest 3.6 CPUs Adding entries for latest 3.6 CPUs. Change-Id: Ia174094407920796b10e45dd736cf65adffcbb69 Bug-Url: https://bugzilla.redhat.com/1319881 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M src/plugins/ovirt-hosted-engine-setup/vdsmd/cpu.py 1 file changed, 57 insertions(+), 12 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/55042 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia174094407920796b10e45dd736cf65adffcbb69 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-release[master]: el7: move CentOS Virt SIG to oVirt 4.0
by sbonazzo＠redhat.com 25 Mar '16

25 Mar '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: el7: move CentOS Virt SIG to oVirt 4.0 ...................................................................... el7: move CentOS Virt SIG to oVirt 4.0 Using candidate repository until we GA oVirt 4.0 Change-Id: Ib5b86c1e6f5a7cb12ca8d19665a0f65036828d6e Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M ovirt-el7-deps.repo.in 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Martin Peřina: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Dan Kenigsberg: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/55223 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib5b86c1e6f5a7cb12ca8d19665a0f65036828d6e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-release Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core: prevent a race on add template version
by piotr.kliczewski＠gmail.com 25 Mar '16

25 Mar '16

Piotr Kliczewski has submitted this change and it was merged. Change subject: core: prevent a race on add template version ...................................................................... core: prevent a race on add template version When adding a template version, we add the quartz job and then mapping the ID of the base template to that job so we will be able to stop on-going updates of VMs to the latest version of the template. The problem is that we first "register" the quartz job and only then add it to the map (because we need to ID of the produced job). But when the job is being executed before the mapping is set, the VM updates will not take place. This patch suggests a simple fix - to add the template with null job before registering the quartz job, and update the mapping after the job is created. We should rewrite the mechanism that cancels on-going updates someday. Change-Id: I955a655f2eaef8510e3884e7895b9ca6cd0a6349 Bug-Url: https://bugzilla.redhat.com/1294511 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/exclude-filters.xml M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java 2 files changed, 11 insertions(+), 0 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/55219 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I955a655f2eaef8510e3884e7895b9ca6cd0a6349 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core: Fix of audit log message in UpdateVmCommand
by piotr.kliczewski＠gmail.com 25 Mar '16

25 Mar '16

Piotr Kliczewski has submitted this change and it was merged. Change subject: core: Fix of audit log message in UpdateVmCommand ...................................................................... core: Fix of audit log message in UpdateVmCommand Fix of copy-paste mistake: AuditLogType.FAILED_HOT_SET_NUMBER_OF_CPUS -> AuditLogType.FAILED_HOT_SET_MEMORY. Change-Id: I16a3a7dcf02f977ab626257d19e39f86785b0cc6 Bug-Url: https://bugzilla.redhat.com/1311899 Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Piotr Kliczewski: Passed CI tests Jakub Niedermertl: Verified; Looks good to me, but someone else must approve Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/55212 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I16a3a7dcf02f977ab626257d19e39f86785b0cc6 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0