Change in ovirt-engine[ovirt-engine-3.6]: core: Fix of "virtual" memory hot (un)plug
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: Fix of "virtual" memory hot (un)plug
......................................................................
core: Fix of "virtual" memory hot (un)plug
Previously engine record of current memory was updated during each
attempt of memory hot (un)plug if the vm was in state PoweringUp
(probably all others than Up or Down).
This path changes UpdateVmCommand#hotSetMemory() method
* Renamed to 'updateCurrentMemory' because it is (and was) used
even if VM is not running.
* If vm is not running, new value of memory is set.
* Otherwise if VM is not up, old value of memory kept.
* Otherwise if memory has changed, attempt to hot plug is fired to VDSM and memory is set
according to result of VDSM operation.
Change-Id: I8eff6eb979ab6abaa958b33688a2adef0db20f1d
Bug-Url: https://bugzilla.redhat.com/1311899
Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java
1 file changed, 37 insertions(+), 16 deletions(-)
Approvals:
Tal Nisan: Passed CI tests
Jakub Niedermertl: Verified; Looks good to me, but someone else must approve
Arik Hadas: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/55213
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8eff6eb979ab6abaa958b33688a2adef0db20f1d
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 9 months
Change in ovirt-engine[master]: core: improve vm-jobs monitoring tests
by ahadas＠redhat.com
Arik Hadas has submitted this change and it was merged.
Change subject: core: improve vm-jobs monitoring tests
......................................................................
core: improve vm-jobs monitoring tests
Change-Id: I7410b016c8205a9461e59f3bbd5571e5c95f2a84
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/monitoring/VmJobsMonitoringTest.java
1 file changed, 16 insertions(+), 9 deletions(-)
Approvals:
Shahar Havivi: Looks good to me, approved
Arik Hadas: Verified; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/54007
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7410b016c8205a9461e59f3bbd5571e5c95f2a84
Gerrit-PatchSet: 13
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 9 months
Change in ovirt-engine[master]: core: manage vm-jobs in-memory
by ahadas＠redhat.com
Arik Hadas has submitted this change and it was merged.
Change subject: core: manage vm-jobs in-memory
......................................................................
core: manage vm-jobs in-memory
Previously the process was:
MergeCommand -> persist job into the database
Monitoring -> on each cycle read jobs from the database and
compare them with the jobs reported by vdsm
The patch suggests another way:
MergeCommand -> pass the job to the monitoring that persists
it into the database and store it in-memory
Monitoring -> compare the reported jobs with the the jobs
that are stored in-memory
On startup, the monitoring retrieve all the existing job in
the database.
This way, we reduce the number of reads from the database.
Change-Id: Id8a9e935f49f458388c089398b110a8854c197e5
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MergeCommand.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmJobDao.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmJobDaoImpl.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmJobDaoTest.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmJobsMonitoring.java
M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/monitoring/VmJobsMonitoringTest.java
M packaging/dbscripts/vm_jobs_sp.sql
7 files changed, 102 insertions(+), 67 deletions(-)
Approvals:
Eli Mesika: Looks good to me, but someone else must approve
Shahar Havivi: Looks good to me, approved
Jenkins CI: Passed CI tests
Arik Hadas: Verified
--
To view, visit https://gerrit.ovirt.org/53926
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id8a9e935f49f458388c089398b110a8854c197e5
Gerrit-PatchSet: 16
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Yaniv Kaul <ykaul(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 9 months
Change in otopi[master]: automation: check-patch.sh: Add debug output
by didi＠redhat.com
Yedidyah Bar David has submitted this change and it was merged.
Change subject: automation: check-patch.sh: Add debug output
......................................................................
automation: check-patch.sh: Add debug output
Change-Id: I6a9f59beaa1c7e47afcbdaf0a49d941d619f08d1
Signed-off-by: Yedidyah Bar David <didi(a)redhat.com>
---
M automation/check-patch.sh
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Jenkins CI: Passed CI tests
Yedidyah Bar David: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/55316
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6a9f59beaa1c7e47afcbdaf0a49d941d619f08d1
Gerrit-PatchSet: 2
Gerrit-Project: otopi
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 9 months
Change in ovirt-engine[master]: engine: fix logger in MergeExtendCommandCallback
by laravot＠redhat.com
Liron Aravot has submitted this change and it was merged.
Change subject: engine: fix logger in MergeExtendCommandCallback
......................................................................
engine: fix logger in MergeExtendCommandCallback
Fix the logger class in MergeExtendCommandCallback
Change-Id: Ib2d66cba54f7f1c850a3ecca755772580203e30d
Signed-off-by: Fred Rolland <frolland(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MergeExtendCommandCallback.java
1 file changed, 1 insertion(+), 2 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Amit Aviram: Looks good to me, but someone else must approve
Freddy Rolland: Verified
Liron Aravot: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/54534
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib2d66cba54f7f1c850a3ecca755772580203e30d
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com>
Gerrit-Reviewer: Fred Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 9 months
Change in ovirt-engine[master]: engine: Remove hotplugged memory & CPUs from changed fields ...
by ahadas＠redhat.com
Arik Hadas has submitted this change and it was merged.
Change subject: engine: Remove hotplugged memory & CPUs from changed fields list
......................................................................
engine: Remove hotplugged memory & CPUs from changed fields list
If number of CPUs or memory size is changed when VM is running, special
info is displayed in the confirmation dialog about hotplugging CPUs or
memory. In the same time, numOfSockets and memSizeMb fields are present
in the list of fields to be changed on the next VM run. Noting these
fields there is redundant, so it was eliminated.
Note that memSizeMb is removed only in the case of memory plugging, but
not in the case of unplugging. Confirmation dialog currently assumes
that memory hot unplugging is not supported and decreased memory size is
applied only on the next VM run.
Change-Id: I38a52f7bfe4f4b6ab35b07e7526746f748c5b92d
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1314426
Signed-off-by: Shmuel Melamud <smelamud(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVmChangedFieldsForNextRunQuery.java
1 file changed, 12 insertions(+), 0 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Shmuel Leib Melamud: Verified
Arik Hadas: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/54474
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I38a52f7bfe4f4b6ab35b07e7526746f748c5b92d
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shmuel Leib Melamud <smelamud(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com>
Gerrit-Reviewer: Shmuel Melamud <smelamud(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 9 months
Change in ovirt-engine[master]: webadmin: SetupNetworkModel refactoring
by alkaplan＠redhat.com
Alona Kaplan has submitted this change and it was merged.
Change subject: webadmin: SetupNetworkModel refactoring
......................................................................
webadmin: SetupNetworkModel refactoring
The commit includes:
1. 'allNics' is a list of the existing host nics.
Until now it was updated upon each operation that was done in the dialog.
Now, once the nic list is queried it will stay untouched.
2. 'DataFromHostSetupNetworksModel hostSetupNetworksParametersData'
contains the data to build the parameters for the setup networks engine
command.
2.1 It contains the 'whole' network config and not just the diffs
(the engine will ignore the unchanged values).
2.2 'hostSetupNetworksParametersData' is updated upon each operation in
the dialog.
2.3 The ui models (LogicalNetworkModel, NetworkInterfaceModel,
BondNetworkInterfaceModel, NetworkLabelModel) of the dialog are built using
the data in 'hostSetupNetworksParametersData'.
2.3 The only proccess that updates and builds the ui models is the redraw/
initAllModels (same as before).
It means that the operations (NetworkOperation) update only the
'hostSetupNetworksParametersData'. After the operation is done update the
params, redraw should be called to recreated the ui models. (Same as it
was prior this commit).
The commit doesn't include:
1. Fixing the setup networks tooltips.
Change-Id: Ic9ab17fce26b36f8d9908d726fb9774eec31600a
Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com>
---
D frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/DcNetworkParams.java
D frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostManagementNetworkModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostSetupNetworksModel.java
A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/InterfacePropertiesAccessor.java
A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/ManagementNetworkAttachmentModel.java
R frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/NetworkAttachmentModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/NetworkParameters.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/SetupNetworksEditBondModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/network/BondNetworkInterfaceModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/network/DataFromHostSetupNetworksModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/network/LogicalNetworkModel.java
A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/network/LogicalNetworkModelParametersHelper.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/network/NetworkInterfaceModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/network/NetworkOperation.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/network/NetworkOperationFactory.java
M frontend/webadmin/modules/uicommonweb/src/test/java/org/ovirt/engine/ui/uicommonweb/models/hosts/network/ExecuteNetworkCommandInNetworkOperationTest.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/PresenterModule.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/uicommon/HostModule.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/uicommon/NetworkModule.java
A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/popup/host/ManagementNetworkAttachmentPopupPresenterWidget.java
A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/popup/host/NetworkAttachmentPopupPresenterWidget.java
D frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/popup/host/SetupNetworksInterfacePopupPresenterWidget.java
D frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/popup/host/SetupNetworksManagementPopupPresenterWidget.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostSetupNetworksPopupView.java
A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/ManagementNetworkAttachmentPopupView.java
R frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/NetworkAttachmentPopupView.java
R frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/NetworkAttachmentPopupView.ui.xml
D frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/SetupNetworksManagementPopupView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/BondPanel.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/ItemInfoPopup.java
30 files changed, 1,518 insertions(+), 1,568 deletions(-)
Approvals:
Alona Kaplan: Verified; Passed CI tests
Daniel Erez: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/53891
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic9ab17fce26b36f8d9908d726fb9774eec31600a
Gerrit-PatchSet: 24
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 9 months
Change in ovirt-dwh[master]: packaging: removed dwh views up to 3.6
by Shirly Radco
Shirly Radco has submitted this change and it was merged.
Change subject: packaging: removed dwh views up to 3.6
......................................................................
packaging: removed dwh views up to 3.6
Removed legacy dwh views up to 3.6.
Change-Id: I41bc65acb1646aaa697f6591c5e6de165087d940
Bug-Url: https://bugzilla.redhat.com/1312638
Signed-off-by: Shirly Radco <sradco(a)redhat.com>
---
D packaging/dbscripts/create_views_3_0.sql
D packaging/dbscripts/create_views_3_1.sql
D packaging/dbscripts/create_views_3_2.sql
D packaging/dbscripts/create_views_3_3.sql
D packaging/dbscripts/create_views_3_4.sql
D packaging/dbscripts/create_views_3_5.sql
M packaging/dbscripts/dbfunc-custom.sh
7 files changed, 0 insertions(+), 5,294 deletions(-)
Approvals:
Shirly Radco: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/54589
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I41bc65acb1646aaa697f6591c5e6de165087d940
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-dwh
Gerrit-Branch: master
Gerrit-Owner: Shirly Radco <sradco(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com>
Gerrit-Reviewer: Yaniv Kaul <ykaul(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 9 months
Change in ovirt-engine[master]: core: Adding lock for scan storage domain.
by mlipchuk＠redhat.com
Maor Lipchuk has submitted this change and it was merged.
Change subject: core: Adding lock for scan storage domain.
......................................................................
core: Adding lock for scan storage domain.
Adding lock when scanning storage domain.
Change-Id: I1ee25e7d006638584341273cffc486afbf3c4a56
Bug-Url: https://bugzilla.redhat.com/1138139
Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/ScanStorageForUnregisteredDisksCommand.java
1 file changed, 22 insertions(+), 0 deletions(-)
Approvals:
Daniel Erez: Looks good to me, approved
Maor Lipchuk: Verified; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/55204
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1ee25e7d006638584341273cffc486afbf3c4a56
Gerrit-PatchSet: 12
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 9 months
Change in ovirt-engine[master]: core: Add lock for register disk command.
by mlipchuk＠redhat.com
Maor Lipchuk has submitted this change and it was merged.
Change subject: core: Add lock for register disk command.
......................................................................
core: Add lock for register disk command.
Add a CDA and lock for register an unregistered disk command.
Change-Id: I16caeee56579345f9a98f81ede38f7e846a8d030
Bug-Url: https://bugzilla.redhat.com/1138139
Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/RegisterDiskCommand.java
1 file changed, 25 insertions(+), 0 deletions(-)
Approvals:
Daniel Erez: Looks good to me, approved
Maor Lipchuk: Verified; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/55203
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I16caeee56579345f9a98f81ede38f7e846a8d030
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 9 months