Change in ovirt-engine[master]: core: Add image id for unregistered disk BE.
by mlipchuk＠redhat.com
Maor Lipchuk has submitted this change and it was merged.
Change subject: core: Add image id for unregistered disk BE.
......................................................................
core: Add image id for unregistered disk BE.
Save also image id for unregistered disks so the GUI will be able to
identify each unregistered disk since the getId of each element is
dependant on the image id.
Change-Id: Ia2d983e8f9bd39837e104819bb4397d0a66aa72f
Bug-Url: https://bugzilla.redhat.com/1138139
Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com>
---
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/UnregisteredDisksDaoImpl.java
M backend/manager/modules/dal/src/test/resources/fixtures.xml
M packaging/dbscripts/unregistered_disks_sp.sql
A packaging/dbscripts/upgrade/04_00_0370_add_imageid_column_to_unregistered_disks.sql
4 files changed, 12 insertions(+), 0 deletions(-)
Approvals:
Daniel Erez: Looks good to me, approved
Maor Lipchuk: Verified; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/55202
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia2d983e8f9bd39837e104819bb4397d0a66aa72f
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 9 months
Change in ovirt-engine[master]: core: Set storage domain id when scan for unregister disk.
by mlipchuk＠redhat.com
Maor Lipchuk has submitted this change and it was merged.
Change subject: core: Set storage domain id when scan for unregister disk.
......................................................................
core: Set storage domain id when scan for unregister disk.
Set the storage domain id when register an unregistered disk instead
of setting the storage id based on the id which was in the meta data.
Change-Id: I5f0f1457cd167b9b12ff8616f3c4f2c9d5e0b290
Bug-Url: https://bugzilla.redhat.com/1138139
Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHandlingCommandBase.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/ScanStorageForUnregisteredDisksCommand.java
2 files changed, 4 insertions(+), 2 deletions(-)
Approvals:
Daniel Erez: Looks good to me, approved
Maor Lipchuk: Verified; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/55060
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5f0f1457cd167b9b12ff8616f3c4f2c9d5e0b290
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 9 months
Change in ovirt-engine[master]: webadmin: Add support for scan unregistered disks
by mlipchuk＠redhat.com
Maor Lipchuk has submitted this change and it was merged.
Change subject: webadmin: Add support for scan unregistered disks
......................................................................
webadmin: Add support for scan unregistered disks
Add support for scan unregistered disks
The command will be called by right clicking on the storage domain
in the storage tab and press "scan disks".
Change-Id: I6e1292bd0bf556bde36e9cc1415041f8c1450405
Bug-Url: https://bugzilla.redhat.com/1138139
Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabStorageView.java
3 files changed, 37 insertions(+), 0 deletions(-)
Approvals:
Daniel Erez: Looks good to me, approved
Maor Lipchuk: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/55059
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6e1292bd0bf556bde36e9cc1415041f8c1450405
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 9 months
Change in ovirt-engine[master]: core: improvements at ScanStorageForUnregisteredDisks.
by mlipchuk＠redhat.com
Maor Lipchuk has submitted this change and it was merged.
Change subject: core: improvements at ScanStorageForUnregisteredDisks.
......................................................................
core: improvements at ScanStorageForUnregisteredDisks.
1. Add audit log support for Scan command
2. Change the command in VdcActionType to be for storage maniplation.
Change-Id: Id15d7126dcc2d319f04dc9af75cb8a694e177948
Bug-Url: https://bugzilla.redhat.com/1138139
Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/ScanStorageForUnregisteredDisksCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
8 files changed, 23 insertions(+), 1 deletion(-)
Approvals:
Daniel Erez: Looks good to me, approved
Maor Lipchuk: Verified; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/55058
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id15d7126dcc2d319f04dc9af75cb8a694e177948
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 9 months
Change in ovirt-engine[master]: dal: Update unregistered view with disks
by mlipchuk＠redhat.com
Maor Lipchuk has submitted this change and it was merged.
Change subject: dal: Update unregistered view with disks
......................................................................
dal: Update unregistered view with disks
Update unregistered entities view with unregistered disks.
Change-Id: I560d005894de36bc4e53c6595f9646d9f5485b8a
Bug-Url: https://bugzilla.redhat.com/1138139
Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com>
---
M packaging/dbscripts/create_views.sql
1 file changed, 5 insertions(+), 2 deletions(-)
Approvals:
Daniel Erez: Looks good to me, approved
Maor Lipchuk: Verified; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/54832
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I560d005894de36bc4e53c6595f9646d9f5485b8a
Gerrit-PatchSet: 21
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 9 months
Change in ovirt-engine[master]: webadmin: Add import disks sub tab
by mlipchuk＠redhat.com
Maor Lipchuk has submitted this change and it was merged.
Change subject: webadmin: Add import disks sub tab
......................................................................
webadmin: Add import disks sub tab
Add sub tab for import disks
Storage -> Import disks
Change-Id: Id61d401f7c19abf0df322cecbcdee1c56ebf6ff6
Bug-Url: https://bugzilla.redhat.com/1138139
Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com>
---
A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/comparators/UnregisteredDiskByDiskAliasComparator.java
M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java
A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageRegisterDiskImageListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/place/WebAdminApplicationPlaces.java
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/ClientGinjectorExtension.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/PresenterModule.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/uicommon/StorageModule.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/tab/storage/SubTabStorageDiskPresenter.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/tab/storage/SubTabStorageDiskProfilePresenter.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/tab/storage/SubTabStorageEventPresenter.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/tab/storage/SubTabStorageIsoPresenter.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/tab/storage/SubTabStoragePermissionPresenter.java
A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/tab/storage/SubTabStorageRegisterDiskImagePresenter.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/tab/storage/SubTabStorageRegisterDiskPresenter.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/tab/storage/SubTabStorageSnapshotPresenter.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/tab/storage/SubTabStorageTemplatePresenter.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/tab/storage/SubTabStorageVmPresenter.java
A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/storage/SubTabStorageRegisterDiskImageView.java
21 files changed, 349 insertions(+), 10 deletions(-)
Approvals:
Daniel Erez: Looks good to me, approved
Maor Lipchuk: Verified; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/54831
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id61d401f7c19abf0df322cecbcdee1c56ebf6ff6
Gerrit-PatchSet: 19
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 9 months
Change in ovirt-engine[master]: core: Fix of "virtual" memory hot (un)plug
by ahadas＠redhat.com
Arik Hadas has submitted this change and it was merged.
Change subject: core: Fix of "virtual" memory hot (un)plug
......................................................................
core: Fix of "virtual" memory hot (un)plug
Previously engine record of current memory was updated during each
attempt of memory hot (un)plug if the vm was in state PoweringUp
(probably all others than Up or Down).
This path changes UpdateVmCommand#hotSetMemory() method
* Renamed to 'updateCurrentMemory' because it is (and was) used
even if VM is not running.
* If vm is not running, new value of memory is set.
* Otherwise if VM is not up, old value of memory kept.
* Otherwise if memory has changed, attempt to hot plug is fired to VDSM and memory is set
according to result of VDSM operation.
Change-Id: I8eff6eb979ab6abaa958b33688a2adef0db20f1d
Bug-Url: https://bugzilla.redhat.com/1311899
Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java
1 file changed, 37 insertions(+), 16 deletions(-)
Approvals:
Jakub Niedermertl: Verified
Jenkins CI: Passed CI tests
Arik Hadas: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/54739
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8eff6eb979ab6abaa958b33688a2adef0db20f1d
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marek Libra <mlibra(a)redhat.com>
Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 9 months
Change in otopi[master]: packaging: spec: drop 3.4 compatibility
by didi＠redhat.com
Yedidyah Bar David has submitted this change and it was merged.
Change subject: packaging: spec: drop 3.4 compatibility
......................................................................
packaging: spec: drop 3.4 compatibility
dropping compatibility with oVirt 3.4
Change-Id: Id5af65bc50b785534993f35273ccd888c8483267
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M otopi.spec.in
1 file changed, 0 insertions(+), 2 deletions(-)
Approvals:
Sandro Bonazzola: Verified
Jenkins CI: Passed CI tests
Yedidyah Bar David: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/55242
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id5af65bc50b785534993f35273ccd888c8483267
Gerrit-PatchSet: 3
Gerrit-Project: otopi
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 9 months
Change in otopi[master]: packagers: add core
by didi＠redhat.com
Yedidyah Bar David has submitted this change and it was merged.
Change subject: packagers: add core
......................................................................
packagers: add core
Add core module to add a marker for PACKAGERS_DETECTION, instead of
using this name for both yum and dnf.
Change-Id: I46f3b879faec0813a89807829943cc1812faf7b1
Signed-off-by: Yedidyah Bar David <didi(a)redhat.com>
---
M src/plugins/otopi/packagers/Makefile.am
M src/plugins/otopi/packagers/__init__.py
A src/plugins/otopi/packagers/core.py
M src/plugins/otopi/packagers/dnfpackager.py
M src/plugins/otopi/packagers/yumpackager.py
5 files changed, 41 insertions(+), 2 deletions(-)
Approvals:
Sandro Bonazzola: Verified
Jenkins CI: Passed CI tests
Yedidyah Bar David: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/55236
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I46f3b879faec0813a89807829943cc1812faf7b1
Gerrit-PatchSet: 5
Gerrit-Project: otopi
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com>
Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 9 months
Change in ovirt-engine[ovirt-engine-3.6]: core: Console stealing fix
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: Console stealing fix
......................................................................
core: Console stealing fix
Only users with permission "VM" > "Administrative Operations" >
"Override opened console session" (in code ActionGroup.RECONNECT_TO_VM)
are able to connect to console someone else already have connected to
(before next restart). This applies to if "Edit" VM dialog > "Console"
tab > "Advanced parameters" > "Disable strict user checking" is disabled
(in code VmBase#allowConsoleReconnect == false).
If Strict user checking is disabled, anyone can steal console form
anyone.
Method SetVmTicketCommand#checkPermissions was removed and thus its
tests were removed.
"General command failure" was removed. Any error in SetVmTicketCommand
that is not related to unauthorized console stealing is reporated by
ConfigureConsoleOptionsQuery as EngineMessage.SETTING_VM_TICKET_FAILED.
Previously it might happen that unauthorized attempt to steal console
resulted in locked screen for current console user. This was caused by
firing VDSM command "desktopLogin" earlier than execution
SetVmTicketCommand (which actually verifies the permissions).
It is solved by fixing frontend permission checking that prevents firing
any command if SetVmTicketCommand would fail on permission check. User
is notified about console being used by other user by pure fronend
dialog.
VM#getConsoleCurrentUserName() was replace by
VM#getConsoleCurrentUserId() in ConsoleModel
#executeCommandWithConsoleSafenessWarning() as
getConsoleCurrentUserName() is not reliable (it is nulled in
VdsEventListener#processOnClientIpChange()).
Change-Id: Ib47107b2e2f85e4d05b13c3fe35ab4ad449d0ca5
Bug-Url: https://bugzilla.redhat.com/1297018
Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ConfigureConsoleOptionsQuery.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SetVmTicketCommand.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/SetVmTicketCommandTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ConsoleModel.java
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
10 files changed, 23 insertions(+), 127 deletions(-)
Approvals:
Tomas Jelinek: Looks good to me, but someone else must approve
Jakub Niedermertl: Verified
Jenkins CI: Passed CI tests
Arik Hadas: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/55226
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib47107b2e2f85e4d05b13c3fe35ab4ad449d0ca5
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 9 months