Change in ovirt-engine[master]: core: Fix existing template check
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Fix existing template check
......................................................................
core: Fix existing template check
Fix the regression introduced in commit
b0008c96dbf43ed68139748504ed4e3c1619d971
Change-Id: I0bd1bd6baab5a47241216b21545a7870220e39c2
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ExportVmTemplateCommand.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Allon Mureinik: Verified
--
To view, visit https://gerrit.ovirt.org/56481
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0bd1bd6baab5a47241216b21545a7870220e39c2
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years
Change in ovirt-engine[master]: core: cleanup in VmStatistics
by ahadas＠redhat.com
Arik Hadas has submitted this change and it was merged.
Change subject: core: cleanup in VmStatistics
......................................................................
core: cleanup in VmStatistics
1. Rename field names according to the Java convention
2. Put all field declarations at the top part of the class
Change-Id: I1081e8487f17f7c9356407469fdb3129fbdc6754
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmStatistics.java
1 file changed, 63 insertions(+), 72 deletions(-)
Approvals:
Shahar Havivi: Looks good to me, approved
Jenkins CI: Passed CI tests
Arik Hadas: Verified
--
To view, visit https://gerrit.ovirt.org/56526
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1081e8487f17f7c9356407469fdb3129fbdc6754
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years
Change in ovirt-engine[master]: core: imageupload: don't succeed if session can't be stopped.
by mlipchuk＠redhat.com
Maor Lipchuk has submitted this change and it was merged.
Change subject: core: imageupload: don't succeed if session can't be stopped.
......................................................................
core: imageupload: don't succeed if session can't be stopped.
Currently, an image uploading session succeeds regardless of succeeding
to actually stop the transfer session. This can cause having a disk ready
to be used by a VM, which is still open for external I/O to be written
into it.
This patch verifies that stopping the session succeeds before proceeding
to mark the image "Legal", therefor ready to be used.
Change-Id: I325c47f575a9fbc40a9653a7ab2178f45086ff41
Signed-off-by: Amit Aviram <aaviram(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/UploadImageCommand.java
1 file changed, 18 insertions(+), 14 deletions(-)
Approvals:
Amit Aviram: Verified
Maor Lipchuk: Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/56158
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I325c47f575a9fbc40a9653a7ab2178f45086ff41
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Amit Aviram <aaviram(a)redhat.com>
Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years
Change in ovirt-engine[master]: core: support uploading QCOW images.
by mlipchuk＠redhat.com
Maor Lipchuk has submitted this change and it was merged.
Change subject: core: support uploading QCOW images.
......................................................................
core: support uploading QCOW images.
Currently, uploading a QCOW image is disabled, since there were
no security verifications made on a QCOW image after upload finishes.
For QCOW images, the system should verify that the uploaded image is
actually QCOW, and verify that it does not have a backing file. This is
because having a backing file in the new image can expose undesired
resources to the user: it can point to any file in the host- including
disks of other VMs, etc..
This patch adds a VDS command that calls a VDSM volume verification
procedure, and makes the uploaded image legal only after doing this
verification- allowing a QCOW format to be chosen in the upload dialog.
Change-Id: I6bde0eb732f75afe0fef94aa79bdaab5687b76fd
Signed-off-by: Amit Aviram <aaviram(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/UploadImageCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/VDSCommandType.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcVdsServer.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/IVdsServer.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerConnector.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerWrapper.java
A backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VerifyUntrustedVolumeVDSCommand.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/UploadImageModel.java
8 files changed, 79 insertions(+), 6 deletions(-)
Approvals:
Amit Aviram: Verified
Maor Lipchuk: Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/55817
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6bde0eb732f75afe0fef94aa79bdaab5687b76fd
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Amit Aviram <aaviram(a)redhat.com>
Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years
Change in ovirt-engine[master]: core: Set image to illegal in storage while uploading.
by mlipchuk＠redhat.com
Maor Lipchuk has submitted this change and it was merged.
Change subject: core: Set image to illegal in storage while uploading.
......................................................................
core: Set image to illegal in storage while uploading.
Currently, when uploading an image- only the engine side sets this image
to locked/illegal- preventing any usage of that image.
However, the image is marked as legal in the storage. regardless to
having the actual image not synced with its engine's representation-
this could break the image's state in the engine as well when detaching
the image's containing domain, and importing it back.
When setting the image to illegal in the storage- importing it will make
the image illegal in the engine when importing again.
This patch makes the image marked as illegal in the storage while the
image is being uploaded.
Change-Id: Id3551b32d4d5f7c5a23de58687612890fcf8cd29
Signed-off-by: Amit Aviram <aaviram(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/UploadImageCommand.java
1 file changed, 26 insertions(+), 0 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Amit Aviram: Verified
Maor Lipchuk: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/55469
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id3551b32d4d5f7c5a23de58687612890fcf8cd29
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Amit Aviram <aaviram(a)redhat.com>
Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years
Change in ovirt-engine[ovirt-engine-3.6]: core: Restrict types accepted by attachments servlet
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: Restrict types accepted by attachments servlet
......................................................................
core: Restrict types accepted by attachments servlet
This patch modifies the "GetAttachmentsServlet" so that it only accepts
a pre-defined set of content types.
Change-Id: I7bcd1fa12826cfe0607863a8bd3fea6ff760c70b
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
(cherry picked from commit 21ee2f40193c45fe88e32836350fc63367f41713)
---
M backend/manager/modules/services/src/main/java/org/ovirt/engine/core/services/GetAttachmentServlet.java
1 file changed, 31 insertions(+), 4 deletions(-)
Approvals:
Juan Hernandez: Verified
Alexander Wels: Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/56500
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7bcd1fa12826cfe0607863a8bd3fea6ff760c70b
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
8 years
Change in ovirt-engine[master]: engine: Unused field in RemoveCinderDiskParameters
by mlipchuk＠redhat.com
Maor Lipchuk has submitted this change and it was merged.
Change subject: engine: Unused field in RemoveCinderDiskParameters
......................................................................
engine: Unused field in RemoveCinderDiskParameters
Remove unused field in RemoveCinderDiskParameters.
Change-Id: I50233f2b221d407c43ac06d4dd9042602dbcc76e
Signed-off-by: Fred Rolland <frolland(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/RemoveCinderDiskParameters.java
1 file changed, 0 insertions(+), 11 deletions(-)
Approvals:
Freddy Rolland: Verified
Maor Lipchuk: Looks good to me, approved; Passed CI tests
Liron Aravot: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/55640
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I50233f2b221d407c43ac06d4dd9042602dbcc76e
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Fred Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years
Change in ovirt-engine[master]: engine: Remove unused AbstractCinderDiskCommand CB
by mlipchuk＠redhat.com
Maor Lipchuk has submitted this change and it was merged.
Change subject: engine: Remove unused AbstractCinderDiskCommand CB
......................................................................
engine: Remove unused AbstractCinderDiskCommand CB
Removed unused AbstractCinderDiskCommandCallback
Change-Id: Ic971bbd8cab70d4df51aa45a76d4063953390621
Signed-off-by: Fred Rolland <frolland(a)redhat.com>
---
D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/cinder/AbstractCinderDiskCommandCallback.java
1 file changed, 0 insertions(+), 49 deletions(-)
Approvals:
Freddy Rolland: Verified
Maor Lipchuk: Looks good to me, approved; Passed CI tests
Liron Aravot: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/55639
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic971bbd8cab70d4df51aa45a76d4063953390621
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Fred Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years
Change in ovirt-engine[master]: engine: Refactor RestoreFromCinderSnapshot Cmd
by mlipchuk＠redhat.com
Maor Lipchuk has submitted this change and it was merged.
Change subject: engine: Refactor RestoreFromCinderSnapshot Cmd
......................................................................
engine: Refactor RestoreFromCinderSnapshot Cmd
Use SerialChildCommandsExecutionCallback in
RestoreFromCinderSnapshotCommand.
Remove not used callback RemoveCinderDiskCommandCallback
Change-Id: I079529da6b4b1ca09e17bb61b59024f3b093d23a
Signed-off-by: Fred Rolland <frolland(a)redhat.com>
---
D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/cinder/RemoveCinderDiskCommandCallback.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/cinder/RestoreFromCinderSnapshotCommand.java
2 files changed, 2 insertions(+), 111 deletions(-)
Approvals:
Freddy Rolland: Verified
Maor Lipchuk: Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/55637
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I079529da6b4b1ca09e17bb61b59024f3b093d23a
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Fred Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years
Change in ovirt-engine[master]: engine: Refactor Cinder Remove Disk callback
by mlipchuk＠redhat.com
Maor Lipchuk has submitted this change and it was merged.
Change subject: engine: Refactor Cinder Remove Disk callback
......................................................................
engine: Refactor Cinder Remove Disk callback
Use the generic callback SerialChildCommandsExecutionCallback
in RemoveCinderDiskCommand.
In RemoveCinderVolumeParentCommand, implement methods of interface
SerialChildExecutingCommand.
Change-Id: Ia26596213dcfe68aa5d88f990fbaf4d30cc6beda
Signed-off-by: Fred Rolland <frolland(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/cinder/RemoveCinderDiskCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/cinder/RemoveCinderVolumeParentCommand.java
2 files changed, 22 insertions(+), 2 deletions(-)
Approvals:
Freddy Rolland: Verified
Maor Lipchuk: Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/55622
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia26596213dcfe68aa5d88f990fbaf4d30cc6beda
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Fred Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years