April 2016 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: engine: Refactor ExtendCinderDiskCommandCallback
by mlipchuk＠redhat.com 24 Apr '16

24 Apr '16

Maor Lipchuk has submitted this change and it was merged. Change subject: engine: Refactor ExtendCinderDiskCommandCallback ...................................................................... engine: Refactor ExtendCinderDiskCommandCallback Refactor ExtendCinderDiskCommandCallback to inherit from ConcurrentChildCommandsExecutionCallback to minimize code duplication and ease future refactors. Change-Id: I1692f187df60c7c37188f685fe6cd84c3aa05ce0 Signed-off-by: Fred Rolland <frolland(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/cinder/ExtendCinderDiskCommandCallback.java 1 file changed, 44 insertions(+), 48 deletions(-) Approvals: Freddy Rolland: Verified Maor Lipchuk: Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/54536 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1692f187df60c7c37188f685fe6cd84c3aa05ce0 Gerrit-PatchSet: 16 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Fred Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: Refactor RemoveCinderDiskVolumeCommand CB
by mlipchuk＠redhat.com 24 Apr '16

24 Apr '16

Maor Lipchuk has submitted this change and it was merged. Change subject: engine: Refactor RemoveCinderDiskVolumeCommand CB ...................................................................... engine: Refactor RemoveCinderDiskVolumeCommand CB Refactor RemoveCinderDiskVolumeCommand to inherit from ConcurrentChildCommandsExecutionCallback to minimize code duplication and ease future refactors. Change-Id: Ia060a9b3bf50a330c1d0e3c06936ec52300fea57 Signed-off-by: Fred Rolland <frolland(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/cinder/RemoveCinderDiskVolumeCommandCallback.java 1 file changed, 22 insertions(+), 43 deletions(-) Approvals: Freddy Rolland: Verified Maor Lipchuk: Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/54161 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia060a9b3bf50a330c1d0e3c06936ec52300fea57 Gerrit-PatchSet: 15 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Fred Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: Refactor RemoveCinderSnapshotCommand CB
by mlipchuk＠redhat.com 24 Apr '16

24 Apr '16

Maor Lipchuk has submitted this change and it was merged. Change subject: engine: Refactor RemoveCinderSnapshotCommand CB ...................................................................... engine: Refactor RemoveCinderSnapshotCommand CB Refactor RemoveCinderSnapshotCommandCallback to inherit from ConcurrentChildCommandsExecutionCallback to minimize code duplication and ease future refactors. Change-Id: Id1edd2530bffd3cc868b961089e7f3f9e43ae3ef Signed-off-by: Fred Rolland <frolland(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/cinder/RemoveCinderSnapshotCommandCallback.java 1 file changed, 19 insertions(+), 52 deletions(-) Approvals: Freddy Rolland: Verified Maor Lipchuk: Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/54126 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id1edd2530bffd3cc868b961089e7f3f9e43ae3ef Gerrit-PatchSet: 17 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Fred Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: Refactor CreateCinderSnapshotCommand CB
by mlipchuk＠redhat.com 24 Apr '16

24 Apr '16

Maor Lipchuk has submitted this change and it was merged. Change subject: engine: Refactor CreateCinderSnapshotCommand CB ...................................................................... engine: Refactor CreateCinderSnapshotCommand CB Refactor CreateCinderSnapshotCommandCallback to inherit from ConcurrentChildCommandsExecutionCallback to minimize code duplication and ease future refactors. Change-Id: I553fc65816827d0729049a2845bd0f46e46883d4 Signed-off-by: Fred Rolland <frolland(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/cinder/CreateCinderSnapshotCommandCallback.java 1 file changed, 20 insertions(+), 65 deletions(-) Approvals: Jenkins CI: Passed CI tests Freddy Rolland: Verified Maor Lipchuk: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/54124 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I553fc65816827d0729049a2845bd0f46e46883d4 Gerrit-PatchSet: 17 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Fred Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: Refactor CloneSingleCinderDiskCommand CB
by mlipchuk＠redhat.com 24 Apr '16

24 Apr '16

Maor Lipchuk has submitted this change and it was merged. Change subject: engine: Refactor CloneSingleCinderDiskCommand CB ...................................................................... engine: Refactor CloneSingleCinderDiskCommand CB Refactor CloneSingleCinderDiskCommandCallBack to inherit from ConcurrentChildCommandsExecutionCallback to minimize code duplication and ease future refactors. Change-Id: I830eb4069c77ad8310ad042d741a37b290738598 Signed-off-by: Fred Rolland <frolland(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/cinder/CloneSingleCinderDiskCommandCallback.java 1 file changed, 17 insertions(+), 45 deletions(-) Approvals: Jenkins CI: Passed CI tests Freddy Rolland: Verified Maor Lipchuk: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/54122 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I830eb4069c77ad8310ad042d741a37b290738598 Gerrit-PatchSet: 17 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Fred Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: Add timeout wrappers in all u/s jobs
by eedri＠redhat.com 24 Apr '16

24 Apr '16

Eyal Edri has submitted this change and it was merged. Change subject: Add timeout wrappers in all u/s jobs ...................................................................... Add timeout wrappers in all u/s jobs - Set timeout to 360 minutes (6 hours) in defaults.yaml file, under "defaults" section Change-Id: I133d95d4c7834947f5c73197161f04758e554b9f Signed-off-by: Shlomi Ben-David <sbendavi(a)redhat.com> --- M jobs/confs/projects/defaults.yaml 1 file changed, 5 insertions(+), 0 deletions(-) Approvals: Shlomo Ben David: Verified; Ready for review Eyal Edri: Ready for merge Jenkins CI: Passed CI tests David Caro: Looks good to me -- To view, visit https://gerrit.ovirt.org/56161 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I133d95d4c7834947f5c73197161f04758e554b9f Gerrit-PatchSet: 4 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Shlomo Ben David <sbendavi(a)redhat.com> Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: David Caro <dcaro(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nadav Goldin <ngoldin(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Sharon Naftaly <snaftaly(a)redhat.com> Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: Refactor AddCinderDiskCommandCallback
by mlipchuk＠redhat.com 24 Apr '16

24 Apr '16

Maor Lipchuk has submitted this change and it was merged. Change subject: engine: Refactor AddCinderDiskCommandCallback ...................................................................... engine: Refactor AddCinderDiskCommandCallback Refactor AddCinderDiskCommandCallback to inherit from ConcurrentChildCommandsExecutionCallback to minimize code duplication and ease future refactors. Change-Id: I97f54ce9f2afe290f7bf38d503706dd57f7a182a Signed-off-by: Fred Rolland <frolland(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/cinder/AddCinderDiskCommandCallback.java 1 file changed, 22 insertions(+), 53 deletions(-) Approvals: Jenkins CI: Passed CI tests Freddy Rolland: Verified Maor Lipchuk: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/54118 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I97f54ce9f2afe290f7bf38d503706dd57f7a182a Gerrit-PatchSet: 13 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Fred Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: RemoveSnapshotCommandCallback refactor
by mlipchuk＠redhat.com 24 Apr '16

24 Apr '16

Maor Lipchuk has submitted this change and it was merged. Change subject: engine: RemoveSnapshotCommandCallback refactor ...................................................................... engine: RemoveSnapshotCommandCallback refactor Use the generic callback for RemoveSnapshotCommand. Change-Id: I6a5e4578b58b94afb7e71b85a89bdf96c77d3060 Signed-off-by: Fred Rolland <frolland(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/RemoveSnapshotCommand.java D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/RemoveSnapshotCommandCallback.java 2 files changed, 1 insertion(+), 68 deletions(-) Approvals: Greg Padgett: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Amit Aviram: Looks good to me, but someone else must approve Freddy Rolland: Verified Liron Aravot: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/53099 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6a5e4578b58b94afb7e71b85a89bdf96c77d3060 Gerrit-PatchSet: 21 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Fred Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: audit console's client ip change in vm-analyzer
by ahadas＠redhat.com 24 Apr '16

24 Apr '16

Arik Hadas has submitted this change and it was merged. Change subject: core: audit console's client ip change in vm-analyzer ...................................................................... core: audit console's client ip change in vm-analyzer There is no reason not to audit a change in console's client ip in VmAnalyzer. We do not call bll command so no need to put it in VdsEventListener. We do not do anything in a batch for all VMs reported on the same host so no need to do it in VmsMonitoring. Thus, moving it to VmAnalyzer. Change-Id: I5a9aafa9820582f11c6b70c1fb7e048c030f5591 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsEventListener.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/IVdsEventListener.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmAnalyzer.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmsMonitoring.java M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/monitoring/VmAnalyzerTest.java 5 files changed, 10 insertions(+), 33 deletions(-) Approvals: Jakub Niedermertl: Looks good to me, but someone else must approve Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/56361 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5a9aafa9820582f11c6b70c1fb7e048c030f5591 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: introduce VmJob#toString
by ahadas＠redhat.com 24 Apr '16

24 Apr '16

Arik Hadas has submitted this change and it was merged. Change subject: core: introduce VmJob#toString ...................................................................... core: introduce VmJob#toString Adding toString method to VmJob in order to have it displayed the same way in all log printings. Change-Id: I75f6e24311060b0cbd912897679da1cca1b8f3e6 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmJob.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmJobsMonitoring.java 2 files changed, 10 insertions(+), 5 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/56247 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I75f6e24311060b0cbd912897679da1cca1b8f3e6 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0