April 2016 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Make setup method in HotPlugDiskToVmCommandTest more r...
by tnisan＠redhat.com 20 Apr '16

20 Apr '16

Tal Nisan has submitted this change and it was merged. Change subject: core: Make setup method in HotPlugDiskToVmCommandTest more readable ...................................................................... core: Make setup method in HotPlugDiskToVmCommandTest more readable Use @Mock instead of manual mocks, separate blocks that handle different mock behaviors to make the setup method more readable Change-Id: Ia8f14326e5098ae07dd1c6cb955fa18cfef9d372 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/disk/HotPlugDiskToVmCommandTest.java 1 file changed, 10 insertions(+), 3 deletions(-) Approvals: Tal Nisan: Verified Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/56420 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia8f14326e5098ae07dd1c6cb955fa18cfef9d372 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Unify both @Before methods in HotPlugDiskToVmCommand
by tnisan＠redhat.com 20 Apr '16

20 Apr '16

Tal Nisan has submitted this change and it was merged. Change subject: core: Unify both @Before methods in HotPlugDiskToVmCommand ...................................................................... core: Unify both @Before methods in HotPlugDiskToVmCommand Unify both @Before methods to make the code more readable, having one method at the top of the class can result in missing the second one which is in the middle of the class. By JUnit spec the order multiple @Before methods are invoked is not guaranteed so it doesn't matter which content comes first Change-Id: Ic10aa3147405a10edb4ed79b762ce7b929dc9804 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/disk/HotPlugDiskToVmCommandTest.java 1 file changed, 15 insertions(+), 18 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/56419 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic10aa3147405a10edb4ed79b762ce7b929dc9804 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Remove duplicate code in HotPlugDiskToVmCommandTest
by tnisan＠redhat.com 20 Apr '16

20 Apr '16

Tal Nisan has submitted this change and it was merged. Change subject: core: Remove duplicate code in HotPlugDiskToVmCommandTest ...................................................................... core: Remove duplicate code in HotPlugDiskToVmCommandTest All tests are mocking DiskDao and VmDao in the command either directly or by calling another method, moved those to the setup method. Inlined the oneline method mockVMDao Change-Id: I18cec31ac2842145d2a106f36671968d547d4c16 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/disk/HotPlugDiskToVmCommandTest.java 1 file changed, 3 insertions(+), 11 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/56422 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I18cec31ac2842145d2a106f36671968d547d4c16 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Fix typo in HotUnPlugDiskFromVmCommandTest methods
by tnisan＠redhat.com 20 Apr '16

20 Apr '16

Tal Nisan has submitted this change and it was merged. Change subject: core: Fix typo in HotUnPlugDiskFromVmCommandTest methods ...................................................................... core: Fix typo in HotUnPlugDiskFromVmCommandTest methods Change-Id: Ic1996e03399c82b153d07c3eb2e8ce57c6319c70 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/disk/HotPlugDiskToVmCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/disk/HotUnPlugDiskFromVmCommandTest.java 2 files changed, 10 insertions(+), 10 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/56421 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic1996e03399c82b153d07c3eb2e8ce57c6319c70 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-live[ovirt-live-3.6]: oVirt Live 3.6.5 Final
by sbonazzo＠redhat.com 20 Apr '16

20 Apr '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: oVirt Live 3.6.5 Final ...................................................................... oVirt Live 3.6.5 Final Change-Id: I7522fdb3748784c8f4e86042d22b1923e74179af Signed-off-by: Lev Veyde <lveyde(a)redhat.com> --- M centos-7/Makefile M centos-7/kickstart/ovirt-live-ovirt-custom.ks.in 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/56426 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7522fdb3748784c8f4e86042d22b1923e74179af Gerrit-PatchSet: 2 Gerrit-Project: ovirt-live Gerrit-Branch: ovirt-live-3.6 Gerrit-Owner: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: utils: make sure to log any exceptions from task failures
by masayag＠redhat.com 20 Apr '16

20 Apr '16

Moti Asayag has submitted this change and it was merged. Change subject: utils: make sure to log any exceptions from task failures ...................................................................... utils: make sure to log any exceptions from task failures When tasks fail due to exception there is no information about the cause of it. We want to log it to know why a task failed. Change-Id: I1dc1e7ea8ef243b2fe43f73fd0d71b3d477aace4 Signed-off-by: pkliczewski <piotr.kliczewski(a)gmail.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/threadpool/ThreadPoolUtil.java 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Piotr Kliczewski: Verified Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved Oved Ourfali: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/56390 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1dc1e7ea8ef243b2fe43f73fd0d71b3d477aace4 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: cache vm-statistics in vm-manager
by ahadas＠redhat.com 20 Apr '16

20 Apr '16

Arik Hadas has submitted this change and it was merged. Change subject: core: cache vm-statistics in vm-manager ...................................................................... core: cache vm-statistics in vm-manager Cache VmStatistics in-memory in VmManager instance of the VM. Change-Id: Ic632b55107b2a9615a5308760e6fc0c68f56b511 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmManager.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmsMonitoring.java 2 files changed, 17 insertions(+), 4 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Shmuel Leib Melamud: Looks good to me, but someone else must approve Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/56358 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic632b55107b2a9615a5308760e6fc0c68f56b511 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek <mskrivan(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: add job id to live-merge polling logs
by ahadas＠redhat.com 20 Apr '16

20 Apr '16

Arik Hadas has submitted this change and it was merged. Change subject: core: add job id to live-merge polling logs ...................................................................... core: add job id to live-merge polling logs Print the ID of the VM-job that is associated with the live merge operation to ease debugging. Change-Id: I4a82acce7f55de9b64aa1b8b0ca6721b42f68c44 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MergeCommandCallback.java 1 file changed, 3 insertions(+), 2 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Shmuel Leib Melamud: Looks good to me, but someone else must approve Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/56151 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4a82acce7f55de9b64aa1b8b0ca6721b42f68c44 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Change HotUnPlugDiskToVmCommandTest to use ValidateTes...
by tnisan＠redhat.com 20 Apr '16

20 Apr '16

Tal Nisan has submitted this change and it was merged. Change subject: core: Change HotUnPlugDiskToVmCommandTest to use ValidateTestUtils ...................................................................... core: Change HotUnPlugDiskToVmCommandTest to use ValidateTestUtils Changed the HotUnPlugDiskToVmCommandTest to use ValidateTestUtils as per the project's standards instead of plain assertions which upon failure display only an assertion failure without the full cause Change-Id: I5b99bc53b39679c2a820c48c3a20ec555487cff7 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/disk/HotUnPlugDiskFromVmCommandTest.java 1 file changed, 2 insertions(+), 6 deletions(-) Approvals: Tal Nisan: Verified Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/56381 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5b99bc53b39679c2a820c48c3a20ec555487cff7 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Change HotPlugDiskToVmCommandTest to use ValidateTestU...
by tnisan＠redhat.com 20 Apr '16

20 Apr '16

Tal Nisan has submitted this change and it was merged. Change subject: core: Change HotPlugDiskToVmCommandTest to use ValidateTestUtils ...................................................................... core: Change HotPlugDiskToVmCommandTest to use ValidateTestUtils Changed the HotPlugDiskToVmCommandTest to use ValidateTestUtils as per the project's standards instead of plain assertions which upon failure display only an assertion failure without the full cause Change-Id: I479b48b000abc168287d5fd2e112241cba017260 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/disk/HotPlugDiskToVmCommandTest.java 1 file changed, 8 insertions(+), 29 deletions(-) Approvals: Tal Nisan: Verified Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/56379 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I479b48b000abc168287d5fd2e112241cba017260 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0