Change in ovirt-engine[master]: core: Change test name in HotPlugDiskToVmCommandTest
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: Change test name in HotPlugDiskToVmCommandTest
......................................................................
core: Change test name in HotPlugDiskToVmCommandTest
Change a test named "validateSuccessFailed" which makes no sense and is
probably the result of a copy paste
Change-Id: I5f5ec75df6a15a7f21995e2cedfd15cbf13bc120
Signed-off-by: Tal Nisan <tnisan(a)redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/disk/HotPlugDiskToVmCommandTest.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Tal Nisan: Verified
Jenkins CI: Passed CI tests
Allon Mureinik: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/56380
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5f5ec75df6a15a7f21995e2cedfd15cbf13bc120
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 2 months
Change in ovirt-engine[master]: core: HostSetupNetworksValidator#networkAttachmentsFromParam...
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: HostSetupNetworksValidator#networkAttachmentsFromParamsByNetworkId
......................................................................
core: HostSetupNetworksValidator#networkAttachmentsFromParamsByNetworkId
Removed a fields that is just updated but never read.
Change-Id: Ice1b3aab61290f0ac4400c4fa3dd200e2f09200d
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/HostSetupNetworksValidator.java
1 file changed, 0 insertions(+), 2 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Martin Mucha: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Allon Mureinik: Verified
Yevgeny Zaspitsky: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/56368
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ice1b3aab61290f0ac4400c4fa3dd200e2f09200d
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <wallaroo1976(a)gmail.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 2 months
Change in ovirt-engine[master]: core: cleanup vm-manager
by ahadas＠redhat.com
Arik Hadas has submitted this change and it was merged.
Change subject: core: cleanup vm-manager
......................................................................
core: cleanup vm-manager
1. Reduce the constructor visibility to package-protected
2. Use injection to get the required DAOs
3. Rename the 'id' field to vmId
4. Move the instantiation of 'lock' field to the constructor
Change-Id: I435344a4f80de3bd826f8e5e062c1d13b14c15e5
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/ResourceManager.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmManager.java
2 files changed, 20 insertions(+), 26 deletions(-)
Approvals:
Shahar Havivi: Looks good to me, approved
Jenkins CI: Passed CI tests
Shmuel Leib Melamud: Looks good to me, but someone else must approve
Arik Hadas: Verified
--
To view, visit https://gerrit.ovirt.org/56357
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I435344a4f80de3bd826f8e5e062c1d13b14c15e5
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek <mskrivan(a)redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 2 months
Change in ovirt-engine[master]: restapi: Add IPv6 fields to HostNic
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: restapi: Add IPv6 fields to HostNic
......................................................................
restapi: Add IPv6 fields to HostNic
Change-Id: I420315342fbf08b2034fa4ed3a7177282a669171
Bug-Url: https://bugzilla.redhat.com/1080725
Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
---
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendHostNicsResourceTest.java
M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/HostNicMapper.java
2 files changed, 112 insertions(+), 38 deletions(-)
Approvals:
Juan Hernandez: Looks good to me, approved
Jenkins CI: Passed CI tests
Yevgeny Zaspitsky: Verified
--
To view, visit https://gerrit.ovirt.org/55476
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I420315342fbf08b2034fa4ed3a7177282a669171
Gerrit-PatchSet: 29
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 2 months
Change in ovirt-engine[master]: core: remove support for fc22
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: core: remove support for fc22
......................................................................
core: remove support for fc22
Remove support for fc22 from check-patch.sh script.
Change-Id: I2c72491cf7c33460aa9467e50071883f5c76d6e5
Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
---
M automation/check-patch.sh
1 file changed, 0 insertions(+), 7 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
Dan Kenigsberg: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/56363
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2c72491cf7c33460aa9467e50071883f5c76d6e5
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: David Caro <dcaro(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 2 months
Change in ovirt-engine-sdk-java[master]: Fix connect timeout of HTTP connection
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: Fix connect timeout of HTTP connection
......................................................................
Fix connect timeout of HTTP connection
setConnectionRequestTimeout set the timeout in milliseconds
used when requesting a connection from the connection manager.
setConnectTimeout set the timeout in milliseconds until a
connection is established.
We have to use setConnectTimeout.
Change-Id: Ie4ff807613a8ae48312544a590f2eaca864cdae4
Signed-off-by: Ondra Machacek <omachace(a)redhat.com>
---
M sdk/src/main/java/org/ovirt/engine/sdk4/internal/ConnectionBuilder45.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Ondra Machacek: Verified
Juan Hernandez: Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/56346
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie4ff807613a8ae48312544a590f2eaca864cdae4
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk-java
Gerrit-Branch: master
Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 2 months
Change in ovirt-engine-sdk-java[master]: Add SSO support
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: Add SSO support
......................................................................
Add SSO support
Use SSO service for authentication.
When authenticating the sdk should obtain access_token from SSO and use
Bearer authentication to access API using the access token.
The SSO access token is revoked at the end of the session to terminate
the session on SSO and clean up the engine session.
Change-Id: I93eefb798b7987ec08ba287f08375c739e19a4ea
Bug-Url: https://bugzilla.redhat.com/1285885
Signed-off-by: Ondra Machacek <omachace(a)redhat.com>
---
M automation/build-artifacts.packages
M automation/check-patch.packages
M packaging/spec.el7.in
M packaging/spec.fc23.in
M sdk/pom.xml
M sdk/src/main/java/org/ovirt/engine/sdk4/ConnectionBuilder.java
M sdk/src/main/java/org/ovirt/engine/sdk4/internal/ConnectionBuilder42.java
M sdk/src/main/java/org/ovirt/engine/sdk4/internal/ConnectionBuilder45.java
M sdk/src/main/java/org/ovirt/engine/sdk4/internal/HttpConnection.java
A sdk/src/main/java/org/ovirt/engine/sdk4/internal/SsoUtils.java
10 files changed, 287 insertions(+), 50 deletions(-)
Approvals:
Ondra Machacek: Verified
Juan Hernandez: Looks good to me, approved
Ravi Nori: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/56109
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I93eefb798b7987ec08ba287f08375c739e19a4ea
Gerrit-PatchSet: 12
Gerrit-Project: ovirt-engine-sdk-java
Gerrit-Branch: master
Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 2 months
Change in ovirt-dwh[master]: history: fix bug in 3.6 views of data center statistics
by Shirly Radco
Shirly Radco has submitted this change and it was merged.
Change subject: history: fix bug in 3.6 views of data center statistics
......................................................................
history: fix bug in 3.6 views of data center statistics
Change-Id: I26b2533431e7dbb7d0a64fcc67f3179bf19ac468
Bug-Url: https://bugzilla.redhat.com/1328769
Signed-off-by: Shirly Radco <sradco(a)redhat.com>
---
M packaging/dbscripts/create_views_3_6.sql
1 file changed, 3 insertions(+), 6 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, but someone else must approve
Shirly Radco: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/56383
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I26b2533431e7dbb7d0a64fcc67f3179bf19ac468
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-dwh
Gerrit-Branch: master
Gerrit-Owner: Shirly Radco <sradco(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 2 months
Change in ovirt-engine[master]: aaa: Add service to invoke SSO Logout
by mperina＠redhat.com
Martin Peřina has submitted this change and it was merged.
Change subject: aaa: Add service to invoke SSO Logout
......................................................................
aaa: Add service to invoke SSO Logout
Add a service sso-logout to invoke
logout given an access token and scope
Change-Id: Idd11e1af4d705b8b6ee6e7a9e621670c3f79dad5
Bug-Url: https://bugzilla.redhat.com/1092744
Signed-off-by: Ravi Nori <rnori(a)redhat.com>
---
A backend/manager/modules/services/src/main/java/org/ovirt/engine/core/services/SSOLogoutServlet.java
M backend/manager/modules/services/src/main/webapp/WEB-INF/web.xml
2 files changed, 58 insertions(+), 0 deletions(-)
Approvals:
Ondra Machacek: Looks good to me, but someone else must approve
Martin Peřina: Looks good to me, approved
Juan Hernandez: Looks good to me, but someone else must approve
Ravi Nori: Verified
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/55031
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Idd11e1af4d705b8b6ee6e7a9e621670c3f79dad5
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 2 months
Change in ovirt-engine[master]: core: stop polling the database for vm-jobs
by ahadas＠redhat.com
Arik Hadas has submitted this change and it was merged.
Change subject: core: stop polling the database for vm-jobs
......................................................................
core: stop polling the database for vm-jobs
Now that we have the up-to-date status of the VM-jobs in memory,
the callback of the merge operation can query that in-memory
repository instead of querying the database.
Change-Id: Ia597bc449b17e5da768998eb5e577dfedb745535
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MergeCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MergeCommandCallback.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmJobDao.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmJobDaoImpl.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmJobDaoTest.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmJobsMonitoring.java
M packaging/dbscripts/vm_jobs_sp.sql
7 files changed, 33 insertions(+), 84 deletions(-)
Approvals:
Shahar Havivi: Looks good to me, approved
Greg Padgett: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Shmuel Leib Melamud: Looks good to me, but someone else must approve
Ala Hino: Looks good to me, but someone else must approve
Moti Asayag: Looks good to me, but someone else must approve
Arik Hadas: Verified
--
To view, visit https://gerrit.ovirt.org/54442
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia597bc449b17e5da768998eb5e577dfedb745535
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 2 months