April 2016 - Engine-commits - oVirt List Archives

Change in ovirt-hosted-engine-setup[master]: packaging: setup: avoid copying answerfile over scp
by sbonazzo＠redhat.com 13 Apr '16

13 Apr '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: avoid copying answerfile over scp ...................................................................... packaging: setup: avoid copying answerfile over scp On additional hosts: - Reading first host answerfile from the shared storage Change-Id: I1ddd660d745887814b77ce4db4c1065e5b2128bd Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1322729 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M ovirt-hosted-engine-setup.spec.in M src/ovirt_hosted_engine_setup/constants.py M src/plugins/ovirt-hosted-engine-setup/core/remote_answerfile.py M src/plugins/ovirt-hosted-engine-setup/storage/storage.py 4 files changed, 63 insertions(+), 228 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Verified Jenkins CI: Passed CI tests Yedidyah Bar David: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/42224 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1ddd660d745887814b77ce4db4c1065e5b2128bd Gerrit-PatchSet: 11 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: Pass internal policy unit info to ClusterPolicyDao
by rgolan＠redhat.com 13 Apr '16

13 Apr '16

Roy Golan has submitted this change and it was merged. Change subject: Pass internal policy unit info to ClusterPolicyDao ...................................................................... Pass internal policy unit info to ClusterPolicyDao ClusterPolicyDao needs extra information to properly reconstruct custom cluster policies when internal policy units are assigned to it. The missing information caused NPE when trying to get the type of internal policy unit. Change-Id: I868a12ca073fcba12ac108daea45dcc7750d2274 Signed-off-by: Martin Sivak <msivak(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/SchedulingManager.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/scheduling/SchedulingManagerTest.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/scheduling/ClusterPolicyDao.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/scheduling/ClusterPolicyDaoImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/ClusterDaoTest.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/ClusterPolicyDaoTest.java 6 files changed, 68 insertions(+), 24 deletions(-) Approvals: Martin Sivák: Verified Martin Peřina: Verified; Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Roy Golan: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/55696 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I868a12ca073fcba12ac108daea45dcc7750d2274 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marek Libra <mlibra(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tomer Saban <tsaban(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-java[master]: Generate Java 7 compliant code
by juan.hernandez＠redhat.com 13 Apr '16

13 Apr '16

Juan Hernandez has submitted this change and it was merged. Change subject: Generate Java 7 compliant code ...................................................................... Generate Java 7 compliant code We need to use Java 7, because tools which provides rpm packaging on el7 can't work with Java 8. Change-Id: I8bf5d01f6c90e08d4729087766e120cfee964550 Signed-off-by: Ondra Machacek <omachace(a)redhat.com> --- M generator/src/main/java/org/ovirt/sdk/java/ServicesImplGenerator.java M pom.xml M sdk/pom.xml 3 files changed, 12 insertions(+), 7 deletions(-) Approvals: Ondra Machacek: Verified Juan Hernandez: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/56039 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8bf5d01f6c90e08d4729087766e120cfee964550 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine-sdk-java Gerrit-Branch: master Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-dwh[master]: history: changed the limit in DeleteTimekeeping job
by Shirly Radco 13 Apr '16

13 Apr '16

Shirly Radco has submitted this change and it was merged. Change subject: history: changed the limit in DeleteTimekeeping job ...................................................................... history: changed the limit in DeleteTimekeeping job Changed the limit for the queries in the historydelete, so each run the number of deleted rows will increase, according to the times the jub run. The initial value that will be used as the multiplier, can be changed by the user. Change-Id: I8e613b32589e594e03c81d24562ebba50eb84c31 Bug-Url: https://bugzilla.redhat.com/1321517 Signed-off-by: Shirly Radco <sradco(a)redhat.com> --- M etl_export/ovirt_engine_dwh/deletetimekeepingjob_4_0/contexts/Default.properties M etl_export/ovirt_engine_dwh/historydelete_4_0/contexts/Default.properties M etl_export/ovirt_engine_dwh/parallelrun_4_0/contexts/Default.properties M etl_export/src/main/java/ovirt_engine_dwh/deletetimekeepingjob_4_0/DeleteTimeKeepingJob.java M etl_export/src/main/java/ovirt_engine_dwh/historydelete_4_0/HistoryDelete.java M etl_export/src/main/java/ovirt_engine_dwh/parallelrun_4_0/ParallelRun.java M etl_export/src/main/resources/ovirt_engine_dwh/deletetimekeepingjob_4_0/contexts/Default.properties M etl_export/src/main/resources/ovirt_engine_dwh/historydelete_4_0/contexts/Default.properties M etl_export/src/main/resources/ovirt_engine_dwh/parallelrun_4_0/contexts/Default.properties M packaging/conf/settings.properties.in M packaging/services/ovirt-engine-dwhd/ovirt-engine-dwhd.conf.in M tos_project/context/connectionJDBC_4.0.item M tos_project/context/connectionJDBC_4.0.properties M tos_project/process/DeleteTimeKeepingJob_4.0.item M tos_project/process/DeleteTimeKeepingJob_4.0.properties M tos_project/process/HistoryDelete_4.0.item M tos_project/process/HistoryDelete_4.0.properties M tos_project/process/ParallelRun_4.0.item M tos_project/process/ParallelRun_4.0.properties 19 files changed, 2,722 insertions(+), 1,032 deletions(-) Approvals: Shirly Radco: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/56066 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8e613b32589e594e03c81d24562ebba50eb84c31 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Moving callback to CommonVmPoolWithVmsCommand
by ahadas＠redhat.com 13 Apr '16

13 Apr '16

Arik Hadas has submitted this change and it was merged. Change subject: core: Moving callback to CommonVmPoolWithVmsCommand ...................................................................... core: Moving callback to CommonVmPoolWithVmsCommand After modification of CommonVmPoolWithVmsCommand, AddVm commands that are launched by it are waiting to be finished by parent. That requires the parent to have a CoCo callback, that was added to AddVmPoolWithVmsCommand, but not to UpdateVmPoolWithVmsCommand. Change-Id: Ifdf71dfd545cb7bce4641cae3a4295b7dcc826c1 Signed-off-by: Shmuel Melamud <smelamud(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmPoolWithVmsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommonVmPoolWithVmsCommand.java 2 files changed, 7 insertions(+), 5 deletions(-) Approvals: Jenkins CI: Passed CI tests Shmuel Leib Melamud: Verified Arik Hadas: Looks good to me, approved Liron Aravot: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/56009 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifdf71dfd545cb7bce4641cae3a4295b7dcc826c1 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: change host deploy dependency
by sbonazzo＠redhat.com 13 Apr '16

13 Apr '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: core: change host deploy dependency ...................................................................... core: change host deploy dependency Change the host-deploy package name in pom.xml Change-Id: Ibd0ab25402b66fa288731ea507663d5ae77c44c7 Signed-off-by: emesika <emesika(a)redhat.com> --- M pom.xml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Martin Peřina: Looks good to me, but someone else must approve Juan Hernandez: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/53595 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibd0ab25402b66fa288731ea507663d5ae77c44c7 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: packaging: setup: Reset firewall manager if not available
by sbonazzo＠redhat.com 13 Apr '16

13 Apr '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: Reset firewall manager if not available ...................................................................... packaging: setup: Reset firewall manager if not available Change-Id: I9b7d7453f31f0eff92a7903a3e578fd57704faf2 Bug-Url: https://bugzilla.redhat.com/1323201 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-setup/base/network/firewall_manager.py 1 file changed, 23 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Jenkins CI: Passed CI tests Yedidyah Bar David: Verified -- To view, visit https://gerrit.ovirt.org/56020 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9b7d7453f31f0eff92a7903a3e578fd57704faf2 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-dwh[master]: history: enabled logging of dwh ETL process in debug mode
by Shirly Radco 13 Apr '16

13 Apr '16

Shirly Radco has submitted this change and it was merged. Change subject: history: enabled logging of dwh ETL process in debug mode ...................................................................... history: enabled logging of dwh ETL process in debug mode It is now possible to enable aggregation debug information. It will be sent to the ovirt-engine-dwhd.log file. Change-Id: I695026140f491261cf310b43d55303bef602cc78 Bug-Url: https://bugzilla.redhat.com/1285788 Signed-off-by: Shirly Radco <sradco(a)redhat.com> --- M etl_export/ovirt_engine_dwh/dailytimekeepingjob_4_0/contexts/Default.properties M etl_export/ovirt_engine_dwh/deletetimekeepingjob_4_0/contexts/Default.properties M etl_export/ovirt_engine_dwh/hourlytimekeepingjob_4_0/contexts/Default.properties M etl_export/ovirt_engine_dwh/parallelrun_4_0/contexts/Default.properties M etl_export/ovirt_engine_dwh/sampletimekeepingjob_4_0/contexts/Default.properties M etl_export/src/main/java/ovirt_engine_dwh/dailytimekeepingjob_4_0/DailyTimeKeepingJob.java M etl_export/src/main/java/ovirt_engine_dwh/deletetimekeepingjob_4_0/DeleteTimeKeepingJob.java M etl_export/src/main/java/ovirt_engine_dwh/hourlytimekeepingjob_4_0/HourlyTimeKeepingJob.java M etl_export/src/main/java/ovirt_engine_dwh/parallelrun_4_0/ParallelRun.java M etl_export/src/main/java/ovirt_engine_dwh/sampletimekeepingjob_4_0/SampleTimeKeepingJob.java M etl_export/src/main/resources/ovirt_engine_dwh/dailytimekeepingjob_4_0/contexts/Default.properties M etl_export/src/main/resources/ovirt_engine_dwh/deletetimekeepingjob_4_0/contexts/Default.properties M etl_export/src/main/resources/ovirt_engine_dwh/hourlytimekeepingjob_4_0/contexts/Default.properties M etl_export/src/main/resources/ovirt_engine_dwh/parallelrun_4_0/contexts/Default.properties M etl_export/src/main/resources/ovirt_engine_dwh/sampletimekeepingjob_4_0/contexts/Default.properties M packaging/conf/settings.properties.in M packaging/services/ovirt-engine-dwhd/ovirt-engine-dwhd.conf.in M tos_project/context/connectionJDBC_4.0.item M tos_project/context/connectionJDBC_4.0.properties M tos_project/process/DailyTimeKeepingJob_4.0.item M tos_project/process/DailyTimeKeepingJob_4.0.properties M tos_project/process/DeleteTimeKeepingJob_4.0.item M tos_project/process/DeleteTimeKeepingJob_4.0.properties M tos_project/process/HourlyTimeKeepingJob_4.0.item M tos_project/process/HourlyTimeKeepingJob_4.0.properties M tos_project/process/ParallelRun_4.0.item M tos_project/process/ParallelRun_4.0.properties M tos_project/process/SampleTimeKeepingJob_4.0.item M tos_project/process/SampleTimeKeepingJob_4.0.properties 29 files changed, 9,773 insertions(+), 1,948 deletions(-) Approvals: Shirly Radco: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/51645 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I695026140f491261cf310b43d55303bef602cc78 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: webadmin: Fix event handling after CPU Count change of runni...
by tnisan＠redhat.com 13 Apr '16

13 Apr '16

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Fix event handling after CPU Count change of running VM ...................................................................... webadmin: Fix event handling after CPU Count change of running VM Fix of CPU topology event handling in Edit VM dialog for existing VM by disabling additional event processing during recomputation. The CPU Total was not properly recomputed when num of sockets changed. Similar to computation of Num of Sockets when Total CPU changed. The Total CPU limit is limited to host cpu count conforming the CPUPolicyUnit. Change-Id: I592d428a9854a4c092ac7cce8ab17888e65ec7cd Bug-Url: https://bugzilla.redhat.com/1317473 Signed-off-by: Marek Libra <mlibra(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ExistingVmModelBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmModelBehaviorBase.java 2 files changed, 33 insertions(+), 7 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Jenkins CI: Passed CI tests Marek Libra: Verified -- To view, visit https://gerrit.ovirt.org/55945 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I592d428a9854a4c092ac7cce8ab17888e65ec7cd Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Marek Libra <mlibra(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marek Libra <mlibra(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Obtaining migration bandwidth
by tjelinek＠redhat.com 13 Apr '16

13 Apr '16

Tomas Jelinek has submitted this change and it was merged. Change subject: core: Obtaining migration bandwidth ...................................................................... core: Obtaining migration bandwidth DAOs, store procedures and queries to obtain necessary entities to compute maximum migration bandwidth. * HostNetworkQosDao#getHostNetworkQosOfMigrationNetworkByClusterId and related GetHostNetworkQosOfMigrationNetworkByClusterId stored procerure and host_network_qos_of_migration_network_by_cluster view added to get host network QoS of migration network of selected cluster if there is any. * InterfaceDao#getAllMigrationNetworkInterfacesInCluster and related GetAllMigrationNetworkInterfacesInCluster and migration_network_interfacesadded view to get all network interfaces of all hosts in cluster such that the network interfaces are connected to a network mark as 'migrational' for the cluster. Change-Id: I8e89932e163d6eecfc1833351d860c4e92d356bc Bug-Url: https://bugzilla.redhat.com/1252426 Feature-Page: http://www.ovirt.org/Features/Migration_Enhancements Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/HostNetworkQos.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/network/HostNetworkQosDao.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/network/HostNetworkQosDaoImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/network/InterfaceDao.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/network/InterfaceDaoImpl.java M packaging/dbscripts/create_views.sql M packaging/dbscripts/network_sp.sql M packaging/dbscripts/qos_sp.sql 8 files changed, 89 insertions(+), 0 deletions(-) Approvals: Jakub Niedermertl: Verified Eli Mesika: Looks good to me, but someone else must approve Alona Kaplan: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/55410 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8e89932e163d6eecfc1833351d860c4e92d356bc Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0