April 2016 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin: Fix NPE in Edit VM dialog
by tjelinek＠redhat.com 13 Apr '16

13 Apr '16

Tomas Jelinek has submitted this change and it was merged. Change subject: webadmin: Fix NPE in Edit VM dialog ...................................................................... webadmin: Fix NPE in Edit VM dialog NPE was thrown when Edit VM dialog was opened by selecting the vm followed by multiple clicks on action button (toolbar above table of vms) "Edit". The problem was in InstanceImagesModel#getAllCurrentDisks() that failed if getItems() returned `null` and in ExistingVmModelBehavior#updateInstanceImages$1.onSuccess that calls `lineModel.initialize` and thus transitively InstanceImagesModel#getAllCurrentDisks() before `getModel().getInstanceImages().setItems()` is called. Change-Id: Idf986bf074a7bb4259ac1707e35916151d5788c2 Bug-Url: https://bugzilla.redhat.com/1326311 Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/InstanceImagesModel.java 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Jakub Niedermertl: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/56055 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idf986bf074a7bb4259ac1707e35916151d5788c2 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: aaa: exttool: use JBoss JAAS configuration by default
by mperina＠redhat.com 13 Apr '16

13 Apr '16

Martin Peřina has submitted this change and it was merged. Change subject: aaa: exttool: use JBoss JAAS configuration by default ...................................................................... aaa: exttool: use JBoss JAAS configuration by default To be consistent with behaviour of aaa-ldap running in JBoss and extension-tool running outside of JBoss, we provide temporary configuration of JAAS to exttool, which reflect configuration of <security-domains> in JBoss. Change-Id: Idf816a065cc4e4b0a3dc5b378bacd4c2aa214dfb Bug-Url: https://bugzilla.redhat.com/1322940 Signed-off-by: Ondra Machacek <omachace(a)redhat.com> --- M backend/manager/extensions-tool/src/main/java/org/ovirt/engine/exttool/core/ExtensionsToolExecutor.java M packaging/bin/ovirt-engine-extensions-tool.sh 2 files changed, 76 insertions(+), 0 deletions(-) Approvals: Ondra Machacek: Verified Martin Peřina: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/56076 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idf816a065cc4e4b0a3dc5b378bacd4c2aa214dfb Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: packaging: engine-backup: Remove unused function bz_cat
by sbonazzo＠redhat.com 13 Apr '16

13 Apr '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: engine-backup: Remove unused function bz_cat ...................................................................... packaging: engine-backup: Remove unused function bz_cat Change-Id: I9cbbc9ba0198bccda4c750b917c7b67877688528 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/bin/engine-backup.sh.in 1 file changed, 0 insertions(+), 12 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Jenkins CI: Passed CI tests Yedidyah Bar David: Verified -- To view, visit https://gerrit.ovirt.org/55077 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9cbbc9ba0198bccda4c750b917c7b67877688528 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Update the syntax of HTTP compression filter
by mperina＠redhat.com 13 Apr '16

13 Apr '16

Martin Peřina has submitted this change and it was merged. Change subject: core: Update the syntax of HTTP compression filter ...................................................................... core: Update the syntax of HTTP compression filter The syntax of the predicates used by Undertow has changed to use parenthesis instead of square brackets. As a result the configuration that we use to enable compression of HTTP responses generates the following warning during startup: WARN Predicate regex[...] uses old style square braces to define predicates, which will be removed in a future release. predicate[value] should be changed to predicate(value) This patch changes replaces the square brackets with parenthesis. Change-Id: If07df6b6f78ff442056a4e46ae7b4fab2184f396 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M packaging/services/ovirt-engine/ovirt-engine.xml.in 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Martin Peřina: Looks good to me, approved Juan Hernandez: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/56058 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If07df6b6f78ff442056a4e46ae7b4fab2184f396 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Unify format of username
by mperina＠redhat.com 13 Apr '16

13 Apr '16

Martin Peřina has submitted this change and it was merged. Change subject: core: Unify format of username ...................................................................... core: Unify format of username Unifies format of username displayed inside engine as: USERNAME@AUTHZ_NAME where USERNAME - simple username AUTHZ_NAME - name of authz extension which was used to get authorization data for the user For example default oVirt administrator is identified as admin@internal-authz. There's one slight exception in the naming: if aaa-ldap is configured for Active Directory forrest which provides multi-domain trust, then we are using UPN instead of simple username, so USERNAME part may contain also reference to a domain, for example: jdoe@eu-ipa.example.com@example.com-authz fsmith@us-ipa.example.com@example.com-authz Change-Id: Ie7ec2f8982c63834eaa63c771ba905bd78d81615 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/SessionDataContainer.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Ondra Machacek: Looks good to me, but someone else must approve Martin Peřina: Verified; Looks good to me, approved Ravi Nori: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/56036 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie7ec2f8982c63834eaa63c771ba905bd78d81615 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Update column's table with timestamp.
by mlipchuk＠redhat.com 13 Apr '16

13 Apr '16

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Update column's table with timestamp. ...................................................................... core: Update column's table with timestamp. Use timestamp instead of date in the unregistered_disks table to also save the hour, minute and second. Change-Id: I4b70e9a767017eea9e67a6c1f8d5793ab4fca1c2 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M packaging/dbscripts/unregistered_disks_sp.sql A packaging/dbscripts/upgrade/04_00_0460_unregistered_disks_use_date_with_timezone.sql 2 files changed, 4 insertions(+), 2 deletions(-) Approvals: Jenkins CI: Passed CI tests Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/55960 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4b70e9a767017eea9e67a6c1f8d5793ab4fca1c2 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-release[ovirt-3.6]: Align package version ot the overall oVirt version
by sbonazzo＠redhat.com 13 Apr '16

13 Apr '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: Align package version ot the overall oVirt version ...................................................................... Align package version ot the overall oVirt version Change-Id: I259b03671c23734e54738d613c38a2a6931a6dd7 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M automation/build-artifacts.sh M configure.ac M ovirt-release36.spec.in 3 files changed, 11 insertions(+), 8 deletions(-) Approvals: Fabian Deutsch: Looks good to me, but someone else must approve Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/56063 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I259b03671c23734e54738d613c38a2a6931a6dd7 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-release Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Fabian Deutsch <fabiand(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: Build Java SDK also on el7
by sbonazzo＠redhat.com 13 Apr '16

13 Apr '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: Build Java SDK also on el7 ...................................................................... Build Java SDK also on el7 We added support to build Java SDK also on el7. Change-Id: I425f5a5acf2781d9f4aa94f4a3d6d7288b54138c Signed-off-by: Ondra Machacek <omachace(a)redhat.com> --- M jobs/confs/projects/ovirt-engine-sdk-java/ovirt-engine-sdk-java_build-artifacts.yaml 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Sandro Bonazzola: Ready for merge Juan Hernandez: Verified; Looks good to me Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/56074 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I425f5a5acf2781d9f4aa94f4a3d6d7288b54138c Gerrit-PatchSet: 2 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-release[master]: [Node]: Add requires for gluster pkgs
by sbonazzo＠redhat.com 13 Apr '16

13 Apr '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: [Node]: Add requires for gluster pkgs ...................................................................... [Node]: Add requires for gluster pkgs Gluster packages are required to be included in the node distro. Change-Id: I3cf5f91a904535eb0adc3efabe92c89ead5cd12e Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> --- M ovirt-release-master.spec.in 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Fabian Deutsch: Looks good to me, but someone else must approve Douglas Schilling Landgraf: Verified Sandro Bonazzola: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/55843 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3cf5f91a904535eb0adc3efabe92c89ead5cd12e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-release Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Fabian Deutsch <fabiand(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-java[master]: Add support to build el7 rpm
by juan.hernandez＠redhat.com 13 Apr '16

13 Apr '16

Juan Hernandez has submitted this change and it was merged. Change subject: Add support to build el7 rpm ...................................................................... Add support to build el7 rpm Because httpclient version 4.5 isn't provided in el7 repos we need to patch sources to provide support to el7, where is httpclient version 4.2 Change-Id: I2fbfe963e9c0dbf27f7f64331adb5364a8e27c97 Signed-off-by: Ondra Machacek <omachace(a)redhat.com> --- A packaging/ovirt-engine-sdk-java-4.0-el7support.patch M packaging/spec.el7.in M packaging/spec.fc23.in 3 files changed, 324 insertions(+), 12 deletions(-) Approvals: Ondra Machacek: Verified Juan Hernandez: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/55965 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2fbfe963e9c0dbf27f7f64331adb5364a8e27c97 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine-sdk-java Gerrit-Branch: master Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0