Change in ovirt-engine[master]: engine: Add External Network Provider to list of providers
by alkaplan@redhat.com
Alona Kaplan has submitted this change and it was merged.
Change subject: engine: Add External Network Provider to list of providers
......................................................................
engine: Add External Network Provider to list of providers
External Network provider is a new type of external provider in oVirt.
This patch adds the backend changes needed for the the external
network provider UI changes.
Several classes in this patch are still empty
(like ExternalNetworkProviderProperties), they will be filled
with content when subsequent features for external networks will be added.
Change-Id: If3a1a60884cbbbcb140314a8b72352306934b202
Signed-off-by: mirecki <mmirecki(a)redhat.com>
Bug-Url: https://bugzilla.redhat.com/1314375
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/ProviderProxyFactory.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/network/openstack/ExternalNetworkProviderProxy.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/network/openstack/ExternalNetworkTokenProvider.java
A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/provider/network/openstack/ExternalNetworkTokenProviderTest.java
A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/ExternalNetworkProviderProperties.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/ProviderType.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/provider/ProviderDaoImpl.java
7 files changed, 206 insertions(+), 1 deletion(-)
Approvals:
Marcin Mirecki: Verified
Martin Mucha: Looks good to me, but someone else must approve
Alona Kaplan: Looks good to me, approved; Passed CI tests
Yevgeny Zaspitsky: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/55404
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If3a1a60884cbbbcb140314a8b72352306934b202
Gerrit-PatchSet: 13
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Marcin Mirecki <mmirecki(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com>
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 8 months
Change in ovirt-engine-sdk-ruby[master]: Add Gemfile.lock
by juan.hernandez@redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: Add Gemfile.lock
......................................................................
Add Gemfile.lock
This patch adds the Gemfile.lock file to the repository.
Change-Id: Ibd86290053d81ac36001061886b8ce57d0a1eb3d
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
A sdk/Gemfile.lock
1 file changed, 40 insertions(+), 0 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/55869
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibd86290053d81ac36001061886b8ce57d0a1eb3d
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk-ruby
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 8 months
Change in ovirt-engine-sdk-ruby[master]: Explicitly require the package tasks
by juan.hernandez@redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: Explicitly require the package tasks
......................................................................
Explicitly require the package tasks
This patch changes the Rakefile to explicit require the package tasks,
as otherwise they may not work with JRuby.
Change-Id: I703cdbb838cdaa7c853df5300de39d9bd1cd4280
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M sdk/Rakefile
1 file changed, 3 insertions(+), 1 deletion(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/55868
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I703cdbb838cdaa7c853df5300de39d9bd1cd4280
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk-ruby
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 8 months
Change in ovirt-engine[master]: webadmin: Widget library enhanced
by tjelinek@redhat.com
Tomas Jelinek has submitted this change and it was merged.
Change subject: webadmin: Widget library enhanced
......................................................................
webadmin: Widget library enhanced
* HasWidgetLabels & WidgetLabel interfaces allowing decoupling of
(editor) widget and its label. The connection is done declaratively in
* LabelWithTooltip - implementation of WidgetLabel
ui.xml files.
* AbstractLabelableEntityModelEditor - a generic editor without label
(it doesn't inherit from AbstractValidatedWidgetWithLabel)
implementing HasWidgetLabels (similar to )
* BootstrapListBoxListModelEditor and IntegerEntityModelEditor -
editors based on AbstractLabelableEntityModelEditor
Change-Id: Ia846c34c4bfaa188a816d5654ea2425e4dea5ea7
Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationTemplates.java
A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/BootstrapListModelListBox.java
A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/generic/AbstractLabelableEntityModelEditor.java
A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/generic/BootstrapListBoxListModelEditor.java
A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/generic/IntegerEntityModelEditor.java
A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/label/HasWidgetLabels.java
A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/label/LabelWithTooltip.java
A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/label/WidgetLabel.java
8 files changed, 477 insertions(+), 0 deletions(-)
Approvals:
Tomas Jelinek: Looks good to me, approved
Jakub Niedermertl: Verified; Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/54320
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia846c34c4bfaa188a816d5654ea2425e4dea5ea7
Gerrit-PatchSet: 15
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com>
Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 8 months
Change in ovirt-engine-sdk-java[master]: Add support to read response of action
by juan.hernandez@redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: Add support to read response of action
......................................................................
Add support to read response of action
This patch is adding missing support of reading response of action
Change-Id: I0246298f4929f51315a240a2f9bd8744511b50c4
Signed-off-by: Ondra Machacek <omachace(a)redhat.com>
---
M generator/src/main/java/org/ovirt/sdk/java/ServicesImplGenerator.java
M generator/src/main/java/org/ovirt/sdk/java/Tool.java
M sdk/src/main/java/org/ovirt/engine/sdk/services/internal/ServiceImpl.java
3 files changed, 52 insertions(+), 81 deletions(-)
Approvals:
Ondra Machacek: Verified
Juan Hernandez: Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/55883
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0246298f4929f51315a240a2f9bd8744511b50c4
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine-sdk-java
Gerrit-Branch: master
Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 8 months
Change in ovirt-engine[master]: hyperv: default on again for windows >= 2008/2012
by ahadas@redhat.com
Arik Hadas has submitted this change and it was merged.
Change subject: hyperv: default on again for windows >= 2008/2012
......................................................................
hyperv: default on again for windows >= 2008/2012
In commit b38298a we disabled by default hyperv optimizations
for windows because of reported instabilities in QEMU.
Back in time, the reference platform was RHEL6.x, which had
less optimal HyperV support.
Now the default platform is RHEL 7.x, so we can re-enable
them again.
Change-Id: Idc3f8ea836f212290b36ec8bed4d4bcd3dec7bb2
Bug-Url: https://bugzilla.redhat.com/1320594
Backport-To: 3.6
Signed-off-by: Francesco Romani <fromani(a)redhat.com>
---
M packaging/conf/osinfo-defaults.properties
1 file changed, 2 insertions(+), 6 deletions(-)
Approvals:
Francesco Romani: Verified
Arik Hadas: Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/55117
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Idc3f8ea836f212290b36ec8bed4d4bcd3dec7bb2
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 8 months
Change in ovirt-engine[master]: core: Javadoc references to ValidationResult#error
by amureini@redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Javadoc references to ValidationResult#error
......................................................................
core: Javadoc references to ValidationResult#error
ValidationResult does not have an "error" method, and never did (at
least not in any committed revision of this class).
This patch fixes the javadoc's references to it to reference the
failWith method that has the same semantics but actually exists.
Change-Id: Iea1d32b27c5d2b9d476a1790ccdc1f6f584cff22
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ValidationResult.java
1 file changed, 4 insertions(+), 4 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Allon Mureinik: Verified; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/55980
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iea1d32b27c5d2b9d476a1790ccdc1f6f584cff22
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 8 months
Change in ovirt-engine[master]: core: <code> HTML tags in ValidationResult javadoc
by amureini@redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: <code> HTML tags in ValidationResult javadoc
......................................................................
core: <code> HTML tags in ValidationResult javadoc
Used the standard javadoc {@code} javadoc tag instead of hardcoding the
HTML <code> tag so that various doclets can better handle this class'
javadoc.
Change-Id: If6effe95f781cabdac0b9230ad14eb426bdc6b8c
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ValidationResult.java
1 file changed, 3 insertions(+), 3 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Allon Mureinik: Verified; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/55979
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If6effe95f781cabdac0b9230ad14eb426bdc6b8c
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 8 months
Change in ovirt-hosted-engine-ha[ovirt-hosted-engine-ha-1.3]: build: ovirt-hosted-engine-ha-1.3.5.3
by sbonazzo@redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: build: ovirt-hosted-engine-ha-1.3.5.3
......................................................................
build: ovirt-hosted-engine-ha-1.3.5.3
Change-Id: I0a330dc7c1998a6c7225326707ee900882a78894
Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com>
---
M configure.ac
M ovirt-hosted-engine-ha.spec.in
2 files changed, 8 insertions(+), 5 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, but someone else must approve
Martin Sivák: Looks good to me, approved
Simone Tiraboschi: Verified
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/55966
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0a330dc7c1998a6c7225326707ee900882a78894
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-hosted-engine-ha
Gerrit-Branch: ovirt-hosted-engine-ha-1.3
Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 8 months
Change in ovirt-engine[master]: core: Fix <UNKNOWN> cluster in task messages
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: Fix <UNKNOWN> cluster in task messages
......................................................................
core: Fix <UNKNOWN> cluster in task messages
The 'Tasks' message in the UI shows the cluster as "<UNKNOWN>"
for several commands.
This patch fix the message to display the cluster name as
expected.
Change-Id: I5fe1644d8f132eb6f9e0148c3140086effda7e05
Signed-off-by: Fred Rolland <frolland(a)redhat.com>
---
M backend/manager/modules/dal/src/main/resources/bundles/ExecutionMessages.properties
1 file changed, 19 insertions(+), 19 deletions(-)
Approvals:
Eli Mesika: Looks good to me, approved
Jenkins CI: Passed CI tests
Allon Mureinik: Looks good to me, but someone else must approve
Freddy Rolland: Verified
--
To view, visit https://gerrit.ovirt.org/55916
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5fe1644d8f132eb6f9e0148c3140086effda7e05
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Fred Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 8 months