Change in ovirt-engine[ovirt-engine-3.6]: core: Added permissions to Power User
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: Added permissions to Power User
......................................................................
core: Added permissions to Power User
Added permission to 'Attach Disk Profile' to Power User.
Change-Id: If17d5bc09c60e3ab6b22e40260f82222ded25c3d
Bug-Url: https://bugzilla.redhat.com/1311052
Signed-off-by: Tomer Saban <tsaban(a)redhat.com>
(cherry picked from commit be9724556fbc82de3a171acc5a2df335ce5b22e2)
---
A packaging/dbscripts/upgrade/03_06_2090_add_attach_disk_profile_permissions_to_power_user_role.sql
1 file changed, 2 insertions(+), 0 deletions(-)
Approvals:
Tal Nisan: Passed CI tests
Eli Mesika: Looks good to me, but someone else must approve
Tomer Saban: Verified
Roy Golan: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/55406
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If17d5bc09c60e3ab6b22e40260f82222ded25c3d
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Tomer Saban <tsaban(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Tomer Saban <tsaban(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years
Change in ovirt-live[ovirt-live-3.6]: oVirt Live 3.6.5 rc2
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: oVirt Live 3.6.5 rc2
......................................................................
oVirt Live 3.6.5 rc2
Change-Id: Id161ff7de70f7f6dbddbbbe486f0ecc7d945f7e3
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M centos-7/Makefile
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/55667
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id161ff7de70f7f6dbddbbbe486f0ecc7d945f7e3
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-live
Gerrit-Branch: ovirt-live-3.6
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
8 years
Change in ovirt-engine[ovirt-engine-3.6.5]: HE: Enable hosted engine vNIC editing
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: HE: Enable hosted engine vNIC editing
......................................................................
HE: Enable hosted engine vNIC editing
This patch enabled vNIC management for the hosted engine VM,
But the management interface (ovirtmgmt) can't be deactivated
for the HE VM.
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1319769
Change-Id: Ic85659ef7c036762afa64a43e7bda7e7d527f483
Signed-off-by: Martin Sivak <msivak(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/ActivateDeactivateVmNicCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/AddVmInterfaceCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/RemoveVmInterfaceCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/validation/VmActionByVmOriginTypeValidator.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
9 files changed, 39 insertions(+), 0 deletions(-)
Approvals:
Tal Nisan: Passed CI tests
Martin Sivák: Verified
Roy Golan: Looks good to me, approved
Objections:
Jenkins CI: Failed CI tests
--
To view, visit https://gerrit.ovirt.org/55569
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic85659ef7c036762afa64a43e7bda7e7d527f483
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6.5
Gerrit-Owner: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years
Change in ovirt-engine[ovirt-engine-3.6.5]: HE: Make the unmanaged hosted engine error a bit more generic
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: HE: Make the unmanaged hosted engine error a bit more generic
......................................................................
HE: Make the unmanaged hosted engine error a bit more generic
This updates the ACTION_TYPE_FAILED_UNMANAGED_HOSTED_ENGINE
error message to include the full action and type to make
it ready for more actions than just VM activation.
The message is changed from:
Cannot ${action} unmanaged hosted engine VM. Please upgrade the cluster
level to 3.6 and wait for the hosted engine storage domain to be
properly imported.
To:
Cannot ${action} ${type}. You are using an unmanaged hosted engine VM.
Please upgrade the cluster level to 3.6 and wait for the hosted engine
storage domain to be properly imported.
Change-Id: Ie3230c4b7a783d200df0da18cf8462a21aa0b54f
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1319769
Signed-off-by: Martin Sivak <msivak(a)redhat.com>
---
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
4 files changed, 4 insertions(+), 4 deletions(-)
Approvals:
Martin Sivák: Verified
Jenkins CI: Passed CI tests
Roy Golan: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/55568
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie3230c4b7a783d200df0da18cf8462a21aa0b54f
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6.5
Gerrit-Owner: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years
Change in ovirt-engine[ovirt-engine-3.6.5]: packaging: Allow different java home per component
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: packaging: Allow different java home per component
......................................................................
packaging: Allow different java home per component
Change-Id: I4943f685c9d972ea6deb098565cea87f72274bab
Bug-Url: https://bugzilla.redhat.com/1303132
Signed-off-by: Yedidyah Bar David <didi(a)redhat.com>
---
M packaging/bin/java-home
M packaging/pythonlib/ovirt_engine/java.py
2 files changed, 60 insertions(+), 7 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved
Jenkins CI: Passed CI tests
Yedidyah Bar David: Verified
--
To view, visit https://gerrit.ovirt.org/55650
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4943f685c9d972ea6deb098565cea87f72274bab
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6.5
Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
8 years
Change in ovirt-engine[ovirt-engine-3.6]: scheduler: Store correct OS version in map
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: scheduler: Store correct OS version in map
......................................................................
scheduler: Store correct OS version in map
Write the new version into the highest version map.
Change-Id: I9594f2f8f8c5d9c7fbeba7b6aff3a77cdc533d14
Bug-Url: https://bugzilla.redhat.com/1241149
Signed-off-by: Roman Mohr <rmohr(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/InClusterUpgradeWeightPolicyUnit.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/scheduling/policyunits/InClusterUpgradeWeightPolicyUnitTest.java
2 files changed, 2 insertions(+), 2 deletions(-)
Approvals:
Roman Mohr: Verified
Jenkins CI: Passed CI tests
Roy Golan: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/55566
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9594f2f8f8c5d9c7fbeba7b6aff3a77cdc533d14
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years
Change in ovirt-engine[ovirt-engine-3.6]: packaging: Allow different java home per component
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: packaging: Allow different java home per component
......................................................................
packaging: Allow different java home per component
Change-Id: I4943f685c9d972ea6deb098565cea87f72274bab
Bug-Url: https://bugzilla.redhat.com/1303132
Signed-off-by: Yedidyah Bar David <didi(a)redhat.com>
---
M packaging/bin/java-home
M packaging/pythonlib/ovirt_engine/java.py
2 files changed, 60 insertions(+), 7 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved
Jenkins CI: Passed CI tests
Yedidyah Bar David: Verified
--
To view, visit https://gerrit.ovirt.org/55648
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4943f685c9d972ea6deb098565cea87f72274bab
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years
Change in ovirt-engine[ovirt-engine-3.6]: webadmin: Added CPU Profiles Roles to the RoleTree
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: Added CPU Profiles Roles to the RoleTree
......................................................................
webadmin: Added CPU Profiles Roles to the RoleTree
CPU profile roles were added to the Role Tree in the UI. The roles are:
CpuProfileCreator and CpuProfileOperator.
Change-Id: Ib5e8b2b11a882fadadd1e6261fb574f871d4ec4c
Bug-Url: https://bugzilla.redhat.com/1143869
Signed-off-by: Tomer Saban <tsaban(a)redhat.com>
Signed-off-by: Tal Nisan <tnisan(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/configure/roles_ui/RoleTreeView.java
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/LocalizedEnums.java
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java
M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/LocalizedEnums.properties
4 files changed, 49 insertions(+), 2 deletions(-)
Approvals:
Tal Nisan: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/55651
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib5e8b2b11a882fadadd1e6261fb574f871d4ec4c
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years
Change in ovirt-engine[master]: core: minor refactoring in vm-analyzer
by ahadas＠redhat.com
Arik Hadas has submitted this change and it was merged.
Change subject: core: minor refactoring in vm-analyzer
......................................................................
core: minor refactoring in vm-analyzer
1. In proceedDownVm, 'prevStatus' is always assigned with some value
now so no need to compare to 'Unassigned'.
2. Remove the arguments from handleVmOnDown and inMigrationTo methods.
3. Remove the argument from afterSuspendTreatment method.
4. Remove redundant null checks in proceedVmBeforeDeletion and
removeVmFromCache methods.
Change-Id: I4128fd29470ddcaeecc882f16ed5aa3e0e34a965
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmAnalyzer.java
1 file changed, 29 insertions(+), 30 deletions(-)
Approvals:
Shahar Havivi: Looks good to me, approved
Jenkins CI: Passed CI tests
Arik Hadas: Verified
--
To view, visit https://gerrit.ovirt.org/55630
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4128fd29470ddcaeecc882f16ed5aa3e0e34a965
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years
Change in ovirt-reports[master]: packaging: Have own java home
by Shirly Radco
Shirly Radco has submitted this change and it was merged.
Change subject: packaging: Have own java home
......................................................................
packaging: Have own java home
Do not use java home as set by the engine code, as the engine currently
supports both 1.7 and 1.8 while reports supports 1.7 only.
Change-Id: I043225d4a55b5f1949d0c6455637c112788d5bdb
Bug-Url: https://bugzilla.redhat.com/1303132
Signed-off-by: Yedidyah Bar David <didi(a)redhat.com>
---
M packaging/services/ovirt-engine-reportsd/ovirt-engine-reportsd.py
M packaging/setup/ovirt_engine_setup/reports/constants.py
M packaging/setup/ovirt_engine_setup/reports/reportsutil.py
M packaging/setup/plugins/ovirt-engine-common/ovirt-engine-reports/config/__init__.py
A packaging/setup/plugins/ovirt-engine-common/ovirt-engine-reports/config/java.py
M packaging/setup/plugins/ovirt-engine-reports-tool/ovirt-engine-reports/core/misc.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/config/jboss.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/jasper/deploy.py
8 files changed, 67 insertions(+), 16 deletions(-)
Approvals:
Shirly Radco: Looks good to me, approved
Jenkins CI: Passed CI tests
Yedidyah Bar David: Verified
--
To view, visit https://gerrit.ovirt.org/55619
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I043225d4a55b5f1949d0c6455637c112788d5bdb
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-reports
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years
