Change in ovirt-engine[master]: webadmin: fixes in cluster migration tab
by tjelinek＠redhat.com
Tomas Jelinek has submitted this change and it was merged.
Change subject: webadmin: fixes in cluster migration tab
......................................................................
webadmin: fixes in cluster migration tab
- moved the migration related properties to "migration" tab
- added disabling the additional properties when a policy is selected
- fixed the showing of the description of the policy (needs to be inited only
after the view)
- removed redundant setting of the changability of the additional properties
(leftover after the version cleanup)
Change-Id: Ib2ad3871baf5eebcd973f6bcc9c235e4a877d9e8
Bug-Url: https://bugzilla.redhat.com/1339538
Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterModel.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterPopupView.ui.xml
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/ApplicationConstants.properties
5 files changed, 39 insertions(+), 19 deletions(-)
Approvals:
Tomas Jelinek: Verified; Looks good to me, approved; Passed CI tests
Marek Libra: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/57923
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib2ad3871baf5eebcd973f6bcc9c235e4a877d9e8
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marek Libra <mlibra(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years
Change in otopi[master]: topic: Spelling error causing KeyError in minidnf
by didi＠redhat.com
Yedidyah Bar David has submitted this change and it was merged.
Change subject: topic: Spelling error causing KeyError in minidnf
......................................................................
topic: Spelling error causing KeyError in minidnf
This misspelling leads to vdsm being unable to install through
the ovirt engine due to a KeyError being raised.
Change-Id: I04872144215b2cea0f4ca7251fa6c3bbc0cf2cdc
Signed-off-by: Hayley Swimelar <hayley(a)linbit.com>
---
M src/otopi/minidnf.py
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Hayley Swimelar: Verified
Jenkins CI: Passed CI tests
Yedidyah Bar David: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/57901
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I04872144215b2cea0f4ca7251fa6c3bbc0cf2cdc
Gerrit-PatchSet: 1
Gerrit-Project: otopi
Gerrit-Branch: master
Gerrit-Owner: Hayley Swimelar <hayley(a)linbit.com>
Gerrit-Reviewer: Hayley Swimelar <hayley(a)linbit.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years
Change in ovirt-engine[master]: core: fixed typo in migration policy name
by tjelinek＠redhat.com
Tomas Jelinek has submitted this change and it was merged.
Change subject: core: fixed typo in migration policy name
......................................................................
core: fixed typo in migration policy name
replaced 'not may not' to 'may not'
Change-Id: Ib49e6e29548507bdc57cd2637f7a30b0a3e1b715
Bug-Url: https://bugzilla.redhat.com/1338843
Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com>
---
M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Tomas Jelinek: Verified
Martin Peřina: Looks good to me, approved
Eli Mesika: Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/58009
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib49e6e29548507bdc57cd2637f7a30b0a3e1b715
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years
Change in ovirt-engine[master]: webadmin: added reporting of current cmd line
by tjelinek＠redhat.com
Tomas Jelinek has submitted this change and it was merged.
Change subject: webadmin: added reporting of current cmd line
......................................................................
webadmin: added reporting of current cmd line
Added the current kernel cmd line reporting to the edit host dialog.
Change-Id: I862ddddd1f7d268425786cded42c6d3ef9c0c6d2
Bug-Url: https://bugzilla.redhat.com/1339539
Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostModel.java
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java
M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/UIConstants.properties
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostPopupView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostPopupView.ui.xml
5 files changed, 29 insertions(+), 0 deletions(-)
Approvals:
Tomas Jelinek: Verified; Passed CI tests
Martin Betak: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/57921
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I862ddddd1f7d268425786cded42c6d3ef9c0c6d2
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years
Change in ovirt-engine[master]: core: added kernelArgs storing to vds_dynamic
by tjelinek＠redhat.com
Tomas Jelinek has submitted this change and it was merged.
Change subject: core: added kernelArgs storing to vds_dynamic
......................................................................
core: added kernelArgs storing to vds_dynamic
VDSM started to report kernelArgs in caps - this patch adds the engine-side
support to store it in the DB.
Change-Id: Ib5f8ea42342b78c857a924d51c4f42a6cacd49db
Bug-Url: https://bugzilla.redhat.com/1339539
Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDS.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsDynamic.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDaoImpl.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDynamicDaoImpl.java
M backend/manager/modules/dal/src/test/resources/fixtures.xml
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsProperties.java
M packaging/dbscripts/create_views.sql
A packaging/dbscripts/upgrade/04_00_0710_add_kernel_args_to_vds_dynamic.sql
M packaging/dbscripts/vds_sp.sql
10 files changed, 45 insertions(+), 6 deletions(-)
Approvals:
Tomas Jelinek: Verified
Martin Peřina: Looks good to me, but someone else must approve
Eli Mesika: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Arik Hadas: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/57920
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib5f8ea42342b78c857a924d51c4f42a6cacd49db
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years
Change in jenkins[master]: ovirt-engine: add 4.0 branch
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: ovirt-engine: add 4.0 branch
......................................................................
ovirt-engine: add 4.0 branch
Change-Id: I45358eeb7a0b55a51ac3c035beba66c810b6ab18
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M jobs/confs/projects/ovirt-engine/ovirt-engine_standard.yaml
M jobs/confs/projects/ovirt-engine/ovirt-engine_upgrade-engine.yaml
M jobs/confs/projects/ovirt/publish-rpms-nightly-4.0.yaml
A jobs/ovirt-engine_upgrade_to_4.0/build_engine_rpm.sh
A jobs/ovirt-engine_upgrade_to_4.0/cleanup.file.otopi
A jobs/ovirt-engine_upgrade_to_4.0/cleanup.sh
A jobs/ovirt-engine_upgrade_to_4.0/setup.file.otopi
A jobs/ovirt-engine_upgrade_to_4.0/upgrade.sh
8 files changed, 840 insertions(+), 2 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me; Ready for merge
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/57949
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I45358eeb7a0b55a51ac3c035beba66c810b6ab18
Gerrit-PatchSet: 2
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nadav Goldin <ngoldin(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Sharon Naftaly <snaftaly(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years
Change in ovirt-engine[master]: core: ChildCommandsCallbackBase - setSucceeded(false)
by laravot＠redhat.com
Liron Aravot has submitted this change and it was merged.
Change subject: core: ChildCommandsCallbackBase - setSucceeded(false)
......................................................................
core: ChildCommandsCallbackBase - setSucceeded(false)
When the command entity is persisted, its return value is persisted as well.
If the command execute() succeeded, getReturnValue().getSucceeded() will return
true.
The command object is built from the persisted command entity, which means
that the return value will be initiated to the persisted return value, when calling
endAction() having the return value returning true value when checking
getSucceeded() might lead to wrong results.
This patch is simple and sets the succeeded flag to false to avoid that issue.
Change-Id: I39fd64001b0ef5354853aa3e6433d478f8dbb74a
Signed-off-by: Liron Aravot <laravot(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChildCommandsCallbackBase.java
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Moti Asayag: Looks good to me, approved
Liron Aravot: Verified; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/58010
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I39fd64001b0ef5354853aa3e6433d478f8dbb74a
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years
Change in ovirt-engine[master]: core: Import template from external provider with balloon de...
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: Import template from external provider with balloon device enabled
......................................................................
core: Import template from external provider with balloon device enabled
When importing images from external providers as template, set the "Ballon
device enabled" to true as done as the default behavior when creating a VM
Change-Id: I533ec7e0c2849bc7ab77579f3f4df7a3ea952a40
Signed-off-by: Tal Nisan <tnisan(a)redhat.com>
Bug-Url: https://bugzilla.redhat.com/1338665
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/repoimage/ImportRepoImageCopyTaskHandler.java
1 file changed, 2 insertions(+), 0 deletions(-)
Approvals:
Tal Nisan: Verified; Passed CI tests
Daniel Erez: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/57980
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I533ec7e0c2849bc7ab77579f3f4df7a3ea952a40
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years
Change in jenkins[master]: restrict engine build-artifacts to bare metal slaves
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: restrict engine build-artifacts to bare metal slaves
......................................................................
restrict engine build-artifacts to bare metal slaves
bug-url: https://ovirt-jira.atlassian.net/browse/OVIRT-523
Change-Id: Ifbb6e36b5527a08100e2dc738417694a5337f71d
Signed-off-by: ngoldin <ngoldin(a)redhat.com>
---
M jobs/confs/projects/ovirt-engine/ovirt-engine_standard.yaml
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me; Ready for merge
Nadav Goldin: Verified; Ready for review
Jenkins CI: Passed CI tests
David Caro: Looks good to me
--
To view, visit https://gerrit.ovirt.org/58007
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifbb6e36b5527a08100e2dc738417694a5337f71d
Gerrit-PatchSet: 2
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: Nadav Goldin <ngoldin(a)redhat.com>
Gerrit-Reviewer: David Caro <dcaro(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nadav Goldin <ngoldin(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years
Change in ovirt-engine[master]: webadmin: Override migration policy
by tjelinek＠redhat.com
Tomas Jelinek has submitted this change and it was merged.
Change subject: webadmin: Override migration policy
......................................................................
webadmin: Override migration policy
- The VM popup update patch mangled the override migration
policy. This patch fixes that issue.
Change-Id: I2c4ec68da042a3977d2432d3f52ad83b96c57428
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1338834
Signed-off-by: Alexander Wels <awels(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.ui.xml
2 files changed, 41 insertions(+), 2 deletions(-)
Approvals:
Tomas Jelinek: Looks good to me, approved
Alexander Wels: Verified
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/57982
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2c4ec68da042a3977d2432d3f52ad83b96c57428
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years