May 2016 - Engine-commits - oVirt List Archives

Change in ovirt-release[ovirt-4.0]: node: Add mailx requirement
by sbonazzo＠redhat.com 18 May '16

18 May '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: node: Add mailx requirement ...................................................................... node: Add mailx requirement Adding mailx to be able to read emails from daemon/agents. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1335503 Change-Id: I952d56574af11ea4748c9d4c33c704b095bbd08e Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> Signed-off-by: Tolik Litovsky <tlitovsk(a)redhat.com> --- M ovirt-release40.spec.in 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/57624 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I952d56574af11ea4748c9d4c33c704b095bbd08e Gerrit-PatchSet: 3 Gerrit-Project: ovirt-release Gerrit-Branch: ovirt-4.0 Gerrit-Owner: Anatoly Litovsky <tlitovsk(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Fabian Deutsch <fabiand(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: restapi: Improve addLinks() readability and performance
by oliel＠redhat.com 18 May '16

18 May '16

Ori Liel has submitted this change and it was merged. Change subject: restapi: Improve addLinks() readability and performance ...................................................................... restapi: Improve addLinks() readability and performance This patch makes improvements to the process of adding links to retrieved API entities, making it slightly more readable and more importantly, more efficient. Bug-Url: https://bugzilla.redhat.com/1208221 Change-Id: If75f7bf1107b3198b196d4b3a06153570562ab93 Signed-off-by: Ori Liel <oliel(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/AbstractBackendResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/util/LinkHelper.java 2 files changed, 297 insertions(+), 206 deletions(-) Approvals: Ori Liel: Verified; Looks good to me, approved; Passed CI tests Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/57231 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If75f7bf1107b3198b196d4b3a06153570562ab93 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: (SN) Actual IP address should be shown for dhcp bo...
by alkaplan＠redhat.com 18 May '16

18 May '16

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: (SN) Actual IP address should be shown for dhcp boot protocol ...................................................................... webadmin: (SN) Actual IP address should be shown for dhcp boot protocol Change-Id: I26a3b5e76e7405b34d52ca0235425264a2cfed6d Bug-Url: https://bugzilla.redhat.com/1325670 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/InterfacePropertiesAccessor.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/NetworkAttachmentModel.java 2 files changed, 61 insertions(+), 1 deletion(-) Approvals: Martin Mucha: Looks good to me, but someone else must approve Alona Kaplan: Verified; Passed CI tests Daniel Erez: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/57505 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I26a3b5e76e7405b34d52ca0235425264a2cfed6d Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-setup[master]: build: post ovirt-hosted-engine-setup-2.0.0_beta1
by stirabos＠redhat.com 18 May '16

18 May '16

Simone Tiraboschi has submitted this change and it was merged. Change subject: build: post ovirt-hosted-engine-setup-2.0.0_beta1 ...................................................................... build: post ovirt-hosted-engine-setup-2.0.0_beta1 Change-Id: I8bdffbb88a99a89b37a0e6bc1fc2da36899a0d86 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M automation/build-artifacts.sh M configure.ac 2 files changed, 4 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Verified Simone Tiraboschi: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/57606 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8bdffbb88a99a89b37a0e6bc1fc2da36899a0d86 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: sort the vms lists in import vms window
by tjelinek＠redhat.com 18 May '16

18 May '16

Tomas Jelinek has submitted this change and it was merged. Change subject: webadmin: sort the vms lists in import vms window ...................................................................... webadmin: sort the vms lists in import vms window Sorting both lists displayed in the "Import Virtual Machine(s)" window (VMs tab->import action). There are 2 lists of VMs in that window: Virtual Machines on Source", "Virtual Machines to Import" and both of them are now displaying the VMs sorted by name (alphabetically, the same as displayed in the Storage tab->VM Import sub tab). Please note that the lists remain sorted after loading the VMs to import and also after moving chosen VMs from list to list using the arrows. Change-Id: I8cb771e129087c77bd2a906a12fe3f9c05f8e0ee Bug-Url: https://bugzilla.redhat.com/1296558 Signed-off-by: Sharon Gratch <sgratch(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/SplitTable.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ImportVmsModel.java 2 files changed, 63 insertions(+), 4 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved; Passed CI tests Sharon Gratch: Verified -- To view, visit https://gerrit.ovirt.org/57552 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8cb771e129087c77bd2a906a12fe3f9c05f8e0ee Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sharon Gratch <sgratch(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sharon Gratch <sgratch(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: engine: bump VM version upon VM nic add/update
by tnisan＠redhat.com 18 May '16

18 May '16

Tal Nisan has submitted this change and it was merged. Change subject: engine: bump VM version upon VM nic add/update ...................................................................... engine: bump VM version upon VM nic add/update Change-Id: I000fa834b4c393e6ab261e4ae52d1fd71acfcdd4 Bug-Url: https://bugzilla.redhat.com/1327267 Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/AbstractVmInterfaceCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/AddVmInterfaceCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/RemoveVmInterfaceCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/UpdateVmInterfaceCommand.java 5 files changed, 16 insertions(+), 0 deletions(-) Approvals: Jenkins CI: Passed CI tests Roy Golan: Looks good to me, but someone else must approve Arik Hadas: Looks good to me, approved Yevgeny Zaspitsky: Verified -- To view, visit https://gerrit.ovirt.org/57453 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I000fa834b4c393e6ab261e4ae52d1fd71acfcdd4 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-setup[master]: build: ovirt-hosted-engine-setup-2.0.0_beta1
by stirabos＠redhat.com 18 May '16

18 May '16

Simone Tiraboschi has submitted this change and it was merged. Change subject: build: ovirt-hosted-engine-setup-2.0.0_beta1 ...................................................................... build: ovirt-hosted-engine-setup-2.0.0_beta1 Change-Id: Id770c665020f4966a357cbb76ffbe0cab3f5d81e Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M automation/build-artifacts.sh M configure.ac M ovirt-hosted-engine-setup.spec.in 3 files changed, 3 insertions(+), 5 deletions(-) Approvals: Sandro Bonazzola: Verified Simone Tiraboschi: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/57605 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id770c665020f4966a357cbb76ffbe0cab3f5d81e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: Kernel cmdline - frontend
by tjelinek＠redhat.com 18 May '16

18 May '16

Tomas Jelinek has submitted this change and it was merged. Change subject: webadmin: Kernel cmdline - frontend ...................................................................... webadmin: Kernel cmdline - frontend This feature allows to customize kernel commandline (bootloader configuration) of hosts. This patch adds 'Kernel' tab to 'Host' dialog allowing to edit kernel commandline parameters. User can either choose form 4 predefined params using checkboxes or use textbox to create fully custom kernel cmdline (the cmdline will still be merged with predefined parameters that are already in bootloader). Kernel command line is never parsed pack to checkboxes. Change-Id: I6794f5b8ac60257e037a1c6e745387ab7c56232a Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/1301104 --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationTemplates.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/generic/AbstractLabelableEntityModelEditor.java A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/generic/TextEntityModelEditor.java M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Cloner.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/TabName.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/EditHostModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostModel.java A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/KernelCmdlineUtil.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/NewHostModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/popup/host/HostPopupPresenterWidget.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostPopupView.ui.xml 17 files changed, 685 insertions(+), 44 deletions(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/57053 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6794f5b8ac60257e037a1c6e745387ab7c56232a Gerrit-PatchSet: 23 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Kernel cmdline - data layer
by tjelinek＠redhat.com 18 May '16

18 May '16

Tomas Jelinek has submitted this change and it was merged. Change subject: core: Kernel cmdline - data layer ...................................................................... core: Kernel cmdline - data layer This feature allows to customize kernel commandline (bootloader configuration) of hosts. The configuration is stored in vds_static table in columns: kernel_cmdline and last_stored_kernel_cmdline. 'kernel_cmdline' column is JSON structured and holds values of checkboxes for UI and generated line to be send to hosts. The line is never parsed to checkboxes again. 'last_stored_kernel_cmdline' column contains last successfully stored line in host. Line from 'kernel_cmdline' column will be copied to last_stored_kernel_cmdline after successful host deploy. VdsStaticDao#update method and underlying stored procedure don't update 'last_stored_kernel_cmdline' column to prevent accidental change. There is separate VdsStaticDao#updateLastStoredKernelCmdline that called that will only be called from host deploy. Host deploy procedure will send both current and last stored line to the host because the tool manipulating bootloader configuration - grubby - can't actually read the configuration, only write. Thus old configuration is necessary to know what to remove before applying new configuration. Bug-Url: https://bugzilla.redhat.com/1301104 Change-Id: I93c1d299fa9c86c2bf4dc958904f61aaccf38ec4 Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/ServerCpu.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDS.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsStatic.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDaoImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsStaticDao.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsStaticDaoImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VdsStaticDaoTest.java M backend/manager/modules/dal/src/test/resources/fixtures.xml M packaging/dbscripts/create_views.sql A packaging/dbscripts/upgrade/04_00_0680_vds_add_kernel_args_columns.sql M packaging/dbscripts/upgrade/post_upgrade/0010_add_object_column_white_list_table.sql M packaging/dbscripts/vds_sp.sql 12 files changed, 328 insertions(+), 14 deletions(-) Approvals: Tomas Jelinek: Verified; Passed CI tests Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/57051 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I93c1d299fa9c86c2bf4dc958904f61aaccf38ec4 Gerrit-PatchSet: 14 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: gluster: fix NPE in gluster volumes Tab.
by sabose＠redhat.com 18 May '16

18 May '16

Sahina Bose has submitted this change and it was merged. Change subject: gluster: fix NPE in gluster volumes Tab. ...................................................................... gluster: fix NPE in gluster volumes Tab. There is an NPE when we compare null > 0. This happens when unsyncedEntries is null in volume bricks. So adding a null check before using this for comparison. Change-Id: I28a12bd37e30e35bdb722fe65e8a428e1cc097df Signed-off-by: Ramesh Nachimuthu <rnachimu(a)redhat.com> --- M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/utils/GlusterVolumeUtils.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationMessages.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/cell/BrickStatusCell.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/BrickStatusColumn.java 4 files changed, 6 insertions(+), 5 deletions(-) Approvals: Jenkins CI: Passed CI tests Sahina Bose: Looks good to me, approved Ramesh N: Verified -- To view, visit https://gerrit.ovirt.org/57609 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I28a12bd37e30e35bdb722fe65e8a428e1cc097df Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0