May 2016 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin: add deprecated to Legacy USB support
by tjelinek＠redhat.com 18 May '16

18 May '16

Tomas Jelinek has submitted this change and it was merged. Change subject: webadmin: add deprecated to Legacy USB support ...................................................................... webadmin: add deprecated to Legacy USB support Change-Id: Ibb307daec0aca4890363f866ca3be2734a7539b0 Bug-Url: https://bugzilla.redhat.com/1337055 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/LocalizedEnums.properties 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tomas Jelinek: Verified; Passed CI tests Martin Betak: Looks good to me, approved Michal Skrivanek: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/57616 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibb307daec0aca4890363f866ca3be2734a7539b0 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-setup[master]: network: skip NetworkManager check/disable via answerfile
by stirabos＠redhat.com 18 May '16

18 May '16

Simone Tiraboschi has submitted this change and it was merged. Change subject: network: skip NetworkManager check/disable via answerfile ...................................................................... network: skip NetworkManager check/disable via answerfile Adding the capability to skip NM check and disabling by host-deploy via answerfile (dafault enforcing). In the normal flow, host-deploy will disable NetworkManager if active. When host-deploy runs, the management bridge has already been created and the engine VM is already running so disabling NetworkManager on the fly can be risky for the engine VM networking. To avoid that, ovirt-hosted-engine-setup will check NetworkManager status and eventually ask the user to stop: this behavior wasn't configurable. On the other side Next Generation Node is based on Cockpit, which requires NetworkManager to report the network status. Next Generation Node comes with NetworkManager-config-server so NetworkManager there should be passive enough. With this patch we make its check optionally skippable via answerfile. Change-Id: Iaec165cfb8bf93a3a17af20b23ce97ec2ad3223d Bug-Url: https://bugzilla.redhat.com/1337050 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M src/ovirt_hosted_engine_setup/constants.py M src/plugins/gr-he-setup/engine/add_host.py M src/plugins/gr-he-setup/network/bridge.py 3 files changed, 21 insertions(+), 3 deletions(-) Approvals: Simone Tiraboschi: Verified; Looks good to me, approved Jenkins CI: Passed CI tests Yedidyah Bar David: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/56146 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iaec165cfb8bf93a3a17af20b23ce97ec2ad3223d Gerrit-PatchSet: 10 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Fabian Deutsch <fabiand(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ryan Barry <rbarry(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: dedicated query for monitored network interfaces
by ahadas＠redhat.com 18 May '16

18 May '16

Arik Hadas has submitted this change and it was merged. Change subject: core: dedicated query for monitored network interfaces ...................................................................... core: dedicated query for monitored network interfaces Previously, we used GetVmNetworkInterfaceViewByVmId that uses the costly vm_interface_view in order to query the network interfaces whose statistics are being monitored. This patches adds a new procedure that uses a much lighter view than vm_interface_view that will be used by the monitoring instead. There is still a lot of place for improvement but this change seems to be the simpler and one that would probably be needed along with further improvements anyway as it reduces the time to fetch the data by more than four times. Change-Id: I475ffe644c7636e1e3a5ddea474d08f4b6ee80bd Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/network/VmNetworkInterfaceDao.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/network/VmNetworkInterfaceDaoImpl.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmAnalyzerFactory.java M packaging/dbscripts/create_views.sql M packaging/dbscripts/network_sp.sql 5 files changed, 84 insertions(+), 1 deletion(-) Approvals: Eli Mesika: Looks good to me, but someone else must approve Shahar Havivi: Looks good to me, approved Alona Kaplan: Looks good to me, approved Arik Hadas: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/57474 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I475ffe644c7636e1e3a5ddea474d08f4b6ee80bd Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek <mskrivan(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-setup[master]: upgrade: improving upgrade flow
by stirabos＠redhat.com 18 May '16

18 May '16

Simone Tiraboschi has submitted this change and it was merged. Change subject: upgrade: improving upgrade flow ...................................................................... upgrade: improving upgrade flow improving the upgrade flow to replace the el6 appliance with an el7 one restoring a backup and configuring it Change-Id: I7fcdee34aad5dbf21bf00822f89c53f6359de283 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M src/ovirt_hosted_engine_setup/constants.py M src/ovirt_hosted_engine_setup/vm_status.py M src/plugins/gr-he-common/core/misc.py M src/plugins/gr-he-common/core/remote_answerfile.py M src/plugins/gr-he-common/engine/health.py M src/plugins/gr-he-common/vm/boot_disk.py M src/plugins/gr-he-common/vm/cloud_init.py M src/plugins/gr-he-common/vm/misc.py M src/plugins/gr-he-upgradeappliance/core/misc.py M src/plugins/gr-he-upgradeappliance/vm/configurevm.py M src/plugins/gr-he-upgradeappliance/vm/runvm.py 11 files changed, 52 insertions(+), 16 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Simone Tiraboschi: Verified; Looks good to me, approved Jenkins CI: Passed CI tests Yedidyah Bar David: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/57521 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7fcdee34aad5dbf21bf00822f89c53f6359de283 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: Revert "ovirt-engine: build on bare metal"
by sbonazzo＠redhat.com 18 May '16

18 May '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: Revert "ovirt-engine: build on bare metal" ...................................................................... Revert "ovirt-engine: build on bare metal" This reverts commit 58849171dde763b09e5bc9b0d68a416df1ac94a5. Bare metal slaves are not compliant. Change-Id: I4866dc4606825e83983817aca2e73cad8c12f30c Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M jobs/confs/projects/ovirt-engine/ovirt-engine_standard.yaml 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Sandro Bonazzola: Verified; Looks good to me; Passed CI tests; Ready for merge -- To view, visit https://gerrit.ovirt.org/57619 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4866dc4606825e83983817aca2e73cad8c12f30c Gerrit-PatchSet: 1 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: added info icon to import VM dialog
by tjelinek＠redhat.com 18 May '16

18 May '16

Tomas Jelinek has submitted this change and it was merged. Change subject: webadmin: added info icon to import VM dialog ...................................................................... webadmin: added info icon to import VM dialog Added a question mark to import VM dialog explaining the XEN URI Change-Id: Ic7f504cd8db0c748941fa72e096f3aa2f73bd65d Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationTemplates.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ImportVmsModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/ImportVmsPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/ImportVmsPopupView.ui.xml 5 files changed, 45 insertions(+), 24 deletions(-) Approvals: Tomas Jelinek: Verified Jenkins CI: Passed CI tests Martin Betak: Looks good to me, approved Tomas Golembiovsky: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/57421 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic7f504cd8db0c748941fa72e096f3aa2f73bd65d Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Tomas Golembiovsky <tgolembi(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: restapi: added the setting of the migration bandwidth to clu...
by tjelinek＠redhat.com 18 May '16

18 May '16

Tomas Jelinek has submitted this change and it was merged. Change subject: restapi: added the setting of the migration bandwidth to cluster ...................................................................... restapi: added the setting of the migration bandwidth to cluster The setting allows to set the migration bandwidth on cluster level (not allowed on VM/template/pool level). There are 3 options possible: - hypervisor_default: fallback to the value defined on the vdsm.conf - custom: value set directly by user as <custom_value> - auto: engine takes the value from QoS if it is defined. If not, it looks the link speed between the two migrating hosts up and uses it. If it is not reported, falls back to hypervisor_default. Change-Id: If84e42bfeb74de6ff3540463714d487c33e435c4 Bug-Url: https://bugzilla.redhat.com/1252426 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendClustersResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendDataCenterClustersResourceTest.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/ClusterMapper.java A backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/ClusterMigrationOptionsMapper.java 4 files changed, 62 insertions(+), 2 deletions(-) Approvals: Tomas Jelinek: Verified Juan Hernandez: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/57397 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If84e42bfeb74de6ff3540463714d487c33e435c4 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: restapi: added migration policy ID to cluster and VmBase
by tjelinek＠redhat.com 18 May '16

18 May '16

Tomas Jelinek has submitted this change and it was merged. Change subject: restapi: added migration policy ID to cluster and VmBase ...................................................................... restapi: added migration policy ID to cluster and VmBase The migration policies are configured only in vdc_options using engine config - so in REST the only thing we can do is to make the assignement of them to cluster or vm based resources configurable. Change-Id: Iaceeb9830f312f9c1e031b7d35b230ce186a8205 Bug-Url: https://bugzilla.redhat.com/1252426 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/HasMigrationOptions.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/MigrationOptionsMapper.java 2 files changed, 24 insertions(+), 0 deletions(-) Approvals: Tomas Jelinek: Verified Juan Hernandez: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/56631 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iaceeb9830f312f9c1e031b7d35b230ce186a8205 Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: ovirt-engine: build on bare metal
by sbonazzo＠redhat.com 18 May '16

18 May '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: ovirt-engine: build on bare metal ...................................................................... ovirt-engine: build on bare metal Build engine on bare metal slaves. This should speed up the builds. Change-Id: I6017721b5c31a5bedb9523da11d2d5c966bae254 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M jobs/confs/projects/ovirt-engine/ovirt-engine_standard.yaml 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified; Ready for merge Gil Shinar: Looks good to me Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/57612 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6017721b5c31a5bedb9523da11d2d5c966bae254 Gerrit-PatchSet: 1 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com> Gerrit-Reviewer: David Caro <dcaro(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in otopi[master]: build: post otopi-1.5.0_beta1
by didi＠redhat.com 18 May '16

18 May '16

Yedidyah Bar David has submitted this change and it was merged. Change subject: build: post otopi-1.5.0_beta1 ...................................................................... build: post otopi-1.5.0_beta1 Change-Id: Idd9acd93c4b512258e483b2ae3e01869c23e7fc0 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M configure.ac 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Verified Jenkins CI: Passed CI tests Yedidyah Bar David: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/57602 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idd9acd93c4b512258e483b2ae3e01869c23e7fc0 Gerrit-PatchSet: 1 Gerrit-Project: otopi Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0