June 2016 - Engine-commits - oVirt List Archives

Change in ovirt-hosted-engine-setup[master]: packaging: setup: Default to empty gateway if no default
by sbonazzo＠redhat.com 23 Jun '16

23 Jun '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: Default to empty gateway if no default ...................................................................... packaging: setup: Default to empty gateway if no default If host has no default gateway, show '[]' instead of '[@DEFAULT@]' Change-Id: I220addd09e0851581b10d516e04fcccbc17d1032 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M src/plugins/gr-he-setup/network/gateway.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Sandro Bonazzola: Looks good to me, approved Jenkins CI: Passed CI tests Yedidyah Bar David: Verified -- To view, visit https://gerrit.ovirt.org/53306 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I220addd09e0851581b10d516e04fcccbc17d1032 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: Adding all the missing build-artifact version jobs
by dcaro＠redhat.com 23 Jun '16

23 Jun '16

David Caro has submitted this change and it was merged. Change subject: Adding all the missing build-artifact version jobs ...................................................................... Adding all the missing build-artifact version jobs They were hidden by collecting the same job from different publishers Change-Id: Idafa4be7a03509d2fcef7031ed07589f2da61c6d Signed-off-by: David Caro <dcaroest(a)redhat.com> --- M jobs/confs/projects/ovirt-engine-sdk-java/ovirt-engine-sdk-java_build-artifacts.yaml M jobs/confs/projects/ovirt-engine-sdk-ruby/ovirt-engine-sdk-ruby_build-artifacts.yaml M jobs/confs/projects/ovirt-engine-sdk/ovirt-engine-sdk_build-artifacts.yaml M jobs/confs/projects/ovirt-host-deploy/ovirt-host-deploy_standard.yaml M jobs/confs/projects/ovirt-image-uploader/ovirt-image-uploader_standard.yaml M jobs/confs/projects/ovirt-imageio/ovirt-imageio.yaml M jobs/confs/projects/ovirt-iso-uploader/ovirt-iso-uploader_standard.yaml M jobs/confs/projects/ovirt-jboss-modules-maven-plugin/ovirt-jboss-modules-maven-plugin_build-artifacts.yaml M jobs/confs/projects/ovirt-log-collector/ovirt-log-collector_standard.yaml M jobs/confs/projects/ovirt-optimizer/ovirt-optimizer_standard.yaml M jobs/confs/projects/ovirt-scheduler-proxy/ovirt-scheduler-proxy_standard.yaml M jobs/confs/projects/ovirt-setup-lib/ovirt-setup-lib_build-artifacts.yaml M jobs/confs/projects/repoman/repoman_build-artifacts.yaml M jobs/confs/projects/vdsm-jsonrpc-java/vdsm-jsonrpc-java_standard.yaml 14 files changed, 96 insertions(+), 60 deletions(-) Approvals: Piotr Kliczewski: Looks good to me Juan Hernandez: Looks good to me Jenkins CI: Passed CI tests David Caro: Verified; Ready for merge -- To view, visit https://gerrit.ovirt.org/59675 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idafa4be7a03509d2fcef7031ed07589f2da61c6d Gerrit-PatchSet: 4 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: David Caro <dcaro(a)redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: David Caro <dcaro(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: Adding deploy to experimental to create_rpms jobs
by dcaro＠redhat.com 23 Jun '16

23 Jun '16

David Caro has submitted this change and it was merged. Change subject: Adding deploy to experimental to create_rpms jobs ...................................................................... Adding deploy to experimental to create_rpms jobs Change-Id: Ia869b7c9728e8d2a88ef32ed1b1611362cafb314 Signed-off-by: David Caro <dcaroest(a)redhat.com> --- M jobs/confs/projects/ebay-cors-filter/ebay-cors-filter.yaml M jobs/confs/projects/ioprocess/ioprocess.yaml M jobs/confs/projects/jasper-reports/jasper-reports_create-rpms.yaml M jobs/confs/projects/mom/mom_create-rpms.yaml M jobs/confs/projects/nsis-simple-service-plugin/nsis-simple-service-plugin.yaml M jobs/confs/projects/otopi/otopi_create-rpms.yaml M jobs/confs/projects/ovirt-dwh/ovirt-dwh_create-rpms.yaml M jobs/confs/projects/ovirt-engine-extension-aaa-jdbc/ovirt-engine-extension-aaa-jdbc_create-rpms.yaml M jobs/confs/projects/ovirt-engine-extension-aaa-ldap/ovirt-engine-extension-aaa-ldap_create-rpms.yaml M jobs/confs/projects/ovirt-engine-extension-logger-log4j/ovirt-engine-extension-logger-log4j_create-rpms.yaml M jobs/confs/projects/ovirt-engine-nodejs-modules/ovirt-engine-nodejs-modules.yaml M jobs/confs/projects/ovirt-engine-nodejs/ovirt-engine-nodejs.yaml M jobs/confs/projects/ovirt-engine-sdk-java/ovirt-engine-sdk-java_create-rpms.yaml M jobs/confs/projects/ovirt-engine-wildfly-overlay/ovirt-engine-wildfly-overlay.yaml M jobs/confs/projects/ovirt-engine-wildfly/ovirt-engine-wildfly.yaml M jobs/confs/projects/ovirt-host-deploy/ovirt-host-deploy_create-rpms.yaml M jobs/confs/projects/ovirt-hosted-engine-ha/ovirt-hosted-engine-ha_create-rpms.yaml M jobs/confs/projects/ovirt-iso-uploader/ovirt-iso-uploader_create-rpms.yaml M jobs/confs/projects/ovirt-log-collector/ovirt-log-collector_create-rpms.yaml M jobs/confs/projects/ovirt-reports/ovirt-reports_create-rpms.yaml M jobs/confs/projects/ovirt-vmconsole/ovirt-vmconsole_create-rpms.yaml M jobs/confs/projects/ovirt-wgt/ovirt-wgt_create-rpms.yaml M jobs/confs/projects/py2exe-py2.7/py2exe-py2.7.yaml M jobs/confs/projects/python-windows/python-windows.yaml M jobs/confs/projects/pywin32-py2.7/pywin32-py2.7.yaml M jobs/confs/projects/qemu/qemu_create-rpms.yaml M jobs/confs/projects/slf4j/slf4j.yaml M jobs/confs/projects/vcredist-x86/vcredist-x86.yaml M jobs/confs/yaml/templates/create-rpms_mock.yaml 29 files changed, 221 insertions(+), 22 deletions(-) Approvals: Eyal Edri: Looks good to me Jenkins CI: Passed CI tests David Caro: Verified; Ready for merge -- To view, visit https://gerrit.ovirt.org/59670 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia869b7c9728e8d2a88ef32ed1b1611362cafb314 Gerrit-PatchSet: 5 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: David Caro <dcaro(a)redhat.com> Gerrit-Reviewer: David Caro <dcaro(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-live[ovirt-live-4.0]: build: oVirt Live 4.0.0
by lveyde＠redhat.com 23 Jun '16

23 Jun '16

Lev Veyde has submitted this change and it was merged. Change subject: build: oVirt Live 4.0.0 ...................................................................... build: oVirt Live 4.0.0 Change-Id: Iae8751250f579d4ff13e529d11e25ddfac2a84bb Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M centos-7/Makefile M centos-7/kickstart/ovirt-live-ovirt-custom.ks.in 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Lev Veyde: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/59688 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iae8751250f579d4ff13e529d11e25ddfac2a84bb Gerrit-PatchSet: 1 Gerrit-Project: ovirt-live Gerrit-Branch: ovirt-live-4.0 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: acquire vm lock on RestoreStatelessVm
by ahadas＠redhat.com 23 Jun '16

23 Jun '16

Arik Hadas has submitted this change and it was merged. Change subject: core: acquire vm lock on RestoreStatelessVm ...................................................................... core: acquire vm lock on RestoreStatelessVm RestoreStatelessVm calls two commands: 1. UpdateVmVersion 2. RestoreAllSnapshots Both used to take exclusive lock on the VM. Change I870ef6 modified UpdateVmVersion so it will not acquire the VM lock when it is called by RestoreStatelessVm but that's because we assume RestoreStatelessVm locked the VM which is not always the case. So this patch changes RestoreStatelessVm to lock the VM. It is safe to do since UpdateVmVersion and RestoreAllSnapshots used to do it later in the control flow as well. This lock is passed to RestoreAllSnapshot so it doesn't try to lock the VM as well. Change-Id: I3e52fafa8fcb1976c309e5ea79227e9dc1a3c01c Bug-Url: https://bugzilla.redhat.com/1346270 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RestoreStatelessVmCommand.java 1 file changed, 18 insertions(+), 0 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Shmuel Leib Melamud: Looks good to me, but someone else must approve Arik Hadas: Verified Liron Aravot: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/59468 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3e52fafa8fcb1976c309e5ea79227e9dc1a3c01c Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: publisher: 4.0: switch dwh to branched version
by eedri＠redhat.com 23 Jun '16

23 Jun '16

Eyal Edri has submitted this change and it was merged. Change subject: publisher: 4.0: switch dwh to branched version ...................................................................... publisher: 4.0: switch dwh to branched version Change-Id: I7361f121a33490fc8363b918372bc4ca2ef5b9f4 Signed-off-by: Shirly Radco <sradco(a)redhat.com> --- M jobs/confs/projects/ovirt/publish-rpms-nightly-4.0.yaml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Shirly Radco: Verified Eyal Edri: Looks good to me; Ready for merge Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/59678 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7361f121a33490fc8363b918372bc4ca2ef5b9f4 Gerrit-PatchSet: 1 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: add KVM provider to v2v infrastructure
by shavivi＠redhat.com 23 Jun '16

23 Jun '16

Shahar Havivi has submitted this change and it was merged. Change subject: add KVM provider to v2v infrastructure ...................................................................... add KVM provider to v2v infrastructure Bug-Url: https://bugzilla.redhat.com/1348107 Change-Id: I91807524daee7c3347344ca1519b2e97a88c9d63 Signed-off-by: Shahar Havivi <shaharh(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/ProviderProxyFactory.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/vms/KVMVmProviderProxy.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/KVMVmProviderProperties.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/ProviderType.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/provider/ProviderDaoImpl.java M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/EditProviderModel.java A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/KVMPropertiesModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/ProviderModel.java A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/ProxyHostPropertiesModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/VmwarePropertiesModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ImportVmsModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/ImportVmsPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/ImportVmsPopupView.ui.xml M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/provider/ProviderPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/provider/ProviderPopupView.ui.xml A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/provider/KVMPropertiesWidget.java A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/provider/KVMPropertiesWidget.ui.xml 18 files changed, 525 insertions(+), 41 deletions(-) Approvals: Tomas Jelinek: Looks good to me, but someone else must approve Shahar Havivi: Verified Jenkins CI: Passed CI tests Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/57621 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I91807524daee7c3347344ca1519b2e97a88c9d63 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in otopi[otopi-1.5]: machine_dialog: fix the comparison for default
by didi＠redhat.com 23 Jun '16

23 Jun '16

Yedidyah Bar David has submitted this change and it was merged. Change subject: machine_dialog: fix the comparison for default ...................................................................... machine_dialog: fix the comparison for default Currently, it evaluates to False even if no values is set. Set "default" to None so the comparison works properly. Change-Id: Ia235e2e886b72cff056b6221923f0eb50178fedd Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1346860 Signed-off-by: Ryan Barry <rbarry(a)redhat.com> (cherry picked from commit 087460ef0fd29ccf88bcbd8357770f01eb1ef3c0) --- M src/plugins/otopi/dialog/machine.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins CI: Passed CI tests Yedidyah Bar David: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/59559 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia235e2e886b72cff056b6221923f0eb50178fedd Gerrit-PatchSet: 1 Gerrit-Project: otopi Gerrit-Branch: otopi-1.5 Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: Add 4.0 branches for ovirt-engine-dwh
by sbonazzo＠redhat.com 23 Jun '16

23 Jun '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: Add 4.0 branches for ovirt-engine-dwh ...................................................................... Add 4.0 branches for ovirt-engine-dwh Change-Id: Ic75a404ee1de6950a0e7d5eb21c1055873ebe964 Signed-off-by: Shirly Radco <sradco(a)redhat.com> --- M jobs/confs/projects/ovirt-dwh/ovirt-dwh_standard.yaml 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Looks good to me; Ready for merge Shirly Radco: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/59667 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic75a404ee1de6950a0e7d5eb21c1055873ebe964 Gerrit-PatchSet: 1 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: prevent removal of all images of prestarted stateless vm
by ahadas＠redhat.com 23 Jun '16

23 Jun '16

Arik Hadas has submitted this change and it was merged. Change subject: core: prevent removal of all images of prestarted stateless vm ...................................................................... core: prevent removal of all images of prestarted stateless vm When prestarted VM shuts down two threads might try to remove its stateless snapshot: 1. Pool's monitoring that automatically starts prestarted VMs 2. VMs monitoring If the pool's monitoring is triggered before VMs monitoring we might get into a race that leads to removal of all images of a prestarted stateless VM: Thread 1 - PoolMonitoring calls RunVm that calls ProceedDownVm which calls RestoreStatelessVm that in turn calls RestoreAllSnapshots Thread 2 - VmsMonitoring calls ProceedDownVm that in turn calls RestoreStatelessVm that also calls RestoreAllSnapshots In thread 1 an exclusive lock is taken for the VM by RunVm and this lock is passed all the way through to RestoreStatelessVm. This in turn calls UpdateVmVersion that most of the time fails to run with its lock and therefore the lock is released. But the instance of the lock is still passed to RestoreAllSnapshots which basically means that this command is executed with no lock on the VM. Then, the second call to RestoreAllSnapshots by thread 2 might also try to remove the latest images of the disks, after the ones from the stateless snapshots had been removed -> so the images attached to the active snapshot is removed as well. The solution is not to pass the lock to UpdateVmVersion. This change is safe since the lock was anyway released at the end of the execute phase of UpdateVmVersion. Change-Id: I870ef6757418205599e97688a276c75097642456 Bug-Url: https://bugzilla.redhat.com/1346270 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RestoreStatelessVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmVersionCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/UpdateVmVersionParameters.java 3 files changed, 19 insertions(+), 4 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/59450 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I870ef6757418205599e97688a276c75097642456 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0