June 2016 - Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-4.0]: core: acquire vm lock on RestoreStatelessVm
by piotr.kliczewski＠gmail.com 24 Jun '16

24 Jun '16

Piotr Kliczewski has submitted this change and it was merged. Change subject: core: acquire vm lock on RestoreStatelessVm ...................................................................... core: acquire vm lock on RestoreStatelessVm RestoreStatelessVm calls two commands: 1. UpdateVmVersion 2. RestoreAllSnapshots Both used to take exclusive lock on the VM. Change I870ef6 modified UpdateVmVersion so it will not acquire the VM lock when it is called by RestoreStatelessVm but that's because we assume RestoreStatelessVm locked the VM which is not always the case. So this patch changes RestoreStatelessVm to lock the VM. It is safe to do since UpdateVmVersion and RestoreAllSnapshots used to do it later in the control flow as well. This lock is passed to RestoreAllSnapshot so it doesn't try to lock the VM as well. Change-Id: I3e52fafa8fcb1976c309e5ea79227e9dc1a3c01c Bug-Url: https://bugzilla.redhat.com/1346270 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RestoreStatelessVmCommand.java 1 file changed, 18 insertions(+), 0 deletions(-) Approvals: Piotr Kliczewski: Passed CI tests Shahar Havivi: Looks good to me, approved Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/59690 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3e52fafa8fcb1976c309e5ea79227e9dc1a3c01c Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: restapi: Host kernel cmdline
by juan.hernandez＠redhat.com 24 Jun '16

24 Jun '16

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Host kernel cmdline ...................................................................... restapi: Host kernel cmdline Host kernel cmdline API allows to inspect kernel command line currently reported by running host and customize kernel parameters that will be set during next host deploy procedure. API: host/os/reported_kernel_cmdline (ro) host/os/custom_kernel_cmdline (rw) Attampts to change host/os/cmdline/reported are silently ignored to keep compatibility with engine SDKs. Change-Id: I6c1f6b3b2fedb74b429ed0d25ba03209f2e10362 Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/1341268 --- M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/HostMapper.java 1 file changed, 28 insertions(+), 13 deletions(-) Approvals: Jakub Niedermertl: Verified Juan Hernandez: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/58391 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6c1f6b3b2fedb74b429ed0d25ba03209f2e10362 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-java[sdk_4.0]: Add an example that lists the disks of a VM
by omachace＠redhat.com 24 Jun '16

24 Jun '16

Ondra Machacek has submitted this change and it was merged. Change subject: Add an example that lists the disks of a VM ...................................................................... Add an example that lists the disks of a VM This patch adds an example that shows how to list the disks attached to a virtual machine. Change-Id: Ia3d12d02c231c6cadf442e4f2713b9af16063d44 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit dd8db92c5f3922c2aa065d1dcb66a5f8b6a29e0f) --- A sdk/src/test/java/org/ovirt/engine/sdk4/examples/ListVmDisks.java 1 file changed, 62 insertions(+), 0 deletions(-) Approvals: Ondra Machacek: Looks good to me, approved Juan Hernandez: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/59757 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia3d12d02c231c6cadf442e4f2713b9af16063d44 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-java Gerrit-Branch: sdk_4.0 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk[sdk_4.0]: Add an example that lists the disks of a VM
by omachace＠redhat.com 24 Jun '16

24 Jun '16

Ondra Machacek has submitted this change and it was merged. Change subject: Add an example that lists the disks of a VM ...................................................................... Add an example that lists the disks of a VM This patch adds an example that shows how to list the disks attached to a virtual machine. Change-Id: I5d9926612b29bd8ba704e4fd2ca9877c29b069c6 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit 801ffb1640a08014caaaccea5a1cfc5a14b98ed7) --- A sdk/examples/list_vm_disks.py 1 file changed, 53 insertions(+), 0 deletions(-) Approvals: Ondra Machacek: Looks good to me, approved Juan Hernandez: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/59758 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5d9926612b29bd8ba704e4fd2ca9877c29b069c6 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: sdk_4.0 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-ruby[sdk_4.0]: Add an example that lists the disks of a VM
by juan.hernandez＠redhat.com 24 Jun '16

24 Jun '16

Juan Hernandez has submitted this change and it was merged. Change subject: Add an example that lists the disks of a VM ...................................................................... Add an example that lists the disks of a VM This patch adds an example that shows how to list the disks attached to a virtual machine. Change-Id: I5a929073e6b8b524fa283eb6d7188280f762e2f9 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit 4b18dfe1eec30f60049ab151fe60a862146e4b82) --- A sdk/examples/list_vm_disks.rb 1 file changed, 53 insertions(+), 0 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/59759 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5a929073e6b8b524fa283eb6d7188280f762e2f9 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: sdk_4.0 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-ruby[master]: Add an example that lists the disks of a VM
by juan.hernandez＠redhat.com 24 Jun '16

24 Jun '16

Juan Hernandez has submitted this change and it was merged. Change subject: Add an example that lists the disks of a VM ...................................................................... Add an example that lists the disks of a VM This patch adds an example that shows how to list the disks attached to a virtual machine. Change-Id: I5a929073e6b8b524fa283eb6d7188280f762e2f9 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- A sdk/examples/list_vm_disks.rb 1 file changed, 53 insertions(+), 0 deletions(-) Approvals: Ondra Machacek: Looks good to me, but someone else must approve Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/59756 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5a929073e6b8b524fa283eb6d7188280f762e2f9 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk[master]: Add an example that lists the disks of a VM
by omachace＠redhat.com 24 Jun '16

24 Jun '16

Ondra Machacek has submitted this change and it was merged. Change subject: Add an example that lists the disks of a VM ...................................................................... Add an example that lists the disks of a VM This patch adds an example that shows how to list the disks attached to a virtual machine. Change-Id: I5d9926612b29bd8ba704e4fd2ca9877c29b069c6 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- A sdk/examples/list_vm_disks.py 1 file changed, 53 insertions(+), 0 deletions(-) Approvals: Ondra Machacek: Looks good to me, approved Juan Hernandez: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/59755 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5d9926612b29bd8ba704e4fd2ca9877c29b069c6 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-java[master]: Add an example that lists the disks of a VM
by omachace＠redhat.com 24 Jun '16

24 Jun '16

Ondra Machacek has submitted this change and it was merged. Change subject: Add an example that lists the disks of a VM ...................................................................... Add an example that lists the disks of a VM This patch adds an example that shows how to list the disks attached to a virtual machine. Change-Id: Ia3d12d02c231c6cadf442e4f2713b9af16063d44 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- A sdk/src/test/java/org/ovirt/engine/sdk4/examples/ListVmDisks.java 1 file changed, 62 insertions(+), 0 deletions(-) Approvals: Ondra Machacek: Looks good to me, approved Juan Hernandez: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/59754 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia3d12d02c231c6cadf442e4f2713b9af16063d44 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-java Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: restapi: Update to model 4.1.1
by juan.hernandez＠redhat.com 24 Jun '16

24 Jun '16

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Update to model 4.1.1 ...................................................................... restapi: Update to model 4.1.1 This updated version of the model includes the following changes: * Add `collapseSnapshots` parameter to the operation that imports a virtual machine from an export storage domain. * Add `passDiscard` attribute to the `DiskAttachment` type. * Add `reportedKernelCmdline` and `customKernelCmdLine` attributes to the `OperatingSystem` type. * Add the `host`, `destroy` and `format` parameters to the operation that removes a storage domain. Change-Id: Ie814c918e47e0d19b3d20813160105bef97b8984 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M pom.xml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jakub Niedermertl: Looks good to me, but someone else must approve Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/59750 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie814c918e47e0d19b3d20813160105bef97b8984 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: engine: Enable 'Select as SPM' only for Virt Cluster
by piotr.kliczewski＠gmail.com 24 Jun '16

24 Jun '16

Piotr Kliczewski has submitted this change and it was merged. Change subject: engine: Enable 'Select as SPM' only for Virt Cluster ...................................................................... engine: Enable 'Select as SPM' only for Virt Cluster 'Select as SPM' action on Host tab is enabled for gluster only hosts. It should be enabled only when the virt service is supported by the cluster. Change-Id: I4a40c7251275a2f48b7d538d967cca022e00f0a5 Bug-Url: https://bugzilla.redhat.com/1264281 Signed-off-by: Ramesh Nachimuthu <rnachimu(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/pool/ForceSelectSPMCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/pool/ForceSelectSPMCommandTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/frontend/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostListModel.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 9 files changed, 22 insertions(+), 1 deletion(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved Sahina Bose: Looks good to me, but someone else must approve Ramesh N: Verified -- To view, visit https://gerrit.ovirt.org/59616 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4a40c7251275a2f48b7d538d967cca022e00f0a5 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0