Change in ovirt-engine[master]: restapi: Remove redundant switch labels
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: restapi: Remove redundant switch labels
......................................................................
restapi: Remove redundant switch labels
This patch removes some switch labels that aren't really needed, as they
have the treatment than the "default" label.
Change-Id: Ifa375793753a4fdd9d28adaf0a3b60ce3cf26bbe
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainTemplateResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainVmResource.java
2 files changed, 0 insertions(+), 4 deletions(-)
Approvals:
Juan Hernandez: Verified; Passed CI tests
Allon Mureinik: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/59608
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifa375793753a4fdd9d28adaf0a3b60ce3cf26bbe
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in ovirt-engine[master]: restapi: Don't try to set IPs for VMs without id
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: restapi: Don't try to set IPs for VMs without id
......................................................................
restapi: Don't try to set IPs for VMs without id
Currently the V3 adapter for VM objects tries to populate the IP
addresses reported by the guest agent, but this doesn't work for VM
objects that haven't been created yet, like the ones returned by the
operation to import a VM from an export storage domain.
In addition retrieving the details of a VM before importing it doesn't
work either, because the implementation uses inheritance and generics
and the JAX-RS implementation that we use in version 4 of the engine
doesn't understand it.
This patch fixes these two isses needed to make the import operation
succeed in both versions of the API.
Change-Id: I2e2ea61f34467bcbc0578fde7ba8a0fa9d12a648
Bug-Url: https://bugzilla.redhat.com/1348805
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/AbstractBackendStorageDomainContentResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainTemplateResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainVmResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/adapters/V3VmOutAdapter.java
4 files changed, 59 insertions(+), 66 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests
Allon Mureinik: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/59602
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2e2ea61f34467bcbc0578fde7ba8a0fa9d12a648
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in ovirt-engine[master]: webadmin: show templates version in remove dialog
by tjelinek＠redhat.com
Tomas Jelinek has submitted this change and it was merged.
Change subject: webadmin: show templates version in remove dialog
......................................................................
webadmin: show templates version in remove dialog
Displaying the template's version name + version number (if exist)
in addition to template name in the "Remove Backed up Templates" dialog
and in the "Remove Template(s)" dialog.
Choose an export domain and display the "Template Import" subtab and
then choose templates and open the "Remove Backed up Templates" dialog
to display the list of templates to be removed. Till now only templates
names were displayed. The same is relevant for removing templates from
Templates main tab.
Now the version name+version number are also displayed for each template
(if exist) in the following format:
Are you sure you want to remove the following items?
template-name (Version: <version-name>(version-num))
....
Change-Id: I64f29ddda865ad03d2618853bfea2cd78ad7681b
Bug-Url: https://bugzilla.redhat.com/1341153
Signed-off-by: Sharon Gratch <sgratch(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/TemplateBackupModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/TemplateListModel.java
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIMessages.java
M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/UIMessages.properties
4 files changed, 31 insertions(+), 2 deletions(-)
Approvals:
Tomas Jelinek: Looks good to me, approved
Jenkins CI: Passed CI tests
Sharon Gratch: Verified
--
To view, visit https://gerrit.ovirt.org/59085
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I64f29ddda865ad03d2618853bfea2cd78ad7681b
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sharon Gratch <sgratch(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sharon Gratch <sgratch(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in ovirt-guest-agent[ovirt-4.0]: packaging: Fix for rhel6 spec file
by vfeenstr＠redhat.com
Vinzenz Feenstra has submitted this change and it was merged.
Change subject: packaging: Fix for rhel6 spec file
......................................................................
packaging: Fix for rhel6 spec file
The jenkins nightly builds were broken due to this mistake.
Change-Id: Ifc44bfca0a08d45fab6dca17eba041d82de00b52
Signed-off-by: Vinzenz Feenstra <vfeenstr(a)redhat.com>
(cherry picked from commit 4c8adf37b9c234598bb6b8ae199ab74bb4128eb3)
---
M ovirt-guest-agent.rhel6.spec
1 file changed, 6 insertions(+), 4 deletions(-)
Approvals:
Vinzenz Feenstra: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/59627
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifc44bfca0a08d45fab6dca17eba041d82de00b52
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-guest-agent
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in ovirt-guest-agent[master]: packaging: Fix for rhel6 spec file
by vfeenstr＠redhat.com
Vinzenz Feenstra has submitted this change and it was merged.
Change subject: packaging: Fix for rhel6 spec file
......................................................................
packaging: Fix for rhel6 spec file
The jenkins nightly builds were broken due to this mistake.
Change-Id: Ifc44bfca0a08d45fab6dca17eba041d82de00b52
Signed-off-by: Vinzenz Feenstra <vfeenstr(a)redhat.com>
---
M ovirt-guest-agent.rhel6.spec
1 file changed, 6 insertions(+), 4 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Vinzenz Feenstra: Verified; Looks good to me, approved
Yedidyah Bar David: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/59610
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifc44bfca0a08d45fab6dca17eba041d82de00b52
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-guest-agent
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in ovirt-engine[master]: restapi: Don't add name to network filter links
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: restapi: Don't add name to network filter links
......................................................................
restapi: Don't add name to network filter links
Currently the links to network filters included in the representation of
VNIC profiles include also the name of the network filters. This is
contrary to the common practice in the API, where links only have the
"id" and "href" attributes. Other attributes or elements are allowed
only when required for backwards compatbility. This patch removes the
code that adds the network filter name.
Change-Id: I3379bbf794cbec22a059544bf9684fd160ade2d0
Bug-Url: https://bugzilla.redhat.com/1347931
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/AbstractBackendVnicProfilesResource.java
1 file changed, 0 insertions(+), 25 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
Yevgeny Zaspitsky: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/59418
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3379bbf794cbec22a059544bf9684fd160ade2d0
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in ovirt-engine[master]: engine: Enable 'Select as SPM' only for Virt Cluster
by sabose＠redhat.com
Sahina Bose has submitted this change and it was merged.
Change subject: engine: Enable 'Select as SPM' only for Virt Cluster
......................................................................
engine: Enable 'Select as SPM' only for Virt Cluster
'Select as SPM' action on Host tab is enabled for
gluster only hosts. It should be enabled only when
the virt service is supported by the cluster.
Change-Id: I4a40c7251275a2f48b7d538d967cca022e00f0a5
Bug-Url: https://bugzilla.redhat.com/1264281
Signed-off-by: Ramesh Nachimuthu <rnachimu(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/pool/ForceSelectSPMCommand.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/pool/ForceSelectSPMCommandTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/frontend/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostListModel.java
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
9 files changed, 22 insertions(+), 1 deletion(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Allon Mureinik: Looks good to me, but someone else must approve
Sahina Bose: Looks good to me, but someone else must approve
Ramesh N: Verified
--
To view, visit https://gerrit.ovirt.org/59474
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4a40c7251275a2f48b7d538d967cca022e00f0a5
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ramesh N <rnachimu(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in ovirt-engine[master]: Adding JsonProperty to fix parsing of foreman entities
by oourfali＠redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: Adding JsonProperty to fix parsing of foreman entities
......................................................................
Adding JsonProperty to fix parsing of foreman entities
For every two or more words field we need explicitly to describe its json name.
In engine the style convention is to use capital latter between words. The
json schema separates words with underscore.
This code used to work before with older jackson package, currently its
mandatory to work properly.
Change-Id: Ie6ca2db5ab081fa2db0df868e962b205202915dd
Bug-Url: https://bugzilla.redhat.com/1348916
Signed-off-by: Yaniv Bronhaim <ybronhei(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/provider/foreman/ForemanDiscoveredHost.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/provider/foreman/ForemanError.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/provider/foreman/ForemanHostGroup.java
3 files changed, 22 insertions(+), 3 deletions(-)
Approvals:
Yaniv Bronhaim: Verified
Jenkins CI: Passed CI tests
Oved Ourfali: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/59413
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie6ca2db5ab081fa2db0df868e962b205202915dd
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in jenkins[master]: lago:Replaced fc22 by fc24
by eedri＠redhat.com
Eyal Edri has submitted this change and it was merged.
Change subject: lago:Replaced fc22 by fc24
......................................................................
lago:Replaced fc22 by fc24
Change-Id: Ic9a189b06d5a7d83ffef86904a98ae5c50fdb011
Signed-off-by: David Caro <dcaroest(a)redhat.com>
---
M jobs/confs/projects/lago/lago_standard.yaml
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Eyal Edri: Looks good to me; Ready for merge
Jenkins CI: Passed CI tests
David Caro: Verified; Ready for review
--
To view, visit https://gerrit.ovirt.org/58806
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic9a189b06d5a7d83ffef86904a98ae5c50fdb011
Gerrit-PatchSet: 2
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: David Caro <dcaro(a)redhat.com>
Gerrit-Reviewer: Anatoly Litovsky <tlitovsk(a)redhat.com>
Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com>
Gerrit-Reviewer: David Caro <dcaro(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months
Change in jenkins[master]: Enable push deploy to experimental for all projects
by eedri＠redhat.com
Eyal Edri has submitted this change and it was merged.
Change subject: Enable push deploy to experimental for all projects
......................................................................
Enable push deploy to experimental for all projects
Some projects have the deploy disabled, as they don't really build any
artifacts to deploy
Change-Id: Ie4d1490bf11844ac230ad8aaf90034108fe9c5f0
Signed-off-by: David Caro <dcaroest(a)redhat.com>
---
M jobs/confs/projects/fabic-ovirt/fabric-ovirt_standard.yaml
M jobs/confs/projects/ovirt-engine-api-explorer/ovirt-engine-api-explorer_build-artifacts.yaml
M jobs/confs/projects/ovirt-engine-api-metamodel/ovirt-engine-api-metamodel_build.yaml
M jobs/confs/projects/ovirt-engine-api-model/ovirt-engine-api-model_build.yaml
M jobs/confs/projects/ovirt-release/ovirt-release_standard.yaml
A jobs/confs/projects/ovirt/deploy_to_experimental.yaml
M jobs/confs/projects/repoman/repoman_build-artifacts.yaml
M jobs/confs/yaml/templates/standard-stage.yaml
8 files changed, 104 insertions(+), 30 deletions(-)
Approvals:
Eyal Edri: Verified; Looks good to me; Passed CI tests; Ready for merge
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/59149
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie4d1490bf11844ac230ad8aaf90034108fe9c5f0
Gerrit-PatchSet: 7
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: David Caro <dcaro(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 3 months