June 2016 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Add gluster type to fetch server connections.
by mlipchuk＠redhat.com 26 Jun '16

26 Jun '16

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Add gluster type to fetch server connections. ...................................................................... core: Add gluster type to fetch server connections. Add gluster storage type to fetch storage server connections. Change-Id: Iab911023ff96a10e2af9e1c0131061fb74593bad Bug-Url: https://bugzilla.redhat.com/1325863 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M packaging/dbscripts/storages_sp.sql 1 file changed, 3 insertions(+), 2 deletions(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/59768 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iab911023ff96a10e2af9e1c0131061fb74593bad Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: drop el6,fc22 from sdk 4.0
by eedri＠redhat.com 26 Jun '16

26 Jun '16

Eyal Edri has submitted this change and it was merged. Change subject: drop el6,fc22 from sdk 4.0 ...................................................................... drop el6,fc22 from sdk 4.0 Change-Id: I8c52a177de87c9fc73a924aba3a79ffca4e16eb5 Signed-off-by: ngoldin <ngoldin(a)redhat.com> --- M jobs/confs/projects/ovirt-engine-sdk/ovirt-engine-sdk_build-artifacts.yaml 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Nadav Goldin: Verified; Ready for review Eyal Edri: Looks good to me; Ready for merge Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/59769 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8c52a177de87c9fc73a924aba3a79ffca4e16eb5 Gerrit-PatchSet: 3 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Nadav Goldin <ngoldin(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nadav Goldin <ngoldin(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: vdsbroker: simplifying StoragePoolDomainHelper.buildStorageP...
by laravot＠redhat.com 26 Jun '16

26 Jun '16

Liron Aravot has submitted this change and it was merged. Change subject: vdsbroker: simplifying StoragePoolDomainHelper.buildStoragePoolDomainsMap() ...................................................................... vdsbroker: simplifying StoragePoolDomainHelper.buildStoragePoolDomainsMap() This patch simplifies and shortens StoragePoolDomainHelper.buildStoragePoolDomainsMap() Change-Id: Id1cc38ec9491275163a156a3fe34fe3214b95afb Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/storage/StoragePoolDomainHelper.java 1 file changed, 8 insertions(+), 16 deletions(-) Approvals: Allon Mureinik: Looks good to me, approved Liron Aravot: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/59552 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id1cc38ec9491275163a156a3fe34fe3214b95afb Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: removing last occurences of rx/tx rate in the engine
by alkaplan＠redhat.com 26 Jun '16

26 Jun '16

Alona Kaplan has submitted this change and it was merged. Change subject: engine: removing last occurences of rx/tx rate in the engine ...................................................................... engine: removing last occurences of rx/tx rate in the engine rxRate and txRate will no longer be send by vdsm. Any references to them in the engine must be eliminated. Change-Id: I33fa8431f30b35a816bdb10712c89f8f5bf32834 Signed-off-by: mirecki <mmirecki(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsProperties.java 2 files changed, 0 insertions(+), 4 deletions(-) Approvals: Marcin Mirecki: Verified Martin Mucha: Looks good to me, but someone else must approve Alona Kaplan: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/59508 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I33fa8431f30b35a816bdb10712c89f8f5bf32834 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: restapi: Update to model 4.0.24
by tnisan＠redhat.com 26 Jun '16

26 Jun '16

Tal Nisan has submitted this change and it was merged. Change subject: restapi: Update to model 4.0.24 ...................................................................... restapi: Update to model 4.0.24 This updated version of the model includes the following changes: * Add `collapseSnapshots` parameter to the operation that imports a virtual machine from an export storage domain. * Add `reportedKernelCmdline` and `customKernelCmdLine` attributes to the `OperatingSystem` type. Change-Id: Ie814c918e47e0d19b3d20813160105bef97b8984 Related-To: https://bugzilla.redhat.com/1341268 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M pom.xml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jakub Niedermertl: Looks good to me, but someone else must approve Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/59753 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie814c918e47e0d19b3d20813160105bef97b8984 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: webadmin: Propagate 'Disable smartcard' to console.vv
by tnisan＠redhat.com 26 Jun '16

26 Jun '16

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Propagate 'Disable smartcard' to console.vv ...................................................................... webadmin: Propagate 'Disable smartcard' to console.vv The user can override 'Enable smartcard' from Edit VM dialog by 'Disable smartcard' in Console Options dialog. The checkbox 'Disable smartcard' was not taken into account when the console.vv is generated. This patch provides fix. Change-Id: If4d291f1fa4595e9f0bdbcddc16c0137a08f2248 Bug-Url: https://bugzilla.redhat.com/1349368 Signed-off-by: Marek Libra <mlibra(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/console/ConsoleDescriptorGenerator.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/SpiceConsoleModel.java 2 files changed, 2 insertions(+), 1 deletion(-) Approvals: Tomas Jelinek: Looks good to me, approved Jenkins CI: Passed CI tests Marek Libra: Verified -- To view, visit https://gerrit.ovirt.org/59733 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If4d291f1fa4595e9f0bdbcddc16c0137a08f2248 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Marek Libra <mlibra(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marek Libra <mlibra(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core: prevent removal of all images of prestarted stateless vm
by tnisan＠redhat.com 26 Jun '16

26 Jun '16

Tal Nisan has submitted this change and it was merged. Change subject: core: prevent removal of all images of prestarted stateless vm ...................................................................... core: prevent removal of all images of prestarted stateless vm When prestarted VM shuts down two threads might try to remove its stateless snapshot: 1. Pool's monitoring that automatically starts prestarted VMs 2. VMs monitoring If the pool's monitoring is triggered before VMs monitoring we might get into a race that leads to removal of all images of a prestarted stateless VM: Thread 1 - PoolMonitoring calls RunVm that calls ProceedDownVm which calls RestoreStatelessVm that in turn calls RestoreAllSnapshots Thread 2 - VmsMonitoring calls ProceedDownVm that in turn calls RestoreStatelessVm that also calls RestoreAllSnapshots In thread 1 an exclusive lock is taken for the VM by RunVm and this lock is passed all the way through to RestoreStatelessVm. This in turn calls UpdateVmVersion that most of the time fails to run with its lock and therefore the lock is released. But the instance of the lock is still passed to RestoreAllSnapshots which basically means that this command is executed with no lock on the VM. Then, the second call to RestoreAllSnapshots by thread 2 might also try to remove the latest images of the disks, after the ones from the stateless snapshots had been removed -> so the images attached to the active snapshot is removed as well. The solution is not to pass the lock to UpdateVmVersion. This change is safe since the lock was anyway released at the end of the execute phase of UpdateVmVersion. Change-Id: I870ef6757418205599e97688a276c75097642456 Bug-Url: https://bugzilla.redhat.com/1348950 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RestoreStatelessVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmVersionCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/UpdateVmVersionParameters.java 3 files changed, 19 insertions(+), 4 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/59697 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I870ef6757418205599e97688a276c75097642456 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core: acquire vm lock on RestoreStatelessVm
by tnisan＠redhat.com 26 Jun '16

26 Jun '16

Tal Nisan has submitted this change and it was merged. Change subject: core: acquire vm lock on RestoreStatelessVm ...................................................................... core: acquire vm lock on RestoreStatelessVm RestoreStatelessVm calls two commands: 1. UpdateVmVersion 2. RestoreAllSnapshots Both used to take exclusive lock on the VM. Change I870ef6 modified UpdateVmVersion so it will not acquire the VM lock when it is called by RestoreStatelessVm but that's because we assume RestoreStatelessVm locked the VM which is not always the case. So this patch changes RestoreStatelessVm to lock the VM. It is safe to do since UpdateVmVersion and RestoreAllSnapshots used to do it later in the control flow as well. This lock is passed to RestoreAllSnapshot so it doesn't try to lock the VM as well. Change-Id: I3e52fafa8fcb1976c309e5ea79227e9dc1a3c01c Bug-Url: https://bugzilla.redhat.com/1348950 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RestoreStatelessVmCommand.java 1 file changed, 18 insertions(+), 0 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/59698 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3e52fafa8fcb1976c309e5ea79227e9dc1a3c01c Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: webadmin: Add Users and Groups dialog: cannot close via 'X' ...
by tnisan＠redhat.com 26 Jun '16

26 Jun '16

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Add Users and Groups dialog: cannot close via 'X' button or Esc key ...................................................................... webadmin: Add Users and Groups dialog: cannot close via 'X' button or Esc key Add Users and Groups dialog should be closable by clicking on the window's X button or hitting ESC key. Change-Id: Ia8ca8db3e2541edb472d1099f93c52a4ce18e276 Bug-Url: https://bugzilla.redhat.com/1349092 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/users/UserListModel.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Ravi Nori: Verified Alexander Wels: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/59762 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia8ca8db3e2541edb472d1099f93c52a4ce18e276 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: Add Users and Groups dialog: cannot close via 'X' ...
by awels＠redhat.com 24 Jun '16

24 Jun '16

Alexander Wels has submitted this change and it was merged. Change subject: webadmin: Add Users and Groups dialog: cannot close via 'X' button or Esc key ...................................................................... webadmin: Add Users and Groups dialog: cannot close via 'X' button or Esc key Add Users and Groups dialog should be closable by clicking on the window's X button or hitting ESC key. Change-Id: Ia8ca8db3e2541edb472d1099f93c52a4ce18e276 Bug-Url: https://bugzilla.redhat.com/1349092 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/users/UserListModel.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Martin Peřina: Looks good to me, but someone else must approve Ravi Nori: Verified Alexander Wels: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/59760 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia8ca8db3e2541edb472d1099f93c52a4ce18e276 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0