Change in ovirt-engine[master]: core: ProcessOvfUpdateForStoragePoolCommandTest poolId
by amureini@redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: ProcessOvfUpdateForStoragePoolCommandTest poolId
......................................................................
core: ProcessOvfUpdateForStoragePoolCommandTest poolId
Removed redundant poolId parameter throughout the code.
Change-Id: I9b9bf929bceedfd7b76be85118ffcdc124a4e435
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/ovfstore/ProcessOvfUpdateForStoragePoolCommandTest.java
1 file changed, 27 insertions(+), 29 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Allon Mureinik: Verified; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/59140
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9b9bf929bceedfd7b76be85118ffcdc124a4e435
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 6 months
Change in ovirt-engine[master]: core: ProcessOvfUpdateForStoragePoolCommandTest's labmdas
by amureini@redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: ProcessOvfUpdateForStoragePoolCommandTest's labmdas
......................................................................
core: ProcessOvfUpdateForStoragePoolCommandTest's labmdas
Use Java 8 styles functional interfaces to reduce code bloat and
improve performance.
Change-Id: I23f845ede805c1257b0f2c97ec04a9506322929c
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/ovfstore/ProcessOvfUpdateForStoragePoolCommandTest.java
1 file changed, 56 insertions(+), 93 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Allon Mureinik: Verified; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/59139
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I23f845ede805c1257b0f2c97ec04a9506322929c
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 6 months
Change in ovirt-guest-agent[ovirt-4.0]: Win: Apply USEPLATFORMCLOCK on Windows 6.x+ on startup
by vfeenstr@redhat.com
Vinzenz Feenstra has submitted this change and it was merged.
Change subject: Win: Apply USEPLATFORMCLOCK on Windows 6.x+ on startup
......................................................................
Win: Apply USEPLATFORMCLOCK on Windows 6.x+ on startup
This patch will apply the boot setting for the current OS configuration
to use the platform clock. This will improve the time keeping for the
windows guest operating systems version 6.x+
Change-Id: Id76464df66f577a1d78db716beb04ee8311b9bb5
Bug-Url: https://bugzilla.redhat.com/1328920
Signed-off-by: Vinzenz Feenstra <vfeenstr(a)redhat.com>
(cherry picked from commit c5f1e25ea31d7df09e344e19e426f2e8247bf9b8)
---
M ovirt-guest-agent/GuestAgentWin32.py
1 file changed, 13 insertions(+), 0 deletions(-)
Approvals:
Vinzenz Feenstra: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/59206
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id76464df66f577a1d78db716beb04ee8311b9bb5
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-guest-agent
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 6 months
Change in ovirt-engine[master]: core: ReconstructMasterDomainCommand type inference
by amureini@redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: ReconstructMasterDomainCommand type inference
......................................................................
core: ReconstructMasterDomainCommand type inference
Change-Id: I167840f7a3ed7ce3f42f10f0f609b1e1a1e7f3c3
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/pool/ReconstructMasterDomainCommand.java
1 file changed, 1 insertion(+), 2 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Allon Mureinik: Verified
--
To view, visit https://gerrit.ovirt.org/59200
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I167840f7a3ed7ce3f42f10f0f609b1e1a1e7f3c3
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 6 months
Change in ovirt-engine[master]: core: ReconstructMasterDomainCommand DbFacade
by amureini@redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: ReconstructMasterDomainCommand DbFacade
......................................................................
core: ReconstructMasterDomainCommand DbFacade
Use inherited DAOs instead of directly calling DbFacade.getInstance() in
order to make the class easier to both read and test.
Change-Id: Ib743a8293b3f787219dc8c1411780cadd4ae26c2
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/pool/ReconstructMasterDomainCommand.java
1 file changed, 1 insertion(+), 4 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Allon Mureinik: Verified
--
To view, visit https://gerrit.ovirt.org/59202
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib743a8293b3f787219dc8c1411780cadd4ae26c2
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 6 months
Change in ovirt-engine[master]: core: ReconstructMasterDomainCommand local initializer
by amureini@redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: ReconstructMasterDomainCommand local initializer
......................................................................
core: ReconstructMasterDomainCommand local initializer
Removed redundant initialization of a local variable. This null value is
overwritten in the following statement, whether the flow goes to the
"if" branch or the "else" branch.
Change-Id: If539522d9e099a54fdb48c312183d660066f7bfe
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/pool/ReconstructMasterDomainCommand.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Allon Mureinik: Verified
--
To view, visit https://gerrit.ovirt.org/59201
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If539522d9e099a54fdb48c312183d660066f7bfe
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 6 months
Change in ovirt-engine[master]: dal: fix DiskVmElementDaoImpl.java style
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: dal: fix DiskVmElementDaoImpl.java style
......................................................................
dal: fix DiskVmElementDaoImpl.java style
This patch changes DiskVmElementDaoImpl to meet the project's style.
Change-Id: I919976b6c3dbef52a3a22c535e0622f9964d37be
Signed-off-by: Idan Shaby <ishaby(a)redhat.com>
---
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DiskVmElementDaoImpl.java
1 file changed, 14 insertions(+), 7 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Freddy Rolland: Looks good to me, but someone else must approve
Idan Shaby: Verified
--
To view, visit https://gerrit.ovirt.org/59130
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I919976b6c3dbef52a3a22c535e0622f9964d37be
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 6 months
Change in ovirt-engine[master]: core: rename migration policies and change descriptions
by tjelinek@redhat.com
Tomas Jelinek has submitted this change and it was merged.
Change subject: core: rename migration policies and change descriptions
......................................................................
core: rename migration policies and change descriptions
Renamed the migration policies to be more user friendly.
Renames:
- change the "Safe but may not converge" to "Minimal downtime"
- change the "Should converge but..." to "Suspend workload if needed"
Added mention in all policy descriptions that
"The guest agent hook mechanism is enabled/disabled."
Change-Id: I10769ff5602e380107dc876d8c10ae0c7f94552e
Bug-Url: https://bugzilla.redhat.com/1346194
Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com>
---
M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Tomas Jelinek: Verified; Looks good to me, approved; Passed CI tests
Martin Peřina: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/59155
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I10769ff5602e380107dc876d8c10ae0c7f94552e
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 6 months
Change in ovirt-engine[ovirt-engine-4.0]: restapi: Don't figure out NIC profile during V3 update
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: restapi: Don't figure out NIC profile during V3 update
......................................................................
restapi: Don't figure out NIC profile during V3 update
Currently the V3 compatibility layer tries to figure out an appropriate
NIC profile when a VM NIC is added or updated and no NIC profile is
explicitly provided. This works fine for adding, but during updates it
may select the wrong profile, thus randomly changing the network that
the NIC is attached to. To avoid that this patch changes the V3 adapter
so that it only tries to figure out the profile when the "network" or
"port_mirroring" attributes are included in the update, as any change to
those attributes requires a change of the VNIC profile.
In addition, to make things less random, the patch also changes the
logic to select the profile so that it sorts the candidates
alphabetically by name and chooses the first one.
Change-Id: Iaa953fcc200a1e175975e3dade9dc3a67d234f27
Bug-Url: https://bugzilla.redhat.com/1342054
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
(cherry picked from commit da9f1e949abb98a80ab63b6c2a46cd2a8e7426b3)
---
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/helpers/V3NICHelper.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/servers/V3VmNicServer.java
2 files changed, 8 insertions(+), 2 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/59179
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iaa953fcc200a1e175975e3dade9dc3a67d234f27
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 6 months
Change in ovirt-engine[master]: core: change default migration policy of 4.0 clusters
by tjelinek@redhat.com
Tomas Jelinek has submitted this change and it was merged.
Change subject: core: change default migration policy of 4.0 clusters
......................................................................
core: change default migration policy of 4.0 clusters
Change-Id: Ie8e1de4ace55b0b02be60b76e940d3f346101e50
Bug-Url: https://bugzilla.redhat.com/1346194
Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com>
---
A packaging/dbscripts/upgrade/04_00_0810_change_cluster_default_policy.sql
1 file changed, 3 insertions(+), 0 deletions(-)
Approvals:
Tomas Jelinek: Verified; Looks good to me, approved
Martin Peřina: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/59154
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie8e1de4ace55b0b02be60b76e940d3f346101e50
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 6 months