Change in ovirt-engine[ovirt-engine-4.0]: core: change default migration policy of 4.0 clusters
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: change default migration policy of 4.0 clusters
......................................................................
core: change default migration policy of 4.0 clusters
Change-Id: Ie8e1de4ace55b0b02be60b76e940d3f346101e50
Bug-Url: https://bugzilla.redhat.com/1346194
Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com>
---
A packaging/dbscripts/upgrade/04_00_0750_change_cluster_default_policy.sql
1 file changed, 3 insertions(+), 0 deletions(-)
Approvals:
Tomas Jelinek: Verified
Martin Peřina: Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/59203
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie8e1de4ace55b0b02be60b76e940d3f346101e50
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0
Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 6 months
Change in ovirt-engine[master]: core: rocessOvfUpdateForStoragePoolCommandTest's anyList
by amureini@redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: rocessOvfUpdateForStoragePoolCommandTest's anyList
......................................................................
core: rocessOvfUpdateForStoragePoolCommandTest's anyList
Use the generically typed anyListOf instead of the raw anyList for some
additional strictness.
Change-Id: I010f9aaba24b3b9f37788a932db5eda8450dfc31
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/ovfstore/ProcessOvfUpdateForStoragePoolCommandTest.java
1 file changed, 7 insertions(+), 6 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Allon Mureinik: Verified; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/59138
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I010f9aaba24b3b9f37788a932db5eda8450dfc31
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 6 months
Change in ovirt-engine[master]: core: OvfUpdateProcessHelper#buildMetadataDictionaryForVm
by amureini@redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: OvfUpdateProcessHelper#buildMetadataDictionaryForVm
......................................................................
core: OvfUpdateProcessHelper#buildMetadataDictionaryForVm
Fix the signature to accept a general purpose List instead of the
overly specific ArrayList implementation.
Change-Id: I5bce9a7d0cf6d7c8c815fd3ece72d18b40212664
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ovfstore/OvfUpdateProcessHelper.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/ovfstore/ProcessOvfUpdateForStoragePoolCommandTest.java
2 files changed, 3 insertions(+), 3 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Allon Mureinik: Verified; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/59137
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5bce9a7d0cf6d7c8c815fd3ece72d18b40212664
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 6 months
Change in ovirt-engine[master]: core: ProcessOvfUpdateForStoragePoolCommandTest collections
by amureini@redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: ProcessOvfUpdateForStoragePoolCommandTest collections
......................................................................
core: ProcessOvfUpdateForStoragePoolCommandTest collections
Replace Arrays.asList with a single argument with
Collections.singletonList in order to [very slightly] improve
performance.
Change-Id: I24c60ef3926338cd06cca503de10bd495625ba74
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/ovfstore/ProcessOvfUpdateForStoragePoolCommandTest.java
1 file changed, 6 insertions(+), 7 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Allon Mureinik: Verified; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/59136
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I24c60ef3926338cd06cca503de10bd495625ba74
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 6 months
Change in ovirt-engine[master]: core: rm ProcessOvfUpdateForStoragePoolCommandTest local var
by amureini@redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: rm ProcessOvfUpdateForStoragePoolCommandTest local var
......................................................................
core: rm ProcessOvfUpdateForStoragePoolCommandTest local var
Remove unused local variable.
Change-Id: I592eae89329f5daa2b360cda69d14d48da355886
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/ovfstore/ProcessOvfUpdateForStoragePoolCommandTest.java
1 file changed, 0 insertions(+), 1 deletion(-)
Approvals:
Tal Nisan: Looks good to me, approved
Allon Mureinik: Verified; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/59135
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I592eae89329f5daa2b360cda69d14d48da355886
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 6 months
Change in ovirt-engine[master]: core: rm iProcessOvfUpdateForStoragePoolCommandTest#executed...
by amureini@redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: rm iProcessOvfUpdateForStoragePoolCommandTest#executedRemovedIds
......................................................................
core: rm iProcessOvfUpdateForStoragePoolCommandTest#executedRemovedIds
The executedRemovedIds member in
ProcessOvfUpdateForStoragePoolCommandTest is just updated but never
queried. Thus, it is redundant, and can (and should!) be removed.
Where removing it reduced a doAnswer block to a simple return statement,
the doAnswer was simplified to doReturn to avoid code bloating.
Change-Id: I4c44f17f9bc8a411e74e42b1be5a439fb89dcced
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/ovfstore/ProcessOvfUpdateForStoragePoolCommandTest.java
1 file changed, 1 insertion(+), 12 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Allon Mureinik: Verified; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/59134
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4c44f17f9bc8a411e74e42b1be5a439fb89dcced
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 6 months
Change in ovirt-engine[master]: core: rm iProcessOvfUpdateForStoragePoolCommandTest#executed...
by amureini@redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: rm iProcessOvfUpdateForStoragePoolCommandTest#executedUpdatedMetadataForStoragePool
......................................................................
core: rm iProcessOvfUpdateForStoragePoolCommandTest#executedUpdatedMetadataForStoragePool
The executedUpdatedMetadataForStoragePool member in
ProcessOvfUpdateForStoragePoolCommandTest is just updated but never
queried. Thus, it is redundant, and can (and should!) be removed.
Change-Id: I1eac7c16603dc4a2fc349153bed862a97faab9c5
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/ovfstore/ProcessOvfUpdateForStoragePoolCommandTest.java
1 file changed, 0 insertions(+), 4 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Allon Mureinik: Verified; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/59133
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1eac7c16603dc4a2fc349153bed862a97faab9c5
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 6 months
Change in ovirt-engine[master]: core: ProcessOvfUpdateForStoragePoolCommandTest type inference
by amureini@redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: ProcessOvfUpdateForStoragePoolCommandTest type inference
......................................................................
core: ProcessOvfUpdateForStoragePoolCommandTest type inference
Change-Id: Icad077ce48705fa3b0650da5d32b2a7bd3be22a8
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/ovfstore/ProcessOvfUpdateForStoragePoolCommandTest.java
1 file changed, 12 insertions(+), 12 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Allon Mureinik: Verified; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/59132
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icad077ce48705fa3b0650da5d32b2a7bd3be22a8
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 6 months
Change in ovirt-engine[master]: core: ProcessOvfUpdateForStoragePoolCommandTest operators
by amureini@redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: ProcessOvfUpdateForStoragePoolCommandTest operators
......................................................................
core: ProcessOvfUpdateForStoragePoolCommandTest operators
Use the *= shorthand operator to decrease code bloat.
Change-Id: Ia41f6d14d625cb5fda337851f2c993e4ac0bcced
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/ovfstore/ProcessOvfUpdateForStoragePoolCommandTest.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Tal Nisan: Looks good to me, approved
Allon Mureinik: Verified; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/59142
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia41f6d14d625cb5fda337851f2c993e4ac0bcced
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 6 months
Change in ovirt-engine[master]: core: ProcessOvfUpdateForStoragePoolCommandTest streaming
by amureini@redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: ProcessOvfUpdateForStoragePoolCommandTest streaming
......................................................................
core: ProcessOvfUpdateForStoragePoolCommandTest streaming
Use Java 8's streams to improve performance and readability.
Change-Id: I8d8682cfa988d01cff8717bbed25fde9a4b4a41d
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/ovfstore/ProcessOvfUpdateForStoragePoolCommandTest.java
1 file changed, 10 insertions(+), 31 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Allon Mureinik: Verified; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/59141
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8d8682cfa988d01cff8717bbed25fde9a4b4a41d
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 6 months