Change in ovirt-engine-sdk-java[master]: Send query parameters with Add/Update actions
by omachace＠redhat.com
Ondra Machacek has submitted this change and it was merged.
Change subject: Send query parameters with Add/Update actions
......................................................................
Send query parameters with Add/Update actions
There are use cases where user can sent query parameters,
along with creating/updating entity action.
For example when creating virtual machine he can also
copy permissions from template to new virtual machine.
This patch add the support so the SDK sends the query parameters,
supported by backend.
Change-Id: Icaee85b912f575a911f2e618b910b7f6f52dfd71
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1366546
Signed-off-by: Ondra Machacek <omachace(a)redhat.com>
---
M .gitignore
M generator/src/main/java/org/ovirt/sdk/java/ServicesImplGenerator.java
A sdk/src/test/java/org/ovirt/engine/sdk4/SecondaryParametersTest.java
M sdk/src/test/java/org/ovirt/engine/sdk4/ServerTest.java
A sdk/src/test/java/org/ovirt/engine/sdk4/examples/AddIndependentVm.java
5 files changed, 206 insertions(+), 53 deletions(-)
Approvals:
Ondra Machacek: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/62546
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icaee85b912f575a911f2e618b910b7f6f52dfd71
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine-sdk-java
Gerrit-Branch: master
Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 1 month
Change in jenkins[master]: ovirt-engine_standard: added 4.0.3 branch
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: ovirt-engine_standard: added 4.0.3 branch
......................................................................
ovirt-engine_standard: added 4.0.3 branch
Change-Id: I8683a552856fe4315dc5ac3fc295d35cad42f039
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M jobs/confs/projects/ovirt-engine/ovirt-engine_standard.yaml
1 file changed, 10 insertions(+), 0 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Ready for merge
Martin Peřina: Looks good to me
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/62548
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8683a552856fe4315dc5ac3fc295d35cad42f039
Gerrit-PatchSet: 1
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 1 month
Change in ovirt-live[master]: Revert "fedora: moving to ganeric branding"
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: Revert "fedora: moving to ganeric branding"
......................................................................
Revert "fedora: moving to ganeric branding"
This reverts commit da0d8d3311441d1fb7a0ed639c34562a079ffb81.
Without fedora branding live media creation fails with
OSError: nothing matching
/var/tmp/lorax.imgutils.x3lnikv1/usr/share/anaconda/boot/syslinux-splash.png
in /
So until we add oVirt artwork we need to use fedora logos.
Change-Id: I9cc9c5e94a2fab6096dcd4b0d09ee1321275f061
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M fedora-24/kickstart/ovirt-live-ovirt-custom.ks.in
1 file changed, 0 insertions(+), 8 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/62550
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9cc9c5e94a2fab6096dcd4b0d09ee1321275f061
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-live
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 1 month
Change in ovirt-engine-sdk-java[master]: Update to model 4.1.10 and metamodel 1.1.2
by omachace＠redhat.com
Ondra Machacek has submitted this change and it was merged.
Change subject: Update to model 4.1.10 and metamodel 1.1.2
......................................................................
Update to model 4.1.10 and metamodel 1.1.2
The more relevant changes in this new version of the model are the
following:
* Add the `clone_permissions` parameter to the operations that add
virtual machines and templates.
* Add the `clone` parameter to the operation that adds a new
* virtual
machine.
* Add the `ad_partner_mac` attribute to the bonding type.
* Add the `ad_aggregator_id` attribute to the host NIC type.
* Add the `upgradecheck` action to the host service.
* Add the `ExternalVmImportsService` and related types.
The more relevant changes in this new version of the metamodel
are the following:
* Name element tag by the enitity, which is written
* Improve name parser
* Report correctly incorrect operators
* Use dash as section id separator
Change-Id: I44b2139c22f51ef7482ce5d0204bfe50740e953a
Signed-off-by: Ondra Machacek <omachace(a)redhat.com>
---
M generator/src/main/java/org/ovirt/sdk/java/ServicesImplGenerator.java
M pom.xml
2 files changed, 4 insertions(+), 2 deletions(-)
Approvals:
Ondra Machacek: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/62534
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I44b2139c22f51ef7482ce5d0204bfe50740e953a
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine-sdk-java
Gerrit-Branch: master
Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 1 month
Change in ovirt-engine[master]: core: update cluster to query only static vm data
by ahadas＠redhat.com
Arik Hadas has submitted this change and it was merged.
Change subject: core: update cluster to query only static vm data
......................................................................
core: update cluster to query only static vm data
In order to update VM, we need only its static data so
no need to use the costly query of whole VM.
Change-Id: If31cd57110eb73574ce2eb6e8e63e232c7c06dc9
Bug-Url: https://bugzilla.redhat.com/1366786
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateClusterCommand.java
1 file changed, 6 insertions(+), 4 deletions(-)
Approvals:
Jakub Niedermertl: Looks good to me, but someone else must approve
Shahar Havivi: Looks good to me, approved
Jenkins CI: Passed CI tests
Arik Hadas: Verified
--
To view, visit https://gerrit.ovirt.org/62522
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If31cd57110eb73574ce2eb6e8e63e232c7c06dc9
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marek Libra <mlibra(a)redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 1 month
Change in ovirt-live[master]: fedora-24: move to lorax
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: fedora-24: move to lorax
......................................................................
fedora-24: move to lorax
moving from livecd-creator to livemedia-creator
due to bug https://bugzilla.redhat.com/1368108
lorax uses dnf instead of yum so it's not affected.
Change-Id: Icfe137d36bbc200a6d6f007ad052d43873279c97
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M fedora-24/Makefile
1 file changed, 7 insertions(+), 3 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/62539
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icfe137d36bbc200a6d6f007ad052d43873279c97
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-live
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 1 month
Change in ovirt-engine[master]: core: make VmBase comparable
by ahadas＠redhat.com
Arik Hadas has submitted this change and it was merged.
Change subject: core: make VmBase comparable
......................................................................
core: make VmBase comparable
The comparison is done according to the ID of the VM.
Change-Id: Ief0d9dc0decc51ad7150d017ed2fd3bb8279c25f
Bug-Url: https://bugzilla.redhat.com/1366786
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmBase.java
1 file changed, 6 insertions(+), 1 deletion(-)
Approvals:
Shahar Havivi: Looks good to me, approved
Jenkins CI: Passed CI tests
Arik Hadas: Verified
--
To view, visit https://gerrit.ovirt.org/62521
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ief0d9dc0decc51ad7150d017ed2fd3bb8279c25f
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 1 month
Change in ovirt-engine[ovirt-engine-4.0]: webadmin: image upload - image info detection
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: image upload - image info detection
......................................................................
webadmin: image upload - image info detection
On 'Image Upload' dialog, upon selection a file:
Image information is detected by its header and according
to qcow2 spec [1].
The following properties are detected (and displayed in dialog):
* Volume format (raw/cow).
* Actual size.
(For COW:)
* Virtual size.
* Backing file.
* Qcow2 Compat (0.10/1.1).
Validation:
* Format is set according to the detected info.
* Uploading an image with a backing file is unsupported.
* Only compat 0.10 is currently supported.
* Minimal disk size should be max(actual, virtual).
[1] See http://git.qemu.org/?p=qemu.git;a=blob;f=docs/specs/qcow2.txt
Screenshot: http://imgur.com/a/Z1zWC
Change-Id: I726678a14451a7faff3a18afa25d013b7f5aa7d5
Bug-Url: https://bugzilla.redhat.com/1357548
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java
A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/ImageInfoForm.java
M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/CommonApplicationConstants.properties
A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/ImageInfoModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/UploadImageModel.java
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Enums.java
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIMessages.java
M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/Enums.properties
M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/UIConstants.properties
M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/UIMessages.properties
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/UploadImagePopupView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/UploadImagePopupView.ui.xml
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/ApplicationConstants.properties
15 files changed, 343 insertions(+), 60 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Daniel Erez: Verified
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/62426
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I726678a14451a7faff3a18afa25d013b7f5aa7d5
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 1 month
Change in ovirt-engine[master]: webadmin: Clean up leftover Linq networking methods
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: webadmin: Clean up leftover Linq networking methods
......................................................................
webadmin: Clean up leftover Linq networking methods
Commit b4ccb43af7203d6c761e6b777cc14aae94b4645b removed a sizable chunk
of code around SetupNetworks.
This patch finishes the job and removes the [now] unused methods left in
the Linq class.
Change-Id: Idd31a2d1e30602a21c835327ec0629445ce9c224
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Linq.java
1 file changed, 0 insertions(+), 64 deletions(-)
Approvals:
Daniel Erez: Looks good to me, approved
Jenkins CI: Passed CI tests
Allon Mureinik: Verified
Yevgeny Zaspitsky: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/62471
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Idd31a2d1e30602a21c835327ec0629445ce9c224
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 1 month
Change in ovirt-engine[master]: core: Refactoring of VM from pool allocation process
by ahadas＠redhat.com
Arik Hadas has submitted this change and it was merged.
Change subject: core: Refactoring of VM from pool allocation process
......................................................................
core: Refactoring of VM from pool allocation process
All functionality of looking for an available VM in a pool and taking
locks on it is moved to a separate class VmPoolHandler. Both
VmPoolMonitor and AttachUserToVmFromPoolAndRunCommand are using it.
Every VM that needs to be run is locked at the moment it is found. This
approach helps to prevent race conditions and makes any internal lock
objects redundant.
Change-Id: I6bbc6d650e0a706f7ff9970ac2dd425e20b6bfc8
Signed-off-by: Shmuel Melamud <smelamud(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AttachUserToVmFromPoolAndRunCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmPoolCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmPoolCommandBase.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmPoolHandler.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmPoolMonitor.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AttachUserToVmFromPoolAndRunParameters.java
7 files changed, 484 insertions(+), 402 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Shmuel Leib Melamud: Verified
Arik Hadas: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/61228
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6bbc6d650e0a706f7ff9970ac2dd425e20b6bfc8
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shmuel Leib Melamud <smelamud(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
8 years, 1 month