Change in ovirt-engine-sdk-java[master]: Add option to not revoke token when closing connection
by omachace＠redhat.com
Ondra Machacek has submitted this change and it was merged.
Change subject: Add option to not revoke token when closing connection
......................................................................
Add option to not revoke token when closing connection
This patch adds support to not revoke token when connection is closed,
it could be handy when we want to reuse token.
Change-Id: Ic3cbae4fc8c66b52875b0dc0eb2d55159b360854
Signed-off-by: Ondra Machacek <omachace(a)redhat.com>
---
M sdk/src/main/java/org/ovirt/engine/sdk4/Connection.java
M sdk/src/main/java/org/ovirt/engine/sdk4/internal/HttpConnection.java
2 files changed, 25 insertions(+), 1 deletion(-)
Approvals:
Ondra Machacek: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/61764
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic3cbae4fc8c66b52875b0dc0eb2d55159b360854
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk-java
Gerrit-Branch: master
Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 8 months
Change in ovirt-engine[master]: core: extract vm numa updates from resource manager
by ahadas＠redhat.com
Arik Hadas has submitted this change and it was merged.
Change subject: core: extract vm numa updates from resource manager
......................................................................
core: extract vm numa updates from resource manager
It is wrong to clear VM numa nodes in DestroyVmVdsCommand because at
that point we cannot be sure that the VM was really destroyed. We
should have waited for the monitoring to detect that the VM is indeed
down and only then clear the VM numa nodes.
But that is the only place that currently rely on internalSetVmStatus
in ResourceManager to clear VM numa nodes. We want this method to
receive only VmDynamic eventually, so as part of this patch I just
extract the updates of VM numa nodes from it to the destroy command.
Change-Id: I504829db92044f4c0a1df41b9f14e2304ce6608f
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/DestroyVmVDSCommand.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/ResourceManager.java
2 files changed, 1 insertion(+), 5 deletions(-)
Approvals:
Shahar Havivi: Looks good to me, approved
Jenkins CI: Passed CI tests
Arik Hadas: Verified
--
To view, visit https://gerrit.ovirt.org/60928
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I504829db92044f4c0a1df41b9f14e2304ce6608f
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 8 months
Change in ovirt-engine-sdk-java[sdk_4.0]: Support both httpclient versions in built jar
by omachace＠redhat.com
Ondra Machacek has submitted this change and it was merged.
Change subject: Support both httpclient versions in built jar
......................................................................
Support both httpclient versions in built jar
User using jar file provided by maven central, shouldn't
depend on any of httpclient versions. He could use whichever
he wants. This patch changes build proccess so both versions
of httpclient are supported and so user can use both of them.
In addition it fixes issue in connection timeout in httpclient v4.2
Change-Id: I2930fb0c93b004fcca5ceca5d80055cc832c24ec
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1360814
Signed-off-by: Ondra Machacek <omachace(a)redhat.com>
(cherry picked from commit f65bb5ea01d54354c5a7b6d4c6cc5d97f4da6fdc)
---
M sdk/pom.xml
M sdk/src/main/java/org/ovirt/engine/sdk4/ConnectionBuilder.java
M sdk/src/main/java/org/ovirt/engine/sdk4/internal/ConnectionBuilder42.java
3 files changed, 7 insertions(+), 14 deletions(-)
Approvals:
Ondra Machacek: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/61753
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2930fb0c93b004fcca5ceca5d80055cc832c24ec
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk-java
Gerrit-Branch: sdk_4.0
Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 8 months
Change in ovirt-engine-sdk-java[master]: Support both httpclient versions in built jar
by omachace＠redhat.com
Ondra Machacek has submitted this change and it was merged.
Change subject: Support both httpclient versions in built jar
......................................................................
Support both httpclient versions in built jar
User using jar file provided by maven central, shouldn't
depend on any of httpclient versions. He could use whichever
he wants. This patch changes build proccess so both versions
of httpclient are supported and so user can use both of them.
In addition it fixes issue in connection timeout in httpclient v4.2
Change-Id: I2930fb0c93b004fcca5ceca5d80055cc832c24ec
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1360814
Signed-off-by: Ondra Machacek <omachace(a)redhat.com>
---
M sdk/pom.xml
M sdk/src/main/java/org/ovirt/engine/sdk4/ConnectionBuilder.java
M sdk/src/main/java/org/ovirt/engine/sdk4/internal/ConnectionBuilder42.java
3 files changed, 7 insertions(+), 14 deletions(-)
Approvals:
Ondra Machacek: Verified; Looks good to me, approved
Juan Hernandez: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/61560
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2930fb0c93b004fcca5ceca5d80055cc832c24ec
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine-sdk-java
Gerrit-Branch: master
Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 8 months
Change in ovirt-engine[master]: core: fix high memory limit default value
by rgolan＠redhat.com
Roy Golan has submitted this change and it was merged.
Change subject: core: fix high memory limit default value
......................................................................
core: fix high memory limit default value
In the secondary methods of power saving load balancing
for finding source/destination hosts by memory utilization
the default value of high memory limit is 0.
In case no value was inserted to this limit -
the scheduling policy will filter out all hosts since no host
will satisfy host available memory < 0.
fix - the default value was changed to max long
in case no value was inserted
Change-Id: I200f1886a0de9c1ff1d15f863d41af67cce07119
Bug-Url: https://bugzilla.redhat.com/1354281
Signed-off-by: yquinn <yquinn(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/PowerSavingBalancePolicyUnit.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/scheduling/policyunits/PowerSavingBalancePolicyUnitTest.java
2 files changed, 55 insertions(+), 2 deletions(-)
Approvals:
Martin Sivák: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Roy Golan: Looks good to me, approved
Yanir Quinn: Verified
--
To view, visit https://gerrit.ovirt.org/60668
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I200f1886a0de9c1ff1d15f863d41af67cce07119
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yanir Quinn <yquinn(a)redhat.com>
Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com>
Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 8 months
Change in ovirt-engine[master]: webadmin: Add gluster fencing policies
by mperina＠redhat.com
Martin Peřina has submitted this change and it was merged.
Change subject: webadmin: Add gluster fencing policies
......................................................................
webadmin: Add gluster fencing policies
Add new fencing policies related to glusterfs in
create/edit cluster popup.
Change-Id: I16fedd4586c54ee035292f2ceb39505bb82d8302
Signed-off-by: Ramesh Nachimuthu <rnachimu(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterModel.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterPopupView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterPopupView.ui.xml
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/ApplicationConstants.properties
6 files changed, 113 insertions(+), 0 deletions(-)
Approvals:
Martin Peřina: Looks good to me, approved
Jenkins CI: Passed CI tests
Sahina Bose: Looks good to me, but someone else must approve
Ramesh N: Verified
--
To view, visit https://gerrit.ovirt.org/59303
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I16fedd4586c54ee035292f2ceb39505bb82d8302
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ramesh N <rnachimu(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 8 months
Change in ovirt-engine[master]: engine: add gluster specific fencing policies.
by mperina＠redhat.com
Martin Peřina has submitted this change and it was merged.
Change subject: engine: add gluster specific fencing policies.
......................................................................
engine: add gluster specific fencing policies.
Adding following gluster specific fencing polices.
1. SkipFencingIfGlusterBricksUp
Fencing will be skipped if bricks are running and can be
reached from other peers.
2. SkipFencingIfGlusterQuorumNotMet
Fencing will be skipped if gluster quorum is not met.
Change-Id: Iecace64d31673fbdcab0cc29eff8d2233c65e240
Signed-off-by: Ramesh Nachimuthu <rnachimu(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/FencingPolicy.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/ClusterDaoImpl.java
M packaging/dbscripts/clusters_sp.sql
A packaging/dbscripts/upgrade/04_01_0180_add_fencing_policy_for_gluster_bricks.sql
4 files changed, 54 insertions(+), 8 deletions(-)
Approvals:
Martin Peřina: Looks good to me, approved
Jenkins CI: Passed CI tests
Sahina Bose: Looks good to me, but someone else must approve
Ramesh N: Verified
--
To view, visit https://gerrit.ovirt.org/59302
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iecace64d31673fbdcab0cc29eff8d2233c65e240
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ramesh N <rnachimu(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 8 months
Change in ovirt-engine[master]: core: Pass gluster fence parameters to VDSM
by mperina＠redhat.com
Martin Peřina has submitted this change and it was merged.
Change subject: core: Pass gluster fence parameters to VDSM
......................................................................
core: Pass gluster fence parameters to VDSM
Passing the newly added gluster fence parameters to VDSM.
These policies will be checked at the proxy host before
fencing the host.
Change-Id: Ib1e71e7d0be3bf872fd406e663eceeea4f0d87a5
Signed-off-by: Ramesh Nachimuthu <rnachimu(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/pm/FenceAgentExecutor.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsProperties.java
2 files changed, 18 insertions(+), 0 deletions(-)
Approvals:
Martin Peřina: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Sahina Bose: Looks good to me, approved
Ramesh N: Verified
--
To view, visit https://gerrit.ovirt.org/59613
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib1e71e7d0be3bf872fd406e663eceeea4f0d87a5
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ramesh N <rnachimu(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 8 months
Change in jenkins[master]: Fix coverity tool download url
by eedri＠redhat.com
Eyal Edri has submitted this change and it was merged.
Change subject: Fix coverity tool download url
......................................................................
Fix coverity tool download url
Change-Id: I16bf3703c1232cc61e3e716765eec2456de763c1
Signed-off-by: Sharon Naftaly <snaftaly(a)redhat.com>
---
M jobs/confs/shell-scripts/coverity_analysis.sh
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Sharon Naftaly: Verified; Ready for review
Eyal Edri: Looks good to me; Ready for merge
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/61750
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I16bf3703c1232cc61e3e716765eec2456de763c1
Gerrit-PatchSet: 1
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: Sharon Naftaly <snaftaly(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sharon Naftaly <snaftaly(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 8 months
Change in ovirt-engine[master]: webadmin:rename "SSL Verification" field
by tjelinek＠redhat.com
Tomas Jelinek has submitted this change and it was merged.
Change subject: webadmin:rename "SSL Verification" field
......................................................................
webadmin:rename "SSL Verification" field
Rename "SSL Verification" checkbox field to
"verify server's SSL certificate" since it's more understandable
and also change the checkbox default value to checked.
Import from VMware provider uses the "SSL verification" check box to
determine if to add the "no_verify="1" flag to the URI or not:
1. if this checkox is checked (default) then the "no_verify=1" flag is not
added to the URI and a verification of the server's SSL certificate is
done.
2. If this checkbox is not checked then the "no_verify=1' flag is
added automatically to the URI and no VMware server's SSL certificate is
verified.
The current field is renamed to: "verify server's SSL
certificate".
The field renaming and default change is done for both
"Add/edit Provider" dialog (VMwarePropertiesWidget) and for Import
VMs dialog.
Change-Id: I4134da4f76e95354c0c980f31f4cb5a7b6d1d3cf
Bug-Url: https://bugzilla.redhat.com/1361193
Signed-off-by: Sharon Gratch <sgratch(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/VmwarePropertiesModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ImportVmsModel.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/ImportVmsPopupView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/ImportVmsPopupView.ui.xml
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/provider/VmwarePropertiesWidget.java
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/ApplicationConstants.properties
7 files changed, 16 insertions(+), 9 deletions(-)
Approvals:
Tomas Jelinek: Looks good to me, approved
Jenkins CI: Passed CI tests
Sharon Gratch: Verified
--
To view, visit https://gerrit.ovirt.org/61660
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4134da4f76e95354c0c980f31f4cb5a7b6d1d3cf
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sharon Gratch <sgratch(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sharon Gratch <sgratch(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 8 months