September 2016 - Engine-commits - oVirt List Archives

Change in jenkins[master]: remove ovirt-engine update db job in ci
by eedri＠redhat.com 19 Sep '16

19 Sep '16

Eyal Edri has submitted this change and it was merged. Change subject: remove ovirt-engine update db job in ci ...................................................................... remove ovirt-engine update db job in ci This job is obseleted by the setup-upgrade job which already does DB update internally as part of the upgrade process and does a much more comprehensive test flow Change-Id: If5a2d79d94d1fd8aece5b32746480cb91f0f153a Signed-off-by: Eyal Edri <eedri(a)redhat.com> --- D jobs/confs/projects/ovirt-engine/ovirt-engine_upgrade-db.yaml D jobs/confs/shell-scripts/ovirt-engine_upgrade-db.cleanup.sh D jobs/confs/shell-scripts/ovirt-engine_upgrade-db.sh D jobs/confs/yaml/builders/ovirt-engine_upgrade-db.yaml D jobs/confs/yaml/templates/engine-upgrade-db.yaml 5 files changed, 0 insertions(+), 216 deletions(-) Approvals: Eyal Edri: Verified; Looks good to me; Passed CI tests; Ready for merge Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/63274 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If5a2d79d94d1fd8aece5b32746480cb91f0f153a Gerrit-PatchSet: 3 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine : Engine should not invoke revoke all on session expi...
by mperina＠redhat.com 19 Sep '16

19 Sep '16

Martin Peřina has submitted this change and it was merged. Change subject: engine : Engine should not invoke revoke all on session expiration ...................................................................... engine : Engine should not invoke revoke all on session expiration On session expiration SessionDataContainer should not invoke revoke-all for the token. If there are no other sessions for the token SSO will cleanup the session on revoke. Change-Id: I8bffd0551efd7ec4850b8913e4e9c8789c36785d Bug-Url: https://bugzilla.redhat.com/1377422 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/SessionDataContainer.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Martin Peřina: Looks good to me, approved Ravi Nori: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/64067 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8bffd0551efd7ec4850b8913e4e9c8789c36785d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: removing changedbowner.sh script
by mperina＠redhat.com 19 Sep '16

19 Sep '16

Martin Peřina has submitted this change and it was merged. Change subject: core: removing changedbowner.sh script ...................................................................... core: removing changedbowner.sh script This script was relevant when the old backup utility was used and there was a chance that the backup was done with other user than 'engine'. In that case, if we try to restore the database we will got permissions issues. Now that engine-backup is used and verifies that the user that backup the database is 'engine', this script is no longer relevant. Change-Id: I0474ea645e2f3a0f4db20b510e2a1ef68e73b4ca Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1371501 Signed-off-by: emesika <emesika(a)redhat.com> --- D packaging/setup/dbutils/changedbowner.sh M packaging/setup/ovirt_engine_setup/engine/constants.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/db/schema.py 3 files changed, 0 insertions(+), 88 deletions(-) Approvals: Martin Peřina: Looks good to me, approved Eli Mesika: Verified Jenkins CI: Passed CI tests Yedidyah Bar David: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/63984 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0474ea645e2f3a0f4db20b510e2a1ef68e73b4ca Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: remove unused field in vm-dynamic
by ahadas＠redhat.com 19 Sep '16

19 Sep '16

Arik Hadas has submitted this change and it was merged. Change subject: core: remove unused field in vm-dynamic ...................................................................... core: remove unused field in vm-dynamic Remove VmDynamic#STATUS_FIELD_NAME Change-Id: Ia65d4c82ec27dfe3db55e9d71ef6119265243a81 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmDynamic.java 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/64157 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia65d4c82ec27dfe3db55e9d71ef6119265243a81 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: adding debug message to DWH heart beat
by mperina＠redhat.com 19 Sep '16

19 Sep '16

Martin Peřina has submitted this change and it was merged. Change subject: core: adding debug message to DWH heart beat ...................................................................... core: adding debug message to DWH heart beat Adding debug messages on DWH heart beat start/end in order to investigate delays that occur sometimes when the result is that the update of the corresponding field in DB not occurs in the configured rate. This will not solve the reported bug, rather it will give us information which part cause the delay, the scheduling mechanism or the database. Change-Id: Ia32c559ee380e0dbb7279f94b7dd9a99c0670a2a Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1373456 Signed-off-by: emesika <emesika(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/dwh/DwhHeartBeat.java 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Martin Peřina: Looks good to me, approved Shirly Radco: Looks good to me, but someone else must approve Eli Mesika: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/64139 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia32c559ee380e0dbb7279f94b7dd9a99c0670a2a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-dwh[ovirt-engine-dwh-4.0]: packaging: setup: Configure scale only on new database
by Shirly Radco 19 Sep '16

19 Sep '16

Shirly Radco has submitted this change and it was merged. Change subject: packaging: setup: Configure scale only on new database ...................................................................... packaging: setup: Configure scale only on new database Change-Id: If4b1adb6556aff015a4d774f8707ccd3e96ba445 Bug-Url: https://bugzilla.redhat.com/1365427 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-dwh/core/scale.py 1 file changed, 10 insertions(+), 2 deletions(-) Approvals: Shirly Radco: Looks good to me, approved Simone Tiraboschi: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Rafael Martins: Looks good to me, but someone else must approve Yedidyah Bar David: Verified -- To view, visit https://gerrit.ovirt.org/63736 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If4b1adb6556aff015a4d774f8707ccd3e96ba445 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-dwh Gerrit-Branch: ovirt-engine-dwh-4.0 Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: disallow boot protocol to be null
by masayag＠redhat.com 19 Sep '16

19 Sep '16

Moti Asayag has submitted this change and it was merged. Change subject: core: disallow boot protocol to be null ...................................................................... core: disallow boot protocol to be null in response to bug 1371119 we should not allow null values in boot protocol columns any more. Change-Id: I535b0945b00b5462cd8a7158f22d63b94f531cd2 Bug-Url: https://bugzilla.redhat.com/1371119 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M backend/manager/modules/dal/src/test/resources/fixtures.xml A packaging/dbscripts/upgrade/04_01_0310_disallow_boot_protocol_to_be_null.sql 2 files changed, 6 insertions(+), 2 deletions(-) Approvals: Eli Mesika: Looks good to me, but someone else must approve Martin Mucha: Verified Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved Yevgeny Zaspitsky: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/64070 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I535b0945b00b5462cd8a7158f22d63b94f531cd2 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: fix retrival of vm's pid
by ahadas＠redhat.com 19 Sep '16

19 Sep '16

Arik Hadas has submitted this change and it was merged. Change subject: core: fix retrival of vm's pid ...................................................................... core: fix retrival of vm's pid The process identifier (PID) of a VM is reported correctly by VDSM but due to incorrect handling in the engine it is not set in VmDynamic#vmPid. This patch fixes that handling so the PID is correctly saved to the database. Further usages of this field need to be considered separately. Change-Id: I83820d8181ee382c720510b3cb51d110cf8bee40 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmDynamic.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsProperties.java 3 files changed, 5 insertions(+), 0 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/64127 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I83820d8181ee382c720510b3cb51d110cf8bee40 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0.4]: packaging: setup: postgres applyEnvironment: Allow missing keys
by tnisan＠redhat.com 19 Sep '16

19 Sep '16

Tal Nisan has submitted this change and it was merged. Change subject: packaging: setup: postgres applyEnvironment: Allow missing keys ...................................................................... packaging: setup: postgres applyEnvironment: Allow missing keys This allows not calling setdefault for each key separately. Bug-Url: https://bugzilla.redhat.com/1369757 Change-Id: I4cbcdb4160df403fc6f58b6757e52c7bcfbe6485 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/setup/ovirt_engine_setup/engine_common/postgres.py 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Jenkins CI: Passed CI tests Yedidyah Bar David: Verified -- To view, visit https://gerrit.ovirt.org/64134 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4cbcdb4160df403fc6f58b6757e52c7bcfbe6485 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0.4 Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: packaging: setup: postgres applyEnvironment: Allow missing keys
by tnisan＠redhat.com 19 Sep '16

19 Sep '16

Tal Nisan has submitted this change and it was merged. Change subject: packaging: setup: postgres applyEnvironment: Allow missing keys ...................................................................... packaging: setup: postgres applyEnvironment: Allow missing keys This allows not calling setdefault for each key separately. Bug-Url: https://bugzilla.redhat.com/1369757 Change-Id: I4cbcdb4160df403fc6f58b6757e52c7bcfbe6485 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/setup/ovirt_engine_setup/engine_common/postgres.py 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Jenkins CI: Passed CI tests Yedidyah Bar David: Verified -- To view, visit https://gerrit.ovirt.org/64133 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4cbcdb4160df403fc6f58b6757e52c7bcfbe6485 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0