Change in ovirt-hosted-engine-setup[master]: python: cleanup import lines using isort
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: python: cleanup import lines using isort
......................................................................
python: cleanup import lines using isort
Ran isort on all the python files included in the project with
the following configuration.
$ cat ~/.isort.cfg
[settings]
line_length=79
known_standard_library=configparser,Cheetah.Template
force_single_line=True
default_section=FIRSTPARTY
known_otopi=otopi
known_host_deploy=ovirt_host_deploy
known_ovirt_engine=ovirt_engine
known_ovirt_engine_setup=ovirt_engine_setup
known_ovirt_setup_lib=ovirt_setup_lib
known_vdsm=vdsm
known_ovirt_hosted_engine_setup=ovirt_hosted_engine_setup
sections=FUTURE,STDLIB,FIRSTPARTY,OTOPI,VDSM,HOST_DEPLOY,OVIRT_ENGINE,OVIRT_ENGINE_SETUP,OVIRT_SETUP_LIB,OVIRT_HOSTED_ENGINE_SETUP,THIRDPARTY,LOCALFOLDER
lines_between_types=2
Change-Id: I090e04f0523b6084b6e429825fff9237473a87a5
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
A .isort.cfg
M build/python.inc
M configure.ac
M po/pt_BR.po
M src/ovirt_hosted_engine_setup/check_liveliness.py
M src/ovirt_hosted_engine_setup/connect_storage_server.py
M src/ovirt_hosted_engine_setup/constants.py
M src/ovirt_hosted_engine_setup/domains.py
M src/ovirt_hosted_engine_setup/engineapi.py
M src/ovirt_hosted_engine_setup/mixins.py
M src/ovirt_hosted_engine_setup/ohttpshandler.py
M src/ovirt_hosted_engine_setup/ovf/ovfenvelope.py
M src/ovirt_hosted_engine_setup/pkissh.py
M src/ovirt_hosted_engine_setup/reinitialize_lockspace.py
M src/ovirt_hosted_engine_setup/set_maintenance.py
M src/ovirt_hosted_engine_setup/tasks.py
M src/ovirt_hosted_engine_setup/util.py
M src/ovirt_hosted_engine_setup/vm_status.py
M src/plugins/gr-he-common/core/misc.py
M src/plugins/gr-he-common/core/offlinepackager.py
M src/plugins/gr-he-common/core/remote_answerfile.py
M src/plugins/gr-he-common/core/vdsmconf.py
M src/plugins/gr-he-common/engine/__init__.py
M src/plugins/gr-he-common/engine/ca.py
M src/plugins/gr-he-common/engine/health.py
M src/plugins/gr-he-common/network/__init__.py
M src/plugins/gr-he-common/network/bridge.py
M src/plugins/gr-he-common/sanlock/__init__.py
M src/plugins/gr-he-common/sanlock/lockspace.py
M src/plugins/gr-he-common/vm/boot_disk.py
M src/plugins/gr-he-common/vm/cloud_init.py
M src/plugins/gr-he-common/vm/misc.py
M src/plugins/gr-he-rollbackupgrade/core/__init__.py
M src/plugins/gr-he-rollbackupgrade/core/misc.py
M src/plugins/gr-he-setup/core/answerfile.py
M src/plugins/gr-he-setup/core/conf.py
M src/plugins/gr-he-setup/core/misc.py
M src/plugins/gr-he-setup/core/preview.py
M src/plugins/gr-he-setup/core/shell.py
M src/plugins/gr-he-setup/core/titles.py
M src/plugins/gr-he-setup/engine/add_host.py
M src/plugins/gr-he-setup/engine/fqdn.py
M src/plugins/gr-he-setup/engine/os_install.py
M src/plugins/gr-he-setup/ha/__init__.py
M src/plugins/gr-he-setup/ha/ha_notifications.py
M src/plugins/gr-he-setup/ha/ha_services.py
M src/plugins/gr-he-setup/libvirt/__init__.py
M src/plugins/gr-he-setup/libvirt/configureqemu.py
M src/plugins/gr-he-setup/network/__init__.py
M src/plugins/gr-he-setup/network/firewall.py
M src/plugins/gr-he-setup/network/firewall_manager.py
M src/plugins/gr-he-setup/network/gateway.py
M src/plugins/gr-he-setup/network/iptables.py
M src/plugins/gr-he-setup/pki/__init__.py
M src/plugins/gr-he-setup/pki/vdsmpki.py
M src/plugins/gr-he-setup/storage/__init__.py
M src/plugins/gr-he-setup/storage/blockd.py
M src/plugins/gr-he-setup/storage/heconf.py
M src/plugins/gr-he-setup/storage/nfs.py
M src/plugins/gr-he-setup/storage/storage.py
M src/plugins/gr-he-setup/system/__init__.py
M src/plugins/gr-he-setup/system/packages.py
M src/plugins/gr-he-setup/system/sshd.py
M src/plugins/gr-he-setup/system/vdsmenv.py
M src/plugins/gr-he-setup/vdsmd/__init__.py
M src/plugins/gr-he-setup/vdsmd/cpu.py
M src/plugins/gr-he-setup/vdsmd/vdsmconf.py
M src/plugins/gr-he-setup/vm/boot_cdrom.py
M src/plugins/gr-he-setup/vm/configurevm.py
M src/plugins/gr-he-setup/vm/cpu.py
M src/plugins/gr-he-setup/vm/image.py
M src/plugins/gr-he-setup/vm/mac.py
M src/plugins/gr-he-setup/vm/machine.py
M src/plugins/gr-he-setup/vm/memory.py
M src/plugins/gr-he-setup/vm/runvm.py
M src/plugins/gr-he-upgradeappliance/core/__init__.py
M src/plugins/gr-he-upgradeappliance/core/misc.py
M src/plugins/gr-he-upgradeappliance/engine/__init__.py
M src/plugins/gr-he-upgradeappliance/engine/misc.py
M src/plugins/gr-he-upgradeappliance/vm/__init__.py
M src/plugins/gr-he-upgradeappliance/vm/configurevm.py
M src/plugins/gr-he-upgradeappliance/vm/runvm.py
M src/vdsm_hooks/hostedengine.py
83 files changed, 1,135 insertions(+), 884 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/62862
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I090e04f0523b6084b6e429825fff9237473a87a5
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 9 months
Change in ovirt-engine[master]: python: Apply isort also to __init__.py files
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: python: Apply isort also to __init__.py files
......................................................................
python: Apply isort also to __init__.py files
Change-Id: I494b535ddd06c099d956d04a64b01a47797b5204
Signed-off-by: Yedidyah Bar David <didi(a)redhat.com>
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M .isort.cfg
M packaging/setup/plugins/ovirt-engine-common/base/core/__init__.py
M packaging/setup/plugins/ovirt-engine-common/base/dialog/__init__.py
M packaging/setup/plugins/ovirt-engine-common/base/network/__init__.py
M packaging/setup/plugins/ovirt-engine-common/base/remote_engine/__init__.py
M packaging/setup/plugins/ovirt-engine-common/base/system/__init__.py
M packaging/setup/plugins/ovirt-engine-common/dockerc/__init__.py
M packaging/setup/plugins/ovirt-engine-common/ovirt-engine-common/config/__init__.py
M packaging/setup/plugins/ovirt-engine-common/ovirt-engine-common/core/__init__.py
M packaging/setup/plugins/ovirt-engine-common/ovirt-engine-common/provisioning/__init__.py
M packaging/setup/plugins/ovirt-engine-common/ovirt-engine-common/system/__init__.py
M packaging/setup/plugins/ovirt-engine-common/ovirt-engine/core/__init__.py
M packaging/setup/plugins/ovirt-engine-common/ovirt-engine/db/__init__.py
M packaging/setup/plugins/ovirt-engine-common/ovirt-engine/system/__init__.py
M packaging/setup/plugins/ovirt-engine-common/vmconsole_proxy_helper/__init__.py
M packaging/setup/plugins/ovirt-engine-common/websocket_proxy/__init__.py
M packaging/setup/plugins/ovirt-engine-provisiondb/ovirt-engine-common/core/__init__.py
M packaging/setup/plugins/ovirt-engine-provisiondb/ovirt-engine-common/provisioning/__init__.py
M packaging/setup/plugins/ovirt-engine-remove/base/core/__init__.py
M packaging/setup/plugins/ovirt-engine-remove/base/files/__init__.py
M packaging/setup/plugins/ovirt-engine-remove/base/network/__init__.py
M packaging/setup/plugins/ovirt-engine-remove/dockerc/__init__.py
M packaging/setup/plugins/ovirt-engine-remove/ovirt-engine-common/system/__init__.py
M packaging/setup/plugins/ovirt-engine-remove/ovirt-engine/config/__init__.py
M packaging/setup/plugins/ovirt-engine-remove/ovirt-engine/db/__init__.py
M packaging/setup/plugins/ovirt-engine-remove/ovirt-engine/system/__init__.py
M packaging/setup/plugins/ovirt-engine-remove/websocket_proxy/__init__.py
M packaging/setup/plugins/ovirt-engine-rename/ovirt-engine/__init__.py
M packaging/setup/plugins/ovirt-engine-rename/vmconsole_proxy_helper/__init__.py
M packaging/setup/plugins/ovirt-engine-setup/base/core/__init__.py
M packaging/setup/plugins/ovirt-engine-setup/base/dialog/__init__.py
M packaging/setup/plugins/ovirt-engine-setup/base/network/__init__.py
M packaging/setup/plugins/ovirt-engine-setup/base/system/__init__.py
M packaging/setup/plugins/ovirt-engine-setup/dockerc/__init__.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-common/apache/__init__.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-common/config/__init__.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-common/dialog/__init__.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-common/distro-rpm/__init__.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-common/system/__init__.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/apache/__init__.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/config/__init__.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/core/__init__.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/db/__init__.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/distro-rpm/__init__.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/fence_kdump_listener/__init__.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/pki/__init__.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/provisioning/__init__.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/system/__init__.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/upgrade/__init__.py
M packaging/setup/plugins/ovirt-engine-setup/vmconsole_proxy_helper/__init__.py
M packaging/setup/plugins/ovirt-engine-setup/websocket_proxy/__init__.py
51 files changed, 28 insertions(+), 71 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved; Passed CI tests
Objections:
Jenkins CI: Failed CI tests
--
To view, visit https://gerrit.ovirt.org/62893
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I494b535ddd06c099d956d04a64b01a47797b5204
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: Ido Rosenzwig <irosenzw(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 9 months
Change in ovirt-hosted-engine-setup[master]: Setup: remove the host label dialog question
by stirabos＠redhat.com
Simone Tiraboschi has submitted this change and it was merged.
Change subject: Setup: remove the host label dialog question
......................................................................
Setup: remove the host label dialog question
Host label at the web interface will be machine's hostname by default
Change-Id: Ie94b899ec66fc7a04aaf735e42c6102aced9c413
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1313916
Signed-off-by: Ido Rosenzwig <irosenzw(a)redhat.com>
---
M src/plugins/gr-he-setup/engine/add_host.py
1 file changed, 4 insertions(+), 37 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, but someone else must approve
Simone Tiraboschi: Looks good to me, approved
Ido Rosenzwig: Verified
Jenkins CI: Passed CI tests
Yedidyah Bar David: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/62944
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie94b899ec66fc7a04aaf735e42c6102aced9c413
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: master
Gerrit-Owner: Ido Rosenzwig <irosenzw(a)redhat.com>
Gerrit-Reviewer: Ido Rosenzwig <irosenzw(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com>
Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 9 months
Change in ovirt-host-deploy[master]: Fix location for OPENSTACK_NEUTRON_OPENVSWITCH_CONFIG
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: Fix location for OPENSTACK_NEUTRON_OPENVSWITCH_CONFIG
......................................................................
Fix location for OPENSTACK_NEUTRON_OPENVSWITCH_CONFIG
With the release of OpenStack Liberty the Open vSwitch
agent ini file location has changed. Includes logic to
use OLD path if running OpenStack Kilo or older.
OLD: /etc/neutron/plugins/openvswitch/ovs_neutron_plugin.ini
NEW: /etc/neutron/plugins/ml2/openvswitch_agent.ini
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1373968
Change-Id: I6adf1078442693410d3435616e4dafb5600a77fb
Signed-off-by: Tony James <tony(a)anthonyjames.org>
---
M src/ovirt_host_deploy/constants.py
1 file changed, 8 insertions(+), 2 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved
Jenkins CI: Passed CI tests
Tony James: Verified
--
To view, visit https://gerrit.ovirt.org/63707
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6adf1078442693410d3435616e4dafb5600a77fb
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-host-deploy
Gerrit-Branch: master
Gerrit-Owner: Tony James <tony(a)anthonyjames.org>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marina Kalinin <mku(a)redhat.com>
Gerrit-Reviewer: Nelly Credi <ncredi(a)redhat.com>
Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Tony James <tony(a)anthonyjames.org>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 9 months
Change in ovirt-engine[master]: core: Use default when getting properties
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Use default when getting properties
......................................................................
core: Use default when getting properties
Remove unneeded boilerplate by using a default value to
System.getProperty.
Change-Id: If7397fbd037189c711a807c4e7bbc3131f8ece1a
Signed-off-by: Nir Soffer <nsoffer(a)redhat.com>
---
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/BaseDaoTestCase.java
1 file changed, 2 insertions(+), 8 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Allon Mureinik: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/64044
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If7397fbd037189c711a807c4e7bbc3131f8ece1a
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 9 months
Change in ovirt-engine[master]: core: ShellLikeConfdTest printing
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: ShellLikeConfdTest printing
......................................................................
core: ShellLikeConfdTest printing
Removed useless printing to System.out from the test - tests should
automatically verify results, not visually.
Change-Id: Id74df2d8df7a88861c9d8757e784f8f9116c112c
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/uutils/src/test/java/org/ovirt/engine/core/uutils/config/ShellLikeConfdTest.java
1 file changed, 0 insertions(+), 7 deletions(-)
Approvals:
Martin Peřina: Looks good to me, approved
Jenkins CI: Passed CI tests
Allon Mureinik: Verified
--
To view, visit https://gerrit.ovirt.org/64039
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id74df2d8df7a88861c9d8757e784f8f9116c112c
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 9 months
Change in ovirt-engine[master]: core: ShellLikeConfdTest try-with-resource
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: ShellLikeConfdTest try-with-resource
......................................................................
core: ShellLikeConfdTest try-with-resource
Clean up the code by using the try-with-resource syntax introduced in
Java 7.
Change-Id: I43bd24670d1e9068519807daa8fea23e54b9a319
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/uutils/src/test/java/org/ovirt/engine/core/uutils/config/ShellLikeConfdTest.java
1 file changed, 3 insertions(+), 10 deletions(-)
Approvals:
Martin Peřina: Looks good to me, approved
Jenkins CI: Passed CI tests
Allon Mureinik: Verified
--
To view, visit https://gerrit.ovirt.org/64040
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I43bd24670d1e9068519807daa8fea23e54b9a319
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 9 months
Change in ovirt-engine[master]: core: ToStringBuilderTest printing
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: ToStringBuilderTest printing
......................................................................
core: ToStringBuilderTest printing
Removed useless printing to System.out from the test - tests should
automatically verify results, not visually.
Change-Id: Idc21f085a1198f4e753f0ba466d669b811dc216e
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/utils/ToStringBuilderTest.java
1 file changed, 0 insertions(+), 1 deletion(-)
Approvals:
Martin Peřina: Looks good to me, approved
Jenkins CI: Passed CI tests
Allon Mureinik: Verified
--
To view, visit https://gerrit.ovirt.org/64041
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Idc21f085a1198f4e753f0ba466d669b811dc216e
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 9 months
Change in ovirt-guest-agent[master]: build: Use newer python-windows and pywin32
by vfeenstr＠redhat.com
Vinzenz Feenstra has submitted this change and it was merged.
Change subject: build: Use newer python-windows and pywin32
......................................................................
build: Use newer python-windows and pywin32
Change-Id: Id286c81e671fc6a5ad6c34e14f3516a7cff1b7f8
Signed-off-by: Yedidyah Bar David <didi(a)redhat.com>
---
M ovirt-guest-agent-windows.spec
1 file changed, 4 insertions(+), 4 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Vinzenz Feenstra: Looks good to me, approved
Yedidyah Bar David: Verified
--
To view, visit https://gerrit.ovirt.org/63730
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id286c81e671fc6a5ad6c34e14f3516a7cff1b7f8
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-guest-agent
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 9 months
Change in ovirt-engine[master]: engine: Use nop-logger for tests
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: engine: Use nop-logger for tests
......................................................................
engine: Use nop-logger for tests
Printing out the logging information during unit tests isn't very
interesting on the one hand, and on the other it slows down the build
dramatically.
Changing the slf4j implementation from the jdk logger
to the nop logger improved build time by more than 10% on my machine
(from ~7:20 minutes to ~6:10 minutes).
Change-Id: Ife3b11a439d2f51a12db85eb66dfc8c87862e496
Bug-Url: https://bugzilla.redhat.com/??????
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
D backend/manager/modules/bll/src/test/resources/logging.properties
D backend/manager/modules/dal/src/test/resources/logging.properties
D backend/manager/tools/src/test/resources/logging.properties
M pom.xml
4 files changed, 1 insertion(+), 61 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Martin Peřina: Looks good to me, but someone else must approve
Allon Mureinik: Verified; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/63946
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ife3b11a439d2f51a12db85eb66dfc8c87862e496
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 9 months