September 2016 - Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-4.0]: restapi: Build correctly creation status links
by tnisan＠redhat.com 19 Sep '16

19 Sep '16

Tal Nisan has submitted this change and it was merged. Change subject: restapi: Build correctly creation status links ...................................................................... restapi: Build correctly creation status links The code that builds the links returned by the creation status resource doesn't build correctly the links, because it doesn't take into account the source of the API version. As a result the links contain always the version prefix. For example: <creation href="/ovirt-engine/api/v4/vms/..." id="..."> <status>complete</status> </creation> Note the '/v4' suffix, it should be there only if it is included in the request URI, but it is currently always present, even when the version is selected using the 'Version' header. This patch fixes the creation status resource so that it builds the link taking into account where the version has been specified. Change-Id: I9cc0f7f03d2dd5ece00ed0081a7fb058cd5b7a27 Related-To: https://bugzilla.redhat.com/1359139 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit df4292de31b3a2ca3bd030da85e8e70086331c7c) --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/AbstractBackendAsyncStatusResource.java 1 file changed, 12 insertions(+), 13 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/64132 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9cc0f7f03d2dd5ece00ed0081a7fb058cd5b7a27 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: standard printing of vm configuration
by ahadas＠redhat.com 19 Sep '16

19 Sep '16

Arik Hadas has submitted this change and it was merged. Change subject: core: standard printing of vm configuration ...................................................................... core: standard printing of vm configuration We currently print the configuration of a VM we are going to run with custom code. This patch replaces this part with a call to Java's AbstractMap#toString. Change-Id: I25db0be4a103d4e25842c3b7475db62c480878c8 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/CreateVDSCommand.java 1 file changed, 1 insertion(+), 19 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/64126 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I25db0be4a103d4e25842c3b7475db62c480878c8 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: restapi: Build correctly creation status links
by juan.hernandez＠redhat.com 19 Sep '16

19 Sep '16

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Build correctly creation status links ...................................................................... restapi: Build correctly creation status links The code that builds the links returned by the creation status resource doesn't build correctly the links, because it doesn't take into account the source of the API version. As a result the links contain always the version prefix. For example: <creation href="/ovirt-engine/api/v4/vms/..." id="..."> <status>complete</status> </creation> Note the '/v4' suffix, it should be there only if it is included in the request URI, but it is currently always present, even when the version is selected using the 'Version' header. This patch fixes the creation status resource so that it builds the link taking into account where the version has been specified. Change-Id: I9cc0f7f03d2dd5ece00ed0081a7fb058cd5b7a27 Related-To: https://bugzilla.redhat.com/1359139 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/AbstractBackendAsyncStatusResource.java 1 file changed, 12 insertions(+), 13 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/64002 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9cc0f7f03d2dd5ece00ed0081a7fb058cd5b7a27 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: core: Require WildFly 10.1.0
by tnisan＠redhat.com 19 Sep '16

19 Sep '16

Tal Nisan has submitted this change and it was merged. Change subject: core: Require WildFly 10.1.0 ...................................................................... core: Require WildFly 10.1.0 Adds requirement on WildFly 10.1.0 Change-Id: Iddb5203893e1d3d694b2199d70757c46b941bc52 Bug-Url: https://bugzilla.redhat.com/1368985 Signed-off-by: Martin Perina <mperina(a)redhat.com> --- M ovirt-engine.spec.in 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Martin Peřina: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/64121 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iddb5203893e1d3d694b2199d70757c46b941bc52 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0.4]: core: Fix disk profile matching by storage domain
by tnisan＠redhat.com 19 Sep '16

19 Sep '16

Tal Nisan has submitted this change and it was merged. Change subject: core: Fix disk profile matching by storage domain ...................................................................... core: Fix disk profile matching by storage domain Disk profile matching by storage domain was done incorrectly Taking under account only the storage domain default disk profile. Matching a disk profile by storage domain is now done against all disk profiles of that storage domain. In addition added correct syntax in errors messages. Change-Id: I074427d394da5610e1327b20a15cc76b1e5f6f43 Bug-Url: https://bugzilla.redhat.com/1361838 Signed-off-by: Yanir Quinn <yquinn(a)redhat.com> (cherry picked from commit e20ff86) Signed-off-by: Yanir Quinn <yquinn(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/profiles/DiskProfileHelper.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/profiles/DiskProfileHelperTest.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 6 files changed, 5 insertions(+), 9 deletions(-) Approvals: Jenkins CI: Passed CI tests Roy Golan: Looks good to me, approved Yanir Quinn: Verified -- To view, visit https://gerrit.ovirt.org/63535 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I074427d394da5610e1327b20a15cc76b1e5f6f43 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0.4 Gerrit-Owner: Yanir Quinn <yquinn(a)redhat.com> Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0.4]: core: replace null valued ipv6_boot_protocol with 'NONE'
by oourfali＠redhat.com 19 Sep '16

19 Sep '16

Oved Ourfali has submitted this change and it was merged. Change subject: core: replace null valued ipv6_boot_protocol with 'NONE' ...................................................................... core: replace null valued ipv6_boot_protocol with 'NONE' update script fixes issue which exist due to problems on all 3 layers. Ipv6BootProtocol should be nonnull(which is not), and this column on dal layer controls creation of IpV6Address(which probably should not be there), and because of that null-valued IpV6Address instance arrives to UI layer, which expects only non-null values (which it should not do), and because of that UI fails on NPE. Change-Id: I9747497c3fbdd0a4e409a1ef8694818d4178dd54 Bug-Url: https://bugzilla.redhat.com/1371119 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- A packaging/dbscripts/upgrade/04_00_0910_do_not_allow_null_boot_protocol.sql 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Eli Mesika: Looks good to me, but someone else must approve Martin Mucha: Verified Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/64073 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9747497c3fbdd0a4e409a1ef8694818d4178dd54 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0.4 Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: core: replace null valued ipv6_boot_protocol with 'NONE'
by oourfali＠redhat.com 19 Sep '16

19 Sep '16

Oved Ourfali has submitted this change and it was merged. Change subject: core: replace null valued ipv6_boot_protocol with 'NONE' ...................................................................... core: replace null valued ipv6_boot_protocol with 'NONE' update script fixes issue which exist due to problems on all 3 layers. Ipv6BootProtocol should be nonnull(which is not), and this column on dal layer controls creation of IpV6Address(which probably should not be there), and because of that null-valued IpV6Address instance arrives to UI layer, which expects only non-null values (which it should not do), and because of that UI fails on NPE. Change-Id: I9747497c3fbdd0a4e409a1ef8694818d4178dd54 Bug-Url: https://bugzilla.redhat.com/1371119 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- A packaging/dbscripts/upgrade/04_00_0910_do_not_allow_null_boot_protocol.sql 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Eli Mesika: Looks good to me, but someone else must approve Martin Mucha: Verified Moti Asayag: Looks good to me, approved Oved Ourfali: Passed CI tests -- To view, visit https://gerrit.ovirt.org/64071 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9747497c3fbdd0a4e409a1ef8694818d4178dd54 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-node-plugin-vdsm[ovirt-3.6]: spec: Add rsyslog requirement
by dougsland＠redhat.com 18 Sep '16

18 Sep '16

Douglas Schilling Landgraf has submitted this change and it was merged. Change subject: spec: Add rsyslog requirement ...................................................................... spec: Add rsyslog requirement The auto-registration works in EL6 and EL7 which requires rsyslog to analyze the kargs used during the boot. Change-Id: I18c7c75a8236f12c2ff8e94370f84b6188a2dfcd Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1377073 Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> Reviewed-on: https://gerrit.ovirt.org/64103 (cherry picked from commit 48896d1f7f24fc81776bb790f904aa7476870346) Reviewed-on: https://gerrit.ovirt.org/64104 --- M ovirt-node-plugin-vdsm.spec.in 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Douglas Schilling Landgraf: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/64104 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I18c7c75a8236f12c2ff8e94370f84b6188a2dfcd Gerrit-PatchSet: 2 Gerrit-Project: ovirt-node-plugin-vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-node-plugin-vdsm[master]: spec: Add rsyslog requirement
by dougsland＠redhat.com 18 Sep '16

18 Sep '16

Douglas Schilling Landgraf has submitted this change and it was merged. Change subject: spec: Add rsyslog requirement ...................................................................... spec: Add rsyslog requirement The auto-registration works in EL6 and EL7 which requires rsyslog to analyze the kargs used during the boot. Change-Id: I18c7c75a8236f12c2ff8e94370f84b6188a2dfcd Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1377073 Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> Reviewed-on: https://gerrit.ovirt.org/64103 --- M ovirt-node-plugin-vdsm.spec.in 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Douglas Schilling Landgraf: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/64103 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I18c7c75a8236f12c2ff8e94370f84b6188a2dfcd Gerrit-PatchSet: 2 Gerrit-Project: ovirt-node-plugin-vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: engine: Clear IDE disk address on bootable change
by tnisan＠redhat.com 18 Sep '16

18 Sep '16

Tal Nisan has submitted this change and it was merged. Change subject: engine: Clear IDE disk address on bootable change ...................................................................... engine: Clear IDE disk address on bootable change In the following scenario, the VM will fail to start: 1. Create new VM with IDE disk, verify it starts 2. Add second IDE disk 3. Turn off bootable flag from 1st disk, make 2nd disk bootable 4. Start the VM The root cause of this issue is that we save the device address of the disk, but we changed the order of the disks. This will cause a mismatch between the address and the name of the disk. In order to fix this issue, the address will be cleared for IDE disks if the 'bootable' attribute changed. Change-Id: I46847ae9f0870e454e81722834535861b87abed8 Bug-Url: https://bugzilla.redhat.com/1186817 Signed-off-by: Fred Rolland <frolland(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/UpdateVmDiskCommand.java 1 file changed, 4 insertions(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, but someone else must approve Freddy Rolland: Verified -- To view, visit https://gerrit.ovirt.org/64101 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I46847ae9f0870e454e81722834535861b87abed8 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0