September 2016 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: extract disk statistics from vm-dynamic
by ahadas＠redhat.com 18 Sep '16

18 Sep '16

Arik Hadas has submitted this change and it was merged. Change subject: core: extract disk statistics from vm-dynamic ...................................................................... core: extract disk statistics from vm-dynamic This is quite an absurd that VmDynamic#disks was set with @UnchangeableByVdsm although it is reported only by VDSM. This might be an indication of a problem with the design - it represents disk statistics and thus should not be part of VmDynamic: 1. It is not supposed to be compared with value from the database (hence why it is set with @UnchangeableByVdsm) 2. It is not supposed to be sent for each VM that is being queried, including search queries. Therefore, this patch extracts this data from VmDynamic to VdsmVm that contains similar type of statistics. Change-Id: I4139db014d4663c1ee1eff5037939db628b2f53e Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmDynamic.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VdsmVm.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmAnalyzer.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmStatsVdsBrokerCommand.java M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectBuilderTest.java 6 files changed, 46 insertions(+), 63 deletions(-) Approvals: Shahar Havivi: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Maor Lipchuk: Looks good to me, approved Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/63329 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4139db014d4663c1ee1eff5037939db628b2f53e Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: engine fail to activate host on unknown RNG source
by shavivi＠redhat.com 18 Sep '16

18 Sep '16

Shahar Havivi has submitted this change and it was merged. Change subject: core: engine fail to activate host on unknown RNG source ...................................................................... core: engine fail to activate host on unknown RNG source Unknown RNG source doesn't need to prevent host from loading. Change-Id: I99fab20589f2866932269fc63e0bb9051b3ddbac Bug-Url: https://bugzilla.redhat.com/1374216 Signed-off-by: Shahar Havivi <shaharh(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmRngDevice.java 1 file changed, 11 insertions(+), 3 deletions(-) Approvals: Shahar Havivi: Verified Jenkins CI: Passed CI tests Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/63985 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I99fab20589f2866932269fc63e0bb9051b3ddbac Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Yaniv Kaul <ykaul(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: tests: refactor SyncLunsInfoForBlockStorageDomainCommandTest
by derez＠redhat.com 18 Sep '16

18 Sep '16

Daniel Erez has submitted this change and it was merged. Change subject: tests: refactor SyncLunsInfoForBlockStorageDomainCommandTest ...................................................................... tests: refactor SyncLunsInfoForBlockStorageDomainCommandTest This patch changes SyncLunsInfoForBlockStorageDomainCommandTest to use two LUNs object members instead of recreating them in each test case. Change-Id: Ic8b41699a69379443bb84fef017532bb74de80b0 Signed-off-by: Idan Shaby <ishaby(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/domain/SyncLunsInfoForBlockStorageDomainCommandTest.java 1 file changed, 33 insertions(+), 33 deletions(-) Approvals: Daniel Erez: Looks good to me, approved Jenkins CI: Passed CI tests Idan Shaby: Verified -- To view, visit https://gerrit.ovirt.org/64008 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic8b41699a69379443bb84fef017532bb74de80b0 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-dwh[master]: packaging: setup: Configure scale only on new database
by Shirly Radco 18 Sep '16

18 Sep '16

Shirly Radco has submitted this change and it was merged. Change subject: packaging: setup: Configure scale only on new database ...................................................................... packaging: setup: Configure scale only on new database Change-Id: If4b1adb6556aff015a4d774f8707ccd3e96ba445 Bug-Url: https://bugzilla.redhat.com/1365427 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-dwh/core/scale.py 1 file changed, 10 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Shirly Radco: Looks good to me, approved Simone Tiraboschi: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Rafael Martins: Looks good to me, but someone else must approve Yedidyah Bar David: Verified -- To view, visit https://gerrit.ovirt.org/63642 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If4b1adb6556aff015a4d774f8707ccd3e96ba445 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core, webadmin: Support upgrade for V4
by mlipchuk＠redhat.com 18 Sep '16

18 Sep '16

Maor Lipchuk has submitted this change and it was merged. Change subject: core, webadmin: Support upgrade for V4 ...................................................................... core, webadmin: Support upgrade for V4 Support storage domain's upgrade to V4. Also, remove a redundant test of validateSucceedsPoolNotSpecified since ensureStorageFormatInitialized in AddStorageDomainCommand insures that the storage domain will always be initialized with a storage format. Change-Id: I5139b85cefdb9c7223fb19e0cb6c0e9278d062d4 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/storage/StorageDomainValidator.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/domain/AddStorageDomainCommonTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StorageFormatType.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/VersionStorageFormatUtil.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/UploadImageModel.java 6 files changed, 12 insertions(+), 14 deletions(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/63637 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5139b85cefdb9c7223fb19e0cb6c0e9278d062d4 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: Default storage format once adding SD.
by mlipchuk＠redhat.com 18 Sep '16

18 Sep '16

Maor Lipchuk has submitted this change and it was merged. Change subject: webadmin: Default storage format once adding SD. ...................................................................... webadmin: Default storage format once adding SD. If a Data Center is in an uninitialized status its format type is also uninitialized although the Data Center might not support specific storage formats. For example a v4.0 Data Center should not support v4 storage domains Today, once a storage domain is being added to an uninitialized 4.0 Data Center the default storage format will be V4 for new storage domains since the Data Center's format type is still un-initialized, and the add operation will fail for a reason of unsupported version format. The proposed fix sets the Data Center's format type once it is uninitialized based on its compatibility version Change-Id: Ia117efc7369056f70854b8bbfbb6dd7dec7ce318 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageModel.java 1 file changed, 11 insertions(+), 7 deletions(-) Approvals: Jenkins CI: Passed CI tests Daniel Erez: Looks good to me, approved Allon Mureinik: Looks good to me, but someone else must approve Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/63717 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia117efc7369056f70854b8bbfbb6dd7dec7ce318 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: Clear IDE disk address on bootable change
by amureini＠redhat.com 18 Sep '16

18 Sep '16

Allon Mureinik has submitted this change and it was merged. Change subject: engine: Clear IDE disk address on bootable change ...................................................................... engine: Clear IDE disk address on bootable change In the following scenario, the VM will fail to start: 1. Create new VM with IDE disk, verify it starts 2. Add second IDE disk 3. Turn off bootable flag from 1st disk, make 2nd disk bootable 4. Start the VM The root cause of this issue is that we save the device address of the disk, but we changed the order of the disks. This will cause a mismatch between the address and the name of the disk. In order to fix this issue, the address will be cleared for IDE disks if the 'bootable' attribute changed. Change-Id: I46847ae9f0870e454e81722834535861b87abed8 Bug-Url: https://bugzilla.redhat.com/1186817 Signed-off-by: Fred Rolland <frolland(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/UpdateVmDiskCommand.java 1 file changed, 4 insertions(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Passed CI tests Freddy Rolland: Verified -- To view, visit https://gerrit.ovirt.org/63726 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I46847ae9f0870e454e81722834535861b87abed8 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Fred Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: replace null valued ipv6_boot_protocol with 'NONE'
by masayag＠redhat.com 18 Sep '16

18 Sep '16

Moti Asayag has submitted this change and it was merged. Change subject: core: replace null valued ipv6_boot_protocol with 'NONE' ...................................................................... core: replace null valued ipv6_boot_protocol with 'NONE' update script fixes issue which exist due to problems on all 3 layers. Ipv6BootProtocol should be nonnull(which is not), and this column on dal layer controls creation of IpV6Address(which probably should not be there), and because of that null-valued IpV6Address instance arrives to UI layer, which expects only non-null values (which it should not do), and because of that UI fails on NPE. Change-Id: I9747497c3fbdd0a4e409a1ef8694818d4178dd54 Bug-Url: https://bugzilla.redhat.com/1371119 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- A packaging/dbscripts/upgrade/04_01_0300_do_not_allow_null_boot_protocol.sql 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Eli Mesika: Looks good to me, but someone else must approve Martin Mucha: Verified Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved Yevgeny Zaspitsky: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/64069 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9747497c3fbdd0a4e409a1ef8694818d4178dd54 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: fix pagination error when navigating the system tree
by gshereme＠redhat.com 16 Sep '16

16 Sep '16

Greg Sheremeta has submitted this change and it was merged. Change subject: webadmin: fix pagination error when navigating the system tree ...................................................................... webadmin: fix pagination error when navigating the system tree Changed SearchableListModel such that the current search page is reset with every search string reset. If the currently displayed page is not tracked correctly, UX elements will misbehave. The broken behavior primarily effected table lists view on main tabs. When the tab's search is updated by either navigating the system tree or by entering search terms, its list model needs to hold the correct search page information. If not, the table view pagination controls may behave as if a different page of records is being displayed than what is actually displayed. Change-Id: I17eab7bb25cbd7aecfedf259e33975947c1df892 Bug-Url: https://bugzilla.redhat.com/1326452 Signed-off-by: Scott J Dickerson <sdickers(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/SearchableListModel.java 1 file changed, 3 insertions(+), 2 deletions(-) Approvals: Jenkins CI: Passed CI tests Greg Sheremeta: Looks good to me, approved Vojtech Szocs: Looks good to me, approved Scott Dickerson: Verified -- To view, visit https://gerrit.ovirt.org/63195 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I17eab7bb25cbd7aecfedf259e33975947c1df892 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Scott Dickerson <sdickers(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Scott Dickerson <sdickers(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-setup[master]: image: ask image size also when using the appliance
by sbonazzo＠redhat.com 16 Sep '16

16 Sep '16

Sandro Bonazzola has submitted this change and it was merged. Change subject: image: ask image size also when using the appliance ...................................................................... image: ask image size also when using the appliance Ask image size also when using the appliance using the appliance disk size as a minimum value. It will let customize the disk size also on upgrades (the code was already exending the volume size if the new appliance was bigger than the initial disk). Change-Id: I7828357a8647af8c816db9d9ea9b5251a0fd2df2 Bug-Url: https://bugzilla.redhat.com/1300591 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M po/POTFILES.in M src/ovirt_hosted_engine_setup/constants.py M src/ovirt_hosted_engine_setup/util.py M src/plugins/gr-he-common/core/remote_answerfile.py M src/plugins/gr-he-common/vm/Makefile.am M src/plugins/gr-he-common/vm/__init__.py M src/plugins/gr-he-common/vm/boot_disk.py R src/plugins/gr-he-common/vm/image.py M src/plugins/gr-he-setup/storage/storage.py M src/plugins/gr-he-setup/vm/Makefile.am M src/plugins/gr-he-setup/vm/__init__.py M src/plugins/gr-he-upgradeappliance/engine/misc.py 12 files changed, 89 insertions(+), 23 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Simone Tiraboschi: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/63151 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7828357a8647af8c816db9d9ea9b5251a0fd2df2 Gerrit-PatchSet: 18 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0