January 2017 - Engine-commits - oVirt List Archives

Change in jenkins[master]: drop jenkins_old backup job
by Code Review 24 Jan '17

24 Jan '17

>From Eyal Edri <eedri(a)redhat.com>: Eyal Edri has submitted this change and it was merged. Change subject: drop jenkins_old backup job ...................................................................... drop jenkins_old backup job Change-Id: I17d028b38ed93f041b9fdef5f116a0096ff43ddc Signed-off-by: Nadav Goldin <ngoldin(a)redhat.com> --- M jobs/confs/projects/system/system_backup.yaml 1 file changed, 0 insertions(+), 19 deletions(-) Approvals: Nadav Goldin: Verified; Ready for review Eyal Edri: Looks good to me, approved; Ready for merge Jenkins CI: Passed CI tests Evgheni Dereveanchin: Looks good to me -- To view, visit https://gerrit.ovirt.org/70949 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I17d028b38ed93f041b9fdef5f116a0096ff43ddc Gerrit-PatchSet: 2 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Nadav Goldin <ngoldin(a)redhat.com> Gerrit-Reviewer: Evgheni Dereveanchin <ederevea(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nadav Goldin <ngoldin(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: Make suit_type strings use '-' instead of '_'
by Code Review 24 Jan '17

24 Jan '17

>From Eyal Edri <eedri(a)redhat.com>: Eyal Edri has submitted this change and it was merged. Change subject: Make suit_type strings use '-' instead of '_' ...................................................................... Make suit_type strings use '-' instead of '_' See Jira ticket for an explanation why is this needed Change-Id: Icca364a0e43b5fba60cc7bdd87636661d7039d0c Jira-Ticket: https://ovirt-jira.atlassian.net/browse/OVIRT-1068 Signed-off-by: Barak Korren <bkorren(a)redhat.com> --- M jobs/confs/yaml/templates/system_tests_templates.yaml 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: Eyal Edri: Looks good to me, approved; Ready for merge Barak Korren: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/70981 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icca364a0e43b5fba60cc7bdd87636661d7039d0c Gerrit-PatchSet: 4 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: David Caro <david(a)dcaro.es> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Gal Ben Haim <galbh2(a)gmail.com> Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Nadav Goldin <ngoldin(a)redhat.com> Gerrit-Reviewer: Pavel Zhukov <pavel(a)zhukoff.net> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com> Gerrit-Reviewer: Yaniv Kaul <ykaul(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: use the junit's Silent runner in DiskValidatorTest
by Code Review 24 Jan '17

24 Jan '17

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: core: use the junit's Silent runner in DiskValidatorTest ...................................................................... core: use the junit's Silent runner in DiskValidatorTest DiskValidatorTest fails with UnnecessaryStubbingException because of two places where the vmDao's stubbing is not used. This patch changes the runner to MockitoJUnitRunner.Silent to ignore that error. Change-Id: If309fb72fdd5f5a89773f8bd419cf99ced0a535f Signed-off-by: Idan Shaby <ishaby(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/storage/DiskValidatorTest.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved Idan Shaby: Verified -- To view, visit https://gerrit.ovirt.org/71069 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If309fb72fdd5f5a89773f8bd419cf99ced0a535f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk[sdk_4.0]: Add image upload example
by Code Review 24 Jan '17

24 Jan '17

>From Ondra Machacek <omachace(a)redhat.com>: Ondra Machacek has submitted this change and it was merged. Change subject: Add image upload example ...................................................................... Add image upload example Image upload was recently introduced to the engine's API. This patch add an example for uploading an image. Change-Id: I165f2b00732bdd4dca07da5210ee0f216875ecec Signed-off-by: Amit Aviram <aaviram(a)redhat.com> (cherry picked from commit ae1d23f228006ecdd681f1b265cbeed10d12146d) (cherry picked from commit 57028effd83b8ca32bb0591c90671ae3fe52e6e9) --- A sdk/examples/upload_disk.py 1 file changed, 158 insertions(+), 0 deletions(-) Approvals: Ondra Machacek: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/71074 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I165f2b00732bdd4dca07da5210ee0f216875ecec Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: sdk_4.0 Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: remove redundant mockings from UpdateHostValidatorTest
by Code Review 24 Jan '17

24 Jan '17

>From Moti Asayag <masayag(a)redhat.com>: Moti Asayag has submitted this change and it was merged. Change subject: engine: remove redundant mockings from UpdateHostValidatorTest ...................................................................... engine: remove redundant mockings from UpdateHostValidatorTest Remove redundant mockings from UpdateHostValidatorTest and by that enable using "strict" Mockito runner. Change-Id: I4cdbd128c8869da4ea45f24d6d2078ebadf6e8d5 Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/UpdateHostValidatorTest.java 1 file changed, 2 insertions(+), 17 deletions(-) Approvals: Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved Yevgeny Zaspitsky: Verified -- To view, visit https://gerrit.ovirt.org/71048 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4cdbd128c8869da4ea45f24d6d2078ebadf6e8d5 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: ovirt-wgt 4.1: Add missing repo
by Code Review 24 Jan '17

24 Jan '17

>From Sandro Bonazzola <sbonazzo(a)redhat.com>: Sandro Bonazzola has submitted this change and it was merged. Change subject: ovirt-wgt 4.1: Add missing repo ...................................................................... ovirt-wgt 4.1: Add missing repo Change-Id: Id210b9ee0ca5378f899e99e037a6c6801116f608 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M jobs/confs/projects/ovirt-wgt/ovirt-wgt_create-rpms.yaml 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved; Ready for merge Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/71079 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id210b9ee0ca5378f899e99e037a6c6801116f608 Gerrit-PatchSet: 1 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk[sdk_4.0]: Check types of locator parameters
by Code Review 24 Jan '17

24 Jan '17

>From Ondra Machacek <omachace(a)redhat.com>: Ondra Machacek has submitted this change and it was merged. Change subject: Check types of locator parameters ...................................................................... Check types of locator parameters Currently the types of the parameters of locator methods aren't checked. This patch addresses that issue, so that the parameters will be checked and useful exceptions will be generated. Change-Id: I8b170c5ee917701b56960d1ffe23d3833d8df833 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit 86bd07f911864b8648c8b51532e6b8203d8f7028) (cherry picked from commit b35abc2fc361b8db2c01619dd136696c0b7a66f0) --- M generator/src/main/java/org/ovirt/sdk/python/ServicesGenerator.java M sdk/tests/test_check_types.py 2 files changed, 20 insertions(+), 0 deletions(-) Approvals: Ondra Machacek: Verified; Looks good to me, approved Juan Hernandez: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/71054 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8b170c5ee917701b56960d1ffe23d3833d8df833 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: sdk_4.0 Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: api: vmmpper from VmTemplate to VmStatic doesn't set boot menu
by Code Review 24 Jan '17

24 Jan '17

>From Juan Hernandez <juan.hernandez(a)redhat.com>: Juan Hernandez has submitted this change and it was merged. Change subject: api: vmmpper from VmTemplate to VmStatic doesn't set boot menu ...................................................................... api: vmmpper from VmTemplate to VmStatic doesn't set boot menu Bug-Url: https://bugzilla.redhat.com/1328093 Change-Id: I6e2e6178b4f77be0e3a5adf0c76d47de0d30caf6 Signed-off-by: Shahar Havivi <shaharh(a)redhat.com> --- M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmMapper.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Juan Hernandez: Looks good to me, approved Shahar Havivi: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/71075 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6e2e6178b4f77be0e3a5adf0c76d47de0d30caf6 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: gwt-servlet: Log an Error when misusing multi queries
by Code Review 24 Jan '17

24 Jan '17

>From Roy Golan <rgolan(a)redhat.com>: Roy Golan has submitted this change and it was merged. Change subject: gwt-servlet: Log an Error when misusing multi queries ...................................................................... gwt-servlet: Log an Error when misusing multi queries Logging an error now when the params and types passed do not much or are null. Unit test added to test the conditions. Change-Id: Icdfb1d2e16dab6cc2e5e219a4533eef78924fabc Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/server/gwt/GenericApiGWTServiceImpl.java A frontend/webadmin/modules/frontend/src/test/java/org/ovirt/engine/ui/frontend/server/gwt/GenericApiGWTServiceImplTest.java 2 files changed, 103 insertions(+), 6 deletions(-) Approvals: Jenkins CI: Passed CI tests Daniel Erez: Looks good to me, approved Roy Golan: Verified -- To view, visit https://gerrit.ovirt.org/65829 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icdfb1d2e16dab6cc2e5e219a4533eef78924fabc Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: gwt-extension: Clean unused method
by Code Review 24 Jan '17

24 Jan '17

>From Roy Golan <rgolan(a)redhat.com>: Roy Golan has submitted this change and it was merged. Change subject: gwt-extension: Clean unused method ...................................................................... gwt-extension: Clean unused method Change-Id: I79c9c2cecea4cbe017fbdf0635faed3d21e3d3ee Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M frontend/webadmin/modules/gwt-extension/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryReturnValue_CustomFieldSerializer.java 1 file changed, 0 insertions(+), 23 deletions(-) Approvals: Jenkins CI: Passed CI tests Daniel Erez: Looks good to me, approved Roy Golan: Verified -- To view, visit https://gerrit.ovirt.org/65886 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I79c9c2cecea4cbe017fbdf0635faed3d21e3d3ee Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0