January 2017 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: add a test to getVmDeviceUnitMapForScsiDisks
by Code Review 25 Jan '17

25 Jan '17

>From Daniel Erez <derez(a)redhat.com>: Daniel Erez has submitted this change and it was merged. Change subject: core: add a test to getVmDeviceUnitMapForScsiDisks ...................................................................... core: add a test to getVmDeviceUnitMapForScsiDisks Added a test for getVmDeviceUnitMapForScsiDisks (VmInfoBuildUtilsTest). The test ensures that the SCSI address unit index of the boot disk is lower than the non-boot disk. Change-Id: Id87e1b7a06e6327c6033d41088e6712807a85138 Bug-Url: https://bugzilla.redhat.com/?????? Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/builder/vminfo/VmInfoBuildUtilsTest.java 1 file changed, 81 insertions(+), 0 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/70984 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id87e1b7a06e6327c6033d41088e6712807a85138 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: rename disks variable
by Code Review 25 Jan '17

25 Jan '17

>From Daniel Erez <derez(a)redhat.com>: Daniel Erez has submitted this change and it was merged. Change subject: core: rename disks variable ...................................................................... core: rename disks variable VmInfoBuildUtils -> getSortedDisks: rename 'diskImages' to 'disks' (as the method sorts 'Disk' entities). Change-Id: I4b4fa76dd324c8a9ff7a166e8122ba3aaf10e064 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/builder/vminfo/VmInfoBuildUtils.java 1 file changed, 4 insertions(+), 6 deletions(-) Approvals: Jenkins CI: Passed CI tests Daniel Erez: Verified Maor Lipchuk: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/70964 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4b4fa76dd324c8a9ff7a166e8122ba3aaf10e064 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: rename DiskImageByBootAndSnapshotComparator
by Code Review 25 Jan '17

25 Jan '17

>From Daniel Erez <derez(a)redhat.com>: Daniel Erez has submitted this change and it was merged. Change subject: core: rename DiskImageByBootAndSnapshotComparator ...................................................................... core: rename DiskImageByBootAndSnapshotComparator Rename comparator as it's applicable for any type of disk: DiskImageByBootAndSnapshotComparator -> DiskByBootAndSnapshotComparator. Change-Id: Ida40f6f544308e1268e646c1638352ee7ccf545b Signed-off-by: Daniel Erez <derez(a)redhat.com> --- R backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/builder/vminfo/DiskByBootAndSnapshotComparator.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/builder/vminfo/VmInfoBuildUtils.java 2 files changed, 3 insertions(+), 3 deletions(-) Approvals: Jenkins CI: Passed CI tests Daniel Erez: Verified Maor Lipchuk: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/70963 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ida40f6f544308e1268e646c1638352ee7ccf545b Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: sort disks by boot order before setting scsi address
by Code Review 25 Jan '17

25 Jan '17

>From Daniel Erez <derez(a)redhat.com>: Daniel Erez has submitted this change and it was merged. Change subject: core: sort disks by boot order before setting scsi address ...................................................................... core: sort disks by boot order before setting scsi address VmInfoBuildUtils -> getVmDeviceUnitMapForScsiDisks: Sort VM's disks by boot order prior to setting SCSI address unit. This is done to ensure that a bootable disk gets an higher priority in unit index of the SCSI controller. Change-Id: I9f8a5a45ec284ebe4fcba9596f177d26986afd71 Bug-Url: https://bugzilla.redhat.com/1336708 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/builder/vminfo/VmInfoBuildUtils.java 1 file changed, 9 insertions(+), 8 deletions(-) Approvals: Jenkins CI: Passed CI tests Daniel Erez: Verified Maor Lipchuk: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/70962 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9f8a5a45ec284ebe4fcba9596f177d26986afd71 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: Fix iSCSI domain layout
by Code Review 25 Jan '17

25 Jan '17

>From Daniel Erez <derez(a)redhat.com>: Daniel Erez has submitted this change and it was merged. Change subject: webadmin: Fix iSCSI domain layout ...................................................................... webadmin: Fix iSCSI domain layout - Switching the iSCSI layout to bootstrap I removed a litte too much css which caused the tabs to be wrong. This patch fixes that change. Change-Id: I401bee2e28bda0e4e84165465135247e196cae06 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/dialog/tab/DialogTabPanel.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/IscsiStorageView.ui.xml M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/StoragePopupView.ui.xml 3 files changed, 43 insertions(+), 12 deletions(-) Approvals: Alexander Wels: Verified Daniel Erez: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/71132 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I401bee2e28bda0e4e84165465135247e196cae06 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: sysprep: Change symlink to real file due to build errors
by Code Review 25 Jan '17

25 Jan '17

>From Shahar Havivi <shavivi(a)redhat.com>: Shahar Havivi has submitted this change and it was merged. Change subject: sysprep: Change symlink to real file due to build errors ...................................................................... sysprep: Change symlink to real file due to build errors Change-Id: I8f437bc12b9d06c2e611056f024268d93074e5e6 Bug-Url: https://bugzilla.redhat.com/1388724 Signed-off-by: Vinzenz Feenstra <vfeenstr(a)redhat.com> --- D packaging/conf/sysprep/sysprep.2k16x64 A packaging/conf/sysprep/sysprep.2k16x64 2 files changed, 80 insertions(+), 1 deletion(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Vinzenz Feenstra: Verified -- To view, visit https://gerrit.ovirt.org/69750 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8f437bc12b9d06c2e611056f024268d93074e5e6 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: move getSortedDisks method to VmInfoBuildUtils
by Code Review 25 Jan '17

25 Jan '17

>From Daniel Erez <derez(a)redhat.com>: Daniel Erez has submitted this change and it was merged. Change subject: core: move getSortedDisks method to VmInfoBuildUtils ...................................................................... core: move getSortedDisks method to VmInfoBuildUtils Moved 'getSortedDisks' method to VmInfoBuildUtils for reusability. Change-Id: Ie539ed68b8b4cf51ffc5c4556f484f74652986c2 Bug-Url: https://bugzilla.redhat.com/1336708 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/builder/vminfo/VmInfoBuildUtils.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/builder/vminfo/VmInfoBuilderImpl.java 2 files changed, 13 insertions(+), 13 deletions(-) Approvals: Jenkins CI: Passed CI tests Daniel Erez: Verified Maor Lipchuk: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/70983 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie539ed68b8b4cf51ffc5c4556f484f74652986c2 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: make AddVmCommandTestBase derrivatives strict
by Code Review 25 Jan '17

25 Jan '17

>From Moti Asayag <masayag(a)redhat.com>: Moti Asayag has submitted this change and it was merged. Change subject: engine: make AddVmCommandTestBase derrivatives strict ...................................................................... engine: make AddVmCommandTestBase derrivatives strict Move the non-common mock expectations into the test cases that actively use them and by that enable using "strict" runner. Change-Id: I6a92e525e878b5de5bcd64691ce761553cf24a2d Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddVmCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddVmCommandTestBase.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddVmFromSnapshotCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddVmFromTemplateCommandTest.java 4 files changed, 49 insertions(+), 71 deletions(-) Approvals: Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved Yevgeny Zaspitsky: Verified -- To view, visit https://gerrit.ovirt.org/71122 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6a92e525e878b5de5bcd64691ce761553cf24a2d Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: remove AddVmCommandTest.createDiskSnapshot method
by Code Review 25 Jan '17

25 Jan '17

>From Moti Asayag <masayag(a)redhat.com>: Moti Asayag has submitted this change and it was merged. Change subject: engine: remove AddVmCommandTest.createDiskSnapshot method ...................................................................... engine: remove AddVmCommandTest.createDiskSnapshot method AddVmCommandTest.createDiskSnapshot is the exact copy of the method it overrides from the base class, thus is removed. Change-Id: I56e65b45e5657a0444caae0298a31f24bbff2801 Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddVmCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddVmCommandTestBase.java 2 files changed, 1 insertion(+), 17 deletions(-) Approvals: Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved Yevgeny Zaspitsky: Verified -- To view, visit https://gerrit.ovirt.org/71123 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I56e65b45e5657a0444caae0298a31f24bbff2801 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: remove redundant mock expectations from AddVmCommand...
by Code Review 25 Jan '17

25 Jan '17

>From Moti Asayag <masayag(a)redhat.com>: Moti Asayag has submitted this change and it was merged. Change subject: engine: remove redundant mock expectations from AddVmCommandTestBase ...................................................................... engine: remove redundant mock expectations from AddVmCommandTestBase Remove redundant mock expectations from AddVmCommandTestBase and AddVmFromTemplateCommandTest and by that enable the last to use the "strict" runner. Change-Id: I16e62087dccbc2a475a0260f50f47137f11b0859 Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddVmCommandTestBase.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddVmFromTemplateCommandTest.java 2 files changed, 2 insertions(+), 11 deletions(-) Approvals: Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved Yevgeny Zaspitsky: Verified -- To view, visit https://gerrit.ovirt.org/71121 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I16e62087dccbc2a475a0260f50f47137f11b0859 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0