Change in ovirt-engine[master]: packaging: ovirt-engine-hosts-ansible-inventory: handle date...
by Code Review
>From Sandro Bonazzola <sbonazzo(a)redhat.com>:
Sandro Bonazzola has submitted this change and it was merged.
Change subject: packaging: ovirt-engine-hosts-ansible-inventory: handle datetime
......................................................................
packaging: ovirt-engine-hosts-ansible-inventory: handle datetime
Convert to strings datetime values, as json can't serialize them.
Change-Id: I786657d3d0f4292bd1d230e4aedb111c43bded1b
Bug-Url: https://bugzilla.redhat.com/1416218
Signed-off-by: Yedidyah Bar David <didi(a)redhat.com>
---
M packaging/setup/bin/ovirt-engine-hosts-ansible-inventory
1 file changed, 9 insertions(+), 1 deletion(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved
Jenkins CI: Passed CI tests
Yedidyah Bar David: Verified
--
To view, visit https://gerrit.ovirt.org/71130
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I786657d3d0f4292bd1d230e4aedb111c43bded1b
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 11 months
Change in ovirt-engine[master]: http: use protocol which is understood by http client
by Code Review
>From Martin Peřina <mperina(a)redhat.com>:
Martin Peřina has submitted this change and it was merged.
Change subject: http: use protocol which is understood by http client
......................................................................
http: use protocol which is understood by http client
We still use http client for commands like UploadStreamVDSCommand.
The client uses older code which has no knowledge about 'TLS' set of
protocols so we need to narrow it down to specific version.
Bug-Url: https://bugzilla.redhat.com/1412547
Change-Id: I8087dd4734cedec885bf6dcdf008cfffe6d148ce
Signed-off-by: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ssl/AuthSSLProtocolSocketFactory.java
M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql
3 files changed, 13 insertions(+), 22 deletions(-)
Approvals:
Martin Peřina: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/70918
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8087dd4734cedec885bf6dcdf008cfffe6d148ce
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 11 months
Change in ovirt-engine[master]: ui: Disable Sparsify for direct LUNs and Cinder disks
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: ui: Disable Sparsify for direct LUNs and Cinder disks
......................................................................
ui: Disable Sparsify for direct LUNs and Cinder disks
SparsifyImageCommand doesn't support direct LUNs and Cinder disks. For
this reason, 'Sparsify' button is disabled in UI for these types of
disks.
Change-Id: I44beaebb3d3c3cd187441d0ec02cff890aaa6dc4
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1414867
Signed-off-by: Shmuel Melamud <smelamud(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmDiskListModel.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Shmuel Leib Melamud: Verified
Idan Shaby: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/70978
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I44beaebb3d3c3cd187441d0ec02cff890aaa6dc4
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shmuel Leib Melamud <smelamud(a)redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 11 months
Change in ovirt-engine[master]: engine: remove redundant mock expectations from HostValidato...
by Code Review
>From Allon Mureinik <amureini(a)redhat.com>:
Allon Mureinik has submitted this change and it was merged.
Change subject: engine: remove redundant mock expectations from HostValidatorTest
......................................................................
engine: remove redundant mock expectations from HostValidatorTest
Change-Id: I8856a1acceeb81ecbfe795a971e920e872e3ef1d
Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/HostValidatorTest.java
1 file changed, 4 insertions(+), 17 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Allon Mureinik: Looks good to me, approved
Moti Asayag: Looks good to me, approved
Yevgeny Zaspitsky: Verified
--
To view, visit https://gerrit.ovirt.org/71108
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8856a1acceeb81ecbfe795a971e920e872e3ef1d
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 11 months
Change in ovirt-engine[master]: webadmin: target login button - remove style manipulation
by Code Review
>From Daniel Erez <derez(a)redhat.com>:
Daniel Erez has submitted this change and it was merged.
Change subject: webadmin: target login button - remove style manipulation
......................................................................
webadmin: target login button - remove style manipulation
Removed style manipulation from Login button, as it's causing
a NullPointerException since we moved to Bootstrap buttons.
Change-Id: Ic9f1b8415d3c1aa098e620806e90e5558d82df1f
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/SanStorageTargetToLunList.java
1 file changed, 0 insertions(+), 4 deletions(-)
Approvals:
Alexander Wels: Looks good to me, approved
Daniel Erez: Verified
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/70976
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic9f1b8415d3c1aa098e620806e90e5558d82df1f
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 11 months
Change in ovirt-engine[master]: scheduler: Remove cluster upgrade policy from the database t...
by Code Review
>From Martin Sivák <msivak(a)redhat.com>:
Martin Sivák has submitted this change and it was merged.
Change subject: scheduler: Remove cluster upgrade policy from the database table
......................................................................
scheduler: Remove cluster upgrade policy from the database table
The previous commit only deleted the policy units for the policy but not
the policy itself.
Change-Id: I3b18ca5383b7734f863087f56e34f549790080b6
Bug-Url: https://bugzilla.redhat.com/1343440
Signed-off-by: Roman Mohr <rmohr(a)redhat.com>
---
A packaging/dbscripts/upgrade/04_02_0100_remove_el7_upgrade_policy.sql
1 file changed, 4 insertions(+), 0 deletions(-)
Approvals:
Martin Sivák: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/58802
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3b18ca5383b7734f863087f56e34f549790080b6
Gerrit-PatchSet: 15
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 11 months
Change in ovirt-engine[master]: packaging: pythonlib: service: Add time zone to log records
by Code Review
>From Sandro Bonazzola <sbonazzo(a)redhat.com>:
Sandro Bonazzola has submitted this change and it was merged.
Change subject: packaging: pythonlib: service: Add time zone to log records
......................................................................
packaging: pythonlib: service: Add time zone to log records
Adds time zone to log records for all python services in engine, like
ovirt-fence-kdump-listener and ovirt-websocket-proxy.
Sample output:
2017-01-17 13:44:23,135+0100 ovirt-websocket-proxy: INFO msg:871 - Listen on *:6100
2017-01-17 13:44:23,135+0100 ovirt-websocket-proxy: INFO msg:871 - Flash security policy server
2017-01-17 13:44:23,136+0100 ovirt-websocket-proxy: INFO msg:871 - SSL/TLS support
2017-01-17 13:44:23,136+0100 ovirt-websocket-proxy: INFO msg:871 - Deny non-SSL/TLS connections
2017-01-17 13:44:23,137+0100 ovirt-websocket-proxy: INFO msg:871 - proxying from *:6100 to targets generated by str
Change-Id: Icbac46cf8e8062179dc389df2cb9eb448beb8646
Bug-Url: https://bugzilla.redhat.com/1408193
Signed-off-by: Martin Perina <mperina(a)redhat.com>
---
M ovirt-engine.spec.in
M packaging/pythonlib/ovirt_engine/service.py
2 files changed, 23 insertions(+), 0 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved
Martin Peřina: Verified
Yaniv Bronhaim: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/70114
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icbac46cf8e8062179dc389df2cb9eb448beb8646
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 11 months
Change in ovirt-engine[ovirt-engine-4.1]: core: StorageJobCallback - jobs fencing
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: core: StorageJobCallback - jobs fencing
......................................................................
core: StorageJobCallback - jobs fencing
When a job status can't be detected using entity polling the
StorageJobCallback will attempt to fence it in case it hasn't
started yet (when a job starts it's persisted in the command
parameters).
This patch changes the logic to attempt to fence the job even if it has
started, in case the job status can't be determined using entity polling
performing the fencing logic can confirm us that the operation has
failed on the next entity polling round.
Additionally, if the job has started and is stuck on a storage operation
we can still attempt to fence it using the entity. As the job should
modify the entity only after acquiring a cluster lock on it.
Change-Id: Ifdbab1c6e898b7791e6b05b62684f036c23cc3d4
Bug-Url: https://bugzilla.redhat.com/1415502
Signed-off-by: Liron Aravot <laravot(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/StorageJobCallback.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/StorageJobCommandParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/HostJobInfo.java
3 files changed, 11 insertions(+), 35 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Freddy Rolland: Looks good to me, but someone else must approve
Liron Aravot: Verified
--
To view, visit https://gerrit.ovirt.org/71100
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifdbab1c6e898b7791e6b05b62684f036c23cc3d4
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1
Gerrit-Owner: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 11 months
Change in ovirt-engine[master]: engine: remove redundant mock expectations from ClusterValid...
by Code Review
>From Moti Asayag <masayag(a)redhat.com>:
Moti Asayag has submitted this change and it was merged.
Change subject: engine: remove redundant mock expectations from ClusterValidatorTest
......................................................................
engine: remove redundant mock expectations from ClusterValidatorTest
Change-Id: I7945f4593ef2bbb9b68717a888455b034ebfd27d
Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/ClusterValidatorTest.java
1 file changed, 3 insertions(+), 9 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Moti Asayag: Looks good to me, approved
Yevgeny Zaspitsky: Verified
--
To view, visit https://gerrit.ovirt.org/71103
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7945f4593ef2bbb9b68717a888455b034ebfd27d
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 11 months
Change in jenkins[master]: ovirt-wgt: Move to 4.1 branch
by Code Review
>From Sandro Bonazzola <sbonazzo(a)redhat.com>:
Sandro Bonazzola has submitted this change and it was merged.
Change subject: ovirt-wgt: Move to 4.1 branch
......................................................................
ovirt-wgt: Move to 4.1 branch
Also clean up the file to be ordered like others - from newest branch to
oldest.
Change-Id: I4c5cf2b1d63ea416c1b6ab20670cc81b042cb7ba
Signed-off-by: Yedidyah Bar David <didi(a)redhat.com>
---
M jobs/confs/projects/ovirt-wgt/ovirt-wgt_create-rpms.yaml
M jobs/confs/projects/ovirt/publish-rpms-nightly-4.1.yaml
2 files changed, 22 insertions(+), 14 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved; Ready for merge
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/71098
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4c5cf2b1d63ea416c1b6ab20670cc81b042cb7ba
Gerrit-PatchSet: 3
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 11 months