January 2017 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Create default ctor for HttpLocationInfo
by Code Review 18 Jan '17

18 Jan '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: core: Create default ctor for HttpLocationInfo ...................................................................... core: Create default ctor for HttpLocationInfo Create default ctor for HttpLocationInfo to allow json serialization and storage of the command in DB Bug-Url: https://bugzilla.redhat.com/1414288 Change-Id: I95a7647db9971b3b8a2a68db152994be50998c0d Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/HttpLocationInfo.java 1 file changed, 5 insertions(+), 1 deletion(-) Approvals: Piotr Kliczewski: Verified; Looks good to me, approved Martin Peřina: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/70738 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I95a7647db9971b3b8a2a68db152994be50998c0d Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in gerrit-admin[master]: Fix get_bug_info function (patch #2)
by Code Review 18 Jan '17

18 Jan '17

>From Shlomo Ben David <sbendavi(a)redhat.com>: Shlomo Ben David has submitted this change and it was merged. Change subject: Fix get_bug_info function (patch #2) ...................................................................... Fix get_bug_info function (patch #2) Change-Id: If7278be4c908e801b900e0346aadcdb3b9914f13 Signed-off-by: Shlomi Ben-David <sbendavi(a)redhat.com> --- M hooks/custom_hooks/check_backport M hooks/custom_hooks/check_product M hooks/custom_hooks/check_target_milestone M hooks/custom_hooks/set_modified M hooks/custom_hooks/set_post 5 files changed, 5 insertions(+), 1 deletion(-) Approvals: Shlomo Ben David: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/70745 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If7278be4c908e801b900e0346aadcdb3b9914f13 Gerrit-PatchSet: 1 Gerrit-Project: gerrit-admin Gerrit-Branch: master Gerrit-Owner: Shlomo Ben David <sbendavi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: minor refactoring in vm devices monitoring
by Code Review 18 Jan '17

18 Jan '17

>From Arik Hadas <ahadas(a)redhat.com>: Arik Hadas has submitted this change and it was merged. Change subject: core: minor refactoring in vm devices monitoring ...................................................................... core: minor refactoring in vm devices monitoring Change-Id: Ice387f9e32e3343a155b1e3daf1af76406afc715 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmDevicesMonitoring.java 1 file changed, 24 insertions(+), 20 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Shmuel Leib Melamud: Looks good to me, but someone else must approve Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/70727 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ice387f9e32e3343a155b1e3daf1af76406afc715 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: avoid PollVDSCommand to fail upon VDSNetworkException
by Code Review 18 Jan '17

18 Jan '17

>From Piotr Kliczewski <piotr.kliczewski(a)gmail.com>: Piotr Kliczewski has submitted this change and it was merged. Change subject: engine: avoid PollVDSCommand to fail upon VDSNetworkException ...................................................................... engine: avoid PollVDSCommand to fail upon VDSNetworkException Change-Id: Ib2053529c995dac712f89bd1fb45c912b9cc35f3 Bug-Url: https://bugzilla.redhat.com/1408175 Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/PollVDSCommand.java 1 file changed, 13 insertions(+), 0 deletions(-) Approvals: Piotr Kliczewski: Looks good to me, approved Jenkins CI: Passed CI tests Yevgeny Zaspitsky: Verified -- To view, visit https://gerrit.ovirt.org/69108 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib2053529c995dac712f89bd1fb45c912b9cc35f3 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: log exceptions in vm devices monitoring
by Code Review 18 Jan '17

18 Jan '17

>From Arik Hadas <ahadas(a)redhat.com>: Arik Hadas has submitted this change and it was merged. Change subject: core: log exceptions in vm devices monitoring ...................................................................... core: log exceptions in vm devices monitoring Add log print of runtime exceptions that are thrown during VM devices monitoring to ease debugging. Change-Id: I3f0c885c2a1e4207ba64a753a9483a33ae640fef Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmDevicesMonitoring.java 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Shmuel Leib Melamud: Looks good to me, but someone else must approve Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/70726 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3f0c885c2a1e4207ba64a753a9483a33ae640fef Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: StorageJobCallback - prevent NPE when there is no exec...
by Code Review 18 Jan '17

18 Jan '17

>From Liron Aravot <laravot(a)redhat.com>: Liron Aravot has submitted this change and it was merged. Change subject: core: StorageJobCallback - prevent NPE when there is no executing host ...................................................................... core: StorageJobCallback - prevent NPE when there is no executing host When there is no executing host (may happen when hosts go no responsive during the command execution for example), the StorageJobCallback may fail with NPE when attempting to check the host status. This patch prevents it, if there is no executing host the job status can be considered as failed. Change-Id: I394c6b6a88bee9ef58d25b4e7bd3e880685b9100 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/StorageJobCallback.java 1 file changed, 50 insertions(+), 43 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Freddy Rolland: Looks good to me, but someone else must approve Liron Aravot: Verified -- To view, visit https://gerrit.ovirt.org/70724 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I394c6b6a88bee9ef58d25b4e7bd3e880685b9100 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: aaa: Username is mandatory for LoginOnBehalf
by Code Review 18 Jan '17

18 Jan '17

>From Martin Peřina <mperina(a)redhat.com>: Martin Peřina has submitted this change and it was merged. Change subject: aaa: Username is mandatory for LoginOnBehalf ...................................................................... aaa: Username is mandatory for LoginOnBehalf If user name is not passed for LoginOnBehalf SSO should reject the request and return an error message. Change-Id: I85cc8b5788b0d451eb9016bcb03c33ced5db5a77 Bug-Url: https://bugzilla.redhat.com/1414083 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/servlets/OAuthTokenServlet.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Martin Peřina: Looks good to me, approved Ravi Nori: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/70692 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I85cc8b5788b0d451eb9016bcb03c33ced5db5a77 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: gluster: fix option listing issue in set options
by Code Review 18 Jan '17

18 Jan '17

>From Tomas Jelinek <tjelinek(a)redhat.com>: Tomas Jelinek has submitted this change and it was merged. Change subject: gluster: fix option listing issue in set options ...................................................................... gluster: fix option listing issue in set options We were using a Combo box but it is not working as expected. Instead of Combo box, I moved this to ListModelTypeAheadChangeableListBoxEditor Change-Id: I09314f09096fb4be9cd81f63a456d1f1b0a45fdf Bug-Url: https://bugzilla.redhat.com/1408803 Signed-off-by: Ramesh Nachimuthu <rnachimu(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeParameterListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeParameterModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/VolumeParameterPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/VolumeParameterPopupView.ui.xml 4 files changed, 102 insertions(+), 121 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Jenkins CI: Passed CI tests Sahina Bose: Looks good to me, but someone else must approve Ramesh N: Verified -- To view, visit https://gerrit.ovirt.org/69998 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I09314f09096fb4be9cd81f63a456d1f1b0a45fdf Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: Remove node-filter from 'jenkins' repo jobs
by Code Review 18 Jan '17

18 Jan '17

>From Eyal Edri <eedri(a)redhat.com>: Eyal Edri has submitted this change and it was merged. Change subject: Remove node-filter from 'jenkins' repo jobs ...................................................................... Remove node-filter from 'jenkins' repo jobs These jobs ase for testing the Standard-CI scripts themselves. It is better to have them run on multipile platforms to ensure thigs stay compatibile. Change-Id: I92af52323aae4761bd0047d18ebe01ca5b13fa41 Jira-Ticket: https://ovirt-jira.atlassian.net/browse/OVIRT-1032 Signed-off-by: Barak Korren <bkorren(a)redhat.com> --- M jobs/confs/projects/jenkins/jenkins_standard.yaml 1 file changed, 1 insertion(+), 3 deletions(-) Approvals: Eyal Edri: Looks good to me, approved; Ready for merge Barak Korren: Verified; Ready for review Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/70702 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I92af52323aae4761bd0047d18ebe01ca5b13fa41 Gerrit-PatchSet: 2 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: David Caro <david(a)dcaro.es> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nadav Goldin <ngoldin(a)redhat.com> Gerrit-Reviewer: Pavel Zhukov <pavel(a)zhukoff.net> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: build: post ovirt-engine-4.1.0 RC
by Code Review 18 Jan '17

18 Jan '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: build: post ovirt-engine-4.1.0 RC ...................................................................... build: post ovirt-engine-4.1.0 RC Change-Id: I79182919b98bb4f7e2272af75fc35ed01da70bf1 Signed-off-by: Lev Veyde <lveyde(a)redhat.com> --- M automation/build-artifacts.sh M backend/manager/dependencies/common/pom.xml M backend/manager/dependencies/pom.xml M backend/manager/dependencies/tools/pom.xml M backend/manager/extensions-tool/pom.xml M backend/manager/modules/aaa/pom.xml M backend/manager/modules/auth-plugin/pom.xml M backend/manager/modules/bll/pom.xml M backend/manager/modules/branding/pom.xml M backend/manager/modules/builtin-extensions/pom.xml M backend/manager/modules/common/pom.xml M backend/manager/modules/compat/pom.xml M backend/manager/modules/dal/pom.xml M backend/manager/modules/docs/pom.xml M backend/manager/modules/enginesso/pom.xml M backend/manager/modules/extensions-api-root/extensions-api/pom.xml M backend/manager/modules/extensions-api-root/pom.xml M backend/manager/modules/extensions-manager/pom.xml M backend/manager/modules/logger/pom.xml M backend/manager/modules/pom.xml M backend/manager/modules/restapi/apidoc/pom.xml M backend/manager/modules/restapi/interface/common/jaxrs/pom.xml M backend/manager/modules/restapi/interface/common/pom.xml M backend/manager/modules/restapi/interface/definition/pom.xml M backend/manager/modules/restapi/interface/pom.xml M backend/manager/modules/restapi/jaxrs/pom.xml M backend/manager/modules/restapi/pom.xml M backend/manager/modules/restapi/types/pom.xml M backend/manager/modules/restapi/webapp/pom.xml M backend/manager/modules/root/pom.xml M backend/manager/modules/scheduler/pom.xml M backend/manager/modules/searchbackend/pom.xml M backend/manager/modules/services/pom.xml M backend/manager/modules/utils/pom.xml M backend/manager/modules/uutils/pom.xml M backend/manager/modules/vdsbroker/pom.xml M backend/manager/modules/welcome/pom.xml M backend/manager/pom.xml M backend/manager/tools/pom.xml M backend/pom.xml M build-tools-root/checkstyles/pom.xml M build-tools-root/ovirt-checkstyle-extension/pom.xml M build-tools-root/ovirt-findbugs-filters/pom.xml M build-tools-root/pom.xml M build/validations/pom.xml M ear/pom.xml M frontend/pom.xml M frontend/webadmin/modules/frontend-symbols/pom.xml M frontend/webadmin/modules/frontend/pom.xml M frontend/webadmin/modules/gwt-common/pom.xml M frontend/webadmin/modules/gwt-extension/pom.xml M frontend/webadmin/modules/pom.xml M frontend/webadmin/modules/uicommonweb/pom.xml M frontend/webadmin/modules/uicompat/pom.xml M frontend/webadmin/modules/userportal-gwtp/pom.xml M frontend/webadmin/modules/webadmin/pom.xml M frontend/webadmin/pom.xml M mavenmake/pom.xml M ovirt-engine.spec.in M pom.xml M version.mak 61 files changed, 68 insertions(+), 62 deletions(-) Approvals: Tal Nisan: Passed CI tests Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/70141 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I79182919b98bb4f7e2272af75fc35ed01da70bf1 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0