January 2017 - Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-4.1]: build: ovirt-engine-4.1.0 RC
by Code Review 18 Jan '17

18 Jan '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: build: ovirt-engine-4.1.0 RC ...................................................................... build: ovirt-engine-4.1.0 RC Change-Id: I2e81a3c4f6377f3f0df0a34586cb4a143ac1cd3b Signed-off-by: Lev Veyde <lveyde(a)redhat.com> --- M automation/build-artifacts.sh M backend/manager/dependencies/common/pom.xml M backend/manager/dependencies/pom.xml M backend/manager/dependencies/tools/pom.xml M backend/manager/extensions-tool/pom.xml M backend/manager/modules/aaa/pom.xml M backend/manager/modules/auth-plugin/pom.xml M backend/manager/modules/bll/pom.xml M backend/manager/modules/branding/pom.xml M backend/manager/modules/builtin-extensions/pom.xml M backend/manager/modules/common/pom.xml M backend/manager/modules/compat/pom.xml M backend/manager/modules/dal/pom.xml M backend/manager/modules/docs/pom.xml M backend/manager/modules/enginesso/pom.xml M backend/manager/modules/extensions-api-root/extensions-api/pom.xml M backend/manager/modules/extensions-api-root/pom.xml M backend/manager/modules/extensions-manager/pom.xml M backend/manager/modules/logger/pom.xml M backend/manager/modules/pom.xml M backend/manager/modules/restapi/apidoc/pom.xml M backend/manager/modules/restapi/interface/common/jaxrs/pom.xml M backend/manager/modules/restapi/interface/common/pom.xml M backend/manager/modules/restapi/interface/definition/pom.xml M backend/manager/modules/restapi/interface/pom.xml M backend/manager/modules/restapi/jaxrs/pom.xml M backend/manager/modules/restapi/pom.xml M backend/manager/modules/restapi/types/pom.xml M backend/manager/modules/restapi/webapp/pom.xml M backend/manager/modules/root/pom.xml M backend/manager/modules/scheduler/pom.xml M backend/manager/modules/searchbackend/pom.xml M backend/manager/modules/services/pom.xml M backend/manager/modules/utils/pom.xml M backend/manager/modules/uutils/pom.xml M backend/manager/modules/vdsbroker/pom.xml M backend/manager/modules/welcome/pom.xml M backend/manager/pom.xml M backend/manager/tools/pom.xml M backend/pom.xml M build-tools-root/checkstyles/pom.xml M build-tools-root/ovirt-checkstyle-extension/pom.xml M build-tools-root/ovirt-findbugs-filters/pom.xml M build-tools-root/pom.xml M build/validations/pom.xml M ear/pom.xml M frontend/pom.xml M frontend/webadmin/modules/frontend-symbols/pom.xml M frontend/webadmin/modules/frontend/pom.xml M frontend/webadmin/modules/gwt-common/pom.xml M frontend/webadmin/modules/gwt-extension/pom.xml M frontend/webadmin/modules/pom.xml M frontend/webadmin/modules/uicommonweb/pom.xml M frontend/webadmin/modules/uicompat/pom.xml M frontend/webadmin/modules/userportal-gwtp/pom.xml M frontend/webadmin/modules/webadmin/pom.xml M frontend/webadmin/pom.xml M mavenmake/pom.xml M ovirt-engine.spec.in M pom.xml M version.mak 61 files changed, 63 insertions(+), 66 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/70095 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2e81a3c4f6377f3f0df0a34586cb4a143ac1cd3b Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: core: Remore redundant equals sign in audit log messages
by Code Review 18 Jan '17

18 Jan '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: core: Remore redundant equals sign in audit log messages ...................................................................... core: Remore redundant equals sign in audit log messages Change-Id: I9b010ea6d5311df09ceed1e68b6878086cf12cb2 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tal Nisan: Verified; Passed CI tests Liron Aravot: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/70712 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9b010ea6d5311df09ceed1e68b6878086cf12cb2 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: packaging: Configure hosts for metrics
by Code Review 18 Jan '17

18 Jan '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: packaging: Configure hosts for metrics ...................................................................... packaging: Configure hosts for metrics Copied parts from opstools-ansible. Bug-Url: https://bugzilla.redhat.com/1405813 Change-Id: If8766ac271ee908d4a5268780c93c9f15c047be7 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> (cherry picked from commit 79780d6285e3479a0bc5954d9491b30d4904f5c0) --- M ovirt-engine.spec.in A packaging/setup/ansible/ansible.cfg A packaging/setup/ansible/config.yml.example A packaging/setup/ansible/configure_ovirt_hosts_for_metrics.sh A packaging/setup/ansible/group_vars/all.yml A packaging/setup/ansible/inventory/dynamic_ovirt_hosts A packaging/setup/ansible/inventory/hosts A packaging/setup/ansible/playbook.yml A packaging/setup/ansible/roles/collectd/defaults/main.yml A packaging/setup/ansible/roles/collectd/handlers/main.yml A packaging/setup/ansible/roles/collectd/tasks/main.yml A packaging/setup/ansible/roles/firewall/README.md A packaging/setup/ansible/roles/firewall/commit/README.md A packaging/setup/ansible/roles/firewall/commit/meta/main.yml A packaging/setup/ansible/roles/firewall/commit/tasks/main.yml A packaging/setup/ansible/roles/firewall/defaults/main.yml A packaging/setup/ansible/roles/firewall/handlers/main.yml A packaging/setup/ansible/roles/firewall/tasks/main.yml A packaging/setup/ansible/roles/fluentd/defaults/main.yml A packaging/setup/ansible/roles/fluentd/handlers/main.yml A packaging/setup/ansible/roles/fluentd/tasks/main.yml A packaging/setup/ansible/roles/fluentd/templates/fluentd.conf A packaging/setup/ansible/roles/ovirt_collectd/ovirt_host/tasks/main.yml A packaging/setup/ansible/roles/ovirt_collectd/ovirt_host/templates/20-builtins-conf-for-ovirt.conf.j2 A packaging/setup/ansible/roles/ovirt_collectd/read_statsd/defaults/main.yml A packaging/setup/ansible/roles/ovirt_collectd/read_statsd/tasks/main.yml A packaging/setup/ansible/roles/ovirt_collectd/read_statsd/templates/10-read-statsd.conf.j2 A packaging/setup/ansible/roles/ovirt_collectd/write_http/defaults/main.yml A packaging/setup/ansible/roles/ovirt_collectd/write_http/tasks/main.yml A packaging/setup/ansible/roles/ovirt_collectd/write_http/templates/10-write-http.conf.j2 A packaging/setup/ansible/roles/ovirt_fluentd/client/README.md A packaging/setup/ansible/roles/ovirt_fluentd/client/defaults/main.yml A packaging/setup/ansible/roles/ovirt_fluentd/client/meta/main.yml A packaging/setup/ansible/roles/ovirt_fluentd/client/tasks/main.yml A packaging/setup/ansible/roles/ovirt_fluentd/client/templates/forward_no_ssl.conf A packaging/setup/ansible/roles/ovirt_fluentd/client/templates/forward_ssl.conf A packaging/setup/ansible/roles/ovirt_fluentd/http_input/README.md A packaging/setup/ansible/roles/ovirt_fluentd/http_input/defaults/main.yml A packaging/setup/ansible/roles/ovirt_fluentd/http_input/meta/main.yml A packaging/setup/ansible/roles/ovirt_fluentd/http_input/tasks/main.yml A packaging/setup/ansible/roles/ovirt_fluentd/http_input/templates/http-input.conf A packaging/setup/ansible/roles/ovirt_fluentd/ovirt_host/README.md A packaging/setup/ansible/roles/ovirt_fluentd/ovirt_host/meta/main.yml A packaging/setup/ansible/roles/ovirt_fluentd/ovirt_host/tasks/main.yml A packaging/setup/ansible/roles/ovirt_fluentd/ovirt_host/templates/ovirt-processing.conf A packaging/setup/ansible/roles/ovirt_fluentd/read_local_ca_cert/README.md A packaging/setup/ansible/roles/ovirt_fluentd/read_local_ca_cert/defaults/main.yml A packaging/setup/ansible/roles/ovirt_fluentd/read_local_ca_cert/tasks/main.yml A packaging/setup/ansible/tools/validate-playbooks 49 files changed, 797 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Jenkins CI: Passed CI tests Yedidyah Bar David: Verified -- To view, visit https://gerrit.ovirt.org/70708 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If8766ac271ee908d4a5268780c93c9f15c047be7 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: packaging: Configure hosts for metrics
by Code Review 18 Jan '17

18 Jan '17

>From Sandro Bonazzola <sbonazzo(a)redhat.com>: Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: Configure hosts for metrics ...................................................................... packaging: Configure hosts for metrics Copied parts from opstools-ansible. Bug-Url: https://bugzilla.redhat.com/1405813 Change-Id: If8766ac271ee908d4a5268780c93c9f15c047be7 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M ovirt-engine.spec.in A packaging/setup/ansible/ansible.cfg A packaging/setup/ansible/config.yml.example A packaging/setup/ansible/configure_ovirt_hosts_for_metrics.sh A packaging/setup/ansible/group_vars/all.yml A packaging/setup/ansible/inventory/dynamic_ovirt_hosts A packaging/setup/ansible/inventory/hosts A packaging/setup/ansible/playbook.yml A packaging/setup/ansible/roles/collectd/defaults/main.yml A packaging/setup/ansible/roles/collectd/handlers/main.yml A packaging/setup/ansible/roles/collectd/tasks/main.yml A packaging/setup/ansible/roles/firewall/README.md A packaging/setup/ansible/roles/firewall/commit/README.md A packaging/setup/ansible/roles/firewall/commit/meta/main.yml A packaging/setup/ansible/roles/firewall/commit/tasks/main.yml A packaging/setup/ansible/roles/firewall/defaults/main.yml A packaging/setup/ansible/roles/firewall/handlers/main.yml A packaging/setup/ansible/roles/firewall/tasks/main.yml A packaging/setup/ansible/roles/fluentd/defaults/main.yml A packaging/setup/ansible/roles/fluentd/handlers/main.yml A packaging/setup/ansible/roles/fluentd/tasks/main.yml A packaging/setup/ansible/roles/fluentd/templates/fluentd.conf A packaging/setup/ansible/roles/ovirt_collectd/ovirt_host/tasks/main.yml A packaging/setup/ansible/roles/ovirt_collectd/ovirt_host/templates/20-builtins-conf-for-ovirt.conf.j2 A packaging/setup/ansible/roles/ovirt_collectd/read_statsd/defaults/main.yml A packaging/setup/ansible/roles/ovirt_collectd/read_statsd/tasks/main.yml A packaging/setup/ansible/roles/ovirt_collectd/read_statsd/templates/10-read-statsd.conf.j2 A packaging/setup/ansible/roles/ovirt_collectd/write_http/defaults/main.yml A packaging/setup/ansible/roles/ovirt_collectd/write_http/tasks/main.yml A packaging/setup/ansible/roles/ovirt_collectd/write_http/templates/10-write-http.conf.j2 A packaging/setup/ansible/roles/ovirt_fluentd/client/README.md A packaging/setup/ansible/roles/ovirt_fluentd/client/defaults/main.yml A packaging/setup/ansible/roles/ovirt_fluentd/client/meta/main.yml A packaging/setup/ansible/roles/ovirt_fluentd/client/tasks/main.yml A packaging/setup/ansible/roles/ovirt_fluentd/client/templates/forward_no_ssl.conf A packaging/setup/ansible/roles/ovirt_fluentd/client/templates/forward_ssl.conf A packaging/setup/ansible/roles/ovirt_fluentd/http_input/README.md A packaging/setup/ansible/roles/ovirt_fluentd/http_input/defaults/main.yml A packaging/setup/ansible/roles/ovirt_fluentd/http_input/meta/main.yml A packaging/setup/ansible/roles/ovirt_fluentd/http_input/tasks/main.yml A packaging/setup/ansible/roles/ovirt_fluentd/http_input/templates/http-input.conf A packaging/setup/ansible/roles/ovirt_fluentd/ovirt_host/README.md A packaging/setup/ansible/roles/ovirt_fluentd/ovirt_host/meta/main.yml A packaging/setup/ansible/roles/ovirt_fluentd/ovirt_host/tasks/main.yml A packaging/setup/ansible/roles/ovirt_fluentd/ovirt_host/templates/ovirt-processing.conf A packaging/setup/ansible/roles/ovirt_fluentd/read_local_ca_cert/README.md A packaging/setup/ansible/roles/ovirt_fluentd/read_local_ca_cert/defaults/main.yml A packaging/setup/ansible/roles/ovirt_fluentd/read_local_ca_cert/tasks/main.yml A packaging/setup/ansible/tools/validate-playbooks 49 files changed, 797 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Jenkins CI: Passed CI tests Yedidyah Bar David: Verified -- To view, visit https://gerrit.ovirt.org/70672 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If8766ac271ee908d4a5268780c93c9f15c047be7 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: webadmin: Select NFS version auto negotiate when creating ne...
by Code Review 18 Jan '17

18 Jan '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Select NFS version auto negotiate when creating new domain ...................................................................... webadmin: Select NFS version auto negotiate when creating new domain Bug-Url: https://bugzilla.redhat.com/1414100 Change-Id: I133a37659d54228144dfb6c4e76ffc42fc79744d Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/NfsStorageModel.java M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/UIConstants.properties 2 files changed, 4 insertions(+), 4 deletions(-) Approvals: Tal Nisan: Verified Daniel Erez: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/70709 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I133a37659d54228144dfb6c4e76ffc42fc79744d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: Select NFS version auto negotiate when creating ne...
by Code Review 18 Jan '17

18 Jan '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Select NFS version auto negotiate when creating new domain ...................................................................... webadmin: Select NFS version auto negotiate when creating new domain Bug-Url: https://bugzilla.redhat.com/1414100 Change-Id: I133a37659d54228144dfb6c4e76ffc42fc79744d Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/NfsStorageModel.java M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/UIConstants.properties 2 files changed, 4 insertions(+), 4 deletions(-) Approvals: Tal Nisan: Verified Jakub Niedermertl: Looks good to me, but someone else must approve Daniel Erez: Looks good to me, approved Jenkins CI: Passed CI tests Idan Shaby: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/70699 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I133a37659d54228144dfb6c4e76ffc42fc79744d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yaniv Kaul <ykaul(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: engine: Include mac address in REST to network provider when...
by Code Review 18 Jan '17

18 Jan '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: engine: Include mac address in REST to network provider when nic is plugged. ...................................................................... engine: Include mac address in REST to network provider when nic is plugged. The mac address of a nic can be changed when a nic is unplugged. When plugging in the nic, the mac must be passed in the PUT request issued during nic plug, so that the mac is updated. Change-Id: I2efd78188771c773d3a609dc74d68e62650987ef Signed-off-by: Marcin Mirecki<mmirecki(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/1408121 --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/network/openstack/BaseNetworkProviderProxy.java 1 file changed, 3 insertions(+), 2 deletions(-) Approvals: Martin Peřina: Looks good to me, approved Marcin Mirecki: Verified Martin Mucha: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/70681 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2efd78188771c773d3a609dc74d68e62650987ef Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: for bonds mode=4 setting default xmit_hash_policy
by Code Review 18 Jan '17

18 Jan '17

>From Moti Asayag <masayag(a)redhat.com>: Moti Asayag has submitted this change and it was merged. Change subject: engine: for bonds mode=4 setting default xmit_hash_policy ...................................................................... engine: for bonds mode=4 setting default xmit_hash_policy On creating new bonds with mode=4 (Dynamic link aggregation (802.3ad)) trough the web UI, the xmit_hash_policy is set explicitly to the numeric value 2 (layer2+3). The value is set numerically to be consistent to vdsm, which reports values of bonding options numerically, instead of textual. Already available bonds with mode=4 without xmit_hash_policy=2 are not changed and reported as "custom" options in the web UI. The previously used default xmit_hash_policy=layer2 uses just hardware MAC addresses of source and destination to decide which slave of the bond is used to transmit. The new default xmit_hash_policy=layer2+3 additionally considers the layer 3 addresses, if available, and is still 802.3ad compliant. This policy is intended to provide a more balanced distribution of traffic than layer2 alone, especially in environments where a layer3 routing is required to reach most destinations. Change-Id: I5b6cb2dfe8f0b60a1e81aa4832bc8c10672f6bb8 Bug-Url: https://bugzilla.redhat.com/1397490 Signed-off-by: Dominik Holler <dholler(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/HostSetupNetworksCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/BondMode.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsProperties.java 4 files changed, 19 insertions(+), 2 deletions(-) Approvals: Dominik Holler: Verified Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/69770 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5b6cb2dfe8f0b60a1e81aa4832bc8c10672f6bb8 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Dominik Holler <dholler(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Dominik Holler <dholler(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com> Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: core: Check storage domain before executing commands with VM...
by Code Review 17 Jan '17

17 Jan '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: core: Check storage domain before executing commands with VM leases ...................................................................... core: Check storage domain before executing commands with VM leases Before creating or updating a VM with a VM lease, validate that the selected storage domain for the lease exists, active and is a part of the storage pool the VM belongs to, if those terms are not met the operation will fail. In case of importing a VM with a VM lease, if the domain does not meet the criteria the VM will be imported without a VM lease and an audit log warning will be issued. Bug-Url: https://bugzilla.redhat.com/1413961 Change-Id: Id448f6e86d635ffe1743ed8e542d631d8ea2fe5a Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ImportVmCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties 6 files changed, 35 insertions(+), 5 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/70701 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id448f6e86d635ffe1743ed8e542d631d8ea2fe5a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Check storage domain before executing commands with VM...
by Code Review 17 Jan '17

17 Jan '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: core: Check storage domain before executing commands with VM leases ...................................................................... core: Check storage domain before executing commands with VM leases Before creating or updating a VM with a VM lease, validate that the selected storage domain for the lease exists, active and is a part of the storage pool the VM belongs to, if those terms are not met the operation will fail. In case of importing a VM with a VM lease, if the domain does not meet the criteria the VM will be imported without a VM lease and an audit log warning will be issued. Bug-Url: https://bugzilla.redhat.com/1413961 Change-Id: Id448f6e86d635ffe1743ed8e542d631d8ea2fe5a Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ImportVmCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties 6 files changed, 35 insertions(+), 5 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/70650 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id448f6e86d635ffe1743ed8e542d631d8ea2fe5a Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Benny Zlotnik <bzlotnik(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0