Change in ovirt-engine[master]: engine: geo-rep sessions for storage domain
by Code Review
>From Sahina Bose <sabose(a)redhat.com>:
Sahina Bose has submitted this change and it was merged.
Change subject: engine: geo-rep sessions for storage domain
......................................................................
engine: geo-rep sessions for storage domain
Change-Id: I0fff2ffeb4b50665008d3e95f3c13f3b946c1efd
Bug-Url: https://bugzilla.redhat.com/1398593
Signed-off-by: Sahina Bose <sabose(a)redhat.com>
---
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetGeoRepSessionsForStorageDomainQuery.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java
2 files changed, 86 insertions(+), 0 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Sahina Bose: Verified; Looks good to me, approved
Ramesh N: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/68936
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0fff2ffeb4b50665008d3e95f3c13f3b946c1efd
Gerrit-PatchSet: 18
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 11 months
Change in ovirt-engine[master]: webadmin: no way to edit the migration bandwidth.
by Code Review
>From Tomas Jelinek <tjelinek(a)redhat.com>:
Tomas Jelinek has submitted this change and it was merged.
Change subject: webadmin: no way to edit the migration bandwidth.
......................................................................
webadmin: no way to edit the migration bandwidth.
Regression introduced by https://gerrit.ovirt.org/#/c/60820/
Accidentally used the label editor which does not synch the values to the
entity.
Change-Id: Ia0c2fd6934961966196eb8fa333353fb5345fe9d
Bug-Url: https://bugzilla.redhat.com/1410475
Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com>
---
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterPopupView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterPopupView.ui.xml
2 files changed, 3 insertions(+), 3 deletions(-)
Approvals:
Tomas Jelinek: Verified
Jenkins CI: Passed CI tests
Martin Betak: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/69726
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia0c2fd6934961966196eb8fa333353fb5345fe9d
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 11 months
Change in ovirt-engine[master]: engine: Schedule DR sync command
by Code Review
>From Sahina Bose <sabose(a)redhat.com>:
Sahina Bose has submitted this change and it was merged.
Change subject: engine: Schedule DR sync command
......................................................................
engine: Schedule DR sync command
Command to create a schedule for DR
against gluster storage domain
Bug-Url: https://bugzilla.redhat.com/1398593
Change-Id: If5e85e82d0ba76dcf553295cecac826261553cd0
Signed-off-by: Sahina Bose <sabose(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/DeleteGeoRepSessionCommand.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/dr/ScheduleGlusterStorageSyncCommand.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/GeoRepSessionCommandTest.java
A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/StorageSyncScheduleParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java
A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StorageDomainDR.java
A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/StorageSyncSchedule.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java
A backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/businessentities/gluster/StorageSyncScheduleTest.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/DbFacade.java
A backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/StorageDomainDRDao.java
A backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/StorageDomainDRDaoImpl.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/FixturesTool.java
A backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/StorageDomainDRDaoTest.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/gluster/GlusterVolumeDaoTest.java
M backend/manager/modules/dal/src/test/resources/fixtures.xml
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/frontend/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
A packaging/dbscripts/storage_domain_dr_sp.sql
A packaging/dbscripts/upgrade/04_01_0710_create_storage_dr.sql
24 files changed, 912 insertions(+), 3 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Sahina Bose: Verified; Looks good to me, approved
Maor Lipchuk: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/67296
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If5e85e82d0ba76dcf553295cecac826261553cd0
Gerrit-PatchSet: 29
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 11 months
Change in ovirt-engine[master]: webadmin: Preserve VM NUMA pinning settings in UI
by Code Review
>From Alexander Wels <awels(a)redhat.com>:
Alexander Wels has submitted this change and it was merged.
Change subject: webadmin: Preserve VM NUMA pinning settings in UI
......................................................................
webadmin: Preserve VM NUMA pinning settings in UI
VM NUMA pinning settings were disappearing in the UI if the
NUMA pinning popup was accessed again after making a change
but before that change was saved. This patch corrects that
issue.
Change-Id: Ifc02cf23cb0c738c4d0c0fb46ea4a78c75aabc47
Bug-Url: https://bugzilla.redhat.com/1404249
Signed-off-by: Phillip Bailey <phbailey(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/numa/VmNumaSupportModel.java
1 file changed, 8 insertions(+), 0 deletions(-)
Approvals:
Martin Sivák: Looks good to me, but someone else must approve
Alexander Wels: Looks good to me, approved
Jenkins CI: Passed CI tests
Phillip Bailey: Verified
--
To view, visit https://gerrit.ovirt.org/69662
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifc02cf23cb0c738c4d0c0fb46ea4a78c75aabc47
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Phillip Bailey <phbailey(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 11 months
Change in ovirt-engine[master]: userportal, webadmin: fixed prohibition reason tooltips
by Code Review
>From Greg Sheremeta <gshereme(a)redhat.com>:
Greg Sheremeta has submitted this change and it was merged.
Change subject: userportal, webadmin: fixed prohibition reason tooltips
......................................................................
userportal, webadmin: fixed prohibition reason tooltips
UICommandButton and UICommandLink had bad logic for computing
the tooltip. This was causing a comma to render at the beginning
of the tooltip. Fixed.
Also replaced the comma with a much nicer line break when there
are multiple change prohibition reasons.
Change-Id: Ic5a0be9f87970a41a63f0a047ae791fd6037e5e7
Bug-Url: https://bugzilla.redhat.com/1396512
Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/UiCommandButton.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/UiCommandLink.java
2 files changed, 19 insertions(+), 14 deletions(-)
Approvals:
Alexander Wels: Looks good to me, approved
Jenkins CI: Passed CI tests
Greg Sheremeta: Verified
--
To view, visit https://gerrit.ovirt.org/68939
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic5a0be9f87970a41a63f0a047ae791fd6037e5e7
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 11 months
Change in ovirt-engine[master]: webadmin: Bootstrap layout storage popup
by Code Review
>From Alexander Wels <awels(a)redhat.com>:
Alexander Wels has submitted this change and it was merged.
Change subject: webadmin: Bootstrap layout storage popup
......................................................................
webadmin: Bootstrap layout storage popup
- Used bootstrap grid for laying out the new/import
storage domain popup.
- Fixed issue with host select not highlighting when
an error occured.
- Updated managed gluster checkbox layout.
Change-Id: I917c8788dad1f88dd6cfba303440942180977e88
Bug-Url: https://bugzilla.redhat.com/1404674
Signed-off-by: Alexander Wels <awels(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/FcpStorageView.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/FcpStorageView.ui.xml
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/IscsiStorageView.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/IscsiStorageView.ui.xml
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/GlusterStorageView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/GlusterStorageView.ui.xml
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/LocalStorageView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/LocalStorageView.ui.xml
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/NfsStorageView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/NfsStorageView.ui.xml
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/PosixStorageView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/PosixStorageView.ui.xml
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/StoragePopupView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/StoragePopupView.ui.xml
14 files changed, 385 insertions(+), 631 deletions(-)
Approvals:
Alexander Wels: Verified
Jenkins CI: Passed CI tests
Greg Sheremeta: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/68665
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I917c8788dad1f88dd6cfba303440942180977e88
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Benny Zlotnik <bzlotnik(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 11 months
Change in ovirt-engine-sdk-ruby[sdk_4.0]: Add import VM example
by Code Review
>From Juan Hernandez <juan.hernandez(a)redhat.com>:
Juan Hernandez has submitted this change and it was merged.
Change subject: Add import VM example
......................................................................
Add import VM example
Example on how to import a VM from an export storage domain
Change-Id: I96e80ab15ba0f712f99ca508eeb3b24f8cef0acf
Signed-off-by: Benny Zlotnik <bzlotnik(a)redhat.com>
(cherry picked from commit aeb4841e5e70471277faa1da49f1f6e412f63791)
(cherry picked from commit 95c83a4fb8c2bbc31e23ee1f004c22b4f3a4c1ab)
---
A sdk/examples/import_vm.rb
1 file changed, 72 insertions(+), 0 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/69733
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I96e80ab15ba0f712f99ca508eeb3b24f8cef0acf
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk-ruby
Gerrit-Branch: sdk_4.0
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 11 months
Change in ovirt-engine-sdk-ruby[sdk_4.1]: Add import VM example
by Code Review
>From Juan Hernandez <juan.hernandez(a)redhat.com>:
Juan Hernandez has submitted this change and it was merged.
Change subject: Add import VM example
......................................................................
Add import VM example
Example on how to import a VM from an export storage domain
Change-Id: I96e80ab15ba0f712f99ca508eeb3b24f8cef0acf
Signed-off-by: Benny Zlotnik <bzlotnik(a)redhat.com>
(cherry picked from commit aeb4841e5e70471277faa1da49f1f6e412f63791)
---
A sdk/examples/import_vm.rb
1 file changed, 72 insertions(+), 0 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/69732
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I96e80ab15ba0f712f99ca508eeb3b24f8cef0acf
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk-ruby
Gerrit-Branch: sdk_4.1
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 11 months
Change in ovirt-engine-sdk-ruby[master]: Add import VM example
by Code Review
>From Juan Hernandez <juan.hernandez(a)redhat.com>:
Juan Hernandez has submitted this change and it was merged.
Change subject: Add import VM example
......................................................................
Add import VM example
Example on how to import a VM from an export storage domain
Change-Id: I96e80ab15ba0f712f99ca508eeb3b24f8cef0acf
Signed-off-by: Benny Zlotnik <bzlotnik(a)redhat.com>
---
A sdk/examples/import_vm.rb
1 file changed, 72 insertions(+), 0 deletions(-)
Approvals:
Benny Zlotnik: Verified
Juan Hernandez: Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/69712
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I96e80ab15ba0f712f99ca508eeb3b24f8cef0acf
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine-sdk-ruby
Gerrit-Branch: master
Gerrit-Owner: Benny Zlotnik <bzlotnik(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Benny Zlotnik <bzlotnik(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 11 months
Change in ovirt-engine[master]: core: increase the interval between retries to auto start vm...
by Code Review
>From Arik Hadas <ahadas(a)redhat.com>:
Arik Hadas has submitted this change and it was merged.
Change subject: core: increase the interval between retries to auto start vm with a lease
......................................................................
core: increase the interval between retries to auto start vm with a lease
Increase it from 30 iterations to 100 iterations. Theoretically that should be
5 minutes but in practice it will be lower. It is expected to be ~4.25 minutes.
Change-Id: I911c29694b04f9438b9a4ba9ac8b4cbaf1b49284
Bug-Url: https://bugzilla.redhat.com/1317429
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java
M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql
2 files changed, 2 insertions(+), 2 deletions(-)
Approvals:
Shahar Havivi: Looks good to me, approved
Jenkins CI: Passed CI tests
Arik Hadas: Verified
--
To view, visit https://gerrit.ovirt.org/69540
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I911c29694b04f9438b9a4ba9ac8b4cbaf1b49284
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 11 months