Change in ovirt-engine[ovirt-engine-4.1]: core: plug passthrough nics while migrated vm is locked
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: core: plug passthrough nics while migrated vm is locked
......................................................................
core: plug passthrough nics while migrated vm is locked
Upon successful migration, passthrough network interfaces need to be plugged.
This should be done while the VM is still locked because otherwise another
migration can be started before these network interfaces are plugged.
Change-Id: Idb05315d9ae5be04cb55e3886f6294bb82af8266
Bug-Url: https://bugzilla.redhat.com/1408834
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmCommand.java
1 file changed, 35 insertions(+), 38 deletions(-)
Approvals:
Shahar Havivi: Looks good to me, approved
Jenkins CI: Passed CI tests
Arik Hadas: Verified
--
To view, visit https://gerrit.ovirt.org/69671
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Idb05315d9ae5be04cb55e3886f6294bb82af8266
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 11 months
Change in ovirt-engine[ovirt-engine-4.1]: core: move cleanup of passthrough nics to runningFailed
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: core: move cleanup of passthrough nics to runningFailed
......................................................................
core: move cleanup of passthrough nics to runningFailed
There are few benefits of moving the cleanup of passthrough network interfaces
to 'runningFailed' method:
1. this cleanup should be done only when the migration fails after the scheduler
chose a host (i.e., not upon an error in 'initVdss') - this is exactly what
'runningFailed' is there for.
2. it simplifies the execute ('executeVmCommand') method.
3. that way, the cleanup is done when call to VDSM for migration fails.
4. that way, the cleanup is done when the last rerun attempt fails.
Change-Id: I5b6055cd4987e75a9c8b956c061eb6452a78f124
Bug-Url: https://bugzilla.redhat.com/1408834
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmCommand.java
1 file changed, 33 insertions(+), 28 deletions(-)
Approvals:
Shahar Havivi: Looks good to me, approved
Jenkins CI: Passed CI tests
Arik Hadas: Verified
--
To view, visit https://gerrit.ovirt.org/69674
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5b6055cd4987e75a9c8b956c061eb6452a78f124
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 11 months
Change in ovirt-engine[ovirt-engine-4.1]: core: cache unplugged passthrough nics on vm migration
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: core: cache unplugged passthrough nics on vm migration
......................................................................
core: cache unplugged passthrough nics on vm migration
This has two benefits:
1. Better performance - not to query VM's passthrough network interfaces on every
migration attempt.
2. We can always retrieve the unplugged NICs when migration succeed. Previously,
when one migration attempt failed, these NICs were cleared and so if the next
migration attempt would have succeed, they could not be plugged back.
Change-Id: Ib5437fdc8fd87bd5fa2b785097c13a6f76c2c8fc
Bug-Url: https://bugzilla.redhat.com/1408834
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmCommand.java
1 file changed, 26 insertions(+), 19 deletions(-)
Approvals:
Shahar Havivi: Looks good to me, approved
Jenkins CI: Passed CI tests
Arik Hadas: Verified
--
To view, visit https://gerrit.ovirt.org/69675
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib5437fdc8fd87bd5fa2b785097c13a6f76c2c8fc
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 11 months
Change in ovirt-engine[ovirt-engine-4.1]: core: minor cleanup in vm migration
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: core: minor cleanup in vm migration
......................................................................
core: minor cleanup in vm migration
- rename unplugNics to unplugPassthroughNics
- extract statement that should not be inside try block
- inline a variable
- remove redundant blank lines
Change-Id: Ibbd8b9595fa33c5e4fb9056e21abe3719e7856fd
Bug-Url: https://bugzilla.redhat.com/1408834
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmCommand.java
1 file changed, 9 insertions(+), 12 deletions(-)
Approvals:
Shahar Havivi: Looks good to me, approved
Jenkins CI: Passed CI tests
Arik Hadas: Verified
--
To view, visit https://gerrit.ovirt.org/69673
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibbd8b9595fa33c5e4fb9056e21abe3719e7856fd
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 11 months
Change in ovirt-hosted-engine-ha[v2.1.z]: Fix getting MD5 hash for configuration tar
by Code Review
>From Martin Sivák <msivak(a)redhat.com>:
Martin Sivák has submitted this change and it was merged.
Change subject: Fix getting MD5 hash for configuration tar
......................................................................
Fix getting MD5 hash for configuration tar
Use the _enforce_vdsm_user method to execute
the md5hash command.
Change-Id: If23a79478f8c7f782b6fe8135118bee72fb8f776
Bug-Url: https://bugzilla.redhat.com/1301681
Signed-off-by: Jenny Tokar <jtokar(a)redhat.com>
(cherry picked from commit 03fd2c5)
---
M ovirt_hosted_engine_ha/lib/heconflib.py
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Martin Sivák: Looks good to me, approved
Jenkins CI: Passed CI tests
Jenny Tokar: Verified
--
To view, visit https://gerrit.ovirt.org/69616
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If23a79478f8c7f782b6fe8135118bee72fb8f776
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-hosted-engine-ha
Gerrit-Branch: v2.1.z
Gerrit-Owner: Jenny Tokar <jtokar(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 11 months
Change in ovirt-hosted-engine-ha[v2.1.z]: Fix refreshing vm conf
by Code Review
>From Martin Sivák <msivak(a)redhat.com>:
Martin Sivák has submitted this change and it was merged.
Change subject: Fix refreshing vm conf
......................................................................
Fix refreshing vm conf
When refreshing the vm configuration on the host
we first try the ovf store, if no content was found
we try the shared storage vm.conf.
When we have the content we can refresh the locally
stored file.
The recent refactor broke this functionality, this patch
fixes it.
Change-Id: I281b42a6cb2c5cfdd5821cd50e3f2608d3ae8896
Bug-Url: https://bugzilla.redhat.com/1301681
Signed-off-by: Jenny Tokar <jtokar(a)redhat.com>
(cherry picked from commit d771cf1)
---
M ovirt_hosted_engine_ha/env/config.py
1 file changed, 8 insertions(+), 3 deletions(-)
Approvals:
Martin Sivák: Looks good to me, approved
Jenkins CI: Passed CI tests
Jenny Tokar: Verified
--
To view, visit https://gerrit.ovirt.org/69615
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I281b42a6cb2c5cfdd5821cd50e3f2608d3ae8896
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-hosted-engine-ha
Gerrit-Branch: v2.1.z
Gerrit-Owner: Jenny Tokar <jtokar(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 11 months
Change in ovirt-hosted-engine-ha[master]: Use RNG device from OVF if provided
by Code Review
>From Martin Sivák <msivak(a)redhat.com>:
Martin Sivák has submitted this change and it was merged.
Change subject: Use RNG device from OVF if provided
......................................................................
Use RNG device from OVF if provided
When building vm.conf instead of stubbing
the RNG device see if one exists in the OVF and
use it instead.
Change-Id: I0552e71ef6c058b1c778ea4ab5b733ee51869db5
Bug-Url: https://bugzilla.redhat.com/1368027
Signed-off-by: Jenny Tokar <jtokar(a)redhat.com>
---
M ovirt_hosted_engine_ha/lib/ovf/ovf2VmParams.py
M ovirt_hosted_engine_ha/lib/ovf/ovf2VmParams_test.py
M ovirt_hosted_engine_ha/lib/ovf/ovf_test.xml
3 files changed, 47 insertions(+), 0 deletions(-)
Approvals:
Martin Sivák: Looks good to me, approved
Jenkins CI: Passed CI tests
Jenny Tokar: Verified
--
To view, visit https://gerrit.ovirt.org/69234
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0552e71ef6c058b1c778ea4ab5b733ee51869db5
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-hosted-engine-ha
Gerrit-Branch: master
Gerrit-Owner: Jenny Tokar <jtokar(a)redhat.com>
Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com>
Gerrit-Reviewer: Denis Chaplygin <dchaplyg(a)redhat.com>
Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com>
Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 11 months
Change in ovirt-engine[master]: core: allow ipv6 address for migration role in cluster network
by Code Review
>From Moti Asayag <masayag(a)redhat.com>:
Moti Asayag has submitted this change and it was merged.
Change subject: core: allow ipv6 address for migration role in cluster network
......................................................................
core: allow ipv6 address for migration role in cluster network
we're now allowing migration networks to consist of interfaces
that solely use ipv6. it is already possible to setup a host migration
attachment to use ipv6, however it is not possible to set migration role
when some host in a cluster doesn't have an ipv4 address in the relevant
nic.
when determining what's considered a missing ip in a nic, check for the
role of the cluster network, and if it's migration, consider it to be
missing only if both ipv6 and ipv4 addresses are missing.
Change-Id: Iae51623ebbfc2431d5f42f1e026c853afbbedb5a
Signed-off-by: Leon Goldberg <lgoldber(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/NetworkClusterValidatorBase.java
1 file changed, 12 insertions(+), 3 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Leon Goldberg: Verified
Moti Asayag: Looks good to me, approved
Yevgeny Zaspitsky: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/68996
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iae51623ebbfc2431d5f42f1e026c853afbbedb5a
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Yevgeny Zaspitsky
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 11 months
Change in ovirt-engine[master]: core: initial delay before automatic start of vm with lease
by Code Review
>From Arik Hadas <ahadas(a)redhat.com>:
Arik Hadas has submitted this change and it was merged.
Change subject: core: initial delay before automatic start of vm with lease
......................................................................
core: initial delay before automatic start of vm with lease
The delay is set to 10 monitoring cycles. Currently, the interval between monitoring
cycles is 3 secs and since the network error is triggered by more than 1 thread
it seems that on the average case the initial delay is ~20 sec rather than 30 sec.
Change-Id: Idb3df308a5389db7b74f0a44bb337568a2f4624f
Bug-Url: https://bugzilla.redhat.com/1317429
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java
M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql
3 files changed, 10 insertions(+), 4 deletions(-)
Approvals:
Shahar Havivi: Looks good to me, approved
Jenkins CI: Passed CI tests
Arik Hadas: Verified
--
To view, visit https://gerrit.ovirt.org/69394
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Idb3df308a5389db7b74f0a44bb337568a2f4624f
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 11 months
Change in jenkins[master]: gamification: enable jenkins integration for more projects
by Code Review
>From Eyal Edri <eedri(a)redhat.com>:
Eyal Edri has submitted this change and it was merged.
Change subject: gamification: enable jenkins integration for more projects
......................................................................
gamification: enable jenkins integration for more projects
- gerrit-admin
- jenkins
- ovirt-system-tests
Change-Id: I58c19eadc8dc489c4c54c6e122a19a716ae60082
Signed-off-by: Eyal Edri <eedri(a)redhat.com>
---
M jobs/confs/projects/gerrit-admin/gerrit-admin.yaml
M jobs/confs/projects/jenkins/jenkins_standard.yaml
M jobs/confs/projects/ovirt-system-tests/ovirt-system-tests_standard.yaml
3 files changed, 3 insertions(+), 0 deletions(-)
Approvals:
Eyal Edri: Verified; Looks good to me, approved; Ready for merge
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/69676
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I58c19eadc8dc489c4c54c6e122a19a716ae60082
Gerrit-PatchSet: 1
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 11 months