Change in ovirt-engine[ovirt-engine-4.1]: vdsbroker: allow to disable host upgrade manager
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: vdsbroker: allow to disable host upgrade manager
......................................................................
vdsbroker: allow to disable host upgrade manager
When using fakevdsm there is no need to use upgrade manager and it
pollutes logs with huge number of exceptions.
Bug-Url: https://bugzilla.redhat.com/1406814
Change-Id: I2b3e92451f68d8088b241061be76768687a92169
Signed-off-by: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
(cherry picked from commit aa4cbb10f4ea3d39a2e1ed21f53e2b08cc4a4ec8)
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java
M packaging/etc/engine-config/engine-config.properties
2 files changed, 15 insertions(+), 12 deletions(-)
Approvals:
Piotr Kliczewski: Looks good to me, approved
Martin Peřina: Verified
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/69587
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2b3e92451f68d8088b241061be76768687a92169
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1
Gerrit-Owner: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 11 months
Change in ovirt-engine[ovirt-engine-4.1]: core: TransferImage - callback end methods NPE
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: core: TransferImage - callback end methods NPE
......................................................................
core: TransferImage - callback end methods NPE
When the TransferImageCommand is being executed for pre existing disk
it'll attempt to load the disk from the db on the OnSucceeded/OnFailed
methods using the image id provided in the command parameters while for a
created disk by the command the data will be taken from the AddDisk parameters.
When uploading to a pre existing disk, the id provided by the user
is passed the in the parameters image id (field which should represent a volume)
instead of in the image group id field (which should represnt the disk id).
When attempting to load the image in the end method using getDiskImage()
no data will be returned as the disk id is used as the volume id and
NPE will be thrown.
In other parts of the command the disk is loaded manually, therefore
this exception is thrown only on the end methods.
Looking forward, we should pass the id provided by the user in the
parameters image group id and complete the image id from the db - this
patch fixes the problem by altering the log in order to reduce the risk
in backporting this change to the stable branches.
Change-Id: Ice26f4d19723042097a81ea4b685a7aa31faf976
Bug-url: https://bugzilla.redhat.com/1400299
Signed-off-by: Liron Aravot <laravot(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/TransferImageCommand.java
1 file changed, 4 insertions(+), 4 deletions(-)
Approvals:
Daniel Erez: Looks good to me, approved
Jenkins CI: Passed CI tests
Liron Aravot: Verified
--
To view, visit https://gerrit.ovirt.org/69604
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ice26f4d19723042097a81ea4b685a7aa31faf976
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1
Gerrit-Owner: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 11 months
Change in ovirt-engine[ovirt-engine-4.1]: core: maxMemory send only if it differs from memory
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: core: maxMemory send only if it differs from memory
......................................................................
core: maxMemory send only if it differs from memory
VM attribute maxMemSize is send to VDSM only if maximum memory is
different from memory. If both attributes are set to the same value,
QEMU crashes.
Change-Id: Ia9a54d1f254c07aeb4ad16c69f76fa8f0b762715
Bug-Url: https://bugzilla.redhat.com/1406749
Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/builder/vminfo/VmInfoBuilderImpl.java
1 file changed, 4 insertions(+), 1 deletion(-)
Approvals:
Jakub Niedermertl: Verified
Jenkins CI: Passed CI tests
Arik Hadas: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/69536
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia9a54d1f254c07aeb4ad16c69f76fa8f0b762715
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1
Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 11 months
Change in ovirt-engine[ovirt-engine-4.1]: text: hosts's certificatE instead of certificatION
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: text: hosts's certificatE instead of certificatION
......................................................................
text: hosts's certificatE instead of certificatION
Change-Id: I87ba66e6b8e3eb2af7b164dfc81486247cfc77ae
Bug-Url: https://bugzilla.redhat.com/1341024
Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
---
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M frontend/webadmin/modules/frontend/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
4 files changed, 4 insertions(+), 4 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Moti Asayag: Looks good to me, approved
Yevgeny Zaspitsky: Verified
--
To view, visit https://gerrit.ovirt.org/69554
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I87ba66e6b8e3eb2af7b164dfc81486247cfc77ae
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1
Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 11 months
Change in ovirt-engine[ovirt-engine-4.1]: restapi: Update to model 4.1.26 and metamodel 1.1.10
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: restapi: Update to model 4.1.26 and metamodel 1.1.10
......................................................................
restapi: Update to model 4.1.26 and metamodel 1.1.10
This change updates the engine to use version 4.1.26 of the model and
version 1.1.10 of the metamodel.
The more relevant changes in the new version of the model are the
following:
* Add `initial_size` attribute to the `Disk` type.
The more relevant changes in the new version of the metamodel are the
following:
* Don't import `JsonParser.Event` directly, as it conflicts with the
`Event` type of the model.
* Fix reading of XML attributes of enum types
https://bugzilla.redhat.com/1408839[#1408839].
* Use non-capturing groups in generated `@Path` annotations
https://bugzilla.redhat.com/1405774[#1405774].
* Add `Disk.initialSize` to the list of exceptions of integer
attributes that are represented using `xs:long` instead of `xs:int`.
Change-Id: I7e649aa26a30f5a450353fa56e1282f9767ba4c3
Related-To: https://bugzilla.redhat.com/1405774
Related-To: https://bugzilla.redhat.com/1408839
Related-To: https://bugzilla.redhat.com/1400296
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M pom.xml
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Juan Hernandez: Verified
Jenkins CI: Passed CI tests
Liron Aravot: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/69617
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7e649aa26a30f5a450353fa56e1282f9767ba4c3
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 11 months
Change in ovirt-engine[master]: engine: Job for DR sync
by Code Review
>From Sahina Bose <sabose(a)redhat.com>:
Sahina Bose has submitted this change and it was merged.
Change subject: engine: Job for DR sync
......................................................................
engine: Job for DR sync
Job and related commands for DR sync
Change-Id: Ib14152c883bb4c8b043f172206c8f3598bc516d2
Bug-Url: https://bugzilla.redhat.com/1398593
Signed-off-by: Sahina Bose <sabose(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandsFactory.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVmsByStorageDomainQuery.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/dr/GlusterStorageDomainDRSyncJob.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/dr/GlusterStorageGeoRepSyncCallback.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/dr/GlusterStorageGeoRepSyncInternalCommand.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/dr/GlusterStorageSyncCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java
A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/GlusterStorageSyncCommandParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterGeoRepSession.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/constants/gluster/GlusterConstants.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/locks/LockingGroup.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/LocalizedEnums.java
M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/LocalizedEnums.properties
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
20 files changed, 516 insertions(+), 0 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Sahina Bose: Verified
Maor Lipchuk: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/67295
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib14152c883bb4c8b043f172206c8f3598bc516d2
Gerrit-PatchSet: 23
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Ramesh <rames(a)ymail.com>
Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 11 months
Change in ovirt-engine[master]: core: Pass migration limits in MigrateBrokerVDSCommand
by Code Review
>From Martin Betak <mbetak(a)redhat.com>:
Martin Betak has submitted this change and it was merged.
Change subject: core: Pass migration limits in MigrateBrokerVDSCommand
......................................................................
core: Pass migration limits in MigrateBrokerVDSCommand
The incoming and outgoing limits from migration profile were not taken into
account. Now we pass them along with other parameters.
Change-Id: I825404cd19b7679520a42d7d56f663937b7c96f3
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1409246
Signed-off-by: Martin Betak <mbetak(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/MigrateVDSCommandParameters.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/MigrateBrokerVDSCommand.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsProperties.java
4 files changed, 41 insertions(+), 2 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Martin Betak: Verified
Arik Hadas: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/69621
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I825404cd19b7679520a42d7d56f663937b7c96f3
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 11 months
Change in ovirt-hosted-engine-setup[master]: Storage: Sort Luns by GUID
by Code Review
>From Simone Tiraboschi <stirabos(a)redhat.com>:
Simone Tiraboschi has submitted this change and it was merged.
Change subject: Storage: Sort Luns by GUID
......................................................................
Storage: Sort Luns by GUID
Change-Id: I5b08f65ce9576fb1a8f3a773430795f7330e95c8
Bug-Url: https://bugzilla.redhat.com/1348225
Signed-off-by: Ido Rosenzwig <irosenzw(a)redhat.com>
---
M src/plugins/gr-he-setup/storage/blockd.py
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, but someone else must approve
Simone Tiraboschi: Looks good to me, approved
Ido Rosenzwig: Verified
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/69071
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5b08f65ce9576fb1a8f3a773430795f7330e95c8
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: master
Gerrit-Owner: Ido Rosenzwig <irosenzw(a)redhat.com>
Gerrit-Reviewer: Ido Rosenzwig <irosenzw(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com>
Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 11 months
Change in ovirt-release[ovirt-4.1]: packaging: added experimental repo
by Code Review
>From Sandro Bonazzola <sbonazzo(a)redhat.com>:
Sandro Bonazzola has submitted this change and it was merged.
Change subject: packaging: added experimental repo
......................................................................
packaging: added experimental repo
Change-Id: Ied478c81f689ca3e01359d77f14b52c2236901af
Signed-off-by: Rafael Martins <rmartins(a)redhat.com>
---
M Makefile.am
M configure.ac
A ovirt-experimental.repo.in
M ovirt-release41.spec.in
4 files changed, 63 insertions(+), 1 deletion(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/69625
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ied478c81f689ca3e01359d77f14b52c2236901af
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-release
Gerrit-Branch: ovirt-4.1
Gerrit-Owner: Rafael Martins <rmartins(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 11 months
Change in ovirt-engine[master]: api: DisksResource - initial size support on add disk
by Code Review
>From Liron Aravot <laravot(a)redhat.com>:
Liron Aravot has submitted this change and it was merged.
Change subject: api: DisksResource - initial size support on add disk
......................................................................
api: DisksResource - initial size support on add disk
When a sparse image disk is created on block domain it's created with
initial allocation and being extended as needed by the spm (when it's
plugged to a running vm).
Speicifying inital size on the disk creation is useful when there's a
need to create the disk with initial allocated different than the
default value (1gb) for various reasons.
An example would be the image upload, when the data is uploaded to disk
extensions aren't supported - so the disk needs to be created with
initial size that is big enough to contain all the uploaded data.
Change-Id: I463c46a0072076fb0db8ba78a3b587ca34868771
Bug-Url: https://bugzilla.redhat.com/1400296
Signed-off-by: Liron Aravot <laravot(a)redhat.com>
---
M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/DiskMapper.java
M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/DiskMapperTest.java
2 files changed, 21 insertions(+), 0 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Juan Hernandez: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Liron Aravot: Verified
--
To view, visit https://gerrit.ovirt.org/69519
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I463c46a0072076fb0db8ba78a3b587ca34868771
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 11 months