Change in ovirt-engine[master]: restapi: Implement 'StorageDomainDisks' and 'AttachedStorage...
by Code Review
>From Juan Hernandez <juan.hernandez(a)redhat.com>:
Juan Hernandez has submitted this change and it was merged.
Change subject: restapi: Implement 'StorageDomainDisks' and 'AttachedStorageDomainDisks'
......................................................................
restapi: Implement 'StorageDomainDisks' and 'AttachedStorageDomainDisks'
Currently we use the same 'Disks' service definitions fo the following
disk collections:
/disks
/storagedomain/{sd:id}/disks
/datacenters/{dc:id}/storagedomains/{sd:id}/disks
This is wrong, because most operations on disk are then available in
multiple places, and it prevents addition of new operations that only
make sense for disks that aren't yet part of the system. A good example
of this is the operation to register an unregistered disk. That only
makes sense for disks that appear in /storagedomains/{sd:id}/disks. To
improve the situation this patch implements the new 'StorageDomainDisks'
and 'AttachedStorageDomainDisk' that have been introduced in the
specification of the API by the following patch:
Add 'StorageDomainDisks' and 'AttachedStorageDomainDisks'
https://gerrit.ovirt.org/69634
After this, each collection will have its own service:
/disks
DisksService
/storagedomain/{sd:id}/disks
StorageDomainDisksService
/datacenters/{dc:id}/storagedomains/{sd:id}/disks
AttachedStorageDomainDisksService
These services will initially preserve most of the duplicated
operations, for backwards compatibility. Those duplicated operations
will be marked as deprecated, and removed in a future version of the
API.
Change-Id: I1021d75609a7b07e6ebea279dd4e91ed37973725
Related-To: https://bugzilla.redhat.com/1366960
Related-To: https://gerrit.ovirt.org/69634
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/AbstractBackendStorageDomainDiskResource.java
A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/AbstractBackendStorageDomainDisksResource.java
A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendAttachedStorageDomainDiskResource.java
A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendAttachedStorageDomainDisksResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendAttachedStorageDomainResource.java
A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendDataCenterHelper.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendDiskResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainDiskResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainDisksResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainResource.java
A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/servers/V3AttachedStorageDomainDiskServer.java
A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/servers/V3AttachedStorageDomainDisksServer.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/servers/V3AttachedStorageDomainServer.java
A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/servers/V3StorageDomainDiskServer.java
A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/servers/V3StorageDomainDisksServer.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/servers/V3StorageDomainServer.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainDiskResourceTest.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainDisksResourceTest.java
M pom.xml
19 files changed, 685 insertions(+), 160 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
Maor Lipchuk: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/70587
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1021d75609a7b07e6ebea279dd4e91ed37973725
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 7 months
Change in jenkins[master]: upgrade-engine: restored the master to master job
by Code Review
>From Eyal Edri <eedri(a)redhat.com>:
Eyal Edri has submitted this change and it was merged.
Change subject: upgrade-engine: restored the master to master job
......................................................................
upgrade-engine: restored the master to master job
Change-Id: I3df2e24326c4dec9f7cef1cc311c0d763f82a5ea
Signed-off-by: Daniel Belenky <dbelenky(a)redhat.com>
---
M jobs/confs/projects/ovirt-engine/ovirt-engine_upgrade-engine.yaml
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Eyal Edri: Looks good to me, approved; Ready for merge
Daniel Belenky: Verified; Ready for review
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/71967
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3df2e24326c4dec9f7cef1cc311c0d763f82a5ea
Gerrit-PatchSet: 1
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: Daniel Belenky <dbelenky(a)redhat.com>
Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com>
Gerrit-Reviewer: Daniel Belenky <dbelenky(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nadav Goldin <ngoldin(a)redhat.com>
Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 7 months
Change in ovirt-engine[ovirt-engine-4.1]: userportal: Pools without VMs are hidden
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: userportal: Pools without VMs are hidden
......................................................................
userportal: Pools without VMs are hidden
Pools without any VMs are filtered out to prevent NPEs.
Change-Id: I6401299c50b784b2a0f36fd194efa932a0917021
Bug-Url: https://bugzilla.redhat.com/1378331
Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/AbstractUserPortalListModel.java
1 file changed, 35 insertions(+), 2 deletions(-)
Approvals:
Tomas Jelinek: Looks good to me, approved
Tal Nisan: Passed CI tests
Jakub Niedermertl: Verified
--
To view, visit https://gerrit.ovirt.org/71925
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6401299c50b784b2a0f36fd194efa932a0917021
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1
Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com>
Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 7 months
Change in ovirt-engine[ovirt-engine-4.1]: userportal: IconUtils.extractIconIds null resistant
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: userportal: IconUtils.extractIconIds null resistant
......................................................................
userportal: IconUtils.extractIconIds null resistant
It failed on NPE when it tried to extract icon id of a pool without any
VM.
Change-Id: Id5bdf9357d581b203065d63b7c82bef5e07691a0
Bug-Url: https://bugzilla.redhat.com/1378331
Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/IconUtils.java
1 file changed, 3 insertions(+), 0 deletions(-)
Approvals:
Tomas Jelinek: Looks good to me, approved
Tal Nisan: Passed CI tests
Jakub Niedermertl: Verified
--
To view, visit https://gerrit.ovirt.org/71924
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id5bdf9357d581b203065d63b7c82bef5e07691a0
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1
Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com>
Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 7 months
Change in ovirt-engine[ovirt-engine-4.1]: aaa: Awkward attempted login error
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: aaa: Awkward attempted login error
......................................................................
aaa: Awkward attempted login error
Remove error page for showing errors
and display them on welcome page using
patternfly alert pattern.
Change-Id: I20ed60f116a5f23f4dc1ac21c071092ffd7e380e
Bug-Url: https://bugzilla.redhat.com/1412687
Signed-off-by: Ravi Nori <rnori(a)redhat.com>
(cherry picked from commit 38c85783bd61330d404bf699e8a79a3dbc35760a)
---
M backend/manager/modules/welcome/src/main/java/org/ovirt/engine/core/LoginServlet.java
M backend/manager/modules/welcome/src/main/java/org/ovirt/engine/core/WelcomeServlet.java
M backend/manager/modules/welcome/src/main/java/org/ovirt/engine/core/WelcomeUtils.java
D backend/manager/modules/welcome/src/main/webapp/WEB-INF/error.jsp
M backend/manager/modules/welcome/src/main/webapp/WEB-INF/ovirt-engine.jsp
M backend/manager/modules/welcome/src/main/webapp/WEB-INF/web.xml
M packaging/services/ovirt-engine/ovirt-engine.conf.in
7 files changed, 28 insertions(+), 90 deletions(-)
Approvals:
Martin Peřina: Looks good to me, approved
Ravi Nori: Verified
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/71586
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I20ed60f116a5f23f4dc1ac21c071092ffd7e380e
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1
Gerrit-Owner: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 7 months
Change in ovirt-engine[ovirt-engine-4.1]: core: Random Generator setting wrong value after saving next...
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: core: Random Generator setting wrong value after saving next run configuration
......................................................................
core: Random Generator setting wrong value after saving next run configuration
When editing VM while its running we apply some of the fields on next
run configuration - one of them is rng which need to be one but
currently we add a new rng device instead of replacing the old one that
cause unwanted results such as saving only one of the devices randomly.
Change-Id: I86fc48f3488cf2dc6fdc2cf4da080e5a8a5c2495
Bug-Url: https://bugzilla.redhat.com/1419337
Signed-off-by: Shahar Havivi <shaharh(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java
1 file changed, 7 insertions(+), 1 deletion(-)
Approvals:
Shahar Havivi: Verified
Jenkins CI: Passed CI tests
Arik Hadas: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/71948
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I86fc48f3488cf2dc6fdc2cf4da080e5a8a5c2495
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1
Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 7 months
Change in ovirt-release[ovirt-3.6]: automation: fix repositories handling
by Code Review
>From Sandro Bonazzola <sbonazzo(a)redhat.com>:
Sandro Bonazzola has submitted this change and it was merged.
Change subject: automation: fix repositories handling
......................................................................
automation: fix repositories handling
we had issues with yum repositories due to conflicts
between epel and CentOS OpsTool
Change-Id: Ie801c8f7aeec25358b149c65ff7f53411c986a25
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
(cherry picked from commit 8bbb61dfd220dec6076f0afdb3f4199a383096c6)
(cherry picked from commit 7161aa806719638953bf5e330ee209e23d9e3684)
(cherry picked from commit b05edf34fc473d11e974659e96f1a3e68b8425f5)
---
M automation/check-patch.sh
1 file changed, 8 insertions(+), 1 deletion(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/71959
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie801c8f7aeec25358b149c65ff7f53411c986a25
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-release
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 7 months
Change in ovirt-release[ovirt-3.6]: automation: stop building unversioned rpms
by Code Review
>From Sandro Bonazzola <sbonazzo(a)redhat.com>:
Sandro Bonazzola has submitted this change and it was merged.
Change subject: automation: stop building unversioned rpms
......................................................................
automation: stop building unversioned rpms
having agnostic unversioned rpms is causing troubles to CI
which is not able to handle this case.
We'll find another way to handle the generation of the agnostic
rpms.
Change-Id: I22c32f2e60d3c2971429f6f2f6f3b94c459ebcb1
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
(cherry picked from commit c60bdf81d83e6b52d3e606ad733da7ea99584c53)
(cherry picked from commit c6266342b6606978797cb61f170c5416bed81e4e)
---
M automation/build-artifacts.sh
M automation/check-patch.sh
2 files changed, 0 insertions(+), 12 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved; Passed CI tests
Objections:
Jenkins CI: Failed CI tests
--
To view, visit https://gerrit.ovirt.org/71958
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I22c32f2e60d3c2971429f6f2f6f3b94c459ebcb1
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-release
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 7 months
Change in ovirt-release[ovirt-3.6]: spec: add dist tag to release
by Code Review
>From Sandro Bonazzola <sbonazzo(a)redhat.com>:
Sandro Bonazzola has submitted this change and it was merged.
Change subject: spec: add dist tag to release
......................................................................
spec: add dist tag to release
This allows repoman to behave correctly when
adding the package to experimental repos
Change-Id: I82dd89b06087f6054c7a46bc386b1affd5f14334
(cherry picked from commit 993e15cb9cb5de1e9305537364744dc17f8f25e3)
(cherry picked from commit 00bf68de4b6787f4dd365bd6d8b7e504ddb535a5)
---
M ovirt-release36.spec.in
1 file changed, 3 insertions(+), 3 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/71960
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I82dd89b06087f6054c7a46bc386b1affd5f14334
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-release
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 7 months
Change in ovirt-engine[master]: webadmin: removing redundant clear() call
by Code Review
>From Alona Kaplan <alkaplan(a)redhat.com>:
Alona Kaplan has submitted this change and it was merged.
Change subject: webadmin: removing redundant clear() call
......................................................................
webadmin: removing redundant clear() call
selectedLabels is being instantiated with clear() being
called immediately thereafter.
Change-Id: I4b64d63c432337dc2c863371a6038475b61a3b37
Signed-off-by: Leon Goldberg <lgoldber(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/VfsNicLabelModel.java
1 file changed, 0 insertions(+), 1 deletion(-)
Approvals:
Alona Kaplan: Looks good to me, approved
Jenkins CI: Passed CI tests
Leon Goldberg: Verified
Yevgeny Zaspitsky: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/71921
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4b64d63c432337dc2c863371a6038475b61a3b37
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 7 months