Change in ovirt-engine[ovirt-engine-4.1]: core, webadmin: Imported VMs have default maxMemory
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: core, webadmin: Imported VMs have default maxMemory
......................................................................
core, webadmin: Imported VMs have default maxMemory
... instead of maximum of allowed value as defined in *MaxMemorySizeInMB
configuration values. The default is 4x value of memory size and it is
maximum suggested value of maxMemory.
Default value of ConfigValues.VM64BitMaxMemorySizeInMB was changed to
4194304 to match the current value in vdc_options table. After this
change default values of all *MaxMemorySizeInMB options should match
values in vdc_options.
Reasons for not exceeding suggested value:
* QEMU goes through nested loop of size of the maxMemory at its start.
Large value of maxMemory can make QEMU to start for a longer time.
* We want hot plugged memory to be also hot unpluggable. This requires
guest kernel to consider hotplugged memory to be 'movable'. Kernel
may be unstable if movable part of memory is significantly larger than
non-movable part of the memory.
* On PowerPC platform continuous block of non-movable memory of size
1/64 of the max memory needs to be allocated for each VM.
Bug-Url: https://bugzilla.redhat.com/1411844
Change-Id: I025a322573915ee90a5a24be61a12fb433f3bb44
Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/VmCommonUtils.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java
4 files changed, 16 insertions(+), 10 deletions(-)
Approvals:
Jakub Niedermertl: Verified
Jenkins CI: Passed CI tests
Arik Hadas: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/71738
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I025a322573915ee90a5a24be61a12fb433f3bb44
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1
Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 8 months
Change in jenkins[master]: ovirt-engine-extension-logger-log4j: add fc25 support on master
by Code Review
>From Sandro Bonazzola <sbonazzo(a)redhat.com>:
Sandro Bonazzola has submitted this change and it was merged.
Change subject: ovirt-engine-extension-logger-log4j: add fc25 support on master
......................................................................
ovirt-engine-extension-logger-log4j: add fc25 support on master
Change-Id: I21d620e74a641e5507fd4ce65a234267ab3340b2
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M jobs/confs/projects/ovirt-engine-extension-logger-log4j/ovirt-engine-extension-logger-log4j_create-rpms.yaml
1 file changed, 14 insertions(+), 0 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved; Ready for merge
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/71927
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I21d620e74a641e5507fd4ce65a234267ab3340b2
Gerrit-PatchSet: 2
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 8 months
Change in jenkins[master]: ovirt-engine-yarn: add fc25 support on master
by Code Review
>From Sandro Bonazzola <sbonazzo(a)redhat.com>:
Sandro Bonazzola has submitted this change and it was merged.
Change subject: ovirt-engine-yarn: add fc25 support on master
......................................................................
ovirt-engine-yarn: add fc25 support on master
Change-Id: Iad32982a6da0dae3553589f57e25c63a6d52b42a
Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com>
---
M jobs/confs/projects/ovirt-engine-yarn/ovirt-engine-yarn_standard.yaml
1 file changed, 4 insertions(+), 0 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved; Ready for merge
Jenkins CI: Passed CI tests
Vojtech Szocs: Looks good to me
--
To view, visit https://gerrit.ovirt.org/71911
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iad32982a6da0dae3553589f57e25c63a6d52b42a
Gerrit-PatchSet: 2
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 8 months
Change in jenkins[master]: publisher: master: re-add cockpit-ovirt dependencies
by Code Review
>From Sandro Bonazzola <sbonazzo(a)redhat.com>:
Sandro Bonazzola has submitted this change and it was merged.
Change subject: publisher: master: re-add cockpit-ovirt dependencies
......................................................................
publisher: master: re-add cockpit-ovirt dependencies
For some reason cockpit ovirt dependencies disappeared.
Re-adding them.
Change-Id: Ic19c5df1d54196273c2af8aac8d2e969648809ad
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M jobs/confs/projects/ovirt/publish-rpms-nightly-master.yaml
1 file changed, 10 insertions(+), 4 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved; Ready for merge
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/71917
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic19c5df1d54196273c2af8aac8d2e969648809ad
Gerrit-PatchSet: 1
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 8 months
Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-2.1]: hc-gluster: optionally enabling the gluster service
by Code Review
>From Simone Tiraboschi <stirabos(a)redhat.com>:
Simone Tiraboschi has submitted this change and it was merged.
Change subject: hc-gluster: optionally enabling the gluster service
......................................................................
hc-gluster: optionally enabling the gluster service
Optionally enabling the gluster service on the
host and its cluster.
This will initially open the required ports on
the host and will set the gluster service
as enabled in the engine for the specific cluster.
Change-Id: Ic8102189d607bd9bbe48ff8fc0fbce5cd3db6bc0
Bug-Url: https://bugzilla.redhat.com/1288979
Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com>
(cherry picked from commit d1e219f6cbb53403f572a7eda8eb1455e59d703e)
---
M src/ovirt_hosted_engine_setup/constants.py
M src/plugins/gr-he-setup/engine/add_host.py
M src/plugins/gr-he-setup/network/firewall.py
M src/plugins/gr-he-setup/network/firewall_manager.py
M src/plugins/gr-he-setup/storage/nfs.py
M src/plugins/gr-he-setup/storage/storage.py
M templates/Makefile.am
A templates/hosted-gluster.xml.in
8 files changed, 122 insertions(+), 1 deletion(-)
Approvals:
Sandro Bonazzola: Looks good to me, but someone else must approve
Simone Tiraboschi: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/71573
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic8102189d607bd9bbe48ff8fc0fbce5cd3db6bc0
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: ovirt-hosted-engine-setup-2.1
Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 8 months
Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-2.1]: network: allow by default to work with NetworkManager
by Code Review
>From Simone Tiraboschi <stirabos(a)redhat.com>:
Simone Tiraboschi has submitted this change and it was merged.
Change subject: network: allow by default to work with NetworkManager
......................................................................
network: allow by default to work with NetworkManager
Allow by default to work with NetworkManager
Change-Id: Ibbad58bf0529d3b63ffabf8b2069b4bfa7a3cb78
Bug-Url: https://bugzilla.redhat.com/1330138
Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com>
(cherry picked from commit 414f6b7dc8c85f9725b5f2e8ec0055cc7a9ea0d9)
---
M src/plugins/gr-he-common/network/bridge.py
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Simone Tiraboschi: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
Dan Kenigsberg: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/71900
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibbad58bf0529d3b63ffabf8b2069b4bfa7a3cb78
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: ovirt-hosted-engine-setup-2.1
Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 8 months
Change in ovirt-engine[ovirt-engine-4.0]: ImageTransfer - removing image link
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: ImageTransfer - removing image link
......................................................................
ImageTransfer - removing image link
We currently use "image" to pass the disk id when performing image
transfer - but currently we don't support image links which causes the
link to appear as "/null".
Looking forward, we'll replace "image" with "disk" which will let us
to provide a link to the disk which is used in the transfer.
Change-Id: Iba9a10c4e153381753e1f66a69edfb23ee7e4c20
Bug-Url: https://bugzilla.redhat.com/1401873
Signed-off-by: Liron Aravot <laravot(a)redhat.com>
---
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendImageTransferResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendImageTransfersResource.java
2 files changed, 26 insertions(+), 0 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Liron Aravot: Verified
--
To view, visit https://gerrit.ovirt.org/71901
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iba9a10c4e153381753e1f66a69edfb23ee7e4c20
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0
Gerrit-Owner: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 8 months
Change in ovirt-engine[ovirt-engine-4.0]: engine: refactor HostConnectivityChecker
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: engine: refactor HostConnectivityChecker
......................................................................
engine: refactor HostConnectivityChecker
Calculate the absolute timeout time and compare the current time to it
instead of calculating number of polling attepts in beforehand.
Change-Id: I15f186830d363f875a478dcfab21b763d301ccf4
Bug-Url: https://bugzilla.redhat.com/1420239
Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/host/HostConnectivityChecker.java
1 file changed, 7 insertions(+), 7 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Moti Asayag: Looks good to me, approved
Yevgeny Zaspitsky: Verified
--
To view, visit https://gerrit.ovirt.org/71875
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I15f186830d363f875a478dcfab21b763d301ccf4
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0
Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 8 months
Change in ovirt-engine[ovirt-engine-4.0]: engine: avoid PollVDSCommand to fail upon VDSNetworkException
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: engine: avoid PollVDSCommand to fail upon VDSNetworkException
......................................................................
engine: avoid PollVDSCommand to fail upon VDSNetworkException
Change-Id: Ib2053529c995dac712f89bd1fb45c912b9cc35f3
Bug-Url: https://bugzilla.redhat.com/1420239
Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
(cherry picked from commit 24d1bc97fffe6b853e3264f1363af4f93898d885)
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/PollVDSCommand.java
1 file changed, 13 insertions(+), 0 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Moti Asayag: Looks good to me, approved
Yevgeny Zaspitsky: Verified
--
To view, visit https://gerrit.ovirt.org/71874
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib2053529c995dac712f89bd1fb45c912b9cc35f3
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0
Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 8 months
Change in ovirt-engine[ovirt-engine-4.0]: engine: overcome VDSM recovery in PollVDSCommand
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: engine: overcome VDSM recovery in PollVDSCommand
......................................................................
engine: overcome VDSM recovery in PollVDSCommand
Refer to VDSM recovery response as a negative poll attempt.
Change-Id: Ice4c1fb7359d6516916f0e360bb62de388974064
Bug-Url: https://bugzilla.redhat.com/1420239
Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/SetAmountOfMemoryVDSCommand.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/SetNumberOfCpusVDSCommand.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VDSCommandBase.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/FutureVDSCommand.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/PollVDSCommand.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SetHaMaintenanceModeVDSCommand.java
6 files changed, 23 insertions(+), 12 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Moti Asayag: Looks good to me, approved
Yevgeny Zaspitsky: Verified
--
To view, visit https://gerrit.ovirt.org/71876
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ice4c1fb7359d6516916f0e360bb62de388974064
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0
Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 8 months