Change in ovirt-engine-sdk-java[master]: Update to model 4.2.7 and metamodel 1.2.3
by Code Review
>From Ondra Machacek <omachace(a)redhat.com>:
Ondra Machacek has submitted this change and it was merged.
Change subject: Update to model 4.2.7 and metamodel 1.2.3
......................................................................
Update to model 4.2.7 and metamodel 1.2.3
The more relevant changes in the new version of the model are the
following:
* Replace the `Seal` operation of the service that manages a template
with a new `seal` parameter in the operation that adds a template
https://bugzilla.redhat.com/1335642[#1335642].
The more relevant changes in the new version of the metamodel are the
following:
* Fix list variable declaration in XML support code generator.
* Read also unsupported enums in lists.
* Merge link with element if it has same name.
Change-Id: Ibf45a56caba3ffcfe6c57fecb0c48f9827cf087a
Signed-off-by: Ondra Machacek <omachace(a)redhat.com>
---
M generator/pom.xml
M generator/src/main/java/org/ovirt/sdk/java/Tool.java
M pom.xml
M sdk/pom.xml
4 files changed, 8 insertions(+), 11 deletions(-)
Approvals:
Ondra Machacek: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/73994
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibf45a56caba3ffcfe6c57fecb0c48f9827cf087a
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine-sdk-java
Gerrit-Branch: master
Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 6 months
Change in jenkins[master]: mock_stup and mock_cleanup:Add Docker engine installation an...
by Code Review
>From Eyal Edri <eedri(a)redhat.com>:
Eyal Edri has submitted this change and it was merged.
Change subject: mock_stup and mock_cleanup:Add Docker engine installation and cleanup
......................................................................
mock_stup and mock_cleanup:Add Docker engine installation and cleanup
Fixes: https://ovirt-jira.atlassian.net/browse/OVIRT-889
Change-Id: I16bae618b77c9f36afb2abfcae51ab7ec334f245
Signed-off-by: Daniel Belenky <dbelenky(a)redhat.com>
---
A automation/check-patch.mounts
M automation/check-patch.packages
M automation/check-patch.packages.el7
M automation/check-patch.packages.fc24
M automation/check-patch.sh
A data/Dockerfiles/Dockerfile
A data/Dockerfiles/check_docker_container.sh
M jobs/confs/projects/jenkins/jenkins_standard.yaml
M jobs/confs/shell-scripts/mock_cleanup.sh
M jobs/confs/shell-scripts/mock_setup.sh
10 files changed, 75 insertions(+), 5 deletions(-)
Approvals:
Eyal Edri: Looks good to me, approved; Ready for merge
Daniel Belenky: Verified
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/73176
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I16bae618b77c9f36afb2abfcae51ab7ec334f245
Gerrit-PatchSet: 41
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: Daniel Belenky <dbelenky(a)redhat.com>
Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com>
Gerrit-Reviewer: Daniel Belenky <dbelenky(a)redhat.com>
Gerrit-Reviewer: Evgheni Dereveanchin <ederevea(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 6 months
Change in ovirt-engine-sdk[sdk_4.1]: Add installation instructions
by Code Review
>From Ondra Machacek <omachace(a)redhat.com>:
Ondra Machacek has submitted this change and it was merged.
Change subject: Add installation instructions
......................................................................
Add installation instructions
This patch adds installation instructions to the README.adoc file of the
SDK, including information about the dependencies required to install
with `pip`.
Change-Id: Ib3619f5e834d342dbc8b8d02858dcb25c8a43e9a
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
(cherry picked from commit dfb14e444ff9fc0cd40d4dd9f9861cc50c4de1bf)
---
M sdk/README.adoc
1 file changed, 56 insertions(+), 0 deletions(-)
Approvals:
Ondra Machacek: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/73983
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib3619f5e834d342dbc8b8d02858dcb25c8a43e9a
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk
Gerrit-Branch: sdk_4.1
Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 6 months
Change in ovirt-engine-sdk[master]: Add installation instructions
by Code Review
>From Ondra Machacek <omachace(a)redhat.com>:
Ondra Machacek has submitted this change and it was merged.
Change subject: Add installation instructions
......................................................................
Add installation instructions
This patch adds installation instructions to the README.adoc file of the
SDK, including information about the dependencies required to install
with `pip`.
Change-Id: Ib3619f5e834d342dbc8b8d02858dcb25c8a43e9a
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M sdk/README.adoc
1 file changed, 56 insertions(+), 0 deletions(-)
Approvals:
Ondra Machacek: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/73796
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib3619f5e834d342dbc8b8d02858dcb25c8a43e9a
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine-sdk
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Nathanaël Blanchet <digitall.finger(a)gmail.com>
Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 6 months
Change in ovirt-engine-sdk-ruby[sdk_4.1]: Add clone VM from snapshot example
by Code Review
>From Juan Hernandez <juan.hernandez(a)redhat.com>:
Juan Hernandez has submitted this change and it was merged.
Change subject: Add clone VM from snapshot example
......................................................................
Add clone VM from snapshot example
This patch adds an example that shows how to create a new virtual
machine cloning it from an snapshot.
Change-Id: Icd8be0e3c40972424d6d6c01408f7730cc050dbe
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
(cherry picked from commit 9a9ccbf8e18ea78f9d81cccb9503774fc129dcec)
---
A sdk/examples/clone_vm_from_snapshot.rb
1 file changed, 76 insertions(+), 0 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/73981
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icd8be0e3c40972424d6d6c01408f7730cc050dbe
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk-ruby
Gerrit-Branch: sdk_4.1
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 6 months
Change in ovirt-engine[master]: restapi: Autoadjusting max memory when VM created
by Code Review
>From Juan Hernandez <juan.hernandez(a)redhat.com>:
Juan Hernandez has submitted this change and it was merged.
Change subject: restapi: Autoadjusting max memory when VM created
......................................................................
restapi: Autoadjusting max memory when VM created
Problem: Since engine 4.1 VM-like entities have new property - max
memory. If one tried to create a new VM using script created for engine
4.0 specifying custom memory size larger template max memory and didn't
specifying max memory explicitly then creation of VM failed. Max memory
copied from template was smaller than memory.
Solution: If max memory is not specified and memory is specified, then
max memory is automatically set to value
VmCommonUtils#getMaxMemorySizeDefault(int memory) (currently 4*memory).
UI uses same method.
Change-Id: I6e1d0847c68a774f6028824e4533df772c19dfea
Bug-Url: https://bugzilla.redhat.com/1430795
Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com>
---
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmsResource.java
1 file changed, 10 insertions(+), 0 deletions(-)
Approvals:
Jakub Niedermertl: Verified
Juan Hernandez: Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/73910
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6e1d0847c68a774f6028824e4533df772c19dfea
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com>
Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 6 months
Change in ovirt-engine-sdk-ruby[master]: Add clone VM from snapshot example
by Code Review
>From Juan Hernandez <juan.hernandez(a)redhat.com>:
Juan Hernandez has submitted this change and it was merged.
Change subject: Add clone VM from snapshot example
......................................................................
Add clone VM from snapshot example
This patch adds an example that shows how to create a new virtual
machine cloning it from an snapshot.
Change-Id: Icd8be0e3c40972424d6d6c01408f7730cc050dbe
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
A sdk/examples/clone_vm_from_snapshot.rb
1 file changed, 76 insertions(+), 0 deletions(-)
Approvals:
Ondra Machacek: Looks good to me, but someone else must approve
Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/73800
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icd8be0e3c40972424d6d6c01408f7730cc050dbe
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine-sdk-ruby
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 6 months
Change in ovirt-engine-sdk-ruby[master]: Add console ticket example
by Code Review
>From Juan Hernandez <juan.hernandez(a)redhat.com>:
Juan Hernandez has submitted this change and it was merged.
Change subject: Add console ticket example
......................................................................
Add console ticket example
This patch adds an example that shows how to find a graphics console for
a given access protocol (VNC or SPICE) and how to get a ticket.
Change-Id: Iff02457a7b9026c0c3d3532d8e131ec1e110d69b
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
A sdk/examples/get_display_ticket.rb
1 file changed, 68 insertions(+), 0 deletions(-)
Approvals:
Piotr Kliczewski: Looks good to me, but someone else must approve
Ondra Machacek: Looks good to me, but someone else must approve
Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/73784
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iff02457a7b9026c0c3d3532d8e131ec1e110d69b
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine-sdk-ruby
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 6 months
Change in ovirt-engine[ovirt-engine-4.1.1.z]: webadmin: Pass Discard is irrelevant for AttachDiskModel
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: Pass Discard is irrelevant for AttachDiskModel
......................................................................
webadmin: Pass Discard is irrelevant for AttachDiskModel
AttachDiskModel is a sub class of AbstractDiskModel, and thus when
events like storageDomain_SelectedItemChanged are raised in
AttachDiskModel, updatePassDiscardAvailability and
updatePassDiscardChangeability are called although Pass Discard is
irrelevant for AttachDiskModel.
This patch adds an empty override of these methods to AttachDiskModel to
solve this problem.
Change-Id: I451b58a0618098690c89dce9aae5929e30d64b54
Bug-Url: https://bugzilla.redhat.com/1430754
Signed-off-by: Idan Shaby <ishaby(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/AbstractDiskModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/AttachDiskModel.java
2 files changed, 13 insertions(+), 1 deletion(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Idan Shaby: Verified
--
To view, visit https://gerrit.ovirt.org/73926
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I451b58a0618098690c89dce9aae5929e30d64b54
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1.1.z
Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
7 years, 6 months
Change in ovirt-engine[ovirt-engine-4.1]: webadmin: Pass Discard is irrelevant for AttachDiskModel
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: Pass Discard is irrelevant for AttachDiskModel
......................................................................
webadmin: Pass Discard is irrelevant for AttachDiskModel
AttachDiskModel is a sub class of AbstractDiskModel, and thus when
events like storageDomain_SelectedItemChanged are raised in
AttachDiskModel, updatePassDiscardAvailability and
updatePassDiscardChangeability are called although Pass Discard is
irrelevant for AttachDiskModel.
This patch adds an empty override of these methods to AttachDiskModel to
solve this problem.
Change-Id: I451b58a0618098690c89dce9aae5929e30d64b54
Bug-Url: https://bugzilla.redhat.com/1430754
Signed-off-by: Idan Shaby <ishaby(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/AbstractDiskModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/AttachDiskModel.java
2 files changed, 13 insertions(+), 1 deletion(-)
Approvals:
Jenkins CI: Passed CI tests
Daniel Erez: Looks good to me, approved
Idan Shaby: Verified
--
To view, visit https://gerrit.ovirt.org/73925
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I451b58a0618098690c89dce9aae5929e30d64b54
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1
Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 6 months