March 2017 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: engine: make host a real object in UpgradeHostValidatorTest
by Code Review 14 Mar '17

14 Mar '17

>From Moti Asayag <masayag(a)redhat.com>: Moti Asayag has submitted this change and it was merged. Change subject: engine: make host a real object in UpgradeHostValidatorTest ...................................................................... engine: make host a real object in UpgradeHostValidatorTest Make the input host a real object instead of mocking that in UpgradeHostValidatorTest. Change-Id: I08711fb08cb62e173732638f64d63746239374db Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/UpgradeHostValidatorTest.java 1 file changed, 8 insertions(+), 14 deletions(-) Approvals: Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved Yevgeny Zaspitsky: Verified -- To view, visit https://gerrit.ovirt.org/74016 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I08711fb08cb62e173732638f64d63746239374db Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-3.6]: core: Allow memory over commitment only if ksm or ballooning...
by Code Review 14 Mar '17

14 Mar '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: core: Allow memory over commitment only if ksm or ballooning are available ...................................................................... core: Allow memory over commitment only if ksm or ballooning are available Currently we allow memory over commitment even if nothing can support it on a host (no ksm and no ballooning). This patch adds verification for that issue so an error is raised if the configuration is wrong. Change-Id: I912285e8d8cd1d55cf58b14bf04f7d2e8bb84e75 Bug-Url: https://bugzilla.redhat.com/1427844 Signed-off-by: Jenny Tokar <jtokar(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsGroupCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVdsGroupCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/ClusterValidator.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVdsGroupCommandTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties A packaging/dbscripts/upgrade/03_06_2180_disable_cluster_over_commintment_if_no_ksm_or_balooning_enabled.sql 10 files changed, 94 insertions(+), 2 deletions(-) Approvals: Martin Sivák: Looks good to me, approved Jenkins CI: Passed CI tests Jenny Tokar: Verified -- To view, visit https://gerrit.ovirt.org/73982 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I912285e8d8cd1d55cf58b14bf04f7d2e8bb84e75 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Jenny Tokar <jtokar(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: core: change indexing of virtio-scsi io threads to start from 1
by Code Review 14 Mar '17

14 Mar '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: core: change indexing of virtio-scsi io threads to start from 1 ...................................................................... core: change indexing of virtio-scsi io threads to start from 1 Libvirt expects the IO Threads to be indexed from 1, not from 0. For virtio blk it was already implemented correctly in VmInfoBuilderImpl.pinToIoThreads() but the case of virtio-scsi have indexed the threads from 0. Change-Id: Ifa818d31d56cbd8f098620d6bc6598ce6ca5d4ea Bug-Url: https://bugzilla.redhat.com/1366507 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Tomas Jelinek: Verified Jenkins CI: Passed CI tests Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/73989 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifa818d31d56cbd8f098620d6bc6598ce6ca5d4ea Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-dwh[ovirt-engine-dwh-4.1]: history: heartbeat error message interval
by Code Review 14 Mar '17

14 Mar '17

>From Shirly Radco <sradco(a)redhat.com>: Shirly Radco has submitted this change and it was merged. Change subject: history: heartbeat error message interval ...................................................................... history: heartbeat error message interval Updated the heartbeat error message to be sent only when the hearbeat on the engine db did not update at least a minute. Change-Id: I16fc70b2d3199277ebfab8e36e65f0231a3e5fde Bug-Url: https://bugzilla.redhat.com/1371111 Signed-off-by: Shirly Radco <sradco(a)redhat.com> --- M etl_export/src/main/java/ovirt_engine_dwh/sampletimekeepingjob_4_1/SampleTimeKeepingJob.java M tos_project/process/SampleTimeKeepingJob_4.1.item M tos_project/process/SampleTimeKeepingJob_4.1.properties 3 files changed, 9 insertions(+), 7 deletions(-) Approvals: Shirly Radco: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/74046 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I16fc70b2d3199277ebfab8e36e65f0231a3e5fde Gerrit-PatchSet: 1 Gerrit-Project: ovirt-dwh Gerrit-Branch: ovirt-engine-dwh-4.1 Gerrit-Owner: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1.1.z]: Revert "rest: Add implementation for update disk qcow2 compat."
by Code Review 14 Mar '17

14 Mar '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: Revert "rest: Add implementation for update disk qcow2 compat." ...................................................................... Revert "rest: Add implementation for update disk qcow2 compat." This reverts commit 0af00ce3bc24d18ab5049933137d25f8f4fa9da9. Change-Id: Iaa2a5ebb0c1f96d05693731e3cc5d241cd5aa159 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendDiskResource.java 1 file changed, 0 insertions(+), 28 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/73830 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iaa2a5ebb0c1f96d05693731e3cc5d241cd5aa159 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1.1.z Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: Revert "rest: Add implementation for update disk qcow2 compat."
by Code Review 14 Mar '17

14 Mar '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: Revert "rest: Add implementation for update disk qcow2 compat." ...................................................................... Revert "rest: Add implementation for update disk qcow2 compat." This reverts commit 0af00ce3bc24d18ab5049933137d25f8f4fa9da9. Change-Id: Iaa2a5ebb0c1f96d05693731e3cc5d241cd5aa159 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendDiskResource.java 1 file changed, 0 insertions(+), 28 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/73829 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iaa2a5ebb0c1f96d05693731e3cc5d241cd5aa159 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: core: Properly adjust # of usb-controllers in UpdateTemplate...
by Code Review 14 Mar '17

14 Mar '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: core: Properly adjust # of usb-controllers in UpdateTemplate & AddVm ...................................................................... core: Properly adjust # of usb-controllers in UpdateTemplate & AddVm The VmDeviceUtils#updateUsbSlots method was not being called in the flows in UpdateVmTemplateCommand and AddVmCommand, which resulted in creation of templates (and consequently also VMs) with incorrect number of usb controllers and thus preventing the VM to be run in some cases. Change-Id: Ic8fbae5d863307bc423c3e04cfd56c370a850863 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1430009 Signed-off-by: Martin Betak <mbetak(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmAndCloneImageCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java 3 files changed, 21 insertions(+), 20 deletions(-) Approvals: Jenkins CI: Passed CI tests Martin Betak: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/73803 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic8fbae5d863307bc423c3e04cfd56c370a850863 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: core: add support for more than one virtio scsi controller
by Code Review 14 Mar '17

14 Mar '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: core: add support for more than one virtio scsi controller ...................................................................... core: add support for more than one virtio scsi controller Since every IO Thread has to have it's own virtio scsi controller and the current code supported only one controller, this patch adds the support for having more than one. If the num of io threads of a VM is lowered, the controller Id is re-generated for this disks. If the num of io threads is enlarged, the existing disks which already have addresses are not re-generated, only for the new disks will be assigned to new controller. Therefore, in order to enforce the rearrangement of the disks to io threads which has already been given some address, the disks have to be de-activated and activated again. The reason is to not to touch the assignement of the disks to controllers since it influences the disk arrangement inside of the guest. Change-Id: I5bc8d58237ae28901bf866a50f30e87ee852c980 Bug-Url: https://bugzilla.redhat.com/1422450 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/AbstractDiskVmCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/builder/vminfo/VmInfoBuildUtils.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/builder/vminfo/VmInfoBuilderImpl.java 4 files changed, 166 insertions(+), 30 deletions(-) Approvals: Tomas Jelinek: Verified Shahar Havivi: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/73544 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5bc8d58237ae28901bf866a50f30e87ee852c980 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: engine: populate macPoolId on DC in queries
by Code Review 14 Mar '17

14 Mar '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: engine: populate macPoolId on DC in queries ...................................................................... engine: populate macPoolId on DC in queries Polpuplate macPoolId on DC in the following queries: * GetAllStoragePools * Search Change-Id: Ia76a8ca63c2a3aca6c81e5e0c361d780dbf8a4d1 Bug-Url: https://bugzilla.redhat.com/1421434 Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com> (cherry picked from commit fc6b1906ed7d5e5f8e6a508257b39a99fb4ff0a3) --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SearchQuery.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/pool/DcSingleMacPoolFinder.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/pool/GetAllStoragePoolsQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/pool/StoragePoolQueryBase.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/pool/DcSingleMacPoolFinderTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/pool/GetStoragePoolByIdQueryTest.java 6 files changed, 157 insertions(+), 60 deletions(-) Approvals: Martin Mucha: Looks good to me, but someone else must approve Alona Kaplan: Looks good to me, approved Jenkins CI: Passed CI tests Yevgeny Zaspitsky: Verified -- To view, visit https://gerrit.ovirt.org/73402 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia76a8ca63c2a3aca6c81e5e0c361d780dbf8a4d1 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-dwh[master]: history: heartbeat error message interval
by Code Review 14 Mar '17

14 Mar '17

>From Shirly Radco <sradco(a)redhat.com>: Shirly Radco has submitted this change and it was merged. Change subject: history: heartbeat error message interval ...................................................................... history: heartbeat error message interval Updated the heartbeat error message to be sent only when the hearbeat on the engine db did not update at least a minute. Change-Id: I16fc70b2d3199277ebfab8e36e65f0231a3e5fde Bug-Url: https://bugzilla.redhat.com/1371111 Signed-off-by: Shirly Radco <sradco(a)redhat.com> --- M etl_export/src/main/java/ovirt_engine_dwh/sampletimekeepingjob_4_2/SampleTimeKeepingJob.java M tos_project/process/SampleTimeKeepingJob_4.2.item M tos_project/process/SampleTimeKeepingJob_4.2.properties 3 files changed, 9 insertions(+), 7 deletions(-) Approvals: Shirly Radco: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/73827 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I16fc70b2d3199277ebfab8e36e65f0231a3e5fde Gerrit-PatchSet: 3 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0