March 2017 - Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-4.1]: engine: user login event is not displayed on events tab
by Code Review 13 Mar '17

13 Mar '17

>From Piotr Kliczewski <piotr.kliczewski(a)gmail.com>: Piotr Kliczewski has submitted this change and it was merged. Change subject: engine: user login event is not displayed on events tab ...................................................................... engine: user login event is not displayed on events tab Audit log event should be added on user login. Change-Id: I31dfc3ecc4e9cc89ca9de2f602690c33b181b2cf Bug-Url: https://bugzilla.redhat.com/1426715 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/CreateUserSessionCommand.java 1 file changed, 7 insertions(+), 0 deletions(-) Approvals: Martin Peřina: Looks good to me, approved Ravi Nori: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/73770 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I31dfc3ecc4e9cc89ca9de2f602690c33b181b2cf Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: restapi: Don't use GetAllDisksByVmId
by Code Review 13 Mar '17

13 Mar '17

>From Juan Hernandez <juan.hernandez(a)redhat.com>: Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Don't use GetAllDisksByVmId ...................................................................... restapi: Don't use GetAllDisksByVmId Currently when version 3 of the API is used to request the disks of a virtual machine, the API uses the GetAllDisksByVmId query, which in turn uses the GetDisksbyVmGuid stored procedure to retrive the disks. In addition this query, for each disk, calls the GetSnapshotByLeafGuid stored procedure, to retrieve snapshot details, and the GetDiskVmElementVyDiskVmElementId, to get attachment details. The GetSnapshotByLeafGuid stored procedure is complex, and consumes a important amount of database time. Version 4 of the API uses lighter stored procedures. This patch changes the V3 compatibility layer of the API so that it calls the V4 disk attachments and disk resources instead of using the GetAllDisksByVmId query. In an otherwise idle enviroment with approxy 4000 virtual machines this reduces the total use of CPU (85% database + 15% engine) from 57 minutes to 14 minutes. This can be reproduced using the following Ruby script, which uses the 'ovirt' gem to retrieve the virtual machines and their disks: require 'active_support/all' require 'ovirt' service = Ovirt::Service.new( server: 'rhvm41.local', port: 443, domain: 'internal', username: 'admin', password: '...', verify_ssl: false, timeout: 1.hour ) vms = Ovirt::Vm.all(service) vms.each do |vm| vm.disks.each do |disk| puts "#{vm[:name]}: #{disk[:name]}" end end service.disconnect Change-Id: I4429aadb4c33271c6ba10752cd3502ceb1d2329e Bug-Url: https://bugzilla.redhat.com/1431578 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/helpers/V3VmHelper.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/servers/V3VmDiskServer.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/v3/servers/V3VmDisksServer.java 3 files changed, 68 insertions(+), 38 deletions(-) Approvals: Juan Hernandez: Verified Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, but someone else must approve Oved Ourfali: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/73904 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4429aadb4c33271c6ba10752cd3502ceb1d2329e Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eldad Marciano <emarcian(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: remove redundant load of NetworkCluster's in UpdateV...
by Code Review 13 Mar '17

13 Mar '17

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: engine: remove redundant load of NetworkCluster's in UpdateVdsCommand ...................................................................... engine: remove redundant load of NetworkCluster's in UpdateVdsCommand Change-Id: I59642de8e33d0c68dfd98dc94e6261a18d1a02b0 Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdeploy/UpdateVdsCommand.java 1 file changed, 2 insertions(+), 8 deletions(-) Approvals: Alona Kaplan: Looks good to me, approved Jenkins CI: Passed CI tests Yevgeny Zaspitsky: Verified -- To view, visit https://gerrit.ovirt.org/73934 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I59642de8e33d0c68dfd98dc94e6261a18d1a02b0 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: refactor UpdateVdsCommandTest
by Code Review 13 Mar '17

13 Mar '17

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: engine: refactor UpdateVdsCommandTest ...................................................................... engine: refactor UpdateVdsCommandTest Refactor UpdateVdsCommandTest so it would verify the interaction between the command and the validatior it uses. Change-Id: Iacece3b4a2e876473ceaaab91223bef4dbaf870a Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdeploy/UpdateVdsCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/hostdeploy/UpdateVdsCommandTest.java 2 files changed, 85 insertions(+), 78 deletions(-) Approvals: Alona Kaplan: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved Yevgeny Zaspitsky: Verified -- To view, visit https://gerrit.ovirt.org/73935 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iacece3b4a2e876473ceaaab91223bef4dbaf870a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: when moving VM to another cluster, update its macs…
by Code Review 13 Mar '17

13 Mar '17

>From Moti Asayag <masayag(a)redhat.com>: Moti Asayag has submitted this change and it was merged. Change subject: core: when moving VM to another cluster, update its macs… ...................................................................... core: when moving VM to another cluster, update its macs… when moving VM to another cluster, and those clusters has set different Mac Pools set, then macs needs to be updated. All macs of such VM needs to be removed from Mac Pool of source Cluster and added to Mac Pool of target cluster. If target Mac Pool disallows duplicates and there's clash, operation will be suspended. Change-Id: Ic57ff7ac249946fa0eafc6034bada1ee86d31b7f Bug-Url: https://bugzilla.redhat.com/1410440 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChangeVMClusterCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChangeVmClusterValidator.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveMacs.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/macpool/ReadMacPool.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ChangeVMClusterCommandTest.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ChangeVmClusterValidatorTest.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/MoveMacsTest.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/macpool/TransactionalMacPoolDecoratorRollbackTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/frontend/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 14 files changed, 616 insertions(+), 28 deletions(-) Approvals: Martin Mucha: Verified Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/71298 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic57ff7ac249946fa0eafc6034bada1ee86d31b7f Gerrit-PatchSet: 16 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Dominik Holler <dholler(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: refactorings related to update cluster flow.
by Code Review 13 Mar '17

13 Mar '17

>From Moti Asayag <masayag(a)redhat.com>: Moti Asayag has submitted this change and it was merged. Change subject: core: refactorings related to update cluster flow. ...................................................................... core: refactorings related to update cluster flow. • renamed parameters • created new parameter: macToMigrate, which was formerly initialized inside of method Change-Id: I5e74e218895d6c0b6fbc015d29a424fffab033ed Bug-Url: https://bugzilla.redhat.com/1410440 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveMacsOfUpdatedCluster.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateClusterCommand.java 2 files changed, 23 insertions(+), 23 deletions(-) Approvals: Dominik Holler: Looks good to me, but someone else must approve Marcin Mirecki: Looks good to me, but someone else must approve Martin Mucha: Verified Alona Kaplan: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/71295 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5e74e218895d6c0b6fbc015d29a424fffab033ed Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Dominik Holler <dholler(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: renamed class MoveMacsOfUpdatedCluster.
by Code Review 13 Mar '17

13 Mar '17

>From Moti Asayag <masayag(a)redhat.com>: Moti Asayag has submitted this change and it was merged. Change subject: core: renamed class MoveMacsOfUpdatedCluster. ...................................................................... core: renamed class MoveMacsOfUpdatedCluster. MoveMacsOfUpdatedCluster.java -> MoveMacs.java Class was renamed, because macs will be moved not only because of updating cluster. Change-Id: I524abafd06ab5e57e8e2fc36f62c31fd58ec993e Bug-Url: https://bugzilla.redhat.com/1410440 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveMacs.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateClusterCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/pool/UpdateStoragePoolCommand.java 3 files changed, 6 insertions(+), 6 deletions(-) Approvals: Dominik Holler: Looks good to me, but someone else must approve Marcin Mirecki: Looks good to me, but someone else must approve Martin Mucha: Verified Alona Kaplan: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/71296 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I524abafd06ab5e57e8e2fc36f62c31fd58ec993e Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Dominik Holler <dholler(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: added bulk methods to MacPool
by Code Review 13 Mar '17

13 Mar '17

>From Moti Asayag <masayag(a)redhat.com>: Moti Asayag has submitted this change and it was merged. Change subject: core: added bulk methods to MacPool ...................................................................... core: added bulk methods to MacPool to allow adding and 'force-adding' list of Macs. Change-Id: I18e60646da2bd82952dd2eae3d4849d1fb39d311 Bug-Url: https://bugzilla.redhat.com/1410440 Signed-off-by: Martin Mucha <mmucha(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/macpool/DelegatingMacPoolDecorator.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/macpool/MacPoolUsingRanges.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/macpool/TransactionalMacPoolDecorator.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/macpool/WriteMacPool.java 4 files changed, 62 insertions(+), 3 deletions(-) Approvals: Martin Mucha: Verified Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/71297 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I18e60646da2bd82952dd2eae3d4849d1fb39d311 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Dominik Holler <dholler(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-java[sdk_4.1]: Update to model 4.1.32 and metamodel 1.1.13
by Code Review 13 Mar '17

13 Mar '17

>From Ondra Machacek <omachace(a)redhat.com>: Ondra Machacek has submitted this change and it was merged. Change subject: Update to model 4.1.32 and metamodel 1.1.13 ...................................................................... Update to model 4.1.32 and metamodel 1.1.13 The more relevant changes in the new version of the model are the following: * Replace the `Seal` operation of the service that manages a template with a new `seal` parameter in the operation that adds a template https://bugzilla.redhat.com/1335642[#1335642]. The more relevant changes in the new version of the metamodel are the following: * Fix list variable declaration in XML support code generator. * Read also unsupported enums in lists. * Merge link with element if it has same name. Change-Id: I7a0712a14879a006b93504d76a84f50927d51b0b Signed-off-by: Ondra Machacek <omachace(a)redhat.com> --- M pom.xml 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Ondra Machacek: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/73995 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7a0712a14879a006b93504d76a84f50927d51b0b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-java Gerrit-Branch: sdk_4.1 Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: ui: set domain value in case that Cloud-Init/Sysprep is enabled
by Code Review 13 Mar '17

13 Mar '17

>From Tomas Jelinek <tjelinek(a)redhat.com>: Tomas Jelinek has submitted this change and it was merged. Change subject: ui: set domain value in case that Cloud-Init/Sysprep is enabled ...................................................................... ui: set domain value in case that Cloud-Init/Sysprep is enabled Fix a bug of not setting the domain name value in case of enabling the Cloud-Init/Sysprep option for VM (new/edit) and Run-Once dialogs. Change-Id: I8f7934347e05497cca1d4a6b0c8950cbb85f7cf7 Bug-Url: https://bugzilla.redhat.com/1425122 Signed-off-by: Sharon Gratch <sgratch(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/RunOnceModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java 2 files changed, 8 insertions(+), 0 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Jenkins CI: Passed CI tests Sharon Gratch: Verified -- To view, visit https://gerrit.ovirt.org/73929 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8f7934347e05497cca1d4a6b0c8950cbb85f7cf7 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sharon Gratch <sgratch(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sharon Gratch <sgratch(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0